* [PATCH 1/2] arm: socfpga: update l2 cache settings
@ 2014-11-21 5:04 dinguyen
2014-11-21 5:04 ` [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller dinguyen
0 siblings, 1 reply; 5+ messages in thread
From: dinguyen @ 2014-11-21 5:04 UTC (permalink / raw)
To: linux; +Cc: dinh.linux, linux-arm-kernel, linux-kernel, Dinh Nguyen
From: Dinh Nguyen <dinguyen@opensource.altera.com>
Enable D and I prefetch helps improve SDRAM preformance.
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
arch/arm/mach-socfpga/socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
index adbf383..13b1858 100644
--- a/arch/arm/mach-socfpga/socfpga.c
+++ b/arch/arm/mach-socfpga/socfpga.c
@@ -104,7 +104,8 @@ static const char *altera_dt_match[] = {
};
DT_MACHINE_START(SOCFPGA, "Altera SOCFPGA")
- .l2c_aux_val = 0,
+ .l2c_aux_val = L310_AUX_CTRL_DATA_PREFETCH |
+ L310_AUX_CTRL_INSTR_PREFETCH,
.l2c_aux_mask = ~0,
.smp = smp_ops(socfpga_smp_ops),
.map_io = socfpga_map_io,
--
2.0.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller
2014-11-21 5:04 [PATCH 1/2] arm: socfpga: update l2 cache settings dinguyen
@ 2014-11-21 5:04 ` dinguyen
2014-11-21 11:04 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: dinguyen @ 2014-11-21 5:04 UTC (permalink / raw)
To: linux; +Cc: dinh.linux, linux-arm-kernel, linux-kernel, Dinh Nguyen
From: Dinh Nguyen <dinguyen@opensource.altera.com>
By not having bit 22 set in the PL310 Auxiliary Control register (shared
attribute override enable) has the side effect of transforming Normal
Shared Non-cacheable reads into Cacheable no-allocate reads.
Coherent DMA buffers in Linux always have a Cacheable alias via the
kernel linear mapping and the processor can speculatively load cache
lines into the PL310 controller. With bit 22 cleared, Non-cacheable
reads would unexpectedly hit such cache lines leading to buffer
corruption.
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
arch/arm/mach-socfpga/socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
index 13b1858..afc009f 100644
--- a/arch/arm/mach-socfpga/socfpga.c
+++ b/arch/arm/mach-socfpga/socfpga.c
@@ -105,7 +105,8 @@ static const char *altera_dt_match[] = {
DT_MACHINE_START(SOCFPGA, "Altera SOCFPGA")
.l2c_aux_val = L310_AUX_CTRL_DATA_PREFETCH |
- L310_AUX_CTRL_INSTR_PREFETCH,
+ L310_AUX_CTRL_INSTR_PREFETCH |
+ L2C_AUX_CTRL_SHARED_OVERRIDE,
.l2c_aux_mask = ~0,
.smp = smp_ops(socfpga_smp_ops),
.map_io = socfpga_map_io,
--
2.0.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller
2014-11-21 5:04 ` [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller dinguyen
@ 2014-11-21 11:04 ` Arnd Bergmann
2014-11-21 15:27 ` Dinh Nguyen
2014-12-17 19:46 ` Dinh Nguyen
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2014-11-21 11:04 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: dinguyen, linux, dinh.linux, linux-kernel
On Thursday 20 November 2014 23:04:40 dinguyen@opensource.altera.com wrote:
>
> ---
> arch/arm/mach-socfpga/socfpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> index 13b1858..afc009f 100644
> --- a/arch/arm/mach-socfpga/socfpga.c
> +++ b/arch/arm/mach-socfpga/socfpga.c
> @@ -105,7 +105,8 @@ static const char *altera_dt_match[] = {
>
> DT_MACHINE_START(SOCFPGA, "Altera SOCFPGA")
> .l2c_aux_val = L310_AUX_CTRL_DATA_PREFETCH |
> - L310_AUX_CTRL_INSTR_PREFETCH,
> + L310_AUX_CTRL_INSTR_PREFETCH |
> + L2C_AUX_CTRL_SHARED_OVERRIDE,
> .l2c_aux_mask = ~0,
> .smp = smp_ops(socfpga_smp_ops),
> .map_io = socfpga_map_io,
Hi Dinh,
Please do this by putting the appropriate proterties into the
l2x0 DT node instead.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller
2014-11-21 11:04 ` Arnd Bergmann
@ 2014-11-21 15:27 ` Dinh Nguyen
2014-12-17 19:46 ` Dinh Nguyen
1 sibling, 0 replies; 5+ messages in thread
From: Dinh Nguyen @ 2014-11-21 15:27 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel; +Cc: linux, dinh.linux, linux-kernel
Hi Arnd,
On 11/21/14, 5:04 AM, Arnd Bergmann wrote:
> On Thursday 20 November 2014 23:04:40 dinguyen@opensource.altera.com wrote:
>>
>> ---
>> arch/arm/mach-socfpga/socfpga.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
>> index 13b1858..afc009f 100644
>> --- a/arch/arm/mach-socfpga/socfpga.c
>> +++ b/arch/arm/mach-socfpga/socfpga.c
>> @@ -105,7 +105,8 @@ static const char *altera_dt_match[] = {
>>
>> DT_MACHINE_START(SOCFPGA, "Altera SOCFPGA")
>> .l2c_aux_val = L310_AUX_CTRL_DATA_PREFETCH |
>> - L310_AUX_CTRL_INSTR_PREFETCH,
>> + L310_AUX_CTRL_INSTR_PREFETCH |
>> + L2C_AUX_CTRL_SHARED_OVERRIDE,
>> .l2c_aux_mask = ~0,
>> .smp = smp_ops(socfpga_smp_ops),
>> .map_io = socfpga_map_io,
>
> Hi Dinh,
>
> Please do this by putting the appropriate proterties into the
> l2x0 DT node instead.
>
I don't see a way to do this yet in DT. Perhaps I'm missing a patchset
to allow this?
Thanks,
Dinh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller
2014-11-21 11:04 ` Arnd Bergmann
2014-11-21 15:27 ` Dinh Nguyen
@ 2014-12-17 19:46 ` Dinh Nguyen
1 sibling, 0 replies; 5+ messages in thread
From: Dinh Nguyen @ 2014-12-17 19:46 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel; +Cc: dinguyen, linux, linux-kernel
Hi Arnd,
On 11/21/14, 5:04 AM, Arnd Bergmann wrote:
> On Thursday 20 November 2014 23:04:40 dinguyen@opensource.altera.com wrote:
>>
>> ---
>> arch/arm/mach-socfpga/socfpga.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
>> index 13b1858..afc009f 100644
>> --- a/arch/arm/mach-socfpga/socfpga.c
>> +++ b/arch/arm/mach-socfpga/socfpga.c
>> @@ -105,7 +105,8 @@ static const char *altera_dt_match[] = {
>>
>> DT_MACHINE_START(SOCFPGA, "Altera SOCFPGA")
>> .l2c_aux_val = L310_AUX_CTRL_DATA_PREFETCH |
>> - L310_AUX_CTRL_INSTR_PREFETCH,
>> + L310_AUX_CTRL_INSTR_PREFETCH |
>> + L2C_AUX_CTRL_SHARED_OVERRIDE,
>> .l2c_aux_mask = ~0,
>> .smp = smp_ops(socfpga_smp_ops),
>> .map_io = socfpga_map_io,
>
> Hi Dinh,
>
> Please do this by putting the appropriate proterties into the
> l2x0 DT node instead.
>
I don't see a way to do this using the l2x0 DT node.
Thanks,
Dinh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-17 19:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-21 5:04 [PATCH 1/2] arm: socfpga: update l2 cache settings dinguyen
2014-11-21 5:04 ` [PATCH 2/2] arm: socfpga: Set share override bit of the l2 cache controller dinguyen
2014-11-21 11:04 ` Arnd Bergmann
2014-11-21 15:27 ` Dinh Nguyen
2014-12-17 19:46 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).