* [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi
@ 2014-11-26 13:22 Andy Yan
2014-11-26 13:26 ` [PATCH v13 01/12] drm: imx: imx-hdmi: make checkpatch happy Andy Yan
` (12 more replies)
0 siblings, 13 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:22 UTC (permalink / raw)
To: airlied, heiko, fabio.estevam, rmk+kernel
Cc: Philipp Zabel, Greg Kroah-Hartman, Grant Likely, Rob Herring,
Shawn Guo, Josh Boyer, Sean Paul, Inki Dae, Dave Airlie,
Arnd Bergmann, Lucas Stach, Zubair.Kakakhel, djkurtz, ykk,
linux-kernel, dri-devel, devel, devicetree, linux-rockchip,
jay.xu, Pawel Moll, mark.yao, Mark Rutland, Ian Campbell,
Kumar Gala, Andy Yan
We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly differences, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288 is 4 bytes width and can only be accessed
by word), 4K support(imx6 doesn't support 4k, but rk3288 does), and HDMI2.0
support.
To reuse the imx-hdmi driver, we make this patch set:
(1): fix some CodingStyle warning to make checkpatch happy
(2): convert imx-hdmi to drm_bridge
(3): split platform specific code
(4): move imx-hdmi to bridge/dw_hdmi
(5): extend dw_hdmi.c to support rk3288 hdmi
(6): add rockchip rk3288 platform specific code dw_hdmi-rockchip.c
Changes in v13:
- patch against drm-next
- split phy configuration from patch#4
Changes in v12:
- refactor of_node_put(ddc_node)
- squash patch <convert dw_hdmi to drm_bridge>
- add comment for the depend on patch
Changes in v11:
- squash patch <split some phy configuration to platform driver>
- split form patch <dw_hdmi: add rk3288 support>
Changes in v10:
- split generic dw_hdmi.c improvements from patch#11 (add rk3288 support)
- add more display mode support mpll configuration for rk3288
Changes in v9:
- move some phy configuration to platform driver
Changes in v8:
- correct some spelling mistake
- modify ddc-i2c-bus and interrupt description
- Add documentation for rockchip dw hdmi
Changes in v7:
- remove unused variables from structure dw_hdmi
- remove a wrong modification
- add copyrights for dw_hdmi-imx.c
Changes in v6:
- rearrange the patch order
- refactor register access without reg_shift
Changes in v5:
- refactor reg-io-width
Changes in v4:
- fix checkpatch CHECK
- defer probe ddc i2c adapter
Changes in v3:
- split multi-register access to one indepent patch
Andy Yan (12):
drm: imx: imx-hdmi: make checkpatch happy
drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter
drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode
drm: imx: imx-hdmi: split phy configuration to platform driver
drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi
dt-bindings: add document for dw_hdmi
drm: bridge/dw_hdmi: add support for multi-byte register width access
drm: bridge/dw_hdmi: add mode_valid support
drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done
drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare
dt-bindings: Add documentation for rockchip dw hdmi
drm: bridge/dw_hdmi: add rockchip rk3288 support
.../devicetree/bindings/drm/bridge/dw_hdmi.txt | 40 ++
.../devicetree/bindings/video/dw_hdmi-rockchip.txt | 43 ++
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile | 1 +
.../gpu/drm/{imx/imx-hdmi.c => bridge/dw_hdmi.c} | 757 +++++++++------------
.../gpu/drm/{imx/imx-hdmi.h => bridge/dw_hdmi.h} | 4 +-
drivers/gpu/drm/imx/Kconfig | 1 +
drivers/gpu/drm/imx/Makefile | 2 +-
drivers/gpu/drm/imx/dw_hdmi-imx.c | 273 ++++++++
drivers/gpu/drm/rockchip/Kconfig | 10 +
drivers/gpu/drm/rockchip/Makefile | 2 +-
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++
include/drm/bridge/dw_hdmi.h | 60 ++
13 files changed, 1132 insertions(+), 421 deletions(-)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
create mode 100644 Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt
rename drivers/gpu/drm/{imx/imx-hdmi.c => bridge/dw_hdmi.c} (71%)
rename drivers/gpu/drm/{imx/imx-hdmi.h => bridge/dw_hdmi.h} (99%)
create mode 100644 drivers/gpu/drm/imx/dw_hdmi-imx.c
create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
create mode 100644 include/drm/bridge/dw_hdmi.h
--
1.9.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v13 01/12] drm: imx: imx-hdmi: make checkpatch happy
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
@ 2014-11-26 13:26 ` Andy Yan
2014-11-26 13:26 ` [PATCH v13 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Andy Yan
` (11 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:26 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
CHECK: Alignment should match open parenthesis
+ if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
+ (hdmi->vic == 12) || (hdmi->vic == 13) ||
CHECK: braces {} should be used on all arms of this statement
+ if (hdmi->hdmi_data.video_mode.mdvi)
[...]
+ else {
[...]
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
Changes in v13:
- patch against drm-next
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6:
- rearrange the patch order
Changes in v5: None
Changes in v4:
- fix checkpatch CHECK
Changes in v3: None
drivers/gpu/drm/imx/imx-hdmi.c | 97 +++++++++++++++++++++---------------------
1 file changed, 48 insertions(+), 49 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c
index aaec6b2..79daec4 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.c
+++ b/drivers/gpu/drm/imx/imx-hdmi.c
@@ -163,7 +163,7 @@ static void hdmi_modb(struct imx_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
}
static void hdmi_mask_writeb(struct imx_hdmi *hdmi, u8 data, unsigned int reg,
- u8 shift, u8 mask)
+ u8 shift, u8 mask)
{
hdmi_modb(hdmi, data << shift, mask, reg);
}
@@ -327,7 +327,7 @@ static unsigned int hdmi_compute_cts(unsigned int freq, unsigned long pixel_clk,
}
static void hdmi_set_clk_regenerator(struct imx_hdmi *hdmi,
- unsigned long pixel_clk)
+ unsigned long pixel_clk)
{
unsigned int clk_n, clk_cts;
@@ -338,7 +338,7 @@ static void hdmi_set_clk_regenerator(struct imx_hdmi *hdmi,
if (!clk_cts) {
dev_dbg(hdmi->dev, "%s: pixel clock not supported: %lu\n",
- __func__, pixel_clk);
+ __func__, pixel_clk);
return;
}
@@ -477,13 +477,11 @@ static void imx_hdmi_update_csc_coeffs(struct imx_hdmi *hdmi)
u16 coeff_b = (*csc_coeff)[1][i];
u16 coeff_c = (*csc_coeff)[2][i];
- hdmi_writeb(hdmi, coeff_a & 0xff,
- HDMI_CSC_COEF_A1_LSB + i * 2);
+ hdmi_writeb(hdmi, coeff_a & 0xff, HDMI_CSC_COEF_A1_LSB + i * 2);
hdmi_writeb(hdmi, coeff_a >> 8, HDMI_CSC_COEF_A1_MSB + i * 2);
hdmi_writeb(hdmi, coeff_b & 0xff, HDMI_CSC_COEF_B1_LSB + i * 2);
hdmi_writeb(hdmi, coeff_b >> 8, HDMI_CSC_COEF_B1_MSB + i * 2);
- hdmi_writeb(hdmi, coeff_c & 0xff,
- HDMI_CSC_COEF_C1_LSB + i * 2);
+ hdmi_writeb(hdmi, coeff_c & 0xff, HDMI_CSC_COEF_C1_LSB + i * 2);
hdmi_writeb(hdmi, coeff_c >> 8, HDMI_CSC_COEF_C1_MSB + i * 2);
}
@@ -535,21 +533,22 @@ static void hdmi_video_packetize(struct imx_hdmi *hdmi)
struct hdmi_data_info *hdmi_data = &hdmi->hdmi_data;
u8 val, vp_conf;
- if (hdmi_data->enc_out_format == RGB
- || hdmi_data->enc_out_format == YCBCR444) {
- if (!hdmi_data->enc_color_depth)
+ if (hdmi_data->enc_out_format == RGB ||
+ hdmi_data->enc_out_format == YCBCR444) {
+ if (!hdmi_data->enc_color_depth) {
output_select = HDMI_VP_CONF_OUTPUT_SELECTOR_BYPASS;
- else if (hdmi_data->enc_color_depth == 8) {
+ } else if (hdmi_data->enc_color_depth == 8) {
color_depth = 4;
output_select = HDMI_VP_CONF_OUTPUT_SELECTOR_BYPASS;
- } else if (hdmi_data->enc_color_depth == 10)
+ } else if (hdmi_data->enc_color_depth == 10) {
color_depth = 5;
- else if (hdmi_data->enc_color_depth == 12)
+ } else if (hdmi_data->enc_color_depth == 12) {
color_depth = 6;
- else if (hdmi_data->enc_color_depth == 16)
+ } else if (hdmi_data->enc_color_depth == 16) {
color_depth = 7;
- else
+ } else {
return;
+ }
} else if (hdmi_data->enc_out_format == YCBCR422_8BITS) {
if (!hdmi_data->enc_color_depth ||
hdmi_data->enc_color_depth == 8)
@@ -561,8 +560,9 @@ static void hdmi_video_packetize(struct imx_hdmi *hdmi)
else
return;
output_select = HDMI_VP_CONF_OUTPUT_SELECTOR_YCC422;
- } else
+ } else {
return;
+ }
/* set the packetizer registers */
val = ((color_depth << HDMI_VP_PR_CD_COLOR_DEPTH_OFFSET) &
@@ -623,34 +623,34 @@ static void hdmi_video_packetize(struct imx_hdmi *hdmi)
}
static inline void hdmi_phy_test_clear(struct imx_hdmi *hdmi,
- unsigned char bit)
+ unsigned char bit)
{
hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLR_OFFSET,
HDMI_PHY_TST0_TSTCLR_MASK, HDMI_PHY_TST0);
}
static inline void hdmi_phy_test_enable(struct imx_hdmi *hdmi,
- unsigned char bit)
+ unsigned char bit)
{
hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTEN_OFFSET,
HDMI_PHY_TST0_TSTEN_MASK, HDMI_PHY_TST0);
}
static inline void hdmi_phy_test_clock(struct imx_hdmi *hdmi,
- unsigned char bit)
+ unsigned char bit)
{
hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLK_OFFSET,
HDMI_PHY_TST0_TSTCLK_MASK, HDMI_PHY_TST0);
}
static inline void hdmi_phy_test_din(struct imx_hdmi *hdmi,
- unsigned char bit)
+ unsigned char bit)
{
hdmi_writeb(hdmi, bit, HDMI_PHY_TST1);
}
static inline void hdmi_phy_test_dout(struct imx_hdmi *hdmi,
- unsigned char bit)
+ unsigned char bit)
{
hdmi_writeb(hdmi, bit, HDMI_PHY_TST2);
}
@@ -666,21 +666,21 @@ static bool hdmi_phy_wait_i2c_done(struct imx_hdmi *hdmi, int msec)
}
static void __hdmi_phy_i2c_write(struct imx_hdmi *hdmi, unsigned short data,
- unsigned char addr)
+ unsigned char addr)
{
hdmi_writeb(hdmi, 0xFF, HDMI_IH_I2CMPHY_STAT0);
hdmi_writeb(hdmi, addr, HDMI_PHY_I2CM_ADDRESS_ADDR);
hdmi_writeb(hdmi, (unsigned char)(data >> 8),
- HDMI_PHY_I2CM_DATAO_1_ADDR);
+ HDMI_PHY_I2CM_DATAO_1_ADDR);
hdmi_writeb(hdmi, (unsigned char)(data >> 0),
- HDMI_PHY_I2CM_DATAO_0_ADDR);
+ HDMI_PHY_I2CM_DATAO_0_ADDR);
hdmi_writeb(hdmi, HDMI_PHY_I2CM_OPERATION_ADDR_WRITE,
- HDMI_PHY_I2CM_OPERATION_ADDR);
+ HDMI_PHY_I2CM_OPERATION_ADDR);
hdmi_phy_wait_i2c_done(hdmi, 1000);
}
static int hdmi_phy_i2c_write(struct imx_hdmi *hdmi, unsigned short data,
- unsigned char addr)
+ unsigned char addr)
{
__hdmi_phy_i2c_write(hdmi, data, addr);
return 0;
@@ -839,7 +839,7 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
hdmi_phy_test_clear(hdmi, 1);
hdmi_writeb(hdmi, HDMI_PHY_I2CM_SLAVE_ADDR_PHY_GEN2,
- HDMI_PHY_I2CM_SLAVE_ADDR);
+ HDMI_PHY_I2CM_SLAVE_ADDR);
hdmi_phy_test_clear(hdmi, 0);
/* PLL/MPLL Cfg - always match on final entry */
@@ -857,9 +857,8 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
break;
if (i >= ARRAY_SIZE(curr_ctrl)) {
- dev_err(hdmi->dev,
- "Pixel clock %d - unsupported by HDMI\n",
- hdmi->hdmi_data.video_mode.mpixelclock);
+ dev_err(hdmi->dev, "Pixel clock %d - unsupported by HDMI\n",
+ hdmi->hdmi_data.video_mode.mpixelclock);
return -EINVAL;
}
@@ -1223,21 +1222,21 @@ static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
}
if ((hdmi->vic == 6) || (hdmi->vic == 7) ||
- (hdmi->vic == 21) || (hdmi->vic == 22) ||
- (hdmi->vic == 2) || (hdmi->vic == 3) ||
- (hdmi->vic == 17) || (hdmi->vic == 18))
+ (hdmi->vic == 21) || (hdmi->vic == 22) ||
+ (hdmi->vic == 2) || (hdmi->vic == 3) ||
+ (hdmi->vic == 17) || (hdmi->vic == 18))
hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_601;
else
hdmi->hdmi_data.colorimetry = HDMI_COLORIMETRY_ITU_709;
if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
- (hdmi->vic == 12) || (hdmi->vic == 13) ||
- (hdmi->vic == 14) || (hdmi->vic == 15) ||
- (hdmi->vic == 25) || (hdmi->vic == 26) ||
- (hdmi->vic == 27) || (hdmi->vic == 28) ||
- (hdmi->vic == 29) || (hdmi->vic == 30) ||
- (hdmi->vic == 35) || (hdmi->vic == 36) ||
- (hdmi->vic == 37) || (hdmi->vic == 38))
+ (hdmi->vic == 12) || (hdmi->vic == 13) ||
+ (hdmi->vic == 14) || (hdmi->vic == 15) ||
+ (hdmi->vic == 25) || (hdmi->vic == 26) ||
+ (hdmi->vic == 27) || (hdmi->vic == 28) ||
+ (hdmi->vic == 29) || (hdmi->vic == 30) ||
+ (hdmi->vic == 35) || (hdmi->vic == 36) ||
+ (hdmi->vic == 37) || (hdmi->vic == 38))
hdmi->hdmi_data.video_mode.mpixelrepetitionoutput = 1;
else
hdmi->hdmi_data.video_mode.mpixelrepetitionoutput = 0;
@@ -1266,9 +1265,9 @@ static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
imx_hdmi_enable_video_path(hdmi);
/* not for DVI mode */
- if (hdmi->hdmi_data.video_mode.mdvi)
+ if (hdmi->hdmi_data.video_mode.mdvi) {
dev_dbg(hdmi->dev, "%s DVI mode\n", __func__);
- else {
+ } else {
dev_dbg(hdmi->dev, "%s CEA mode\n", __func__);
/* HDMI Initialization Step E - Configure audio */
@@ -1525,7 +1524,7 @@ static irqreturn_t imx_hdmi_irq(int irq, void *dev_id)
dev_dbg(hdmi->dev, "EVENT=plugout\n");
hdmi_modb(hdmi, HDMI_PHY_HPD, HDMI_PHY_HPD,
- HDMI_PHY_POL0);
+ HDMI_PHY_POL0);
imx_hdmi_poweroff(hdmi);
}
@@ -1554,7 +1553,7 @@ static int imx_hdmi_register(struct drm_device *drm, struct imx_hdmi *hdmi)
DRM_MODE_ENCODER_TMDS);
drm_connector_helper_add(&hdmi->connector,
- &imx_hdmi_connector_helper_funcs);
+ &imx_hdmi_connector_helper_funcs);
drm_connector_init(drm, &hdmi->connector, &imx_hdmi_connector_funcs,
DRM_MODE_CONNECTOR_HDMIA);
@@ -1671,11 +1670,11 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
/* Product and revision IDs */
dev_info(dev,
- "Detected HDMI controller 0x%x:0x%x:0x%x:0x%x\n",
- hdmi_readb(hdmi, HDMI_DESIGN_ID),
- hdmi_readb(hdmi, HDMI_REVISION_ID),
- hdmi_readb(hdmi, HDMI_PRODUCT_ID0),
- hdmi_readb(hdmi, HDMI_PRODUCT_ID1));
+ "Detected HDMI controller 0x%x:0x%x:0x%x:0x%x\n",
+ hdmi_readb(hdmi, HDMI_DESIGN_ID),
+ hdmi_readb(hdmi, HDMI_REVISION_ID),
+ hdmi_readb(hdmi, HDMI_PRODUCT_ID0),
+ hdmi_readb(hdmi, HDMI_PRODUCT_ID1));
initialize_hdmi_ih_mutes(hdmi);
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
2014-11-26 13:26 ` [PATCH v13 01/12] drm: imx: imx-hdmi: make checkpatch happy Andy Yan
@ 2014-11-26 13:26 ` Andy Yan
2014-11-26 13:27 ` [PATCH v13 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode Andy Yan
` (10 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:26 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
drm driver may probe before the i2c bus, so the driver should
defer probing until it is available
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
Changes in v13: None
Changes in v12:
- refactor of_node_put(ddc_node)
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4:
- defer probe ddc i2c adapter
Changes in v3: None
drivers/gpu/drm/imx/imx-hdmi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c
index 79daec4..8029a07 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.c
+++ b/drivers/gpu/drm/imx/imx-hdmi.c
@@ -1611,10 +1611,12 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
if (ddc_node) {
hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
- if (!hdmi->ddc)
+ of_node_put(ddc_node);
+ if (!hdmi->ddc) {
dev_dbg(hdmi->dev, "failed to read ddc node\n");
+ return -EPROBE_DEFER;
+ }
- of_node_put(ddc_node);
} else {
dev_dbg(hdmi->dev, "no ddc property found\n");
}
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
2014-11-26 13:26 ` [PATCH v13 01/12] drm: imx: imx-hdmi: make checkpatch happy Andy Yan
2014-11-26 13:26 ` [PATCH v13 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Andy Yan
@ 2014-11-26 13:27 ` Andy Yan
2014-11-26 13:30 ` [PATCH v13 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver Andy Yan
` (9 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:27 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
IMX6 and Rockchip RK3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly differences, such as phy pll configuration,
register width, 4K support, clk useage, and the crtc mux configuration
is also platform specific.
To reuse the imx hdmi driver, convert it to drm_bridge
handle encoder in imx-hdmi_pltfm.c, as most of the encoder
operation are platform specific such as crtc select and
panel format set
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v13:
- split platform specific phy configuration
Changes in v12:
- squash patch <convert dw_hdmi to drm_bridge>
Changes in v11:
- squash patch <split some phy configuration to platform driver>
Changes in v10:
- split generic dw_hdmi.c improvements from patch#11 (add rk3288 support)
Changes in v9: None
Changes in v8: None
Changes in v7:
- remove unused variables from structure dw_hdmi
- remove a wrong modification
- add copyrights for dw_hdmi-imx.c
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/imx/Makefile | 2 +-
drivers/gpu/drm/imx/imx-hdmi.c | 297 ++++++++++++-----------------------
drivers/gpu/drm/imx/imx-hdmi.h | 14 ++
drivers/gpu/drm/imx/imx-hdmi_pltfm.c | 218 +++++++++++++++++++++++++
4 files changed, 331 insertions(+), 200 deletions(-)
create mode 100644 drivers/gpu/drm/imx/imx-hdmi_pltfm.c
diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile
index 582c438..63cf56a 100644
--- a/drivers/gpu/drm/imx/Makefile
+++ b/drivers/gpu/drm/imx/Makefile
@@ -9,4 +9,4 @@ obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
imx-ipuv3-crtc-objs := ipuv3-crtc.o ipuv3-plane.o
obj-$(CONFIG_DRM_IMX_IPUV3) += imx-ipuv3-crtc.o
-obj-$(CONFIG_DRM_IMX_HDMI) += imx-hdmi.o
+obj-$(CONFIG_DRM_IMX_HDMI) += imx-hdmi.o imx-hdmi_pltfm.o
diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c
index 8029a07..4c3047f 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.c
+++ b/drivers/gpu/drm/imx/imx-hdmi.c
@@ -12,22 +12,17 @@
* Copyright (C) 2010, Guennadi Liakhovetski <g.liakhovetski@gmx.de>
*/
-#include <linux/component.h>
#include <linux/irq.h>
#include <linux/delay.h>
#include <linux/err.h>
-#include <linux/clk.h>
#include <linux/hdmi.h>
-#include <linux/regmap.h>
-#include <linux/mfd/syscon.h>
-#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
#include <linux/of_device.h>
+#include <drm/drm_of.h>
#include <drm/drmP.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_edid.h>
#include <drm/drm_encoder_slave.h>
-#include <video/imx-ipu-v3.h>
#include "imx-hdmi.h"
#include "imx-drm.h"
@@ -54,11 +49,6 @@ enum hdmi_datamap {
YCbCr422_12B = 0x12,
};
-enum imx_hdmi_devtype {
- IMX6Q_HDMI,
- IMX6DL_HDMI,
-};
-
static const u16 csc_coeff_default[3][4] = {
{ 0x2000, 0x0000, 0x0000, 0x0000 },
{ 0x0000, 0x2000, 0x0000, 0x0000 },
@@ -113,14 +103,14 @@ struct hdmi_data_info {
struct imx_hdmi {
struct drm_connector connector;
- struct drm_encoder encoder;
+ struct drm_encoder *encoder;
+ struct drm_bridge *bridge;
enum imx_hdmi_devtype dev_type;
struct device *dev;
- struct clk *isfr_clk;
- struct clk *iahb_clk;
struct hdmi_data_info hdmi_data;
+ const struct imx_hdmi_plat_data *plat_data;
int vic;
u8 edid[HDMI_EDID_LEN];
@@ -137,13 +127,6 @@ struct imx_hdmi {
int ratio;
};
-static void imx_hdmi_set_ipu_di_mux(struct imx_hdmi *hdmi, int ipu_di)
-{
- regmap_update_bits(hdmi->regmap, IOMUXC_GPR3,
- IMX6Q_GPR3_HDMI_MUX_CTL_MASK,
- ipu_di << IMX6Q_GPR3_HDMI_MUX_CTL_SHIFT);
-}
-
static inline void hdmi_writeb(struct imx_hdmi *hdmi, u8 val, int offset)
{
writeb(val, hdmi->regs + offset);
@@ -1371,6 +1354,50 @@ static void imx_hdmi_poweroff(struct imx_hdmi *hdmi)
imx_hdmi_phy_disable(hdmi);
}
+static void imx_hdmi_bridge_mode_set(struct drm_bridge *bridge,
+ struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
+{
+ struct imx_hdmi *hdmi = bridge->driver_private;
+
+ imx_hdmi_setup(hdmi, mode);
+
+ /* Store the display mode for plugin/DKMS poweron events */
+ memcpy(&hdmi->previous_mode, mode, sizeof(hdmi->previous_mode));
+}
+
+static bool imx_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
+ const struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
+{
+ return true;
+}
+
+static void imx_hdmi_bridge_disable(struct drm_bridge *bridge)
+{
+ struct imx_hdmi *hdmi = bridge->driver_private;
+
+ imx_hdmi_poweroff(hdmi);
+}
+
+static void imx_hdmi_bridge_enable(struct drm_bridge *bridge)
+{
+ struct imx_hdmi *hdmi = bridge->driver_private;
+
+ imx_hdmi_poweron(hdmi);
+}
+
+static void imx_hdmi_bridge_destroy(struct drm_bridge *bridge)
+{
+ drm_bridge_cleanup(bridge);
+ kfree(bridge);
+}
+
+static void imx_hdmi_bridge_nope(struct drm_bridge *bridge)
+{
+ /* do nothing */
+}
+
static enum drm_connector_status imx_hdmi_connector_detect(struct drm_connector
*connector, bool force)
{
@@ -1412,78 +1439,20 @@ static struct drm_encoder *imx_hdmi_connector_best_encoder(struct drm_connector
struct imx_hdmi *hdmi = container_of(connector, struct imx_hdmi,
connector);
- return &hdmi->encoder;
+ return hdmi->encoder;
}
-static void imx_hdmi_encoder_mode_set(struct drm_encoder *encoder,
- struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
+static void imx_hdmi_connector_destroy(struct drm_connector *connector)
{
- struct imx_hdmi *hdmi = container_of(encoder, struct imx_hdmi, encoder);
-
- imx_hdmi_setup(hdmi, mode);
-
- /* Store the display mode for plugin/DKMS poweron events */
- memcpy(&hdmi->previous_mode, mode, sizeof(hdmi->previous_mode));
+ drm_connector_unregister(connector);
+ drm_connector_cleanup(connector);
}
-static bool imx_hdmi_encoder_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
-{
- return true;
-}
-
-static void imx_hdmi_encoder_disable(struct drm_encoder *encoder)
-{
-}
-
-static void imx_hdmi_encoder_dpms(struct drm_encoder *encoder, int mode)
-{
- struct imx_hdmi *hdmi = container_of(encoder, struct imx_hdmi, encoder);
-
- if (mode)
- imx_hdmi_poweroff(hdmi);
- else
- imx_hdmi_poweron(hdmi);
-}
-
-static void imx_hdmi_encoder_prepare(struct drm_encoder *encoder)
-{
- struct imx_hdmi *hdmi = container_of(encoder, struct imx_hdmi, encoder);
-
- imx_hdmi_poweroff(hdmi);
- imx_drm_panel_format(encoder, V4L2_PIX_FMT_RGB24);
-}
-
-static void imx_hdmi_encoder_commit(struct drm_encoder *encoder)
-{
- struct imx_hdmi *hdmi = container_of(encoder, struct imx_hdmi, encoder);
- int mux = imx_drm_encoder_get_mux_id(hdmi->dev->of_node, encoder);
-
- imx_hdmi_set_ipu_di_mux(hdmi, mux);
-
- imx_hdmi_poweron(hdmi);
-}
-
-static struct drm_encoder_funcs imx_hdmi_encoder_funcs = {
- .destroy = imx_drm_encoder_destroy,
-};
-
-static struct drm_encoder_helper_funcs imx_hdmi_encoder_helper_funcs = {
- .dpms = imx_hdmi_encoder_dpms,
- .prepare = imx_hdmi_encoder_prepare,
- .commit = imx_hdmi_encoder_commit,
- .mode_set = imx_hdmi_encoder_mode_set,
- .mode_fixup = imx_hdmi_encoder_mode_fixup,
- .disable = imx_hdmi_encoder_disable,
-};
-
static struct drm_connector_funcs imx_hdmi_connector_funcs = {
.dpms = drm_helper_connector_dpms,
.fill_modes = drm_helper_probe_single_connector_modes,
.detect = imx_hdmi_connector_detect,
- .destroy = imx_drm_connector_destroy,
+ .destroy = imx_hdmi_connector_destroy,
};
static struct drm_connector_helper_funcs imx_hdmi_connector_helper_funcs = {
@@ -1491,6 +1460,16 @@ static struct drm_connector_helper_funcs imx_hdmi_connector_helper_funcs = {
.best_encoder = imx_hdmi_connector_best_encoder,
};
+struct drm_bridge_funcs imx_hdmi_bridge_funcs = {
+ .enable = imx_hdmi_bridge_enable,
+ .disable = imx_hdmi_bridge_disable,
+ .pre_enable = imx_hdmi_bridge_nope,
+ .post_disable = imx_hdmi_bridge_nope,
+ .mode_set = imx_hdmi_bridge_mode_set,
+ .mode_fixup = imx_hdmi_bridge_mode_fixup,
+ .destroy = imx_hdmi_bridge_destroy,
+};
+
static irqreturn_t imx_hdmi_hardirq(int irq, void *dev_id)
{
struct imx_hdmi *hdmi = dev_id;
@@ -1539,54 +1518,45 @@ static irqreturn_t imx_hdmi_irq(int irq, void *dev_id)
static int imx_hdmi_register(struct drm_device *drm, struct imx_hdmi *hdmi)
{
+ struct drm_encoder *encoder = hdmi->encoder;
+ struct drm_bridge *bridge;
int ret;
- ret = imx_drm_encoder_parse_of(drm, &hdmi->encoder,
- hdmi->dev->of_node);
- if (ret)
- return ret;
+ bridge = devm_kzalloc(drm->dev, sizeof(*bridge), GFP_KERNEL);
+ if (!bridge) {
+ DRM_ERROR("Failed to allocate drm bridge\n");
+ return -ENOMEM;
+ }
- hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
+ hdmi->bridge = bridge;
+ bridge->driver_private = hdmi;
- drm_encoder_helper_add(&hdmi->encoder, &imx_hdmi_encoder_helper_funcs);
- drm_encoder_init(drm, &hdmi->encoder, &imx_hdmi_encoder_funcs,
- DRM_MODE_ENCODER_TMDS);
+ ret = drm_bridge_init(drm, bridge, &imx_hdmi_bridge_funcs);
+ if (ret) {
+ DRM_ERROR("Failed to initialize bridge with drm\n");
+ return -EINVAL;
+ }
+
+ encoder->bridge = bridge;
+ hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
drm_connector_helper_add(&hdmi->connector,
&imx_hdmi_connector_helper_funcs);
drm_connector_init(drm, &hdmi->connector, &imx_hdmi_connector_funcs,
DRM_MODE_CONNECTOR_HDMIA);
- hdmi->connector.encoder = &hdmi->encoder;
+ hdmi->connector.encoder = encoder;
- drm_mode_connector_attach_encoder(&hdmi->connector, &hdmi->encoder);
+ drm_mode_connector_attach_encoder(&hdmi->connector, encoder);
return 0;
}
-static struct platform_device_id imx_hdmi_devtype[] = {
- {
- .name = "imx6q-hdmi",
- .driver_data = IMX6Q_HDMI,
- }, {
- .name = "imx6dl-hdmi",
- .driver_data = IMX6DL_HDMI,
- }, { /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(platform, imx_hdmi_devtype);
-
-static const struct of_device_id imx_hdmi_dt_ids[] = {
-{ .compatible = "fsl,imx6q-hdmi", .data = &imx_hdmi_devtype[IMX6Q_HDMI], },
-{ .compatible = "fsl,imx6dl-hdmi", .data = &imx_hdmi_devtype[IMX6DL_HDMI], },
-{ /* sentinel */ }
-};
-MODULE_DEVICE_TABLE(of, imx_hdmi_dt_ids);
-
-static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
+int imx_hdmi_bind(struct device *dev, struct device *master,
+ void *data, struct drm_encoder *encoder,
+ const struct imx_hdmi_plat_data *plat_data)
{
struct platform_device *pdev = to_platform_device(dev);
- const struct of_device_id *of_id =
- of_match_device(imx_hdmi_dt_ids, dev);
struct drm_device *drm = data;
struct device_node *np = dev->of_node;
struct device_node *ddc_node;
@@ -1594,19 +1564,16 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
struct resource *iores;
int ret, irq;
- hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL);
+ hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
if (!hdmi)
return -ENOMEM;
- hdmi->dev = dev;
+ hdmi->plat_data = plat_data;
+ hdmi->dev = &pdev->dev;
+ hdmi->dev_type = plat_data->dev_type;
hdmi->sample_rate = 48000;
hdmi->ratio = 100;
-
- if (of_id) {
- const struct platform_device_id *device_id = of_id->data;
-
- hdmi->dev_type = device_id->driver_data;
- }
+ hdmi->encoder = encoder;
ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
if (ddc_node) {
@@ -1636,40 +1603,6 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
if (IS_ERR(hdmi->regs))
return PTR_ERR(hdmi->regs);
- hdmi->regmap = syscon_regmap_lookup_by_phandle(np, "gpr");
- if (IS_ERR(hdmi->regmap))
- return PTR_ERR(hdmi->regmap);
-
- hdmi->isfr_clk = devm_clk_get(hdmi->dev, "isfr");
- if (IS_ERR(hdmi->isfr_clk)) {
- ret = PTR_ERR(hdmi->isfr_clk);
- dev_err(hdmi->dev,
- "Unable to get HDMI isfr clk: %d\n", ret);
- return ret;
- }
-
- ret = clk_prepare_enable(hdmi->isfr_clk);
- if (ret) {
- dev_err(hdmi->dev,
- "Cannot enable HDMI isfr clock: %d\n", ret);
- return ret;
- }
-
- hdmi->iahb_clk = devm_clk_get(hdmi->dev, "iahb");
- if (IS_ERR(hdmi->iahb_clk)) {
- ret = PTR_ERR(hdmi->iahb_clk);
- dev_err(hdmi->dev,
- "Unable to get HDMI iahb clk: %d\n", ret);
- goto err_isfr;
- }
-
- ret = clk_prepare_enable(hdmi->iahb_clk);
- if (ret) {
- dev_err(hdmi->dev,
- "Cannot enable HDMI iahb clock: %d\n", ret);
- goto err_isfr;
- }
-
/* Product and revision IDs */
dev_info(dev,
"Detected HDMI controller 0x%x:0x%x:0x%x:0x%x\n",
@@ -1697,11 +1630,11 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
ret = imx_hdmi_fb_registered(hdmi);
if (ret)
- goto err_iahb;
+ return ret;
ret = imx_hdmi_register(drm, hdmi);
if (ret)
- goto err_iahb;
+ return ret;
/* Unmute interrupts */
hdmi_writeb(hdmi, ~HDMI_IH_PHY_STAT0_HPD, HDMI_IH_MUTE_PHY_STAT0);
@@ -1709,17 +1642,10 @@ static int imx_hdmi_bind(struct device *dev, struct device *master, void *data)
dev_set_drvdata(dev, hdmi);
return 0;
-
-err_iahb:
- clk_disable_unprepare(hdmi->iahb_clk);
-err_isfr:
- clk_disable_unprepare(hdmi->isfr_clk);
-
- return ret;
}
+EXPORT_SYMBOL_GPL(imx_hdmi_bind);
-static void imx_hdmi_unbind(struct device *dev, struct device *master,
- void *data)
+void imx_hdmi_unbind(struct device *dev, struct device *master, void *data)
{
struct imx_hdmi *hdmi = dev_get_drvdata(dev);
@@ -1727,42 +1653,15 @@ static void imx_hdmi_unbind(struct device *dev, struct device *master,
hdmi_writeb(hdmi, ~0, HDMI_IH_MUTE_PHY_STAT0);
hdmi->connector.funcs->destroy(&hdmi->connector);
- hdmi->encoder.funcs->destroy(&hdmi->encoder);
+ hdmi->encoder->funcs->destroy(hdmi->encoder);
- clk_disable_unprepare(hdmi->iahb_clk);
- clk_disable_unprepare(hdmi->isfr_clk);
i2c_put_adapter(hdmi->ddc);
}
-
-static const struct component_ops hdmi_ops = {
- .bind = imx_hdmi_bind,
- .unbind = imx_hdmi_unbind,
-};
-
-static int imx_hdmi_platform_probe(struct platform_device *pdev)
-{
- return component_add(&pdev->dev, &hdmi_ops);
-}
-
-static int imx_hdmi_platform_remove(struct platform_device *pdev)
-{
- component_del(&pdev->dev, &hdmi_ops);
- return 0;
-}
-
-static struct platform_driver imx_hdmi_driver = {
- .probe = imx_hdmi_platform_probe,
- .remove = imx_hdmi_platform_remove,
- .driver = {
- .name = "imx-hdmi",
- .owner = THIS_MODULE,
- .of_match_table = imx_hdmi_dt_ids,
- },
-};
-
-module_platform_driver(imx_hdmi_driver);
+EXPORT_SYMBOL_GPL(imx_hdmi_unbind);
MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
+MODULE_AUTHOR("Andy Yan <andy.yan@rock-chips.com>");
+MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
MODULE_DESCRIPTION("i.MX6 HDMI transmitter driver");
MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:imx-hdmi");
diff --git a/drivers/gpu/drm/imx/imx-hdmi.h b/drivers/gpu/drm/imx/imx-hdmi.h
index 39b6776..14e593e 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.h
+++ b/drivers/gpu/drm/imx/imx-hdmi.h
@@ -1029,4 +1029,18 @@ enum {
HDMI_A_VIDPOLCFG_HSYNCPOL_ACTIVE_HIGH = 0x2,
HDMI_A_VIDPOLCFG_HSYNCPOL_ACTIVE_LOW = 0x0,
};
+
+enum imx_hdmi_devtype {
+ IMX6Q_HDMI,
+ IMX6DL_HDMI,
+};
+
+struct imx_hdmi_plat_data {
+ enum imx_hdmi_devtype dev_type;
+};
+
+int imx_hdmi_bind(struct device *dev, struct device *master,
+ void *data, struct drm_encoder *encoder,
+ const struct imx_hdmi_plat_data *plat_data);
+void imx_hdmi_unbind(struct device *dev, struct device *master, void *data);
#endif /* __IMX_HDMI_H__ */
diff --git a/drivers/gpu/drm/imx/imx-hdmi_pltfm.c b/drivers/gpu/drm/imx/imx-hdmi_pltfm.c
new file mode 100644
index 0000000..a7983f2
--- /dev/null
+++ b/drivers/gpu/drm/imx/imx-hdmi_pltfm.c
@@ -0,0 +1,218 @@
+/* Copyright (C) 2011-2013 Freescale Semiconductor, Inc.
+ *
+ * derived from imx-hdmi.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/component.h>
+#include <linux/mfd/syscon.h>
+#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
+#include <video/imx-ipu-v3.h>
+#include <linux/regmap.h>
+#include <linux/clk.h>
+#include <drm/drm_of.h>
+#include <drm/drmP.h>
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_edid.h>
+#include <drm/drm_encoder_slave.h>
+
+#include "imx-drm.h"
+#include "imx-hdmi.h"
+
+struct imx_hdmi_priv {
+ struct device *dev;
+ struct drm_encoder encoder;
+ struct clk *isfr_clk;
+ struct clk *iahb_clk;
+ struct regmap *regmap;
+};
+
+static int imx_hdmi_parse_dt(struct imx_hdmi_priv *hdmi)
+{
+ struct device_node *np = hdmi->dev->of_node;
+
+ hdmi->regmap = syscon_regmap_lookup_by_phandle(np, "gpr");
+ if (IS_ERR(hdmi->regmap)) {
+ dev_err(hdmi->dev, "Unable to get gpr\n");
+ return PTR_ERR(hdmi->regmap);
+ }
+
+ hdmi->isfr_clk = devm_clk_get(hdmi->dev, "isfr");
+ if (IS_ERR(hdmi->isfr_clk)) {
+ dev_err(hdmi->dev, "Unable to get HDMI isfr clk\n");
+ return PTR_ERR(hdmi->isfr_clk);
+ }
+
+ hdmi->iahb_clk = devm_clk_get(hdmi->dev, "iahb");
+ if (IS_ERR(hdmi->iahb_clk)) {
+ dev_err(hdmi->dev, "Unable to get HDMI iahb clk\n");
+ return PTR_ERR(hdmi->iahb_clk);
+ }
+
+ return 0;
+}
+
+static void imx_hdmi_encoder_disable(struct drm_encoder *encoder)
+{
+}
+
+static bool imx_hdmi_encoder_mode_fixup(struct drm_encoder *encoder,
+ const struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
+{
+ return true;
+}
+
+static void imx_hdmi_encoder_mode_set(struct drm_encoder *encoder,
+ struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
+{
+}
+
+static void imx_hdmi_encoder_commit(struct drm_encoder *encoder)
+{
+ struct imx_hdmi_priv *hdmi = container_of(encoder,
+ struct imx_hdmi_priv,
+ encoder);
+ int mux = imx_drm_encoder_get_mux_id(hdmi->dev->of_node, encoder);
+
+ regmap_update_bits(hdmi->regmap, IOMUXC_GPR3,
+ IMX6Q_GPR3_HDMI_MUX_CTL_MASK,
+ mux << IMX6Q_GPR3_HDMI_MUX_CTL_SHIFT);
+}
+
+static void imx_hdmi_encoder_prepare(struct drm_encoder *encoder)
+{
+ imx_drm_panel_format(encoder, V4L2_PIX_FMT_RGB24);
+}
+
+static struct drm_encoder_helper_funcs imx_hdmi_encoder_helper_funcs = {
+ .mode_fixup = imx_hdmi_encoder_mode_fixup,
+ .mode_set = imx_hdmi_encoder_mode_set,
+ .prepare = imx_hdmi_encoder_prepare,
+ .commit = imx_hdmi_encoder_commit,
+ .disable = imx_hdmi_encoder_disable,
+};
+
+static struct drm_encoder_funcs imx_hdmi_encoder_funcs = {
+ .destroy = drm_encoder_cleanup,
+};
+
+static struct imx_hdmi_plat_data imx6q_hdmi_drv_data = {
+ .dev_type = IMX6Q_HDMI,
+};
+
+static struct imx_hdmi_plat_data imx6dl_hdmi_drv_data = {
+ .dev_type = IMX6DL_HDMI,
+};
+
+static const struct of_device_id imx_hdmi_dt_ids[] = {
+ { .compatible = "fsl,imx6q-hdmi",
+ .data = &imx6q_hdmi_drv_data
+ }, {
+ .compatible = "fsl,imx6dl-hdmi",
+ .data = &imx6dl_hdmi_drv_data
+ },
+ {},
+};
+MODULE_DEVICE_TABLE(of, imx_hdmi_dt_ids);
+
+static int imx_hdmi_pltfm_bind(struct device *dev, struct device *master,
+ void *data)
+{
+ struct platform_device *pdev = to_platform_device(dev);
+ const struct imx_hdmi_plat_data *plat_data;
+ const struct of_device_id *match;
+ struct drm_device *drm = data;
+ struct drm_encoder *encoder;
+ struct imx_hdmi_priv *hdmi;
+ int ret;
+
+ if (!pdev->dev.of_node)
+ return -ENODEV;
+
+ hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
+ if (!hdmi)
+ return -ENOMEM;
+
+ match = of_match_node(imx_hdmi_dt_ids, pdev->dev.of_node);
+ plat_data = match->data;
+ hdmi->dev = &pdev->dev;
+ encoder = &hdmi->encoder;
+ platform_set_drvdata(pdev, hdmi);
+
+ ret = imx_hdmi_parse_dt(hdmi);
+ if (ret < 0)
+ return ret;
+
+ ret = clk_prepare_enable(hdmi->isfr_clk);
+ if (ret) {
+ dev_err(dev, "Cannot enable HDMI isfr clock: %d\n", ret);
+ return ret;
+ }
+
+ ret = clk_prepare_enable(hdmi->iahb_clk);
+ if (ret) {
+ dev_err(dev, "Cannot enable HDMI iahb clock: %d\n", ret);
+ return ret;
+ }
+
+ encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
+
+ drm_encoder_helper_add(encoder, &imx_hdmi_encoder_helper_funcs);
+ drm_encoder_init(drm, encoder, &imx_hdmi_encoder_funcs,
+ DRM_MODE_ENCODER_TMDS);
+
+ return imx_hdmi_bind(dev, master, data, encoder, plat_data);
+}
+
+static void imx_hdmi_pltfm_unbind(struct device *dev, struct device *master,
+ void *data)
+{
+ struct platform_device *pdev = to_platform_device(dev);
+ struct imx_hdmi_priv *hdmi = platform_get_drvdata(pdev);
+
+ clk_disable_unprepare(hdmi->isfr_clk);
+ clk_disable_unprepare(hdmi->iahb_clk);
+
+ return imx_hdmi_unbind(dev, master, data);
+}
+
+static const struct component_ops imx_hdmi_ops = {
+ .bind = imx_hdmi_pltfm_bind,
+ .unbind = imx_hdmi_pltfm_unbind,
+};
+
+static int imx_hdmi_probe(struct platform_device *pdev)
+{
+ return component_add(&pdev->dev, &imx_hdmi_ops);
+}
+
+static int imx_hdmi_remove(struct platform_device *pdev)
+{
+ component_del(&pdev->dev, &imx_hdmi_ops);
+
+ return 0;
+}
+
+static struct platform_driver imx_hdmi_pltfm_driver = {
+ .probe = imx_hdmi_probe,
+ .remove = imx_hdmi_remove,
+ .driver = {
+ .name = "hdmi-imx",
+ .owner = THIS_MODULE,
+ .of_match_table = imx_hdmi_dt_ids,
+ },
+};
+
+module_platform_driver(imx_hdmi_pltfm_driver);
+
+MODULE_AUTHOR("Andy Yan <andy.yan@rock-chips.com>");
+MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
+MODULE_DESCRIPTION("IMX6 Specific DW-HDMI Driver Extension");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:hdmi-imx");
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (2 preceding siblings ...)
2014-11-26 13:27 ` [PATCH v13 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode Andy Yan
@ 2014-11-26 13:30 ` Andy Yan
2014-11-26 13:30 ` [PATCH v13 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Andy Yan
` (8 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:30 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
hdmi phy configuration is platform specific, which can be adusted
according to the board to get the best SI
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13:
- split phy configuration from patch#4
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/imx/imx-hdmi.c | 85 +++++++-----------------------------
drivers/gpu/drm/imx/imx-hdmi.h | 29 ++++++++++++
drivers/gpu/drm/imx/imx-hdmi_pltfm.c | 57 ++++++++++++++++++++++++
3 files changed, 101 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/imx/imx-hdmi.c
index 4c3047f..9503728 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.c
+++ b/drivers/gpu/drm/imx/imx-hdmi.c
@@ -711,76 +711,14 @@ static void imx_hdmi_phy_sel_interface_control(struct imx_hdmi *hdmi, u8 enable)
HDMI_PHY_CONF0_SELDIPIF_MASK);
}
-enum {
- RES_8,
- RES_10,
- RES_12,
- RES_MAX,
-};
-
-struct mpll_config {
- unsigned long mpixelclock;
- struct {
- u16 cpce;
- u16 gmp;
- } res[RES_MAX];
-};
-
-static const struct mpll_config mpll_config[] = {
- {
- 45250000, {
- { 0x01e0, 0x0000 },
- { 0x21e1, 0x0000 },
- { 0x41e2, 0x0000 }
- },
- }, {
- 92500000, {
- { 0x0140, 0x0005 },
- { 0x2141, 0x0005 },
- { 0x4142, 0x0005 },
- },
- }, {
- 148500000, {
- { 0x00a0, 0x000a },
- { 0x20a1, 0x000a },
- { 0x40a2, 0x000a },
- },
- }, {
- ~0UL, {
- { 0x00a0, 0x000a },
- { 0x2001, 0x000f },
- { 0x4002, 0x000f },
- },
- }
-};
-
-struct curr_ctrl {
- unsigned long mpixelclock;
- u16 curr[RES_MAX];
-};
-
-static const struct curr_ctrl curr_ctrl[] = {
- /* pixelclk bpp8 bpp10 bpp12 */
- {
- 54000000, { 0x091c, 0x091c, 0x06dc },
- }, {
- 58400000, { 0x091c, 0x06dc, 0x06dc },
- }, {
- 72000000, { 0x06dc, 0x06dc, 0x091c },
- }, {
- 74250000, { 0x06dc, 0x0b5c, 0x091c },
- }, {
- 118800000, { 0x091c, 0x091c, 0x06dc },
- }, {
- 216000000, { 0x06dc, 0x0b5c, 0x091c },
- }
-};
-
static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
unsigned char res, int cscon)
{
unsigned res_idx, i;
u8 val, msec;
+ const struct mpll_config *mpll_config = hdmi->plat_data->mpll_cfg;
+ const struct curr_ctrl *curr_ctrl = hdmi->plat_data->cur_ctr;
+ const struct sym_term *sym_term = hdmi->plat_data->sym_term;
if (prep)
return -EINVAL;
@@ -826,7 +764,7 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
hdmi_phy_test_clear(hdmi, 0);
/* PLL/MPLL Cfg - always match on final entry */
- for (i = 0; i < ARRAY_SIZE(mpll_config) - 1; i++)
+ for (i = 0; mpll_config[i].mpixelclock != (~0UL); i++)
if (hdmi->hdmi_data.video_mode.mpixelclock <=
mpll_config[i].mpixelclock)
break;
@@ -834,12 +772,12 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
hdmi_phy_i2c_write(hdmi, mpll_config[i].res[res_idx].cpce, 0x06);
hdmi_phy_i2c_write(hdmi, mpll_config[i].res[res_idx].gmp, 0x15);
- for (i = 0; i < ARRAY_SIZE(curr_ctrl); i++)
+ for (i = 0; curr_ctrl[i].mpixelclock != (~0UL); i++)
if (hdmi->hdmi_data.video_mode.mpixelclock <=
curr_ctrl[i].mpixelclock)
break;
- if (i >= ARRAY_SIZE(curr_ctrl)) {
+ if (curr_ctrl[i].mpixelclock == (~0UL)) {
dev_err(hdmi->dev, "Pixel clock %d - unsupported by HDMI\n",
hdmi->hdmi_data.video_mode.mpixelclock);
return -EINVAL;
@@ -850,10 +788,17 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
hdmi_phy_i2c_write(hdmi, 0x0000, 0x13); /* PLLPHBYCTRL */
hdmi_phy_i2c_write(hdmi, 0x0006, 0x17);
+
+ for (i = 0; sym_term[i].mpixelclock != (~0UL); i++)
+ if (hdmi->hdmi_data.video_mode.mpixelclock <=
+ sym_term[i].mpixelclock)
+ break;
+
/* RESISTANCE TERM 133Ohm Cfg */
- hdmi_phy_i2c_write(hdmi, 0x0005, 0x19); /* TXTERM */
+ hdmi_phy_i2c_write(hdmi, sym_term[i].term, 0x19); /* TXTERM */
/* PREEMP Cgf 0.00 */
- hdmi_phy_i2c_write(hdmi, 0x800d, 0x09); /* CKSYMTXCTRL */
+ hdmi_phy_i2c_write(hdmi, sym_term[i].sym_ctr, 0x09); /* CKSYMTXCTRL */
+
/* TX/CK LVL 10 */
hdmi_phy_i2c_write(hdmi, 0x01ad, 0x0E); /* VLEVCTRL */
/* REMOVE CLK TERM */
diff --git a/drivers/gpu/drm/imx/imx-hdmi.h b/drivers/gpu/drm/imx/imx-hdmi.h
index 14e593e..bced9ef 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.h
+++ b/drivers/gpu/drm/imx/imx-hdmi.h
@@ -1037,6 +1037,35 @@ enum imx_hdmi_devtype {
struct imx_hdmi_plat_data {
enum imx_hdmi_devtype dev_type;
+ const struct mpll_config *mpll_cfg;
+ const struct curr_ctrl *cur_ctr;
+ const struct sym_term *sym_term;
+};
+
+enum {
+ RES_8,
+ RES_10,
+ RES_12,
+ RES_MAX,
+};
+
+struct mpll_config {
+ unsigned long mpixelclock;
+ struct {
+ u16 cpce;
+ u16 gmp;
+ } res[RES_MAX];
+};
+
+struct curr_ctrl {
+ unsigned long mpixelclock;
+ u16 curr[RES_MAX];
+};
+
+struct sym_term {
+ unsigned long mpixelclock;
+ u16 sym_ctr; /*clock symbol and transmitter control*/
+ u16 term; /*transmission termination value*/
};
int imx_hdmi_bind(struct device *dev, struct device *master,
diff --git a/drivers/gpu/drm/imx/imx-hdmi_pltfm.c b/drivers/gpu/drm/imx/imx-hdmi_pltfm.c
index a7983f2..519a22d 100644
--- a/drivers/gpu/drm/imx/imx-hdmi_pltfm.c
+++ b/drivers/gpu/drm/imx/imx-hdmi_pltfm.c
@@ -31,6 +31,57 @@ struct imx_hdmi_priv {
struct regmap *regmap;
};
+static const struct mpll_config imx_mpll_cfg[] = {
+ {
+ 45250000, {
+ { 0x01e0, 0x0000 },
+ { 0x21e1, 0x0000 },
+ { 0x41e2, 0x0000 }
+ },
+ }, {
+ 92500000, {
+ { 0x0140, 0x0005 },
+ { 0x2141, 0x0005 },
+ { 0x4142, 0x0005 },
+ },
+ }, {
+ 148500000, {
+ { 0x00a0, 0x000a },
+ { 0x20a1, 0x000a },
+ { 0x40a2, 0x000a },
+ },
+ }, {
+ ~0UL, {
+ { 0x00a0, 0x000a },
+ { 0x2001, 0x000f },
+ { 0x4002, 0x000f },
+ },
+ }
+};
+
+static const struct curr_ctrl imx_cur_ctr[] = {
+ /* pixelclk bpp8 bpp10 bpp12 */
+ {
+ 54000000, { 0x091c, 0x091c, 0x06dc },
+ }, {
+ 58400000, { 0x091c, 0x06dc, 0x06dc },
+ }, {
+ 72000000, { 0x06dc, 0x06dc, 0x091c },
+ }, {
+ 74250000, { 0x06dc, 0x0b5c, 0x091c },
+ }, {
+ 118800000, { 0x091c, 0x091c, 0x06dc },
+ }, {
+ 216000000, { 0x06dc, 0x0b5c, 0x091c },
+ }
+};
+
+static const struct sym_term imx_sym_term[] = {
+ /*pixelclk symbol term*/
+ { 148500000, 0x800d, 0x0005 },
+ { ~0UL, 0x0000, 0x0000 }
+};
+
static int imx_hdmi_parse_dt(struct imx_hdmi_priv *hdmi)
{
struct device_node *np = hdmi->dev->of_node;
@@ -103,10 +154,16 @@ static struct drm_encoder_funcs imx_hdmi_encoder_funcs = {
};
static struct imx_hdmi_plat_data imx6q_hdmi_drv_data = {
+ .mpll_cfg = imx_mpll_cfg,
+ .cur_ctr = imx_cur_ctr,
+ .sym_term = imx_sym_term,
.dev_type = IMX6Q_HDMI,
};
static struct imx_hdmi_plat_data imx6dl_hdmi_drv_data = {
+ .mpll_cfg = imx_mpll_cfg,
+ .cur_ctr = imx_cur_ctr,
+ .sym_term = imx_sym_term,
.dev_type = IMX6DL_HDMI,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (3 preceding siblings ...)
2014-11-26 13:30 ` [PATCH v13 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver Andy Yan
@ 2014-11-26 13:30 ` Andy Yan
2014-11-26 13:31 ` [PATCH v13 06/12] dt-bindings: add document for dw_hdmi Andy Yan
` (7 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:30 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
the original imx hdmi driver is under drm/imx/,
which depends on imx-drm, so move the imx hdmi
driver out to drm/bridge and rename it to dw_hdmi
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile | 1 +
.../gpu/drm/{imx/imx-hdmi.c => bridge/dw_hdmi.c} | 270 ++++++++++-----------
.../gpu/drm/{imx/imx-hdmi.h => bridge/dw_hdmi.h} | 42 ----
drivers/gpu/drm/imx/Kconfig | 1 +
drivers/gpu/drm/imx/Makefile | 2 +-
.../drm/imx/{imx-hdmi_pltfm.c => dw_hdmi-imx.c} | 118 +++++----
include/drm/bridge/dw_hdmi.h | 57 +++++
8 files changed, 258 insertions(+), 238 deletions(-)
rename drivers/gpu/drm/{imx/imx-hdmi.c => bridge/dw_hdmi.c} (84%)
rename drivers/gpu/drm/{imx/imx-hdmi.h => bridge/dw_hdmi.h} (98%)
rename drivers/gpu/drm/imx/{imx-hdmi_pltfm.c => dw_hdmi-imx.c} (60%)
create mode 100644 include/drm/bridge/dw_hdmi.h
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 884923f..26162ef 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -3,3 +3,8 @@ config DRM_PTN3460
depends on DRM
select DRM_KMS_HELPER
---help---
+
+config DRM_DW_HDMI
+ bool "Synopsys DesignWare High-Definition Multimedia Interface"
+ depends on DRM
+ select DRM_KMS_HELPER
diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
index b4733e1..d8a8cfd 100644
--- a/drivers/gpu/drm/bridge/Makefile
+++ b/drivers/gpu/drm/bridge/Makefile
@@ -1,3 +1,4 @@
ccflags-y := -Iinclude/drm
obj-$(CONFIG_DRM_PTN3460) += ptn3460.o
+obj-$(CONFIG_DRM_DW_HDMI) += dw_hdmi.o
diff --git a/drivers/gpu/drm/imx/imx-hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
similarity index 84%
rename from drivers/gpu/drm/imx/imx-hdmi.c
rename to drivers/gpu/drm/bridge/dw_hdmi.c
index 9503728..a53bf63 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -6,12 +6,11 @@
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
- * SH-Mobile High-Definition Multimedia Interface (HDMI) driver
- * for SLISHDMI13T and SLIPHDMIT IP cores
+ * Designware High-Definition Multimedia Interface (HDMI) driver
*
* Copyright (C) 2010, Guennadi Liakhovetski <g.liakhovetski@gmx.de>
*/
-
+#include <linux/module.h>
#include <linux/irq.h>
#include <linux/delay.h>
#include <linux/err.h>
@@ -23,9 +22,9 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_edid.h>
#include <drm/drm_encoder_slave.h>
+#include <drm/bridge/dw_hdmi.h>
-#include "imx-hdmi.h"
-#include "imx-drm.h"
+#include "dw_hdmi.h"
#define HDMI_EDID_LEN 512
@@ -101,16 +100,17 @@ struct hdmi_data_info {
struct hdmi_vmode video_mode;
};
-struct imx_hdmi {
+struct dw_hdmi {
struct drm_connector connector;
struct drm_encoder *encoder;
struct drm_bridge *bridge;
- enum imx_hdmi_devtype dev_type;
+ enum dw_hdmi_devtype dev_type;
struct device *dev;
struct hdmi_data_info hdmi_data;
- const struct imx_hdmi_plat_data *plat_data;
+ const struct dw_hdmi_plat_data *plat_data;
+
int vic;
u8 edid[HDMI_EDID_LEN];
@@ -127,17 +127,17 @@ struct imx_hdmi {
int ratio;
};
-static inline void hdmi_writeb(struct imx_hdmi *hdmi, u8 val, int offset)
+static inline void hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
{
writeb(val, hdmi->regs + offset);
}
-static inline u8 hdmi_readb(struct imx_hdmi *hdmi, int offset)
+static inline u8 hdmi_readb(struct dw_hdmi *hdmi, int offset)
{
return readb(hdmi->regs + offset);
}
-static void hdmi_modb(struct imx_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
+static void hdmi_modb(struct dw_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
{
u8 val = hdmi_readb(hdmi, reg) & ~mask;
@@ -145,13 +145,13 @@ static void hdmi_modb(struct imx_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
hdmi_writeb(hdmi, val, reg);
}
-static void hdmi_mask_writeb(struct imx_hdmi *hdmi, u8 data, unsigned int reg,
+static void hdmi_mask_writeb(struct dw_hdmi *hdmi, u8 data, unsigned int reg,
u8 shift, u8 mask)
{
hdmi_modb(hdmi, data << shift, mask, reg);
}
-static void hdmi_set_clock_regenerator_n(struct imx_hdmi *hdmi,
+static void hdmi_set_clock_regenerator_n(struct dw_hdmi *hdmi,
unsigned int value)
{
hdmi_writeb(hdmi, value & 0xff, HDMI_AUD_N1);
@@ -162,7 +162,7 @@ static void hdmi_set_clock_regenerator_n(struct imx_hdmi *hdmi,
hdmi_modb(hdmi, 0, HDMI_AUD_CTS3_N_SHIFT_MASK, HDMI_AUD_CTS3);
}
-static void hdmi_regenerate_cts(struct imx_hdmi *hdmi, unsigned int cts)
+static void hdmi_regenerate_cts(struct dw_hdmi *hdmi, unsigned int cts)
{
/* Must be set/cleared first */
hdmi_modb(hdmi, 0, HDMI_AUD_CTS3_CTS_MANUAL, HDMI_AUD_CTS3);
@@ -309,7 +309,7 @@ static unsigned int hdmi_compute_cts(unsigned int freq, unsigned long pixel_clk,
return (cts * ratio) / 100;
}
-static void hdmi_set_clk_regenerator(struct imx_hdmi *hdmi,
+static void hdmi_set_clk_regenerator(struct dw_hdmi *hdmi,
unsigned long pixel_clk)
{
unsigned int clk_n, clk_cts;
@@ -333,12 +333,12 @@ static void hdmi_set_clk_regenerator(struct imx_hdmi *hdmi,
hdmi_regenerate_cts(hdmi, clk_cts);
}
-static void hdmi_init_clk_regenerator(struct imx_hdmi *hdmi)
+static void hdmi_init_clk_regenerator(struct dw_hdmi *hdmi)
{
hdmi_set_clk_regenerator(hdmi, 74250000);
}
-static void hdmi_clk_regenerator_update_pixel_clock(struct imx_hdmi *hdmi)
+static void hdmi_clk_regenerator_update_pixel_clock(struct dw_hdmi *hdmi)
{
hdmi_set_clk_regenerator(hdmi, hdmi->hdmi_data.video_mode.mpixelclock);
}
@@ -350,7 +350,7 @@ static void hdmi_clk_regenerator_update_pixel_clock(struct imx_hdmi *hdmi)
* pin{31~24} <==> G[7:0]
* pin{15~8} <==> B[7:0]
*/
-static void hdmi_video_sample(struct imx_hdmi *hdmi)
+static void hdmi_video_sample(struct dw_hdmi *hdmi)
{
int color_format = 0;
u8 val;
@@ -406,12 +406,12 @@ static void hdmi_video_sample(struct imx_hdmi *hdmi)
hdmi_writeb(hdmi, 0x0, HDMI_TX_BCBDATA1);
}
-static int is_color_space_conversion(struct imx_hdmi *hdmi)
+static int is_color_space_conversion(struct dw_hdmi *hdmi)
{
return hdmi->hdmi_data.enc_in_format != hdmi->hdmi_data.enc_out_format;
}
-static int is_color_space_decimation(struct imx_hdmi *hdmi)
+static int is_color_space_decimation(struct dw_hdmi *hdmi)
{
if (hdmi->hdmi_data.enc_out_format != YCBCR422_8BITS)
return 0;
@@ -421,7 +421,7 @@ static int is_color_space_decimation(struct imx_hdmi *hdmi)
return 0;
}
-static int is_color_space_interpolation(struct imx_hdmi *hdmi)
+static int is_color_space_interpolation(struct dw_hdmi *hdmi)
{
if (hdmi->hdmi_data.enc_in_format != YCBCR422_8BITS)
return 0;
@@ -431,7 +431,7 @@ static int is_color_space_interpolation(struct imx_hdmi *hdmi)
return 0;
}
-static void imx_hdmi_update_csc_coeffs(struct imx_hdmi *hdmi)
+static void dw_hdmi_update_csc_coeffs(struct dw_hdmi *hdmi)
{
const u16 (*csc_coeff)[3][4] = &csc_coeff_default;
unsigned i;
@@ -472,7 +472,7 @@ static void imx_hdmi_update_csc_coeffs(struct imx_hdmi *hdmi)
HDMI_CSC_SCALE);
}
-static void hdmi_video_csc(struct imx_hdmi *hdmi)
+static void hdmi_video_csc(struct dw_hdmi *hdmi)
{
int color_depth = 0;
int interpolation = HDMI_CSC_CFG_INTMODE_DISABLE;
@@ -500,7 +500,7 @@ static void hdmi_video_csc(struct imx_hdmi *hdmi)
hdmi_modb(hdmi, color_depth, HDMI_CSC_SCALE_CSC_COLORDE_PTH_MASK,
HDMI_CSC_SCALE);
- imx_hdmi_update_csc_coeffs(hdmi);
+ dw_hdmi_update_csc_coeffs(hdmi);
}
/*
@@ -508,7 +508,7 @@ static void hdmi_video_csc(struct imx_hdmi *hdmi)
* for example, if input is YCC422 mode or repeater is used,
* data should be repacked this module can be bypassed.
*/
-static void hdmi_video_packetize(struct imx_hdmi *hdmi)
+static void hdmi_video_packetize(struct dw_hdmi *hdmi)
{
unsigned int color_depth = 0;
unsigned int remap_size = HDMI_VP_REMAP_YCC422_16bit;
@@ -605,40 +605,40 @@ static void hdmi_video_packetize(struct imx_hdmi *hdmi)
HDMI_VP_CONF);
}
-static inline void hdmi_phy_test_clear(struct imx_hdmi *hdmi,
+static inline void hdmi_phy_test_clear(struct dw_hdmi *hdmi,
unsigned char bit)
{
hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLR_OFFSET,
HDMI_PHY_TST0_TSTCLR_MASK, HDMI_PHY_TST0);
}
-static inline void hdmi_phy_test_enable(struct imx_hdmi *hdmi,
+static inline void hdmi_phy_test_enable(struct dw_hdmi *hdmi,
unsigned char bit)
{
hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTEN_OFFSET,
HDMI_PHY_TST0_TSTEN_MASK, HDMI_PHY_TST0);
}
-static inline void hdmi_phy_test_clock(struct imx_hdmi *hdmi,
+static inline void hdmi_phy_test_clock(struct dw_hdmi *hdmi,
unsigned char bit)
{
hdmi_modb(hdmi, bit << HDMI_PHY_TST0_TSTCLK_OFFSET,
HDMI_PHY_TST0_TSTCLK_MASK, HDMI_PHY_TST0);
}
-static inline void hdmi_phy_test_din(struct imx_hdmi *hdmi,
+static inline void hdmi_phy_test_din(struct dw_hdmi *hdmi,
unsigned char bit)
{
hdmi_writeb(hdmi, bit, HDMI_PHY_TST1);
}
-static inline void hdmi_phy_test_dout(struct imx_hdmi *hdmi,
+static inline void hdmi_phy_test_dout(struct dw_hdmi *hdmi,
unsigned char bit)
{
hdmi_writeb(hdmi, bit, HDMI_PHY_TST2);
}
-static bool hdmi_phy_wait_i2c_done(struct imx_hdmi *hdmi, int msec)
+static bool hdmi_phy_wait_i2c_done(struct dw_hdmi *hdmi, int msec)
{
while ((hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3) == 0) {
if (msec-- == 0)
@@ -648,7 +648,7 @@ static bool hdmi_phy_wait_i2c_done(struct imx_hdmi *hdmi, int msec)
return true;
}
-static void __hdmi_phy_i2c_write(struct imx_hdmi *hdmi, unsigned short data,
+static void __hdmi_phy_i2c_write(struct dw_hdmi *hdmi, unsigned short data,
unsigned char addr)
{
hdmi_writeb(hdmi, 0xFF, HDMI_IH_I2CMPHY_STAT0);
@@ -662,56 +662,56 @@ static void __hdmi_phy_i2c_write(struct imx_hdmi *hdmi, unsigned short data,
hdmi_phy_wait_i2c_done(hdmi, 1000);
}
-static int hdmi_phy_i2c_write(struct imx_hdmi *hdmi, unsigned short data,
+static int hdmi_phy_i2c_write(struct dw_hdmi *hdmi, unsigned short data,
unsigned char addr)
{
__hdmi_phy_i2c_write(hdmi, data, addr);
return 0;
}
-static void imx_hdmi_phy_enable_power(struct imx_hdmi *hdmi, u8 enable)
+static void dw_hdmi_phy_enable_power(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
HDMI_PHY_CONF0_PDZ_OFFSET,
HDMI_PHY_CONF0_PDZ_MASK);
}
-static void imx_hdmi_phy_enable_tmds(struct imx_hdmi *hdmi, u8 enable)
+static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
HDMI_PHY_CONF0_ENTMDS_OFFSET,
HDMI_PHY_CONF0_ENTMDS_MASK);
}
-static void imx_hdmi_phy_gen2_pddq(struct imx_hdmi *hdmi, u8 enable)
+static void dw_hdmi_phy_gen2_pddq(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
HDMI_PHY_CONF0_GEN2_PDDQ_OFFSET,
HDMI_PHY_CONF0_GEN2_PDDQ_MASK);
}
-static void imx_hdmi_phy_gen2_txpwron(struct imx_hdmi *hdmi, u8 enable)
+static void dw_hdmi_phy_gen2_txpwron(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
HDMI_PHY_CONF0_GEN2_TXPWRON_OFFSET,
HDMI_PHY_CONF0_GEN2_TXPWRON_MASK);
}
-static void imx_hdmi_phy_sel_data_en_pol(struct imx_hdmi *hdmi, u8 enable)
+static void dw_hdmi_phy_sel_data_en_pol(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
HDMI_PHY_CONF0_SELDATAENPOL_OFFSET,
HDMI_PHY_CONF0_SELDATAENPOL_MASK);
}
-static void imx_hdmi_phy_sel_interface_control(struct imx_hdmi *hdmi, u8 enable)
+static void dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
HDMI_PHY_CONF0_SELDIPIF_OFFSET,
HDMI_PHY_CONF0_SELDIPIF_MASK);
}
-static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
+static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep,
unsigned char res, int cscon)
{
unsigned res_idx, i;
@@ -747,10 +747,10 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
hdmi_writeb(hdmi, val, HDMI_MC_FLOWCTRL);
/* gen2 tx power off */
- imx_hdmi_phy_gen2_txpwron(hdmi, 0);
+ dw_hdmi_phy_gen2_txpwron(hdmi, 0);
/* gen2 pddq */
- imx_hdmi_phy_gen2_pddq(hdmi, 1);
+ dw_hdmi_phy_gen2_pddq(hdmi, 1);
/* PHY reset */
hdmi_writeb(hdmi, HDMI_MC_PHYRSTZ_DEASSERT, HDMI_MC_PHYRSTZ);
@@ -804,15 +804,15 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
/* REMOVE CLK TERM */
hdmi_phy_i2c_write(hdmi, 0x8000, 0x05); /* CKCALCTRL */
- imx_hdmi_phy_enable_power(hdmi, 1);
+ dw_hdmi_phy_enable_power(hdmi, 1);
/* toggle TMDS enable */
- imx_hdmi_phy_enable_tmds(hdmi, 0);
- imx_hdmi_phy_enable_tmds(hdmi, 1);
+ dw_hdmi_phy_enable_tmds(hdmi, 0);
+ dw_hdmi_phy_enable_tmds(hdmi, 1);
/* gen2 tx power on */
- imx_hdmi_phy_gen2_txpwron(hdmi, 1);
- imx_hdmi_phy_gen2_pddq(hdmi, 0);
+ dw_hdmi_phy_gen2_txpwron(hdmi, 1);
+ dw_hdmi_phy_gen2_pddq(hdmi, 0);
/*Wait for PHY PLL lock */
msec = 5;
@@ -833,7 +833,7 @@ static int hdmi_phy_configure(struct imx_hdmi *hdmi, unsigned char prep,
return 0;
}
-static int imx_hdmi_phy_init(struct imx_hdmi *hdmi)
+static int dw_hdmi_phy_init(struct dw_hdmi *hdmi)
{
int i, ret;
bool cscon = false;
@@ -844,10 +844,10 @@ static int imx_hdmi_phy_init(struct imx_hdmi *hdmi)
/* HDMI Phy spec says to do the phy initialization sequence twice */
for (i = 0; i < 2; i++) {
- imx_hdmi_phy_sel_data_en_pol(hdmi, 1);
- imx_hdmi_phy_sel_interface_control(hdmi, 0);
- imx_hdmi_phy_enable_tmds(hdmi, 0);
- imx_hdmi_phy_enable_power(hdmi, 0);
+ dw_hdmi_phy_sel_data_en_pol(hdmi, 1);
+ dw_hdmi_phy_sel_interface_control(hdmi, 0);
+ dw_hdmi_phy_enable_tmds(hdmi, 0);
+ dw_hdmi_phy_enable_power(hdmi, 0);
/* Enable CSC */
ret = hdmi_phy_configure(hdmi, 0, 8, cscon);
@@ -859,7 +859,7 @@ static int imx_hdmi_phy_init(struct imx_hdmi *hdmi)
return 0;
}
-static void hdmi_tx_hdcp_config(struct imx_hdmi *hdmi)
+static void hdmi_tx_hdcp_config(struct dw_hdmi *hdmi)
{
u8 de;
@@ -878,7 +878,7 @@ static void hdmi_tx_hdcp_config(struct imx_hdmi *hdmi)
HDMI_A_HDCPCFG1_ENCRYPTIONDISABLE_MASK, HDMI_A_HDCPCFG1);
}
-static void hdmi_config_AVI(struct imx_hdmi *hdmi)
+static void hdmi_config_AVI(struct dw_hdmi *hdmi)
{
u8 val, pix_fmt, under_scan;
u8 act_ratio, coded_ratio, colorimetry, ext_colorimetry;
@@ -972,7 +972,7 @@ static void hdmi_config_AVI(struct imx_hdmi *hdmi)
hdmi_writeb(hdmi, 0, HDMI_FC_AVISRB1);
}
-static void hdmi_av_composer(struct imx_hdmi *hdmi,
+static void hdmi_av_composer(struct dw_hdmi *hdmi,
const struct drm_display_mode *mode)
{
u8 inv_val;
@@ -1056,19 +1056,19 @@ static void hdmi_av_composer(struct imx_hdmi *hdmi,
hdmi_writeb(hdmi, vsync_len, HDMI_FC_VSYNCINWIDTH);
}
-static void imx_hdmi_phy_disable(struct imx_hdmi *hdmi)
+static void dw_hdmi_phy_disable(struct dw_hdmi *hdmi)
{
if (!hdmi->phy_enabled)
return;
- imx_hdmi_phy_enable_tmds(hdmi, 0);
- imx_hdmi_phy_enable_power(hdmi, 0);
+ dw_hdmi_phy_enable_tmds(hdmi, 0);
+ dw_hdmi_phy_enable_power(hdmi, 0);
hdmi->phy_enabled = false;
}
/* HDMI Initialization Step B.4 */
-static void imx_hdmi_enable_video_path(struct imx_hdmi *hdmi)
+static void dw_hdmi_enable_video_path(struct dw_hdmi *hdmi)
{
u8 clkdis;
@@ -1097,13 +1097,13 @@ static void imx_hdmi_enable_video_path(struct imx_hdmi *hdmi)
}
}
-static void hdmi_enable_audio_clk(struct imx_hdmi *hdmi)
+static void hdmi_enable_audio_clk(struct dw_hdmi *hdmi)
{
hdmi_modb(hdmi, 0, HDMI_MC_CLKDIS_AUDCLK_DISABLE, HDMI_MC_CLKDIS);
}
/* Workaround to clear the overflow condition */
-static void imx_hdmi_clear_overflow(struct imx_hdmi *hdmi)
+static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
{
int count;
u8 val;
@@ -1121,19 +1121,19 @@ static void imx_hdmi_clear_overflow(struct imx_hdmi *hdmi)
hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF);
}
-static void hdmi_enable_overflow_interrupts(struct imx_hdmi *hdmi)
+static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi)
{
hdmi_writeb(hdmi, 0, HDMI_FC_MASK2);
hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2);
}
-static void hdmi_disable_overflow_interrupts(struct imx_hdmi *hdmi)
+static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi)
{
hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK,
HDMI_IH_MUTE_FC_STAT2);
}
-static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
+static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
{
int ret;
@@ -1185,12 +1185,12 @@ static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
hdmi_av_composer(hdmi, mode);
/* HDMI Initializateion Step B.2 */
- ret = imx_hdmi_phy_init(hdmi);
+ ret = dw_hdmi_phy_init(hdmi);
if (ret)
return ret;
/* HDMI Initialization Step B.3 */
- imx_hdmi_enable_video_path(hdmi);
+ dw_hdmi_enable_video_path(hdmi);
/* not for DVI mode */
if (hdmi->hdmi_data.video_mode.mdvi) {
@@ -1211,7 +1211,7 @@ static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
hdmi_video_sample(hdmi);
hdmi_tx_hdcp_config(hdmi);
- imx_hdmi_clear_overflow(hdmi);
+ dw_hdmi_clear_overflow(hdmi);
if (hdmi->cable_plugin && !hdmi->hdmi_data.video_mode.mdvi)
hdmi_enable_overflow_interrupts(hdmi);
@@ -1219,7 +1219,7 @@ static int imx_hdmi_setup(struct imx_hdmi *hdmi, struct drm_display_mode *mode)
}
/* Wait until we are registered to enable interrupts */
-static int imx_hdmi_fb_registered(struct imx_hdmi *hdmi)
+static int dw_hdmi_fb_registered(struct dw_hdmi *hdmi)
{
hdmi_writeb(hdmi, HDMI_PHY_I2CM_INT_ADDR_DONE_POL,
HDMI_PHY_I2CM_INT_ADDR);
@@ -1237,7 +1237,7 @@ static int imx_hdmi_fb_registered(struct imx_hdmi *hdmi)
return 0;
}
-static void initialize_hdmi_ih_mutes(struct imx_hdmi *hdmi)
+static void initialize_hdmi_ih_mutes(struct dw_hdmi *hdmi)
{
u8 ih_mute;
@@ -1289,73 +1289,73 @@ static void initialize_hdmi_ih_mutes(struct imx_hdmi *hdmi)
hdmi_writeb(hdmi, ih_mute, HDMI_IH_MUTE);
}
-static void imx_hdmi_poweron(struct imx_hdmi *hdmi)
+static void dw_hdmi_poweron(struct dw_hdmi *hdmi)
{
- imx_hdmi_setup(hdmi, &hdmi->previous_mode);
+ dw_hdmi_setup(hdmi, &hdmi->previous_mode);
}
-static void imx_hdmi_poweroff(struct imx_hdmi *hdmi)
+static void dw_hdmi_poweroff(struct dw_hdmi *hdmi)
{
- imx_hdmi_phy_disable(hdmi);
+ dw_hdmi_phy_disable(hdmi);
}
-static void imx_hdmi_bridge_mode_set(struct drm_bridge *bridge,
- struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
+static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge,
+ struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
{
- struct imx_hdmi *hdmi = bridge->driver_private;
+ struct dw_hdmi *hdmi = bridge->driver_private;
- imx_hdmi_setup(hdmi, mode);
+ dw_hdmi_setup(hdmi, mode);
/* Store the display mode for plugin/DKMS poweron events */
memcpy(&hdmi->previous_mode, mode, sizeof(hdmi->previous_mode));
}
-static bool imx_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
- const struct drm_display_mode *mode,
- struct drm_display_mode *adjusted_mode)
+static bool dw_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
+ const struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
{
return true;
}
-static void imx_hdmi_bridge_disable(struct drm_bridge *bridge)
+static void dw_hdmi_bridge_disable(struct drm_bridge *bridge)
{
- struct imx_hdmi *hdmi = bridge->driver_private;
+ struct dw_hdmi *hdmi = bridge->driver_private;
- imx_hdmi_poweroff(hdmi);
+ dw_hdmi_poweroff(hdmi);
}
-static void imx_hdmi_bridge_enable(struct drm_bridge *bridge)
+static void dw_hdmi_bridge_enable(struct drm_bridge *bridge)
{
- struct imx_hdmi *hdmi = bridge->driver_private;
+ struct dw_hdmi *hdmi = bridge->driver_private;
- imx_hdmi_poweron(hdmi);
+ dw_hdmi_poweron(hdmi);
}
-static void imx_hdmi_bridge_destroy(struct drm_bridge *bridge)
+static void dw_hdmi_bridge_destroy(struct drm_bridge *bridge)
{
drm_bridge_cleanup(bridge);
kfree(bridge);
}
-static void imx_hdmi_bridge_nope(struct drm_bridge *bridge)
+static void dw_hdmi_bridge_nope(struct drm_bridge *bridge)
{
/* do nothing */
}
-static enum drm_connector_status imx_hdmi_connector_detect(struct drm_connector
- *connector, bool force)
+static enum drm_connector_status
+dw_hdmi_connector_detect(struct drm_connector *connector, bool force)
{
- struct imx_hdmi *hdmi = container_of(connector, struct imx_hdmi,
+ struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi,
connector);
return hdmi_readb(hdmi, HDMI_PHY_STAT0) & HDMI_PHY_HPD ?
connector_status_connected : connector_status_disconnected;
}
-static int imx_hdmi_connector_get_modes(struct drm_connector *connector)
+static int dw_hdmi_connector_get_modes(struct drm_connector *connector)
{
- struct imx_hdmi *hdmi = container_of(connector, struct imx_hdmi,
+ struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi,
connector);
struct edid *edid;
int ret;
@@ -1378,46 +1378,46 @@ static int imx_hdmi_connector_get_modes(struct drm_connector *connector)
return 0;
}
-static struct drm_encoder *imx_hdmi_connector_best_encoder(struct drm_connector
+static struct drm_encoder *dw_hdmi_connector_best_encoder(struct drm_connector
*connector)
{
- struct imx_hdmi *hdmi = container_of(connector, struct imx_hdmi,
+ struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi,
connector);
return hdmi->encoder;
}
-static void imx_hdmi_connector_destroy(struct drm_connector *connector)
+static void dw_hdmi_connector_destroy(struct drm_connector *connector)
{
drm_connector_unregister(connector);
drm_connector_cleanup(connector);
}
-static struct drm_connector_funcs imx_hdmi_connector_funcs = {
+static struct drm_connector_funcs dw_hdmi_connector_funcs = {
.dpms = drm_helper_connector_dpms,
.fill_modes = drm_helper_probe_single_connector_modes,
- .detect = imx_hdmi_connector_detect,
- .destroy = imx_hdmi_connector_destroy,
+ .detect = dw_hdmi_connector_detect,
+ .destroy = dw_hdmi_connector_destroy,
};
-static struct drm_connector_helper_funcs imx_hdmi_connector_helper_funcs = {
- .get_modes = imx_hdmi_connector_get_modes,
- .best_encoder = imx_hdmi_connector_best_encoder,
+static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = {
+ .get_modes = dw_hdmi_connector_get_modes,
+ .best_encoder = dw_hdmi_connector_best_encoder,
};
-struct drm_bridge_funcs imx_hdmi_bridge_funcs = {
- .enable = imx_hdmi_bridge_enable,
- .disable = imx_hdmi_bridge_disable,
- .pre_enable = imx_hdmi_bridge_nope,
- .post_disable = imx_hdmi_bridge_nope,
- .mode_set = imx_hdmi_bridge_mode_set,
- .mode_fixup = imx_hdmi_bridge_mode_fixup,
- .destroy = imx_hdmi_bridge_destroy,
+struct drm_bridge_funcs dw_hdmi_bridge_funcs = {
+ .enable = dw_hdmi_bridge_enable,
+ .disable = dw_hdmi_bridge_disable,
+ .pre_enable = dw_hdmi_bridge_nope,
+ .post_disable = dw_hdmi_bridge_nope,
+ .mode_set = dw_hdmi_bridge_mode_set,
+ .mode_fixup = dw_hdmi_bridge_mode_fixup,
+ .destroy = dw_hdmi_bridge_destroy,
};
-static irqreturn_t imx_hdmi_hardirq(int irq, void *dev_id)
+static irqreturn_t dw_hdmi_hardirq(int irq, void *dev_id)
{
- struct imx_hdmi *hdmi = dev_id;
+ struct dw_hdmi *hdmi = dev_id;
u8 intr_stat;
intr_stat = hdmi_readb(hdmi, HDMI_IH_PHY_STAT0);
@@ -1427,9 +1427,9 @@ static irqreturn_t imx_hdmi_hardirq(int irq, void *dev_id)
return intr_stat ? IRQ_WAKE_THREAD : IRQ_NONE;
}
-static irqreturn_t imx_hdmi_irq(int irq, void *dev_id)
+static irqreturn_t dw_hdmi_irq(int irq, void *dev_id)
{
- struct imx_hdmi *hdmi = dev_id;
+ struct dw_hdmi *hdmi = dev_id;
u8 intr_stat;
u8 phy_int_pol;
@@ -1443,14 +1443,14 @@ static irqreturn_t imx_hdmi_irq(int irq, void *dev_id)
hdmi_modb(hdmi, 0, HDMI_PHY_HPD, HDMI_PHY_POL0);
- imx_hdmi_poweron(hdmi);
+ dw_hdmi_poweron(hdmi);
} else {
dev_dbg(hdmi->dev, "EVENT=plugout\n");
hdmi_modb(hdmi, HDMI_PHY_HPD, HDMI_PHY_HPD,
HDMI_PHY_POL0);
- imx_hdmi_poweroff(hdmi);
+ dw_hdmi_poweroff(hdmi);
}
drm_helper_hpd_irq_event(hdmi->connector.dev);
}
@@ -1461,7 +1461,7 @@ static irqreturn_t imx_hdmi_irq(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static int imx_hdmi_register(struct drm_device *drm, struct imx_hdmi *hdmi)
+static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
{
struct drm_encoder *encoder = hdmi->encoder;
struct drm_bridge *bridge;
@@ -1476,7 +1476,7 @@ static int imx_hdmi_register(struct drm_device *drm, struct imx_hdmi *hdmi)
hdmi->bridge = bridge;
bridge->driver_private = hdmi;
- ret = drm_bridge_init(drm, bridge, &imx_hdmi_bridge_funcs);
+ ret = drm_bridge_init(drm, bridge, &dw_hdmi_bridge_funcs);
if (ret) {
DRM_ERROR("Failed to initialize bridge with drm\n");
return -EINVAL;
@@ -1486,8 +1486,8 @@ static int imx_hdmi_register(struct drm_device *drm, struct imx_hdmi *hdmi)
hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
drm_connector_helper_add(&hdmi->connector,
- &imx_hdmi_connector_helper_funcs);
- drm_connector_init(drm, &hdmi->connector, &imx_hdmi_connector_funcs,
+ &dw_hdmi_connector_helper_funcs);
+ drm_connector_init(drm, &hdmi->connector, &dw_hdmi_connector_funcs,
DRM_MODE_CONNECTOR_HDMIA);
hdmi->connector.encoder = encoder;
@@ -1497,15 +1497,15 @@ static int imx_hdmi_register(struct drm_device *drm, struct imx_hdmi *hdmi)
return 0;
}
-int imx_hdmi_bind(struct device *dev, struct device *master,
- void *data, struct drm_encoder *encoder,
- const struct imx_hdmi_plat_data *plat_data)
+int dw_hdmi_bind(struct device *dev, struct device *master,
+ void *data, struct drm_encoder *encoder,
+ const struct dw_hdmi_plat_data *plat_data)
{
struct platform_device *pdev = to_platform_device(dev);
struct drm_device *drm = data;
struct device_node *np = dev->of_node;
struct device_node *ddc_node;
- struct imx_hdmi *hdmi;
+ struct dw_hdmi *hdmi;
struct resource *iores;
int ret, irq;
@@ -1537,8 +1537,8 @@ int imx_hdmi_bind(struct device *dev, struct device *master,
if (irq < 0)
return irq;
- ret = devm_request_threaded_irq(dev, irq, imx_hdmi_hardirq,
- imx_hdmi_irq, IRQF_SHARED,
+ ret = devm_request_threaded_irq(dev, irq, dw_hdmi_hardirq,
+ dw_hdmi_irq, IRQF_SHARED,
dev_name(dev), hdmi);
if (ret)
return ret;
@@ -1573,11 +1573,11 @@ int imx_hdmi_bind(struct device *dev, struct device *master,
/* Clear Hotplug interrupts */
hdmi_writeb(hdmi, HDMI_IH_PHY_STAT0_HPD, HDMI_IH_PHY_STAT0);
- ret = imx_hdmi_fb_registered(hdmi);
+ ret = dw_hdmi_fb_registered(hdmi);
if (ret)
return ret;
- ret = imx_hdmi_register(drm, hdmi);
+ ret = dw_hdmi_register(drm, hdmi);
if (ret)
return ret;
@@ -1588,11 +1588,11 @@ int imx_hdmi_bind(struct device *dev, struct device *master,
return 0;
}
-EXPORT_SYMBOL_GPL(imx_hdmi_bind);
+EXPORT_SYMBOL_GPL(dw_hdmi_bind);
-void imx_hdmi_unbind(struct device *dev, struct device *master, void *data)
+void dw_hdmi_unbind(struct device *dev, struct device *master, void *data)
{
- struct imx_hdmi *hdmi = dev_get_drvdata(dev);
+ struct dw_hdmi *hdmi = dev_get_drvdata(dev);
/* Disable all interrupts */
hdmi_writeb(hdmi, ~0, HDMI_IH_MUTE_PHY_STAT0);
@@ -1602,11 +1602,11 @@ void imx_hdmi_unbind(struct device *dev, struct device *master, void *data)
i2c_put_adapter(hdmi->ddc);
}
-EXPORT_SYMBOL_GPL(imx_hdmi_unbind);
+EXPORT_SYMBOL_GPL(dw_hdmi_unbind);
MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
MODULE_AUTHOR("Andy Yan <andy.yan@rock-chips.com>");
MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
-MODULE_DESCRIPTION("i.MX6 HDMI transmitter driver");
+MODULE_DESCRIPTION("DW HDMI transmitter driver");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:imx-hdmi");
+MODULE_ALIAS("platform:dw-hdmi");
diff --git a/drivers/gpu/drm/imx/imx-hdmi.h b/drivers/gpu/drm/bridge/dw_hdmi.h
similarity index 98%
rename from drivers/gpu/drm/imx/imx-hdmi.h
rename to drivers/gpu/drm/bridge/dw_hdmi.h
index bced9ef..baa7849 100644
--- a/drivers/gpu/drm/imx/imx-hdmi.h
+++ b/drivers/gpu/drm/bridge/dw_hdmi.h
@@ -1030,46 +1030,4 @@ enum {
HDMI_A_VIDPOLCFG_HSYNCPOL_ACTIVE_LOW = 0x0,
};
-enum imx_hdmi_devtype {
- IMX6Q_HDMI,
- IMX6DL_HDMI,
-};
-
-struct imx_hdmi_plat_data {
- enum imx_hdmi_devtype dev_type;
- const struct mpll_config *mpll_cfg;
- const struct curr_ctrl *cur_ctr;
- const struct sym_term *sym_term;
-};
-
-enum {
- RES_8,
- RES_10,
- RES_12,
- RES_MAX,
-};
-
-struct mpll_config {
- unsigned long mpixelclock;
- struct {
- u16 cpce;
- u16 gmp;
- } res[RES_MAX];
-};
-
-struct curr_ctrl {
- unsigned long mpixelclock;
- u16 curr[RES_MAX];
-};
-
-struct sym_term {
- unsigned long mpixelclock;
- u16 sym_ctr; /*clock symbol and transmitter control*/
- u16 term; /*transmission termination value*/
-};
-
-int imx_hdmi_bind(struct device *dev, struct device *master,
- void *data, struct drm_encoder *encoder,
- const struct imx_hdmi_plat_data *plat_data);
-void imx_hdmi_unbind(struct device *dev, struct device *master, void *data);
#endif /* __IMX_HDMI_H__ */
diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
index 82fb758..7070077 100644
--- a/drivers/gpu/drm/imx/Kconfig
+++ b/drivers/gpu/drm/imx/Kconfig
@@ -48,6 +48,7 @@ config DRM_IMX_IPUV3
config DRM_IMX_HDMI
tristate "Freescale i.MX DRM HDMI"
+ select DRM_DW_HDMI
depends on DRM_IMX
help
Choose this if you want to use HDMI on i.MX6.
diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile
index 63cf56a..f3ecd89 100644
--- a/drivers/gpu/drm/imx/Makefile
+++ b/drivers/gpu/drm/imx/Makefile
@@ -9,4 +9,4 @@ obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
imx-ipuv3-crtc-objs := ipuv3-crtc.o ipuv3-plane.o
obj-$(CONFIG_DRM_IMX_IPUV3) += imx-ipuv3-crtc.o
-obj-$(CONFIG_DRM_IMX_HDMI) += imx-hdmi.o imx-hdmi_pltfm.o
+obj-$(CONFIG_DRM_IMX_HDMI) += dw_hdmi-imx.o
diff --git a/drivers/gpu/drm/imx/imx-hdmi_pltfm.c b/drivers/gpu/drm/imx/dw_hdmi-imx.c
similarity index 60%
rename from drivers/gpu/drm/imx/imx-hdmi_pltfm.c
rename to drivers/gpu/drm/imx/dw_hdmi-imx.c
index 519a22d..ac6563f 100644
--- a/drivers/gpu/drm/imx/imx-hdmi_pltfm.c
+++ b/drivers/gpu/drm/imx/dw_hdmi-imx.c
@@ -1,6 +1,6 @@
/* Copyright (C) 2011-2013 Freescale Semiconductor, Inc.
*
- * derived from imx-hdmi.c
+ * derived from imx-hdmi.c(renamed to bridge/dw_hdmi.c now)
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
@@ -11,6 +11,7 @@
#include <linux/component.h>
#include <linux/mfd/syscon.h>
#include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
+#include <drm/bridge/dw_hdmi.h>
#include <video/imx-ipu-v3.h>
#include <linux/regmap.h>
#include <linux/clk.h>
@@ -21,9 +22,8 @@
#include <drm/drm_encoder_slave.h>
#include "imx-drm.h"
-#include "imx-hdmi.h"
-struct imx_hdmi_priv {
+struct imx_hdmi {
struct device *dev;
struct drm_encoder encoder;
struct clk *isfr_clk;
@@ -82,7 +82,7 @@ static const struct sym_term imx_sym_term[] = {
{ ~0UL, 0x0000, 0x0000 }
};
-static int imx_hdmi_parse_dt(struct imx_hdmi_priv *hdmi)
+static int dw_hdmi_imx_parse_dt(struct imx_hdmi *hdmi)
{
struct device_node *np = hdmi->dev->of_node;
@@ -107,28 +107,26 @@ static int imx_hdmi_parse_dt(struct imx_hdmi_priv *hdmi)
return 0;
}
-static void imx_hdmi_encoder_disable(struct drm_encoder *encoder)
+static void dw_hdmi_imx_encoder_disable(struct drm_encoder *encoder)
{
}
-static bool imx_hdmi_encoder_mode_fixup(struct drm_encoder *encoder,
- const struct drm_display_mode *mode,
+static bool dw_hdmi_imx_encoder_mode_fixup(struct drm_encoder *encoder,
+ const struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
return true;
}
-static void imx_hdmi_encoder_mode_set(struct drm_encoder *encoder,
- struct drm_display_mode *mode,
+static void dw_hdmi_imx_encoder_mode_set(struct drm_encoder *encoder,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
}
-static void imx_hdmi_encoder_commit(struct drm_encoder *encoder)
+static void dw_hdmi_imx_encoder_commit(struct drm_encoder *encoder)
{
- struct imx_hdmi_priv *hdmi = container_of(encoder,
- struct imx_hdmi_priv,
- encoder);
+ struct imx_hdmi *hdmi = container_of(encoder, struct imx_hdmi, encoder);
int mux = imx_drm_encoder_get_mux_id(hdmi->dev->of_node, encoder);
regmap_update_bits(hdmi->regmap, IOMUXC_GPR3,
@@ -136,38 +134,38 @@ static void imx_hdmi_encoder_commit(struct drm_encoder *encoder)
mux << IMX6Q_GPR3_HDMI_MUX_CTL_SHIFT);
}
-static void imx_hdmi_encoder_prepare(struct drm_encoder *encoder)
+static void dw_hdmi_imx_encoder_prepare(struct drm_encoder *encoder)
{
imx_drm_panel_format(encoder, V4L2_PIX_FMT_RGB24);
}
-static struct drm_encoder_helper_funcs imx_hdmi_encoder_helper_funcs = {
- .mode_fixup = imx_hdmi_encoder_mode_fixup,
- .mode_set = imx_hdmi_encoder_mode_set,
- .prepare = imx_hdmi_encoder_prepare,
- .commit = imx_hdmi_encoder_commit,
- .disable = imx_hdmi_encoder_disable,
+static struct drm_encoder_helper_funcs dw_hdmi_imx_encoder_helper_funcs = {
+ .mode_fixup = dw_hdmi_imx_encoder_mode_fixup,
+ .mode_set = dw_hdmi_imx_encoder_mode_set,
+ .prepare = dw_hdmi_imx_encoder_prepare,
+ .commit = dw_hdmi_imx_encoder_commit,
+ .disable = dw_hdmi_imx_encoder_disable,
};
-static struct drm_encoder_funcs imx_hdmi_encoder_funcs = {
+static struct drm_encoder_funcs dw_hdmi_imx_encoder_funcs = {
.destroy = drm_encoder_cleanup,
};
-static struct imx_hdmi_plat_data imx6q_hdmi_drv_data = {
- .mpll_cfg = imx_mpll_cfg,
- .cur_ctr = imx_cur_ctr,
- .sym_term = imx_sym_term,
- .dev_type = IMX6Q_HDMI,
+static struct dw_hdmi_plat_data imx6q_hdmi_drv_data = {
+ .mpll_cfg = imx_mpll_cfg,
+ .cur_ctr = imx_cur_ctr,
+ .sym_term = imx_sym_term,
+ .dev_type = IMX6Q_HDMI,
};
-static struct imx_hdmi_plat_data imx6dl_hdmi_drv_data = {
- .mpll_cfg = imx_mpll_cfg,
- .cur_ctr = imx_cur_ctr,
- .sym_term = imx_sym_term,
- .dev_type = IMX6DL_HDMI,
+static struct dw_hdmi_plat_data imx6dl_hdmi_drv_data = {
+ .mpll_cfg = imx_mpll_cfg,
+ .cur_ctr = imx_cur_ctr,
+ .sym_term = imx_sym_term,
+ .dev_type = IMX6DL_HDMI,
};
-static const struct of_device_id imx_hdmi_dt_ids[] = {
+static const struct of_device_id dw_hdmi_imx_dt_ids[] = {
{ .compatible = "fsl,imx6q-hdmi",
.data = &imx6q_hdmi_drv_data
}, {
@@ -176,17 +174,17 @@ static const struct of_device_id imx_hdmi_dt_ids[] = {
},
{},
};
-MODULE_DEVICE_TABLE(of, imx_hdmi_dt_ids);
+MODULE_DEVICE_TABLE(of, dw_hdmi_imx_dt_ids);
-static int imx_hdmi_pltfm_bind(struct device *dev, struct device *master,
- void *data)
+static int dw_hdmi_imx_bind(struct device *dev, struct device *master,
+ void *data)
{
struct platform_device *pdev = to_platform_device(dev);
- const struct imx_hdmi_plat_data *plat_data;
+ const struct dw_hdmi_plat_data *plat_data;
const struct of_device_id *match;
struct drm_device *drm = data;
struct drm_encoder *encoder;
- struct imx_hdmi_priv *hdmi;
+ struct imx_hdmi *hdmi;
int ret;
if (!pdev->dev.of_node)
@@ -196,13 +194,13 @@ static int imx_hdmi_pltfm_bind(struct device *dev, struct device *master,
if (!hdmi)
return -ENOMEM;
- match = of_match_node(imx_hdmi_dt_ids, pdev->dev.of_node);
+ match = of_match_node(dw_hdmi_imx_dt_ids, pdev->dev.of_node);
plat_data = match->data;
hdmi->dev = &pdev->dev;
encoder = &hdmi->encoder;
platform_set_drvdata(pdev, hdmi);
- ret = imx_hdmi_parse_dt(hdmi);
+ ret = dw_hdmi_imx_parse_dt(hdmi);
if (ret < 0)
return ret;
@@ -220,56 +218,56 @@ static int imx_hdmi_pltfm_bind(struct device *dev, struct device *master,
encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
- drm_encoder_helper_add(encoder, &imx_hdmi_encoder_helper_funcs);
- drm_encoder_init(drm, encoder, &imx_hdmi_encoder_funcs,
+ drm_encoder_helper_add(encoder, &dw_hdmi_imx_encoder_helper_funcs);
+ drm_encoder_init(drm, encoder, &dw_hdmi_imx_encoder_funcs,
DRM_MODE_ENCODER_TMDS);
- return imx_hdmi_bind(dev, master, data, encoder, plat_data);
+ return dw_hdmi_bind(dev, master, data, encoder, plat_data);
}
-static void imx_hdmi_pltfm_unbind(struct device *dev, struct device *master,
- void *data)
+static void dw_hdmi_imx_unbind(struct device *dev, struct device *master,
+ void *data)
{
struct platform_device *pdev = to_platform_device(dev);
- struct imx_hdmi_priv *hdmi = platform_get_drvdata(pdev);
+ struct imx_hdmi *hdmi = platform_get_drvdata(pdev);
clk_disable_unprepare(hdmi->isfr_clk);
clk_disable_unprepare(hdmi->iahb_clk);
- return imx_hdmi_unbind(dev, master, data);
+ return dw_hdmi_unbind(dev, master, data);
}
-static const struct component_ops imx_hdmi_ops = {
- .bind = imx_hdmi_pltfm_bind,
- .unbind = imx_hdmi_pltfm_unbind,
+static const struct component_ops dw_hdmi_imx_ops = {
+ .bind = dw_hdmi_imx_bind,
+ .unbind = dw_hdmi_imx_unbind,
};
-static int imx_hdmi_probe(struct platform_device *pdev)
+static int dw_hdmi_imx_probe(struct platform_device *pdev)
{
- return component_add(&pdev->dev, &imx_hdmi_ops);
+ return component_add(&pdev->dev, &dw_hdmi_imx_ops);
}
-static int imx_hdmi_remove(struct platform_device *pdev)
+static int dw_hdmi_imx_remove(struct platform_device *pdev)
{
- component_del(&pdev->dev, &imx_hdmi_ops);
+ component_del(&pdev->dev, &dw_hdmi_imx_ops);
return 0;
}
-static struct platform_driver imx_hdmi_pltfm_driver = {
- .probe = imx_hdmi_probe,
- .remove = imx_hdmi_remove,
+static struct platform_driver dw_hdmi_imx_platform_driver = {
+ .probe = dw_hdmi_imx_probe,
+ .remove = dw_hdmi_imx_remove,
.driver = {
- .name = "hdmi-imx",
+ .name = "dwhdmi-imx",
.owner = THIS_MODULE,
- .of_match_table = imx_hdmi_dt_ids,
+ .of_match_table = dw_hdmi_imx_dt_ids,
},
};
-module_platform_driver(imx_hdmi_pltfm_driver);
+module_platform_driver(dw_hdmi_imx_platform_driver);
MODULE_AUTHOR("Andy Yan <andy.yan@rock-chips.com>");
MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
MODULE_DESCRIPTION("IMX6 Specific DW-HDMI Driver Extension");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:hdmi-imx");
+MODULE_ALIAS("platform:dwhdmi-imx");
diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
new file mode 100644
index 0000000..1bbf3ca
--- /dev/null
+++ b/include/drm/bridge/dw_hdmi.h
@@ -0,0 +1,57 @@
+/*
+ * Copyright (C) 2011 Freescale Semiconductor, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#ifndef __DW_HDMI__
+#define __DW_HDMI__
+
+#include <drm/drmP.h>
+
+enum {
+ RES_8,
+ RES_10,
+ RES_12,
+ RES_MAX,
+};
+
+enum dw_hdmi_devtype {
+ IMX6Q_HDMI,
+ IMX6DL_HDMI,
+};
+
+struct mpll_config {
+ unsigned long mpixelclock;
+ struct {
+ u16 cpce;
+ u16 gmp;
+ } res[RES_MAX];
+};
+
+struct curr_ctrl {
+ unsigned long mpixelclock;
+ u16 curr[RES_MAX];
+};
+
+struct sym_term {
+ unsigned long mpixelclock;
+ u16 sym_ctr; /*clock symbol and transmitter control*/
+ u16 term; /*transmission termination value*/
+};
+
+struct dw_hdmi_plat_data {
+ enum dw_hdmi_devtype dev_type;
+ const struct mpll_config *mpll_cfg;
+ const struct curr_ctrl *cur_ctr;
+ const struct sym_term *sym_term;
+};
+
+void dw_hdmi_unbind(struct device *dev, struct device *master, void *data);
+int dw_hdmi_bind(struct device *dev, struct device *master,
+ void *data, struct drm_encoder *encoder,
+ const struct dw_hdmi_plat_data *plat_data);
+#endif /* __IMX_HDMI_H__ */
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 06/12] dt-bindings: add document for dw_hdmi
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (4 preceding siblings ...)
2014-11-26 13:30 ` [PATCH v13 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Andy Yan
@ 2014-11-26 13:31 ` Andy Yan
2014-11-26 13:32 ` [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Andy Yan
` (6 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:31 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8:
- correct some spelling mistake
- modify ddc-i2c-bus and interrupt description
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
.../devicetree/bindings/drm/bridge/dw_hdmi.txt | 40 ++++++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
new file mode 100644
index 0000000..107c1ca
--- /dev/null
+++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt
@@ -0,0 +1,40 @@
+DesignWare HDMI bridge bindings
+
+Required properities:
+- compatible: platform specific such as:
+ * "fsl,imx6q-hdmi"
+ * "fsl,imx6dl-hdmi"
+ * "rockchip,rk3288-dw-hdmi"
+- reg: Physical base address and length of the controller's registers.
+- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
+- interrupts: The HDMI interrupt number
+
+Optional properties
+- reg-io-width: the width of the reg:1,4, default set to 1 if not present
+
+Example:
+ hdmi: hdmi@0120000 {
+ compatible = "fsl,imx6q-hdmi";
+ reg = <0x00120000 0x9000>;
+ interrupts = <0 115 0x04>;
+ gpr = <&gpr>;
+ clocks = <&clks 123>, <&clks 124>;
+ clock-names = "iahb", "isfr";
+ ddc-i2c-bus = <&i2c2>;
+
+ port@0 {
+ reg = <0>;
+
+ hdmi_mux_0: endpoint {
+ remote-endpoint = <&ipu1_di0_hdmi>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ hdmi_mux_1: endpoint {
+ remote-endpoint = <&ipu1_di1_hdmi>;
+ };
+ };
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (5 preceding siblings ...)
2014-11-26 13:31 ` [PATCH v13 06/12] dt-bindings: add document for dw_hdmi Andy Yan
@ 2014-11-26 13:32 ` Andy Yan
2014-11-26 16:34 ` Philipp Zabel
2014-11-26 13:33 ` [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support Andy Yan
` (5 subsequent siblings)
12 siblings, 1 reply; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:32 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width accesses (writeb,
readb) generate an imprecise external abort.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6:
- refactor register access without reg_shift
Changes in v5:
- refactor reg-io-width
Changes in v4: None
Changes in v3:
- split multi-register access to one indepent patch
drivers/gpu/drm/bridge/dw_hdmi.c | 57 +++++++++++++++++++++++++++++++++++-----
1 file changed, 51 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index a53bf63..5e88c8d 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -100,6 +100,11 @@ struct hdmi_data_info {
struct hdmi_vmode video_mode;
};
+union dw_reg_ptr {
+ u32 __iomem *p32;
+ u8 __iomem *p8;
+};
+
struct dw_hdmi {
struct drm_connector connector;
struct drm_encoder *encoder;
@@ -121,20 +126,43 @@ struct dw_hdmi {
struct regmap *regmap;
struct i2c_adapter *ddc;
- void __iomem *regs;
+ union dw_reg_ptr regs;
unsigned int sample_rate;
int ratio;
+
+ void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
+ u8 (*read)(struct dw_hdmi *hdmi, int offset);
};
+static void dw_hdmi_writel(struct dw_hdmi *hdmi, u8 val, int offset)
+{
+ writel(val, hdmi->regs.p32 + offset);
+}
+
+static u8 dw_hdmi_readl(struct dw_hdmi *hdmi, int offset)
+{
+ return readl(hdmi->regs.p32 + offset);
+}
+
+static void dw_hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
+{
+ writeb(val, hdmi->regs.p8 + offset);
+}
+
+static u8 dw_hdmi_readb(struct dw_hdmi *hdmi, int offset)
+{
+ return readb(hdmi->regs.p8 + offset);
+}
+
static inline void hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
{
- writeb(val, hdmi->regs + offset);
+ hdmi->write(hdmi, val, offset);
}
static inline u8 hdmi_readb(struct dw_hdmi *hdmi, int offset)
{
- return readb(hdmi->regs + offset);
+ return hdmi->read(hdmi, offset);
}
static void hdmi_modb(struct dw_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
@@ -1508,6 +1536,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
struct dw_hdmi *hdmi;
struct resource *iores;
int ret, irq;
+ u32 val = 1;
hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
if (!hdmi)
@@ -1520,6 +1549,22 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
hdmi->ratio = 100;
hdmi->encoder = encoder;
+ of_property_read_u32(np, "reg-io-width", &val);
+
+ switch (val) {
+ case 4:
+ hdmi->write = dw_hdmi_writel;
+ hdmi->read = dw_hdmi_readl;
+ break;
+ case 1:
+ hdmi->write = dw_hdmi_writeb;
+ hdmi->read = dw_hdmi_readb;
+ break;
+ default:
+ dev_err(dev, "reg-io-width must be 1 or 4\n");
+ return -EINVAL;
+ }
+
ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
if (ddc_node) {
hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
@@ -1544,9 +1589,9 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
return ret;
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- hdmi->regs = devm_ioremap_resource(dev, iores);
- if (IS_ERR(hdmi->regs))
- return PTR_ERR(hdmi->regs);
+ hdmi->regs.p32 = devm_ioremap_resource(dev, iores);
+ if (IS_ERR(hdmi->regs.p32))
+ return PTR_ERR(hdmi->regs.p32);
/* Product and revision IDs */
dev_info(dev,
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (6 preceding siblings ...)
2014-11-26 13:32 ` [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Andy Yan
@ 2014-11-26 13:33 ` Andy Yan
2014-11-26 16:23 ` Philipp Zabel
2014-11-26 13:34 ` [PATCH v13 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done Andy Yan
` (4 subsequent siblings)
12 siblings, 1 reply; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:33 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
some platform may not support all the display mode,
add mode_valid interface check it
also add drm_connector_register which add a debugfs
interface for dump display modes and edid information
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/bridge/dw_hdmi.c | 17 +++++++++++++++++
include/drm/bridge/dw_hdmi.h | 2 ++
2 files changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 5e88c8d..b13e782 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1406,6 +1406,20 @@ static int dw_hdmi_connector_get_modes(struct drm_connector *connector)
return 0;
}
+static enum drm_mode_status
+dw_hdmi_connector_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ struct dw_hdmi *hdmi = container_of(connector,
+ struct dw_hdmi, connector);
+ enum drm_mode_status mode_status = MODE_OK;
+
+ if (hdmi->plat_data->mode_valid)
+ mode_status = hdmi->plat_data->mode_valid(connector, mode);
+
+ return mode_status;
+}
+
static struct drm_encoder *dw_hdmi_connector_best_encoder(struct drm_connector
*connector)
{
@@ -1430,6 +1444,7 @@ static struct drm_connector_funcs dw_hdmi_connector_funcs = {
static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = {
.get_modes = dw_hdmi_connector_get_modes,
+ .mode_valid = dw_hdmi_connector_mode_valid,
.best_encoder = dw_hdmi_connector_best_encoder,
};
@@ -1631,6 +1646,8 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
dev_set_drvdata(dev, hdmi);
+ drm_connector_register(&hdmi->connector);
+
return 0;
}
EXPORT_SYMBOL_GPL(dw_hdmi_bind);
diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
index 1bbf3ca..1777ab4 100644
--- a/include/drm/bridge/dw_hdmi.h
+++ b/include/drm/bridge/dw_hdmi.h
@@ -48,6 +48,8 @@ struct dw_hdmi_plat_data {
const struct mpll_config *mpll_cfg;
const struct curr_ctrl *cur_ctr;
const struct sym_term *sym_term;
+ enum drm_mode_status (*mode_valid)(struct drm_connector *connector,
+ struct drm_display_mode *mode);
};
void dw_hdmi_unbind(struct device *dev, struct device *master, void *data);
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (7 preceding siblings ...)
2014-11-26 13:33 ` [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support Andy Yan
@ 2014-11-26 13:34 ` Andy Yan
2014-11-26 13:35 ` [PATCH v13 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare Andy Yan
` (3 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:34 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
HDMI_IH_I2CMPHY_STAT0 is a clear on write register, which indicates i2cm
operation status(i2c transfer done or error), every hdmi phy register
configuration must check this register to make sure the configuration
has complete. But the indication bit should be cleared after check, otherwise
the corresponding bit will hold on forever, this may give a wrong signal for
next check.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11:
- split form patch <dw_hdmi: add rk3288 support>
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/bridge/dw_hdmi.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index b13e782..8aa5f61 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -668,11 +668,15 @@ static inline void hdmi_phy_test_dout(struct dw_hdmi *hdmi,
static bool hdmi_phy_wait_i2c_done(struct dw_hdmi *hdmi, int msec)
{
- while ((hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3) == 0) {
+ u32 val;
+
+ while ((val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3) == 0) {
if (msec-- == 0)
return false;
udelay(1000);
}
+ hdmi_writeb(hdmi, val, HDMI_IH_I2CMPHY_STAT0);
+
return true;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (8 preceding siblings ...)
2014-11-26 13:34 ` [PATCH v13 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done Andy Yan
@ 2014-11-26 13:35 ` Andy Yan
2014-11-26 13:36 ` [PATCH v13 11/12] dt-bindings: Add documentation for rockchip dw hdmi Andy Yan
` (2 subsequent siblings)
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:35 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
RK3288 HDMI will not work without the spare bit of
HDMI_PHY_CONF0 enable
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/bridge/dw_hdmi.c | 7 +++++++
drivers/gpu/drm/bridge/dw_hdmi.h | 3 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 8aa5f61..160f8c7 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -715,6 +715,13 @@ static void dw_hdmi_phy_enable_tmds(struct dw_hdmi *hdmi, u8 enable)
HDMI_PHY_CONF0_ENTMDS_MASK);
}
+static void dw_hdmi_phy_enable_spare(struct dw_hdmi *hdmi, u8 enable)
+{
+ hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
+ HDMI_PHY_CONF0_SPARECTRL_OFFSET,
+ HDMI_PHY_CONF0_SPARECTRL_MASK);
+}
+
static void dw_hdmi_phy_gen2_pddq(struct dw_hdmi *hdmi, u8 enable)
{
hdmi_mask_writeb(hdmi, enable, HDMI_PHY_CONF0,
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.h b/drivers/gpu/drm/bridge/dw_hdmi.h
index baa7849..175dbc8 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.h
+++ b/drivers/gpu/drm/bridge/dw_hdmi.h
@@ -837,7 +837,8 @@ enum {
HDMI_PHY_CONF0_PDZ_OFFSET = 7,
HDMI_PHY_CONF0_ENTMDS_MASK = 0x40,
HDMI_PHY_CONF0_ENTMDS_OFFSET = 6,
- HDMI_PHY_CONF0_SPARECTRL = 0x20,
+ HDMI_PHY_CONF0_SPARECTRL_MASK = 0x20,
+ HDMI_PHY_CONF0_SPARECTRL_OFFSET = 5,
HDMI_PHY_CONF0_GEN2_PDDQ_MASK = 0x10,
HDMI_PHY_CONF0_GEN2_PDDQ_OFFSET = 4,
HDMI_PHY_CONF0_GEN2_TXPWRON_MASK = 0x8,
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 11/12] dt-bindings: Add documentation for rockchip dw hdmi
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (9 preceding siblings ...)
2014-11-26 13:35 ` [PATCH v13 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare Andy Yan
@ 2014-11-26 13:36 ` Andy Yan
2014-11-26 13:37 ` [PATCH v13 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Andy Yan
2014-11-26 16:20 ` [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Philipp Zabel
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:36 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12: None
Changes in v11: None
Changes in v10: None
Changes in v9: None
Changes in v8:
- Add documentation for rockchip dw hdmi
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
.../devicetree/bindings/video/dw_hdmi-rockchip.txt | 43 ++++++++++++++++++++++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt
diff --git a/Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt b/Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt
new file mode 100644
index 0000000..0735464
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/dw_hdmi-rockchip.txt
@@ -0,0 +1,43 @@
+Rockchip specific extensions to the Synopsys Designware HDMI
+================================
+
+Required properties:
+- compatible: "rockchip,rk3288-dw-hdmi";
+- reg: Physical base address and length of the controller's registers.
+- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
+- clocks: from common clock binding: handle to hdmi clock.
+- clock-names: should be "clk" "hdcp_clk"
+- rockchip,grf: this soc should set GRF regs to mux vopl/vopb.
+- interrupts: HDMI interrupt number
+- ports: contain a port node with endpoint definitions as defined in
+ Documentation/devicetree/bindings/media/video-interfaces.txt. For
+ vopb,set the reg = <0> and set the reg = <1> for vopl.
+- reg-io-width: the width of the reg:1,4, the value should be 4 on
+ rk3288 platform
+
+Example:
+hdmi: hdmi@ff980000 {
+ compatible = "rockchip,rk3288-dw-hdmi";
+ reg = <0xff980000 0x20000>;
+ reg-io-width = <4>;
+ ddc-i2c-bus = <&i2c5>;
+ rockchip,grf = <&grf>;
+ interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru PCLK_HDMI_CTRL>, <&cru SCLK_HDMI_HDCP>;
+ clock-names = "clk", "hdcp_clk";
+ status = "disabled";
+ ports {
+ hdmi_in: port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ hdmi_in_vopb: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vopb_out_hdmi>;
+ };
+ hdmi_in_vopl: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&vopl_out_hdmi>;
+ };
+ };
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v13 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (10 preceding siblings ...)
2014-11-26 13:36 ` [PATCH v13 11/12] dt-bindings: Add documentation for rockchip dw hdmi Andy Yan
@ 2014-11-26 13:37 ` Andy Yan
2014-11-26 16:20 ` [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Philipp Zabel
12 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-26 13:37 UTC (permalink / raw)
To: airlied, Philipp Zabel, heiko, fabio.estevam, rmk+kernel
Cc: Greg Kroah-Hartman, Grant Likely, Rob Herring, Shawn Guo,
Josh Boyer, Sean Paul, Inki Dae, Dave Airlie, Arnd Bergmann,
Lucas Stach, Zubair.Kakakhel, djkurtz, ykk, linux-kernel,
dri-devel, devel, devicetree, linux-rockchip, jay.xu, Pawel Moll,
mark.yao, Mark Rutland, Ian Campbell, Kumar Gala, Andy Yan
Rockchip RK3288 hdmi is compatible with dw_hdmi
this patch is depend on patch by Mark Yao Add drm
driver for Rockchip Socs
see https://lkml.org/lkml/2014/11/19/1153
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
Changes in v13: None
Changes in v12:
- add comment for the depend on patch
Changes in v11: None
Changes in v10:
- add more display mode support mpll configuration for rk3288
Changes in v9:
- move some phy configuration to platform driver
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
drivers/gpu/drm/bridge/dw_hdmi.c | 3 +
drivers/gpu/drm/rockchip/Kconfig | 10 +
drivers/gpu/drm/rockchip/Makefile | 2 +-
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 355 ++++++++++++++++++++++++++++
include/drm/bridge/dw_hdmi.h | 1 +
5 files changed, 370 insertions(+), 1 deletion(-)
create mode 100644 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index 160f8c7..8305390 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -853,6 +853,9 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep,
dw_hdmi_phy_gen2_txpwron(hdmi, 1);
dw_hdmi_phy_gen2_pddq(hdmi, 0);
+ if (hdmi->dev_type == RK3288_HDMI)
+ dw_hdmi_phy_enable_spare(hdmi, 1);
+
/*Wait for PHY PLL lock */
msec = 5;
do {
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 0ff6682..06371ae 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -15,3 +15,13 @@ config DRM_ROCKCHIP
management to userspace. This driver does not provide
2D or 3D acceleration; acceleration is performed by other
IP found on the SoC.
+
+config ROCKCHIP_DW_HDMI
+ bool "Rockchip specific extensions for Synopsys DW HDMI"
+ depends on DRM_ROCKCHIP
+ select DRM_DW_HDMI
+ help
+ This selects support for Rockchip SoC specific extensions
+ for the Synopsys DesignWare HDMI driver. If you want to
+ enable HDMI on RK3288 based SoC, you should selet this
+ option.
diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gpu/drm/rockchip/Makefile
index b3a5193..347e65c 100644
--- a/drivers/gpu/drm/rockchip/Makefile
+++ b/drivers/gpu/drm/rockchip/Makefile
@@ -4,5 +4,5 @@
rockchipdrm-y := rockchip_drm_drv.o rockchip_drm_fb.o rockchip_drm_fbdev.o \
rockchip_drm_gem.o rockchip_drm_vop.o
-
+rockchipdrm-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o
obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
new file mode 100644
index 0000000..16cad75
--- /dev/null
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -0,0 +1,355 @@
+/*
+ * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/mfd/syscon.h>
+#include <linux/regmap.h>
+#include <linux/clk.h>
+#include <drm/drm_of.h>
+#include <drm/drmP.h>
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_edid.h>
+#include <drm/drm_encoder_slave.h>
+#include <drm/bridge/dw_hdmi.h>
+
+#include "rockchip_drm_drv.h"
+#include "rockchip_drm_vop.h"
+
+#define GRF_SOC_CON6 0x025c
+#define HDMI_SEL_VOP_LIT (1 << 4)
+
+struct rockchip_hdmi {
+ struct device *dev;
+ struct clk *clk;
+ struct clk *hdcp_clk;
+ struct regmap *regmap;
+ struct drm_encoder encoder;
+};
+
+#define to_rockchip_hdmi(x) container_of(x, struct rockchip_hdmi, x)
+
+static const struct mpll_config rockchip_mpll_cfg[] = {
+ {
+ 27000000, {
+ { 0x00b3, 0x0000},
+ { 0x2153, 0x0000},
+ { 0x40f3, 0x0000}
+ },
+ }, {
+ 36000000, {
+ { 0x00b3, 0x0000},
+ { 0x2153, 0x0000},
+ { 0x40f3, 0x0000}
+ },
+ }, {
+ 40000000, {
+ { 0x00b3, 0x0000},
+ { 0x2153, 0x0000},
+ { 0x40f3, 0x0000}
+ },
+ }, {
+ 54000000, {
+ { 0x0072, 0x0001},
+ { 0x2142, 0x0001},
+ { 0x40a2, 0x0001},
+ },
+ }, {
+ 65000000, {
+ { 0x0072, 0x0001},
+ { 0x2142, 0x0001},
+ { 0x40a2, 0x0001},
+ },
+ }, {
+ 66000000, {
+ { 0x013e, 0x0003},
+ { 0x217e, 0x0002},
+ { 0x4061, 0x0002}
+ },
+ }, {
+ 74250000, {
+ { 0x0072, 0x0001},
+ { 0x2145, 0x0002},
+ { 0x4061, 0x0002}
+ },
+ }, {
+ 83500000, {
+ { 0x0072, 0x0001},
+ },
+ }, {
+ 108000000, {
+ { 0x0051, 0x0002},
+ { 0x2145, 0x0002},
+ { 0x4061, 0x0002}
+ },
+ }, {
+ 106500000, {
+ { 0x0051, 0x0002},
+ { 0x2145, 0x0002},
+ { 0x4061, 0x0002}
+ },
+ }, {
+ 146250000, {
+ { 0x0051, 0x0002},
+ { 0x2145, 0x0002},
+ { 0x4061, 0x0002}
+ },
+ }, {
+ 148500000, {
+ { 0x0051, 0x0003},
+ { 0x214c, 0x0003},
+ { 0x4064, 0x0003}
+ },
+ }, {
+ ~0UL, {
+ { 0x00a0, 0x000a },
+ { 0x2001, 0x000f },
+ { 0x4002, 0x000f },
+ },
+ }
+};
+
+static const struct curr_ctrl rockchip_cur_ctr[] = {
+ /* pixelclk bpp8 bpp10 bpp12 */
+ {
+ 40000000, { 0x0018, 0x0018, 0x0018 },
+ }, {
+ 65000000, { 0x0028, 0x0028, 0x0028 },
+ }, {
+ 66000000, { 0x0038, 0x0038, 0x0038 },
+ }, {
+ 74250000, { 0x0028, 0x0038, 0x0038 },
+ }, {
+ 83500000, { 0x0028, 0x0038, 0x0038 },
+ }, {
+ 146250000, { 0x0038, 0x0038, 0x0038 },
+ }, {
+ 148500000, { 0x0000, 0x0038, 0x0038 },
+ }, {
+ ~0UL, { 0x0000, 0x0000, 0x0000},
+ }
+};
+
+static const struct sym_term rockchip_sym_term[] = {
+ /*pixelclk symbol term*/
+ { 74250000, 0x8009, 0x0004 },
+ { 148500000, 0x8029, 0x0004 },
+ { 297000000, 0x8039, 0x0005 },
+ { ~0UL, 0x0000, 0x0000 }
+};
+
+static int rockchip_hdmi_parse_dt(struct rockchip_hdmi *hdmi)
+{
+ struct device_node *np = hdmi->dev->of_node;
+
+ hdmi->regmap = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
+ if (IS_ERR(hdmi->regmap)) {
+ dev_err(hdmi->dev, "Unable to get rockchip,grf\n");
+ return PTR_ERR(hdmi->regmap);
+ }
+
+ hdmi->clk = devm_clk_get(hdmi->dev, "clk");
+ if (IS_ERR(hdmi->clk)) {
+ dev_err(hdmi->dev, "Unable to get HDMI clk\n");
+ return PTR_ERR(hdmi->clk);
+ }
+
+ hdmi->hdcp_clk = devm_clk_get(hdmi->dev, "hdcp_clk");
+ if (IS_ERR(hdmi->hdcp_clk)) {
+ dev_err(hdmi->dev, "Unable to get HDMI hdcp clk\n");
+ return PTR_ERR(hdmi->hdcp_clk);
+ }
+
+ return 0;
+}
+
+static enum drm_mode_status
+dw_hdmi_rockchip_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ const struct mpll_config *mpll_cfg = rockchip_mpll_cfg;
+ int pclk = mode->clock * 1000;
+ bool valid = false;
+ int i;
+
+ for (i = 0; mpll_cfg[i].mpixelclock != (~0UL); i++) {
+ if (pclk == mpll_cfg[i].mpixelclock) {
+ valid = true;
+ break;
+ }
+ }
+
+ return (valid) ? MODE_OK : MODE_BAD;
+}
+
+static struct drm_encoder_funcs dw_hdmi_encoder_funcs = {
+ .destroy = drm_encoder_cleanup,
+};
+
+static void dw_hdmi_rockchip_disable(struct drm_encoder *encoder)
+{
+}
+
+static bool dw_hdmi_rockchip_mode_fixup(struct drm_encoder *encoder,
+ const struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
+{
+ return true;
+}
+
+static void dw_hdmi_rockchip_mode_set(struct drm_encoder *encoder,
+ struct drm_display_mode *mode,
+ struct drm_display_mode *adjusted_mode)
+{
+}
+
+static void dw_hdmi_rockchip_commit(struct drm_encoder *encoder)
+{
+ struct rockchip_hdmi *hdmi = to_rockchip_hdmi(encoder);
+ u32 val;
+ int mux;
+
+ mux = rockchip_drm_encoder_get_mux_id(hdmi->dev->of_node, encoder);
+ if (mux)
+ val = HDMI_SEL_VOP_LIT | (HDMI_SEL_VOP_LIT << 16);
+ else
+ val = HDMI_SEL_VOP_LIT << 16;
+
+ regmap_write(hdmi->regmap, GRF_SOC_CON6, val);
+ dev_dbg(hdmi->dev, "vop %s output to hdmi\n",
+ (mux) ? "LIT" : "BIG");
+}
+
+static void dw_hdmi_rockchip_prepare(struct drm_encoder *encoder)
+{
+ rockchip_drm_crtc_mode_config(encoder->crtc, DRM_MODE_CONNECTOR_HDMIA,
+ ROCKCHIP_OUT_MODE_AAAA);
+}
+
+static struct drm_encoder_helper_funcs dw_hdmi_encoder_helper_funcs = {
+ .mode_fixup = dw_hdmi_rockchip_mode_fixup,
+ .mode_set = dw_hdmi_rockchip_mode_set,
+ .prepare = dw_hdmi_rockchip_prepare,
+ .commit = dw_hdmi_rockchip_commit,
+ .disable = dw_hdmi_rockchip_disable,
+};
+
+static const struct dw_hdmi_plat_data rockchip_hdmi_drv_data = {
+ .mode_valid = dw_hdmi_rockchip_mode_valid,
+ .mpll_cfg = rockchip_mpll_cfg,
+ .cur_ctr = rockchip_cur_ctr,
+ .sym_term = rockchip_sym_term,
+ .dev_type = RK3288_HDMI,
+};
+
+static const struct of_device_id dw_hdmi_rockchip_ids[] = {
+ { .compatible = "rockchip,rk3288-dw-hdmi",
+ .data = &rockchip_hdmi_drv_data
+ },
+ {},
+};
+MODULE_DEVICE_TABLE(of, dw_hdmi_rockchip_dt_ids);
+
+static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
+ void *data)
+{
+ struct platform_device *pdev = to_platform_device(dev);
+ const struct dw_hdmi_plat_data *plat_data;
+ const struct of_device_id *match;
+ struct drm_device *drm = data;
+ struct drm_encoder *encoder;
+ struct rockchip_hdmi *hdmi;
+ int ret;
+
+ if (!pdev->dev.of_node)
+ return -ENODEV;
+
+ hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
+ if (!hdmi)
+ return -ENOMEM;
+
+ match = of_match_node(dw_hdmi_rockchip_ids, pdev->dev.of_node);
+ plat_data = match->data;
+ hdmi->dev = &pdev->dev;
+ encoder = &hdmi->encoder;
+ platform_set_drvdata(pdev, hdmi);
+
+ ret = rockchip_hdmi_parse_dt(hdmi);
+ if (ret) {
+ dev_err(hdmi->dev, "Unable to parse OF data\n");
+ return ret;
+ }
+
+ ret = clk_prepare_enable(hdmi->clk);
+ if (ret) {
+ dev_err(hdmi->dev, "Cannot enable HDMI clock: %d\n", ret);
+ return ret;
+ }
+
+ ret = clk_prepare_enable(hdmi->hdcp_clk);
+ if (ret) {
+ dev_err(hdmi->dev, "Cannot enable HDMI hdcp clock: %d\n", ret);
+ return ret;
+ }
+
+ encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
+
+ drm_encoder_helper_add(encoder, &dw_hdmi_encoder_helper_funcs);
+ drm_encoder_init(drm, encoder, &dw_hdmi_encoder_funcs,
+ DRM_MODE_ENCODER_TMDS);
+
+ return dw_hdmi_bind(dev, master, data, encoder, plat_data);
+}
+
+static void dw_hdmi_rockchip_unbind(struct device *dev, struct device *master,
+ void *data)
+{
+ struct platform_device *pdev = to_platform_device(dev);
+ struct rockchip_hdmi *hdmi = platform_get_drvdata(pdev);
+
+ clk_disable_unprepare(hdmi->clk);
+ clk_disable_unprepare(hdmi->hdcp_clk);
+
+ return dw_hdmi_unbind(dev, master, data);
+}
+
+static const struct component_ops dw_hdmi_rockchip_ops = {
+ .bind = dw_hdmi_rockchip_bind,
+ .unbind = dw_hdmi_rockchip_unbind,
+};
+
+static int dw_hdmi_rockchip_probe(struct platform_device *pdev)
+{
+ return component_add(&pdev->dev, &dw_hdmi_rockchip_ops);
+}
+
+static int dw_hdmi_rockchip_remove(struct platform_device *pdev)
+{
+ component_del(&pdev->dev, &dw_hdmi_rockchip_ops);
+
+ return 0;
+}
+
+static struct platform_driver dw_hdmi_rockchip_pltfm_driver = {
+ .probe = dw_hdmi_rockchip_probe,
+ .remove = dw_hdmi_rockchip_remove,
+ .driver = {
+ .name = "dwhdmi-rockchip",
+ .owner = THIS_MODULE,
+ .of_match_table = dw_hdmi_rockchip_ids,
+ },
+};
+
+module_platform_driver(dw_hdmi_rockchip_pltfm_driver);
+
+MODULE_AUTHOR("Andy Yan <andy.yan@rock-chips.com>");
+MODULE_AUTHOR("Yakir Yang <ykk@rock-chips.com>");
+MODULE_DESCRIPTION("Rockchip Specific DW-HDMI Driver Extension");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:dwhdmi-rockchip");
diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
index 1777ab4..b898bb1 100644
--- a/include/drm/bridge/dw_hdmi.h
+++ b/include/drm/bridge/dw_hdmi.h
@@ -22,6 +22,7 @@ enum {
enum dw_hdmi_devtype {
IMX6Q_HDMI,
IMX6DL_HDMI,
+ RK3288_HDMI,
};
struct mpll_config {
--
1.9.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
` (11 preceding siblings ...)
2014-11-26 13:37 ` [PATCH v13 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Andy Yan
@ 2014-11-26 16:20 ` Philipp Zabel
2014-11-28 9:57 ` Andy Yan
12 siblings, 1 reply; 22+ messages in thread
From: Philipp Zabel @ 2014-11-26 16:20 UTC (permalink / raw)
To: Andy Yan
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Hi Andy,
I have yet to look at this in more detail, but from a quick test
starting with patch 3, the HDMI display stays black on Nitrogen6X,
and starting with patch 8 I get the following error.
imx-drm display-subsystem: [CONNECTOR:21:HDMI-A-1] drm_connector_register failed: -12
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:851 __clk_disable+0x6c/0x70()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.18.0-rc6+ #8377
Backtrace:
[<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
r6:00000353 r5:00000000 r4:8083ea08 r3:00000000
[<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
[<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
r5:00000009 r4:00000000
[<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
r8:b721c610 r7:b72b0400 r6:b735504c r5:80000113 r4:b735504c
[<800227f0>] (warn_slowpath_null) from [<80458088>] (__clk_disable+0x6c/0x70)
[<8045801c>] (__clk_disable) from [<804581a8>] (clk_disable+0x34/0x40)
r4:b735504c r3:b700e000
[<80458174>] (clk_disable) from [<803241f0>] (dw_hdmi_imx_unbind+0x30/0x60)
r5:b7355010 r4:b7219a10
[<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
[<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
r5:b725f4c0 r4:b725f140
[<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
[<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
[<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
[<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
r6:b725f140 r5:0000000c r4:b686ad70
[<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
[<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
[<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
[<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
[<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
[<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
r5:b682ba10 r4:00000000
[<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
r6:808454e0 r5:b682ba44 r4:b682ba10
[<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
[<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
[<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
[<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
[<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
r5:00000000 r4:b7079ce0
[<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
r4:b721c410
[<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
r4:b721c410
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
[<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
[<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
[<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
r6:808454e0 r5:b728d000 r4:80845078
[<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
[<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
[<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
r5:8082be60 r4:8082be60
[<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
[<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
[<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
r4:8081aec0
[<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
r4:00008fc0
[<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
r4:00000000 r3:b7078000
---[ end trace 450768ad577083a9 ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:760 __clk_unprepare+0x78/0x90()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.18.0-rc6+ #8377
Backtrace:
[<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
r6:000002f8 r5:00000000 r4:8083ea08 r3:00000000
[<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
[<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
r5:00000009 r4:00000000
[<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
r8:b721c610 r7:b72b0400 r6:b735504c r5:b7355010 r4:b735504c
[<800227f0>] (warn_slowpath_null) from [<80458bfc>] (__clk_unprepare+0x78/0x90)
[<80458b84>] (__clk_unprepare) from [<80458c44>] (clk_unprepare+0x30/0x38)
r4:b735504c r3:0000004c
[<80458c14>] (clk_unprepare) from [<803241f8>] (dw_hdmi_imx_unbind+0x38/0x60)
r4:b7219a10 r3:0000004c
[<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
[<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
r5:b725f4c0 r4:b725f140
[<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
[<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
[<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
[<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
r6:b725f140 r5:0000000c r4:b686ad70
[<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
[<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
[<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
[<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
[<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
[<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
r5:b682ba10 r4:00000000
[<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
r6:808454e0 r5:b682ba44 r4:b682ba10
[<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
[<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
[<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
[<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
[<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
r5:00000000 r4:b7079ce0
[<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
r4:b721c410
[<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
r4:b721c410
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
[<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
[<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
[<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
r6:808454e0 r5:b728d000 r4:80845078
[<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
[<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
[<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
r5:8082be60 r4:8082be60
[<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
[<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
[<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
r4:8081aec0
[<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
r4:00008fc0
[<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
r4:00000000 r3:b7078000
---[ end trace 450768ad577083aa ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:851 __clk_disable+0x6c/0x70()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.18.0-rc6+ #8377
Backtrace:
[<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
r6:00000353 r5:00000000 r4:8083ea08 r3:00000000
[<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
[<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
r5:00000009 r4:00000000
[<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
r8:b721c610 r7:b72b0400 r6:b735504c r5:80000113 r4:b735504c
[<800227f0>] (warn_slowpath_null) from [<80458088>] (__clk_disable+0x6c/0x70)
[<8045801c>] (__clk_disable) from [<804581a8>] (clk_disable+0x34/0x40)
r4:b735504c r3:b700e000
[<80458174>] (clk_disable) from [<80324204>] (dw_hdmi_imx_unbind+0x44/0x60)
r5:b735504c r4:b7219a10
[<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
[<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
r5:b725f4c0 r4:b725f140
[<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
[<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
[<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
[<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
r6:b725f140 r5:0000000c r4:b686ad70
[<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
[<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
[<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
[<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
[<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
[<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
r5:b682ba10 r4:00000000
[<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
r6:808454e0 r5:b682ba44 r4:b682ba10
[<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
[<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
[<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
[<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
[<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
r5:00000000 r4:b7079ce0
[<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
r4:b721c410
[<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
r4:b721c410
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
[<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
[<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
[<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
r6:808454e0 r5:b728d000 r4:80845078
[<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
[<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
[<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
r5:8082be60 r4:8082be60
[<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
[<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
[<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
r4:8081aec0
[<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
r4:00008fc0
[<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
r4:00000000 r3:b7078000
---[ end trace 450768ad577083ab ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:760 __clk_unprepare+0x78/0x90()
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.18.0-rc6+ #8377
Backtrace:
[<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
r6:000002f8 r5:00000000 r4:8083ea08 r3:00000000
[<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
[<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
r5:00000009 r4:00000000
[<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
r8:b721c610 r7:b72b0400 r6:b735504c r5:b735504c r4:b735504c
[<800227f0>] (warn_slowpath_null) from [<80458bfc>] (__clk_unprepare+0x78/0x90)
[<80458b84>] (__clk_unprepare) from [<80458c44>] (clk_unprepare+0x30/0x38)
r4:b735504c r3:000003b5
[<80458c14>] (clk_unprepare) from [<8032420c>] (dw_hdmi_imx_unbind+0x4c/0x60)
r4:b7219a10 r3:000003b5
[<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
[<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
r5:b725f4c0 r4:b725f140
[<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
[<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
[<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
[<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
r6:b725f140 r5:0000000c r4:b686ad70
[<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
[<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
[<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
[<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
[<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
[<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
r5:b682ba10 r4:00000000
[<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
r6:808454e0 r5:b682ba44 r4:b682ba10
[<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
[<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
[<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
[<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
[<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
r5:00000000 r4:b7079ce0
[<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
r4:b721c410
[<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
r4:b721c410
[<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
[<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
[<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
[<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
r6:808454e0 r5:b728d000 r4:80845078
[<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
[<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
[<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
r5:8082be60 r4:8082be60
[<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
[<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
[<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
r4:8081aec0
[<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
r4:00008fc0
[<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
r4:00000000 r3:b7078000
---[ end trace 450768ad577083ac ]---
imx-ipuv3-crtc: probe of imx-ipuv3-crtc.5 failed with error -12
regards
Philipp
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support
2014-11-26 13:33 ` [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support Andy Yan
@ 2014-11-26 16:23 ` Philipp Zabel
2014-11-28 9:47 ` Andy Yan
0 siblings, 1 reply; 22+ messages in thread
From: Philipp Zabel @ 2014-11-26 16:23 UTC (permalink / raw)
To: Andy Yan
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Am Mittwoch, den 26.11.2014, 21:33 +0800 schrieb Andy Yan:
> some platform may not support all the display mode,
> add mode_valid interface check it
>
> also add drm_connector_register which add a debugfs
> interface for dump display modes and edid information
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> Changes in v13: None
> Changes in v12: None
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 17 +++++++++++++++++
> include/drm/bridge/dw_hdmi.h | 2 ++
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index 5e88c8d..b13e782 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> @@ -1406,6 +1406,20 @@ static int dw_hdmi_connector_get_modes(struct drm_connector *connector)
> return 0;
> }
>
> +static enum drm_mode_status
> +dw_hdmi_connector_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> +{
> + struct dw_hdmi *hdmi = container_of(connector,
> + struct dw_hdmi, connector);
> + enum drm_mode_status mode_status = MODE_OK;
> +
> + if (hdmi->plat_data->mode_valid)
> + mode_status = hdmi->plat_data->mode_valid(connector, mode);
> +
> + return mode_status;
> +}
> +
> static struct drm_encoder *dw_hdmi_connector_best_encoder(struct drm_connector
> *connector)
> {
> @@ -1430,6 +1444,7 @@ static struct drm_connector_funcs dw_hdmi_connector_funcs = {
>
> static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = {
> .get_modes = dw_hdmi_connector_get_modes,
> + .mode_valid = dw_hdmi_connector_mode_valid,
> .best_encoder = dw_hdmi_connector_best_encoder,
> };
>
> @@ -1631,6 +1646,8 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
>
> dev_set_drvdata(dev, hdmi);
>
> + drm_connector_register(&hdmi->connector);
> +
This is not right, the connector is registered by the imx-drm core in
the drm_driver .load callback.
regards
Philipp
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access
2014-11-26 13:32 ` [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Andy Yan
@ 2014-11-26 16:34 ` Philipp Zabel
2014-11-28 9:43 ` Andy Yan
0 siblings, 1 reply; 22+ messages in thread
From: Philipp Zabel @ 2014-11-26 16:34 UTC (permalink / raw)
To: Andy Yan
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Am Mittwoch, den 26.11.2014, 21:32 +0800 schrieb Andy Yan:
> On rockchip rk3288, only word(32-bit) accesses are
> permitted for hdmi registers. Byte width accesses (writeb,
> readb) generate an imprecise external abort.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v13: None
> Changes in v12: None
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6:
> - refactor register access without reg_shift
>
> Changes in v5:
> - refactor reg-io-width
>
> Changes in v4: None
> Changes in v3:
> - split multi-register access to one indepent patch
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 57 +++++++++++++++++++++++++++++++++++-----
> 1 file changed, 51 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> index a53bf63..5e88c8d 100644
> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> @@ -100,6 +100,11 @@ struct hdmi_data_info {
> struct hdmi_vmode video_mode;
> };
>
> +union dw_reg_ptr {
> + u32 __iomem *p32;
> + u8 __iomem *p8;
> +};
I see no need to introduce this. Just explicitly multiply the offset in
dw_hdmi_writel.
> struct dw_hdmi {
> struct drm_connector connector;
> struct drm_encoder *encoder;
> @@ -121,20 +126,43 @@ struct dw_hdmi {
>
> struct regmap *regmap;
> struct i2c_adapter *ddc;
> - void __iomem *regs;
> + union dw_reg_ptr regs;
Keep this as void __iomem *
> unsigned int sample_rate;
> int ratio;
> +
> + void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
> + u8 (*read)(struct dw_hdmi *hdmi, int offset);
> };
>
> +static void dw_hdmi_writel(struct dw_hdmi *hdmi, u8 val, int offset)
> +{
> + writel(val, hdmi->regs.p32 + offset);
hdmi->regs + 4 * offset
> +}
> +
> +static u8 dw_hdmi_readl(struct dw_hdmi *hdmi, int offset)
> +{
> + return readl(hdmi->regs.p32 + offset);
same here
> +}
> +
> +static void dw_hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
> +{
> + writeb(val, hdmi->regs.p8 + offset);
> +}
> +
> +static u8 dw_hdmi_readb(struct dw_hdmi *hdmi, int offset)
> +{
> + return readb(hdmi->regs.p8 + offset);
> +}
> +
> static inline void hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
> {
> - writeb(val, hdmi->regs + offset);
> + hdmi->write(hdmi, val, offset);
> }
>
> static inline u8 hdmi_readb(struct dw_hdmi *hdmi, int offset)
> {
> - return readb(hdmi->regs + offset);
> + return hdmi->read(hdmi, offset);
> }
>
> static void hdmi_modb(struct dw_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
> @@ -1508,6 +1536,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> struct dw_hdmi *hdmi;
> struct resource *iores;
> int ret, irq;
> + u32 val = 1;
>
> hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
> if (!hdmi)
> @@ -1520,6 +1549,22 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> hdmi->ratio = 100;
> hdmi->encoder = encoder;
>
> + of_property_read_u32(np, "reg-io-width", &val);
> +
> + switch (val) {
> + case 4:
> + hdmi->write = dw_hdmi_writel;
> + hdmi->read = dw_hdmi_readl;
> + break;
> + case 1:
> + hdmi->write = dw_hdmi_writeb;
> + hdmi->read = dw_hdmi_readb;
> + break;
> + default:
> + dev_err(dev, "reg-io-width must be 1 or 4\n");
> + return -EINVAL;
> + }
> +
> ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
> if (ddc_node) {
> hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
> @@ -1544,9 +1589,9 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
> return ret;
>
> iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - hdmi->regs = devm_ioremap_resource(dev, iores);
> - if (IS_ERR(hdmi->regs))
> - return PTR_ERR(hdmi->regs);
> + hdmi->regs.p32 = devm_ioremap_resource(dev, iores);
> + if (IS_ERR(hdmi->regs.p32))
> + return PTR_ERR(hdmi->regs.p32);
>
> /* Product and revision IDs */
> dev_info(dev,
regards
Philipp
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access
2014-11-26 16:34 ` Philipp Zabel
@ 2014-11-28 9:43 ` Andy Yan
2014-12-01 12:04 ` Philipp Zabel
0 siblings, 1 reply; 22+ messages in thread
From: Andy Yan @ 2014-11-28 9:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Hi Zabel:
On 2014年11月27日 00:34, Philipp Zabel wrote:
> Am Mittwoch, den 26.11.2014, 21:32 +0800 schrieb Andy Yan:
>> On rockchip rk3288, only word(32-bit) accesses are
>> permitted for hdmi registers. Byte width accesses (writeb,
>> readb) generate an imprecise external abort.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> ---
>>
>> Changes in v13: None
>> Changes in v12: None
>> Changes in v11: None
>> Changes in v10: None
>> Changes in v9: None
>> Changes in v8: None
>> Changes in v7: None
>> Changes in v6:
>> - refactor register access without reg_shift
>>
>> Changes in v5:
>> - refactor reg-io-width
>>
>> Changes in v4: None
>> Changes in v3:
>> - split multi-register access to one indepent patch
>>
>> drivers/gpu/drm/bridge/dw_hdmi.c | 57 +++++++++++++++++++++++++++++++++++-----
>> 1 file changed, 51 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
>> index a53bf63..5e88c8d 100644
>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
>> @@ -100,6 +100,11 @@ struct hdmi_data_info {
>> struct hdmi_vmode video_mode;
>> };
>>
>> +union dw_reg_ptr {
>> + u32 __iomem *p32;
>> + u8 __iomem *p8;
>> +};
> I see no need to introduce this. Just explicitly multiply the offset in
> dw_hdmi_writel.
>
Is there any disadvantage to do like this?
The compiler can help us do the explicitly multiply by this way.
>> struct dw_hdmi {
>> struct drm_connector connector;
>> struct drm_encoder *encoder;
>> @@ -121,20 +126,43 @@ struct dw_hdmi {
>>
>> struct regmap *regmap;
>> struct i2c_adapter *ddc;
>> - void __iomem *regs;
>> + union dw_reg_ptr regs;
> Keep this as void __iomem *
>
>> unsigned int sample_rate;
>> int ratio;
>> +
>> + void (*write)(struct dw_hdmi *hdmi, u8 val, int offset);
>> + u8 (*read)(struct dw_hdmi *hdmi, int offset);
>> };
>>
>> +static void dw_hdmi_writel(struct dw_hdmi *hdmi, u8 val, int offset)
>> +{
>> + writel(val, hdmi->regs.p32 + offset);
> hdmi->regs + 4 * offset
>
>> +}
>> +
>> +static u8 dw_hdmi_readl(struct dw_hdmi *hdmi, int offset)
>> +{
>> + return readl(hdmi->regs.p32 + offset);
> same here
>
>> +}
>> +
>> +static void dw_hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
>> +{
>> + writeb(val, hdmi->regs.p8 + offset);
>> +}
>> +
>> +static u8 dw_hdmi_readb(struct dw_hdmi *hdmi, int offset)
>> +{
>> + return readb(hdmi->regs.p8 + offset);
>> +}
>> +
>> static inline void hdmi_writeb(struct dw_hdmi *hdmi, u8 val, int offset)
>> {
>> - writeb(val, hdmi->regs + offset);
>> + hdmi->write(hdmi, val, offset);
>> }
>>
>> static inline u8 hdmi_readb(struct dw_hdmi *hdmi, int offset)
>> {
>> - return readb(hdmi->regs + offset);
>> + return hdmi->read(hdmi, offset);
>> }
>>
>> static void hdmi_modb(struct dw_hdmi *hdmi, u8 data, u8 mask, unsigned reg)
>> @@ -1508,6 +1536,7 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
>> struct dw_hdmi *hdmi;
>> struct resource *iores;
>> int ret, irq;
>> + u32 val = 1;
>>
>> hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL);
>> if (!hdmi)
>> @@ -1520,6 +1549,22 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
>> hdmi->ratio = 100;
>> hdmi->encoder = encoder;
>>
>> + of_property_read_u32(np, "reg-io-width", &val);
>> +
>> + switch (val) {
>> + case 4:
>> + hdmi->write = dw_hdmi_writel;
>> + hdmi->read = dw_hdmi_readl;
>> + break;
>> + case 1:
>> + hdmi->write = dw_hdmi_writeb;
>> + hdmi->read = dw_hdmi_readb;
>> + break;
>> + default:
>> + dev_err(dev, "reg-io-width must be 1 or 4\n");
>> + return -EINVAL;
>> + }
>> +
>> ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
>> if (ddc_node) {
>> hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
>> @@ -1544,9 +1589,9 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
>> return ret;
>>
>> iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - hdmi->regs = devm_ioremap_resource(dev, iores);
>> - if (IS_ERR(hdmi->regs))
>> - return PTR_ERR(hdmi->regs);
>> + hdmi->regs.p32 = devm_ioremap_resource(dev, iores);
>> + if (IS_ERR(hdmi->regs.p32))
>> + return PTR_ERR(hdmi->regs.p32);
>>
>> /* Product and revision IDs */
>> dev_info(dev,
> regards
> Philipp
>
>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support
2014-11-26 16:23 ` Philipp Zabel
@ 2014-11-28 9:47 ` Andy Yan
0 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-11-28 9:47 UTC (permalink / raw)
To: Philipp Zabel
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Hi Philipp:
On 2014年11月27日 00:23, Philipp Zabel wrote:
> Am Mittwoch, den 26.11.2014, 21:33 +0800 schrieb Andy Yan:
>> some platform may not support all the display mode,
>> add mode_valid interface check it
>>
>> also add drm_connector_register which add a debugfs
>> interface for dump display modes and edid information
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> Changes in v13: None
>> Changes in v12: None
>> Changes in v11: None
>> Changes in v10: None
>> Changes in v9: None
>> Changes in v8: None
>> Changes in v7: None
>> Changes in v6: None
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3: None
>>
>> drivers/gpu/drm/bridge/dw_hdmi.c | 17 +++++++++++++++++
>> include/drm/bridge/dw_hdmi.h | 2 ++
>> 2 files changed, 19 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
>> index 5e88c8d..b13e782 100644
>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
>> @@ -1406,6 +1406,20 @@ static int dw_hdmi_connector_get_modes(struct drm_connector *connector)
>> return 0;
>> }
>>
>> +static enum drm_mode_status
>> +dw_hdmi_connector_mode_valid(struct drm_connector *connector,
>> + struct drm_display_mode *mode)
>> +{
>> + struct dw_hdmi *hdmi = container_of(connector,
>> + struct dw_hdmi, connector);
>> + enum drm_mode_status mode_status = MODE_OK;
>> +
>> + if (hdmi->plat_data->mode_valid)
>> + mode_status = hdmi->plat_data->mode_valid(connector, mode);
>> +
>> + return mode_status;
>> +}
>> +
>> static struct drm_encoder *dw_hdmi_connector_best_encoder(struct drm_connector
>> *connector)
>> {
>> @@ -1430,6 +1444,7 @@ static struct drm_connector_funcs dw_hdmi_connector_funcs = {
>>
>> static struct drm_connector_helper_funcs dw_hdmi_connector_helper_funcs = {
>> .get_modes = dw_hdmi_connector_get_modes,
>> + .mode_valid = dw_hdmi_connector_mode_valid,
>> .best_encoder = dw_hdmi_connector_best_encoder,
>> };
>>
>> @@ -1631,6 +1646,8 @@ int dw_hdmi_bind(struct device *dev, struct device *master,
>>
>> dev_set_drvdata(dev, hdmi);
>>
>> + drm_connector_register(&hdmi->connector);
>> +
> This is not right, the connector is registered by the imx-drm core in
> the drm_driver .load callback.
Sorry, I didn't found imx-drm core has did that before.And I found many
connector drivers register it by itself.
This will be removed in next patch.
> regards
> Philipp
>
>
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi
2014-11-26 16:20 ` [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Philipp Zabel
@ 2014-11-28 9:57 ` Andy Yan
2014-11-28 16:14 ` Philipp Zabel
0 siblings, 1 reply; 22+ messages in thread
From: Andy Yan @ 2014-11-28 9:57 UTC (permalink / raw)
To: Philipp Zabel
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Hi Philipp:
On 2014年11月27日 00:20, Philipp Zabel wrote:
> Hi Andy,
>
> I have yet to look at this in more detail, but from a quick test
> starting with patch 3, the HDMI display stays black on Nitrogen6X,
> and starting with patch 8 I get the following error.
>
> imx-drm display-subsystem: [CONNECTOR:21:HDMI-A-1] drm_connector_register failed: -12
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:851 __clk_disable+0x6c/0x70()
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.18.0-rc6+ #8377
> Backtrace:
> [<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
> r6:00000353 r5:00000000 r4:8083ea08 r3:00000000
> [<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
> [<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
> r5:00000009 r4:00000000
> [<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
> r8:b721c610 r7:b72b0400 r6:b735504c r5:80000113 r4:b735504c
> [<800227f0>] (warn_slowpath_null) from [<80458088>] (__clk_disable+0x6c/0x70)
> [<8045801c>] (__clk_disable) from [<804581a8>] (clk_disable+0x34/0x40)
> r4:b735504c r3:b700e000
> [<80458174>] (clk_disable) from [<803241f0>] (dw_hdmi_imx_unbind+0x30/0x60)
> r5:b7355010 r4:b7219a10
> [<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
> r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
> [<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
> r5:b725f4c0 r4:b725f140
> [<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
> r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
> [<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
> r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
> [<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
> r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
> [<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
> r6:b725f140 r5:0000000c r4:b686ad70
> [<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
> [<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
> r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
> [<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
> r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
> [<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
> [<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
> r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
> [<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
> r5:b682ba10 r4:00000000
> [<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
> r6:808454e0 r5:b682ba44 r4:b682ba10
> [<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
> r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
> [<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
> r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
> [<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
> r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
> [<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
> r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
> [<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
> r5:00000000 r4:b7079ce0
> [<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
> r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
> r4:b721c410
> [<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
> r4:b721c410
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
> [<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
> r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
> [<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
> r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
> [<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
> r6:808454e0 r5:b728d000 r4:80845078
> [<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
> [<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
> r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
> [<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
> r5:8082be60 r4:8082be60
> [<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
> [<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
> [<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
> r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
> r4:8081aec0
> [<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
> r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
> r4:00008fc0
> [<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
> r4:00000000 r3:b7078000
> ---[ end trace 450768ad577083a9 ]---
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:760 __clk_unprepare+0x78/0x90()
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.18.0-rc6+ #8377
> Backtrace:
> [<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
> r6:000002f8 r5:00000000 r4:8083ea08 r3:00000000
> [<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
> [<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
> r5:00000009 r4:00000000
> [<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
> r8:b721c610 r7:b72b0400 r6:b735504c r5:b7355010 r4:b735504c
> [<800227f0>] (warn_slowpath_null) from [<80458bfc>] (__clk_unprepare+0x78/0x90)
> [<80458b84>] (__clk_unprepare) from [<80458c44>] (clk_unprepare+0x30/0x38)
> r4:b735504c r3:0000004c
> [<80458c14>] (clk_unprepare) from [<803241f8>] (dw_hdmi_imx_unbind+0x38/0x60)
> r4:b7219a10 r3:0000004c
> [<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
> r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
> [<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
> r5:b725f4c0 r4:b725f140
> [<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
> r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
> [<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
> r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
> [<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
> r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
> [<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
> r6:b725f140 r5:0000000c r4:b686ad70
> [<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
> [<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
> r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
> [<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
> r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
> [<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
> [<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
> r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
> [<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
> r5:b682ba10 r4:00000000
> [<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
> r6:808454e0 r5:b682ba44 r4:b682ba10
> [<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
> r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
> [<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
> r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
> [<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
> r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
> [<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
> r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
> [<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
> r5:00000000 r4:b7079ce0
> [<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
> r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
> r4:b721c410
> [<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
> r4:b721c410
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
> [<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
> r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
> [<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
> r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
> [<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
> r6:808454e0 r5:b728d000 r4:80845078
> [<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
> [<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
> r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
> [<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
> r5:8082be60 r4:8082be60
> [<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
> [<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
> [<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
> r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
> r4:8081aec0
> [<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
> r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
> r4:00008fc0
> [<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
> r4:00000000 r3:b7078000
> ---[ end trace 450768ad577083aa ]---
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:851 __clk_disable+0x6c/0x70()
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.18.0-rc6+ #8377
> Backtrace:
> [<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
> r6:00000353 r5:00000000 r4:8083ea08 r3:00000000
> [<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
> [<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
> r5:00000009 r4:00000000
> [<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
> r8:b721c610 r7:b72b0400 r6:b735504c r5:80000113 r4:b735504c
> [<800227f0>] (warn_slowpath_null) from [<80458088>] (__clk_disable+0x6c/0x70)
> [<8045801c>] (__clk_disable) from [<804581a8>] (clk_disable+0x34/0x40)
> r4:b735504c r3:b700e000
> [<80458174>] (clk_disable) from [<80324204>] (dw_hdmi_imx_unbind+0x44/0x60)
> r5:b735504c r4:b7219a10
> [<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
> r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
> [<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
> r5:b725f4c0 r4:b725f140
> [<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
> r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
> [<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
> r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
> [<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
> r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
> [<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
> r6:b725f140 r5:0000000c r4:b686ad70
> [<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
> [<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
> r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
> [<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
> r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
> [<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
> [<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
> r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
> [<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
> r5:b682ba10 r4:00000000
> [<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
> r6:808454e0 r5:b682ba44 r4:b682ba10
> [<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
> r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
> [<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
> r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
> [<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
> r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
> [<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
> r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
> [<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
> r5:00000000 r4:b7079ce0
> [<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
> r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
> r4:b721c410
> [<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
> r4:b721c410
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
> [<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
> r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
> [<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
> r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
> [<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
> r6:808454e0 r5:b728d000 r4:80845078
> [<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
> [<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
> r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
> [<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
> r5:8082be60 r4:8082be60
> [<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
> [<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
> [<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
> r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
> r4:8081aec0
> [<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
> r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
> r4:00008fc0
> [<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
> r4:00000000 r3:b7078000
> ---[ end trace 450768ad577083ab ]---
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:760 __clk_unprepare+0x78/0x90()
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 3.18.0-rc6+ #8377
> Backtrace:
> [<80012414>] (dump_backtrace) from [<80012754>] (show_stack+0x20/0x24)
> r6:000002f8 r5:00000000 r4:8083ea08 r3:00000000
> [<80012734>] (show_stack) from [<805ae670>] (dump_stack+0x8c/0x9c)
> [<805ae5e4>] (dump_stack) from [<80022744>] (warn_slowpath_common+0x80/0x9c)
> r5:00000009 r4:00000000
> [<800226c4>] (warn_slowpath_common) from [<8002281c>] (warn_slowpath_null+0x2c/0x34)
> r8:b721c610 r7:b72b0400 r6:b735504c r5:b735504c r4:b735504c
> [<800227f0>] (warn_slowpath_null) from [<80458bfc>] (__clk_unprepare+0x78/0x90)
> [<80458b84>] (__clk_unprepare) from [<80458c44>] (clk_unprepare+0x30/0x38)
> r4:b735504c r3:000003b5
> [<80458c14>] (clk_unprepare) from [<8032420c>] (dw_hdmi_imx_unbind+0x4c/0x60)
> r4:b7219a10 r3:000003b5
> [<803241c0>] (dw_hdmi_imx_unbind) from [<8032fc84>] (component_unbind.isra.3+0x40/0x78)
> r8:b72a1e40 r7:b725f158 r6:b72b0400 r5:b725f158 r4:b725f4c0 r3:803241c0
> [<8032fc44>] (component_unbind.isra.3) from [<8032fd44>] (component_unbind_all+0x88/0xb8)
> r5:b725f4c0 r4:b725f140
> [<8032fcbc>] (component_unbind_all) from [<80321a3c>] (imx_drm_driver_load+0x100/0x13c)
> r7:b72b05cc r6:fffffff4 r5:b7355010 r4:b72b0400
> [<8032193c>] (imx_drm_driver_load) from [<8030c260>] (drm_dev_register+0xb8/0x114)
> r7:b686ad10 r6:00000000 r5:00000000 r4:b72b0400
> [<8030c1a8>] (drm_dev_register) from [<8030dd58>] (drm_platform_init+0x54/0xe8)
> r6:80844bf4 r5:b721c600 r4:b72b0400 r3:00000000
> [<8030dd04>] (drm_platform_init) from [<803218e8>] (imx_drm_bind+0x20/0x28)
> r6:b725f140 r5:0000000c r4:b686ad70
> [<803218c8>] (imx_drm_bind) from [<8032f9b0>] (try_to_bring_up_master.part.2+0xd8/0x118)
> [<8032f8d8>] (try_to_bring_up_master.part.2) from [<8032fbe4>] (component_add+0xa0/0x100)
> r8:b72a1c40 r7:80602b6c r6:b72a1e40 r5:808451e8 r4:b725f140 r3:00000000
> [<8032fb44>] (component_add) from [<8032330c>] (ipu_drm_probe+0x7c/0x150)
> r7:b682ba10 r6:b77b3cc0 r5:b682ba00 r4:b77b4868
> [<80323290>] (ipu_drm_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r9:00000000 r8:00000000 r7:80844e94 r6:80844e94 r5:fffffdfb r4:b682ba10
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80844e94 r6:00000000 r5:808bc064 r4:b682ba10
> [<80334780>] (driver_probe_device) from [<80334a2c>] (__device_attach+0x50/0x54)
> r8:00000000 r7:b721c410 r6:803349dc r5:b682ba10 r4:80844e94 r3:80336838
> [<803349dc>] (__device_attach) from [<80332c34>] (bus_for_each_drv+0x68/0x9c)
> r5:b682ba10 r4:00000000
> [<80332bcc>] (bus_for_each_drv) from [<8033473c>] (device_attach+0x84/0x98)
> r6:808454e0 r5:b682ba44 r4:b682ba10
> [<803346b8>] (device_attach) from [<80333d14>] (bus_probe_device+0x94/0xb8)
> r6:808454e0 r5:b682ba10 r4:b682ba18 r3:b7046800
> [<80333c80>] (bus_probe_device) from [<80331e58>] (device_add+0x450/0x530)
> r6:b682ba10 r5:00000000 r4:b682ba18 r3:00000000
> [<80331a08>] (device_add) from [<803362c8>] (platform_device_add+0xc4/0x228)
> r9:00000006 r8:b721c410 r7:b7079cc4 r6:b682ba10 r5:b682ba00 r4:00000000
> [<80336204>] (platform_device_add) from [<80336b60>] (platform_device_register_full+0xcc/0xf0)
> r7:b7079cc4 r6:b7079ce0 r5:b682ba00 r4:b7079ce0
> [<80336a94>] (platform_device_register_full) from [<80328354>] (ipu_add_client_devices.isra.10+0x164/0x19c)
> r5:00000000 r4:b7079ce0
> [<803281f0>] (ipu_add_client_devices.isra.10) from [<80328940>] (ipu_probe+0x5b4/0x740)
> r10:808450d4 r9:00000001 r8:b7028180 r7:b72b0010 r6:808450d4 r5:00000000
> r4:b721c410
> [<8032838c>] (ipu_probe) from [<80336640>] (platform_drv_probe+0x54/0xb4)
> r10:00000000 r9:b725f580 r8:00000000 r7:80845078 r6:80845078 r5:fffffdfb
> r4:b721c410
> [<803365ec>] (platform_drv_probe) from [<803348a8>] (driver_probe_device+0x128/0x25c)
> r7:80845078 r6:00000000 r5:808bc064 r4:b721c410
> [<80334780>] (driver_probe_device) from [<80334acc>] (__driver_attach+0x9c/0xa0)
> r8:807ab5e8 r7:00000000 r6:b721c444 r5:80845078 r4:b721c410 r3:00000000
> [<80334a30>] (__driver_attach) from [<80332b6c>] (bus_for_each_dev+0x70/0xa4)
> r6:80334a30 r5:80845078 r4:00000000 r3:b704685c
> [<80332afc>] (bus_for_each_dev) from [<80334334>] (driver_attach+0x2c/0x30)
> r6:808454e0 r5:b728d000 r4:80845078
> [<80334308>] (driver_attach) from [<80333fac>] (bus_add_driver+0x15c/0x204)
> [<80333e50>] (bus_add_driver) from [<803352d4>] (driver_register+0x88/0x108)
> r7:b7078000 r6:807d86c0 r5:8082be60 r4:80845078
> [<8033524c>] (driver_register) from [<8033656c>] (__platform_driver_register+0x64/0x6c)
> r5:8082be60 r4:8082be60
> [<80336508>] (__platform_driver_register) from [<807d86dc>] (imx_ipu_driver_init+0x1c/0x20)
> [<807d86c0>] (imx_ipu_driver_init) from [<80008980>] (do_one_initcall+0x9c/0x1dc)
> [<800088e4>] (do_one_initcall) from [<807abe5c>] (kernel_init_freeable+0x144/0x1e8)
> r10:000000aa r9:807f9320 r8:807ab5e8 r7:80868fc0 r6:80868fc0 r5:00000006
> r4:8081aec0
> [<807abd18>] (kernel_init_freeable) from [<805a9b44>] (kernel_init+0x1c/0xf8)
> r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:805a9b28
> r4:00008fc0
> [<805a9b28>] (kernel_init) from [<8000eb38>] (ret_from_fork+0x14/0x20)
> r4:00000000 r3:b7078000
> ---[ end trace 450768ad577083ac ]---
> imx-ipuv3-crtc: probe of imx-ipuv3-crtc.5 failed with error -12
>
> regards
> Philipp
>
>
>
>
Very sorry about this trouble. Because I have no imx board, we do all
the test on
RK3288 board.
I had sent a mail with a debug patch to you directly yesterday, hope
it will helpful.
If you have received the mail, would you please give me a reply?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi
2014-11-28 9:57 ` Andy Yan
@ 2014-11-28 16:14 ` Philipp Zabel
0 siblings, 0 replies; 22+ messages in thread
From: Philipp Zabel @ 2014-11-28 16:14 UTC (permalink / raw)
To: Andy Yan
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Am Freitag, den 28.11.2014, 17:57 +0800 schrieb Andy Yan:
> Hi Philipp:
[...]
> Very sorry about this trouble. Because I have no imx board, we do all
> the test on
> RK3288 board.
> I had sent a mail with a debug patch to you directly yesterday, hope
> it will helpful.
> If you have received the mail, would you please give me a reply?
Yes, that was helpful, thank you.
I needed to apply Russell's "imx-drm: convert imx-drm to use the generic
DRM OF helper" patch for drm_of_find_possible_crtcs to work on imx-drm.
regards
Philipp
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access
2014-11-28 9:43 ` Andy Yan
@ 2014-12-01 12:04 ` Philipp Zabel
2014-12-01 12:46 ` Andy Yan
0 siblings, 1 reply; 22+ messages in thread
From: Philipp Zabel @ 2014-12-01 12:04 UTC (permalink / raw)
To: Andy Yan
Cc: airlied, heiko, fabio.estevam, rmk+kernel, Greg Kroah-Hartman,
Grant Likely, Rob Herring, Shawn Guo, Josh Boyer, Sean Paul,
Inki Dae, Dave Airlie, Arnd Bergmann, Lucas Stach,
Zubair.Kakakhel, djkurtz, ykk, linux-kernel, dri-devel, devel,
devicetree, linux-rockchip, jay.xu, Pawel Moll, mark.yao,
Mark Rutland, Ian Campbell, Kumar Gala
Am Freitag, den 28.11.2014, 17:43 +0800 schrieb Andy Yan:
> Hi Zabel:
> On 2014年11月27日 00:34, Philipp Zabel wrote:
> > Am Mittwoch, den 26.11.2014, 21:32 +0800 schrieb Andy Yan:
> >> On rockchip rk3288, only word(32-bit) accesses are
> >> permitted for hdmi registers. Byte width accesses (writeb,
> >> readb) generate an imprecise external abort.
> >>
> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> >>
> >> ---
> >>
> >> Changes in v13: None
> >> Changes in v12: None
> >> Changes in v11: None
> >> Changes in v10: None
> >> Changes in v9: None
> >> Changes in v8: None
> >> Changes in v7: None
> >> Changes in v6:
> >> - refactor register access without reg_shift
> >>
> >> Changes in v5:
> >> - refactor reg-io-width
> >>
> >> Changes in v4: None
> >> Changes in v3:
> >> - split multi-register access to one indepent patch
> >>
> >> drivers/gpu/drm/bridge/dw_hdmi.c | 57 +++++++++++++++++++++++++++++++++++-----
> >> 1 file changed, 51 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
> >> index a53bf63..5e88c8d 100644
> >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
> >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
> >> @@ -100,6 +100,11 @@ struct hdmi_data_info {
> >> struct hdmi_vmode video_mode;
> >> };
> >>
> >> +union dw_reg_ptr {
> >> + u32 __iomem *p32;
> >> + u8 __iomem *p8;
> >> +};
> > I see no need to introduce this. Just explicitly multiply the offset in
> > dw_hdmi_writel.
> >
> Is there any disadvantage to do like this?
> The compiler can help us do the explicitly multiply by this way.
Four additional lines, a new defined type, a few more changes to struct
dw_hdmi and dw_hdmi_bind necessary.
Technically I see no problem to let the compiler do the multiplication,
my issue is that it ever so slightly obfuscates the code. Instead of
just writing "* 4" in two functions, we get a new union that you need to
know about when looking at struct dw_hdmi and dw_hdmi_bind, regs.p8 is
used but never assigned directly, it's just a tiny bit of additional
effort needed to understand the code. But when the cost to avoid that is
so small...
regards
Philipp
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access
2014-12-01 12:04 ` Philipp Zabel
@ 2014-12-01 12:46 ` Andy Yan
0 siblings, 0 replies; 22+ messages in thread
From: Andy Yan @ 2014-12-01 12:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Mark Rutland, heiko, airlied, dri-devel, ykk, devel, Pawel Moll,
linux-rockchip, Grant Likely, Dave Airlie, jay.xu, devicetree,
Zubair.Kakakhel, Arnd Bergmann, Ian Campbell, Inki Dae,
Rob Herring, Sean Paul, rmk+kernel, mark.yao, fabio.estevam,
Josh Boyer, Greg Kroah-Hartman, linux-kernel, djkurtz,
Kumar Gala, Shawn Guo, Lucas Stach
Hi Philipp:
On 2014年12月01日 20:04, Philipp Zabel wrote:
> Am Freitag, den 28.11.2014, 17:43 +0800 schrieb Andy Yan:
>> Hi Zabel:
>> On 2014年11月27日 00:34, Philipp Zabel wrote:
>>> Am Mittwoch, den 26.11.2014, 21:32 +0800 schrieb Andy Yan:
>>>> On rockchip rk3288, only word(32-bit) accesses are
>>>> permitted for hdmi registers. Byte width accesses (writeb,
>>>> readb) generate an imprecise external abort.
>>>>
>>>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v13: None
>>>> Changes in v12: None
>>>> Changes in v11: None
>>>> Changes in v10: None
>>>> Changes in v9: None
>>>> Changes in v8: None
>>>> Changes in v7: None
>>>> Changes in v6:
>>>> - refactor register access without reg_shift
>>>>
>>>> Changes in v5:
>>>> - refactor reg-io-width
>>>>
>>>> Changes in v4: None
>>>> Changes in v3:
>>>> - split multi-register access to one indepent patch
>>>>
>>>> drivers/gpu/drm/bridge/dw_hdmi.c | 57 +++++++++++++++++++++++++++++++++++-----
>>>> 1 file changed, 51 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
>>>> index a53bf63..5e88c8d 100644
>>>> --- a/drivers/gpu/drm/bridge/dw_hdmi.c
>>>> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c
>>>> @@ -100,6 +100,11 @@ struct hdmi_data_info {
>>>> struct hdmi_vmode video_mode;
>>>> };
>>>>
>>>> +union dw_reg_ptr {
>>>> + u32 __iomem *p32;
>>>> + u8 __iomem *p8;
>>>> +};
>>> I see no need to introduce this. Just explicitly multiply the offset in
>>> dw_hdmi_writel.
>>>
>> Is there any disadvantage to do like this?
>> The compiler can help us do the explicitly multiply by this way.
> Four additional lines, a new defined type, a few more changes to struct
> dw_hdmi and dw_hdmi_bind necessary.
>
> Technically I see no problem to let the compiler do the multiplication,
> my issue is that it ever so slightly obfuscates the code. Instead of
> just writing "* 4" in two functions, we get a new union that you need to
> know about when looking at struct dw_hdmi and dw_hdmi_bind, regs.p8 is
> used but never assigned directly, it's just a tiny bit of additional
> effort needed to understand the code. But when the cost to avoid that is
> so small...
>
> regards
> Philipp
>
What you said is right, I will change it in PATCH V15
thanks .
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2014-12-01 12:46 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-26 13:22 [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
2014-11-26 13:26 ` [PATCH v13 01/12] drm: imx: imx-hdmi: make checkpatch happy Andy Yan
2014-11-26 13:26 ` [PATCH v13 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Andy Yan
2014-11-26 13:27 ` [PATCH v13 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode Andy Yan
2014-11-26 13:30 ` [PATCH v13 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver Andy Yan
2014-11-26 13:30 ` [PATCH v13 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Andy Yan
2014-11-26 13:31 ` [PATCH v13 06/12] dt-bindings: add document for dw_hdmi Andy Yan
2014-11-26 13:32 ` [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Andy Yan
2014-11-26 16:34 ` Philipp Zabel
2014-11-28 9:43 ` Andy Yan
2014-12-01 12:04 ` Philipp Zabel
2014-12-01 12:46 ` Andy Yan
2014-11-26 13:33 ` [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support Andy Yan
2014-11-26 16:23 ` Philipp Zabel
2014-11-28 9:47 ` Andy Yan
2014-11-26 13:34 ` [PATCH v13 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done Andy Yan
2014-11-26 13:35 ` [PATCH v13 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare Andy Yan
2014-11-26 13:36 ` [PATCH v13 11/12] dt-bindings: Add documentation for rockchip dw hdmi Andy Yan
2014-11-26 13:37 ` [PATCH v13 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Andy Yan
2014-11-26 16:20 ` [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Philipp Zabel
2014-11-28 9:57 ` Andy Yan
2014-11-28 16:14 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).