* [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change
@ 2014-12-02 15:28 Sreekanth Reddy
2014-12-02 15:28 ` [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change." Sreekanth Reddy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sreekanth Reddy @ 2014-12-02 15:28 UTC (permalink / raw)
To: jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, Sreekanth Reddy
Reverting the below commit IDs
1. [PATCH 1/2] mpt2sas: Remove phys on topology change
commit ID: 3520f9c779bed098ca76dd3fb6377264301d57ed
2. [PATCH 2/2] mpt3sas: Remove phys on topology change
commit ID: 963ba22b90a955363644cd397b20226928eab976
Sreekanth Reddy (2):
Revert "[SCSI] mpt2sas: Remove phys on topology change."
Revert "[SCSI] mpt3sas: Remove phys on topology change"
drivers/scsi/mpt2sas/mpt2sas_transport.c | 5 +----
drivers/scsi/mpt3sas/mpt3sas_transport.c | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
--
2.0.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change."
2014-12-02 15:28 [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Sreekanth Reddy
@ 2014-12-02 15:28 ` Sreekanth Reddy
2014-12-03 12:17 ` Tomas Henzl
2014-12-02 15:28 ` [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change" Sreekanth Reddy
2014-12-04 9:24 ` [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Sreekanth Reddy @ 2014-12-02 15:28 UTC (permalink / raw)
To: jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, Sreekanth Reddy, stable,
Tomas Henzl
This reverts commit 3520f9c779bed098ca76dd3fb6377264301d57ed
("mpt2sas: Remove phys on topology change")
Reverting the previous mpt2sas drives patch changes,
since we will observe below issue
Issue:
Drives connected Enclosure/Expander will unregister with
SCSI Transport Layer, if any one remove and add expander
cable with in DMD (Device Missing Delay) time period or
even any one power-off and power-on the Enclosure with in
the DMD period.
Cc: <stable@vger.kernel.org>
Cc: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
---
drivers/scsi/mpt2sas/mpt2sas_transport.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c
index 0d1d064..e689bf2 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_transport.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c
@@ -1006,12 +1006,9 @@ mpt2sas_transport_update_links(struct MPT2SAS_ADAPTER *ioc,
&mpt2sas_phy->remote_identify);
_transport_add_phy_to_an_existing_port(ioc, sas_node,
mpt2sas_phy, mpt2sas_phy->remote_identify.sas_address);
- } else {
+ } else
memset(&mpt2sas_phy->remote_identify, 0 , sizeof(struct
sas_identify));
- _transport_del_phy_from_an_existing_port(ioc, sas_node,
- mpt2sas_phy);
- }
if (mpt2sas_phy->phy)
mpt2sas_phy->phy->negotiated_linkrate =
--
2.0.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change"
2014-12-02 15:28 [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Sreekanth Reddy
2014-12-02 15:28 ` [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change." Sreekanth Reddy
@ 2014-12-02 15:28 ` Sreekanth Reddy
2014-12-03 12:18 ` Tomas Henzl
2014-12-04 9:24 ` [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Sreekanth Reddy @ 2014-12-02 15:28 UTC (permalink / raw)
To: jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, Sreekanth Reddy, stable,
Tomas Henzl
This reverts commit 963ba22b90a955363644cd397b20226928eab976
("mpt3sas: Remove phys on topology change")
Reverting the previous mpt3sas drives patch changes,
since we will observe below issue
Issue:
Drives connected Enclosure/Expander will unregister with
SCSI Transport Layer, if any one remove and add expander
cable with in DMD (Device Missing Delay) time period or
even any one power-off and power-on the Enclosure with in
the DMD period.
Cc: <stable@vger.kernel.org>
Cc: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
---
drivers/scsi/mpt3sas/mpt3sas_transport.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
index d4bafaa..3637ae6 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
@@ -1003,12 +1003,9 @@ mpt3sas_transport_update_links(struct MPT3SAS_ADAPTER *ioc,
&mpt3sas_phy->remote_identify);
_transport_add_phy_to_an_existing_port(ioc, sas_node,
mpt3sas_phy, mpt3sas_phy->remote_identify.sas_address);
- } else {
+ } else
memset(&mpt3sas_phy->remote_identify, 0 , sizeof(struct
sas_identify));
- _transport_del_phy_from_an_existing_port(ioc, sas_node,
- mpt3sas_phy);
- }
if (mpt3sas_phy->phy)
mpt3sas_phy->phy->negotiated_linkrate =
--
2.0.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change."
2014-12-02 15:28 ` [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change." Sreekanth Reddy
@ 2014-12-03 12:17 ` Tomas Henzl
0 siblings, 0 replies; 6+ messages in thread
From: Tomas Henzl @ 2014-12-03 12:17 UTC (permalink / raw)
To: Sreekanth Reddy, jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, stable
On 12/02/2014 04:28 PM, Sreekanth Reddy wrote:
> This reverts commit 3520f9c779bed098ca76dd3fb6377264301d57ed
> ("mpt2sas: Remove phys on topology change")
>
> Reverting the previous mpt2sas drives patch changes,
> since we will observe below issue
>
> Issue:
> Drives connected Enclosure/Expander will unregister with
> SCSI Transport Layer, if any one remove and add expander
> cable with in DMD (Device Missing Delay) time period or
> even any one power-off and power-on the Enclosure with in
> the DMD period.
We were not able to reproduce the issue which the original patch
should have fixed, so it's fine to remove it.
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
> Cc: <stable@vger.kernel.org>
> Cc: Tomas Henzl <thenzl@redhat.com>
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
> ---
> drivers/scsi/mpt2sas/mpt2sas_transport.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c
> index 0d1d064..e689bf2 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c
> @@ -1006,12 +1006,9 @@ mpt2sas_transport_update_links(struct MPT2SAS_ADAPTER *ioc,
> &mpt2sas_phy->remote_identify);
> _transport_add_phy_to_an_existing_port(ioc, sas_node,
> mpt2sas_phy, mpt2sas_phy->remote_identify.sas_address);
> - } else {
> + } else
> memset(&mpt2sas_phy->remote_identify, 0 , sizeof(struct
> sas_identify));
> - _transport_del_phy_from_an_existing_port(ioc, sas_node,
> - mpt2sas_phy);
> - }
>
> if (mpt2sas_phy->phy)
> mpt2sas_phy->phy->negotiated_linkrate =
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change"
2014-12-02 15:28 ` [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change" Sreekanth Reddy
@ 2014-12-03 12:18 ` Tomas Henzl
0 siblings, 0 replies; 6+ messages in thread
From: Tomas Henzl @ 2014-12-03 12:18 UTC (permalink / raw)
To: Sreekanth Reddy, jejb, hch
Cc: martin.petersen, linux-scsi, JBottomley, Sathya.Prakash,
Nagalakshmi.Nandigama, linux-kernel, stable
On 12/02/2014 04:28 PM, Sreekanth Reddy wrote:
> This reverts commit 963ba22b90a955363644cd397b20226928eab976
> ("mpt3sas: Remove phys on topology change")
>
> Reverting the previous mpt3sas drives patch changes,
> since we will observe below issue
>
> Issue:
> Drives connected Enclosure/Expander will unregister with
> SCSI Transport Layer, if any one remove and add expander
> cable with in DMD (Device Missing Delay) time period or
> even any one power-off and power-on the Enclosure with in
> the DMD period.
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
>
> Cc: <stable@vger.kernel.org>
> Cc: Tomas Henzl <thenzl@redhat.com>
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
> ---
> drivers/scsi/mpt3sas/mpt3sas_transport.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
> index d4bafaa..3637ae6 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
> @@ -1003,12 +1003,9 @@ mpt3sas_transport_update_links(struct MPT3SAS_ADAPTER *ioc,
> &mpt3sas_phy->remote_identify);
> _transport_add_phy_to_an_existing_port(ioc, sas_node,
> mpt3sas_phy, mpt3sas_phy->remote_identify.sas_address);
> - } else {
> + } else
> memset(&mpt3sas_phy->remote_identify, 0 , sizeof(struct
> sas_identify));
> - _transport_del_phy_from_an_existing_port(ioc, sas_node,
> - mpt3sas_phy);
> - }
>
> if (mpt3sas_phy->phy)
> mpt3sas_phy->phy->negotiated_linkrate =
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change
2014-12-02 15:28 [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Sreekanth Reddy
2014-12-02 15:28 ` [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change." Sreekanth Reddy
2014-12-02 15:28 ` [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change" Sreekanth Reddy
@ 2014-12-04 9:24 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2014-12-04 9:24 UTC (permalink / raw)
To: Sreekanth Reddy
Cc: jejb, hch, martin.petersen, linux-scsi, JBottomley,
Sathya.Prakash, Nagalakshmi.Nandigama, linux-kernel
Thanks,
I've applied both patches.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-04 9:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-02 15:28 [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Sreekanth Reddy
2014-12-02 15:28 ` [PATCH 1/2] Revert "[SCSI] mpt2sas: Remove phys on topology change." Sreekanth Reddy
2014-12-03 12:17 ` Tomas Henzl
2014-12-02 15:28 ` [PATCH 2/2] Revert "[SCSI] mpt3sas: Remove phys on topology change" Sreekanth Reddy
2014-12-03 12:18 ` Tomas Henzl
2014-12-04 9:24 ` [PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).