* [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function
@ 2014-12-20 12:48 Rickard Strandqvist
2014-12-20 18:07 ` Larry Finger
2014-12-24 16:56 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2014-12-20 12:48 UTC (permalink / raw)
To: Larry Finger, Chaoming Li
Cc: Rickard Strandqvist, John W. Linville, Greg Kroah-Hartman,
Rasmus Villemoes, Joe Perches, linux-wireless, netdev,
linux-kernel
Remove the function rtl92ee_get_available_desc() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/net/wireless/rtlwifi/rtl8192ee/trx.c | 21 ---------------------
drivers/net/wireless/rtlwifi/rtl8192ee/trx.h | 1 -
2 files changed, 22 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c
index 2fcbef1..8186ed2 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c
@@ -710,27 +710,6 @@ static u16 get_desc_addr_fr_q_idx(u16 queue_index)
return desc_address;
}
-void rtl92ee_get_available_desc(struct ieee80211_hw *hw, u8 q_idx)
-{
- struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
- struct rtl_priv *rtlpriv = rtl_priv(hw);
- u16 point_diff = 0;
- u16 current_tx_read_point = 0, current_tx_write_point = 0;
- u32 tmp_4byte;
-
- tmp_4byte = rtl_read_dword(rtlpriv,
- get_desc_addr_fr_q_idx(q_idx));
- current_tx_read_point = (u16)((tmp_4byte >> 16) & 0x0fff);
- current_tx_write_point = (u16)((tmp_4byte) & 0x0fff);
-
- point_diff = ((current_tx_read_point > current_tx_write_point) ?
- (current_tx_read_point - current_tx_write_point) :
- (TX_DESC_NUM_92E - current_tx_write_point +
- current_tx_read_point));
-
- rtlpci->tx_ring[q_idx].avl_desc = point_diff;
-}
-
void rtl92ee_pre_fill_tx_bd_desc(struct ieee80211_hw *hw,
u8 *tx_bd_desc, u8 *desc, u8 queue_index,
struct sk_buff *skb, dma_addr_t addr)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h
index 6f9be1c..4426c49 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h
@@ -829,7 +829,6 @@ void rtl92ee_rx_check_dma_ok(struct ieee80211_hw *hw, u8 *header_desc,
u8 queue_index);
u16 rtl92ee_rx_desc_buff_remained_cnt(struct ieee80211_hw *hw,
u8 queue_index);
-void rtl92ee_get_available_desc(struct ieee80211_hw *hw, u8 queue_index);
void rtl92ee_pre_fill_tx_bd_desc(struct ieee80211_hw *hw,
u8 *tx_bd_desc, u8 *desc, u8 queue_index,
struct sk_buff *skb, dma_addr_t addr);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function
2014-12-20 12:48 [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function Rickard Strandqvist
@ 2014-12-20 18:07 ` Larry Finger
2014-12-24 16:56 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2014-12-20 18:07 UTC (permalink / raw)
To: Rickard Strandqvist, Chaoming Li
Cc: John W. Linville, Greg Kroah-Hartman, Rasmus Villemoes,
Joe Perches, linux-wireless, netdev, linux-kernel
On 12/20/2014 06:48 AM, Rickard Strandqvist wrote:
> Remove the function rtl92ee_get_available_desc() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/net/wireless/rtlwifi/rtl8192ee/trx.c | 21 ---------------------
> drivers/net/wireless/rtlwifi/rtl8192ee/trx.h | 1 -
> 2 files changed, 22 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Richard: FYI, John Linville stepped down as wireless maintainer this week, thus
there is no need to send patches to him anymore. Kalle Valo, the new maintainer,
has stated that it is not necessary to Cc him.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c
> index 2fcbef1..8186ed2 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.c
> @@ -710,27 +710,6 @@ static u16 get_desc_addr_fr_q_idx(u16 queue_index)
> return desc_address;
> }
>
> -void rtl92ee_get_available_desc(struct ieee80211_hw *hw, u8 q_idx)
> -{
> - struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
> - struct rtl_priv *rtlpriv = rtl_priv(hw);
> - u16 point_diff = 0;
> - u16 current_tx_read_point = 0, current_tx_write_point = 0;
> - u32 tmp_4byte;
> -
> - tmp_4byte = rtl_read_dword(rtlpriv,
> - get_desc_addr_fr_q_idx(q_idx));
> - current_tx_read_point = (u16)((tmp_4byte >> 16) & 0x0fff);
> - current_tx_write_point = (u16)((tmp_4byte) & 0x0fff);
> -
> - point_diff = ((current_tx_read_point > current_tx_write_point) ?
> - (current_tx_read_point - current_tx_write_point) :
> - (TX_DESC_NUM_92E - current_tx_write_point +
> - current_tx_read_point));
> -
> - rtlpci->tx_ring[q_idx].avl_desc = point_diff;
> -}
> -
> void rtl92ee_pre_fill_tx_bd_desc(struct ieee80211_hw *hw,
> u8 *tx_bd_desc, u8 *desc, u8 queue_index,
> struct sk_buff *skb, dma_addr_t addr)
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h
> index 6f9be1c..4426c49 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ee/trx.h
> @@ -829,7 +829,6 @@ void rtl92ee_rx_check_dma_ok(struct ieee80211_hw *hw, u8 *header_desc,
> u8 queue_index);
> u16 rtl92ee_rx_desc_buff_remained_cnt(struct ieee80211_hw *hw,
> u8 queue_index);
> -void rtl92ee_get_available_desc(struct ieee80211_hw *hw, u8 queue_index);
> void rtl92ee_pre_fill_tx_bd_desc(struct ieee80211_hw *hw,
> u8 *tx_bd_desc, u8 *desc, u8 queue_index,
> struct sk_buff *skb, dma_addr_t addr);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function
2014-12-20 12:48 [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function Rickard Strandqvist
2014-12-20 18:07 ` Larry Finger
@ 2014-12-24 16:56 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2014-12-24 16:56 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Larry Finger, Chaoming Li, John W. Linville, Greg Kroah-Hartman,
Rasmus Villemoes, Joe Perches, linux-wireless, netdev,
linux-kernel
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> writes:
> Remove the function rtl92ee_get_available_desc() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, applied to wireless-drivers-next.git.
But I simplified the patch title:
commit 9898b77536b8569be2704964d3c519ef070e4a27
Author: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Date: Sat Dec 20 13:48:14 2014 +0100
rtlwifi: rtl8192ee: trx.c: Remove unused function
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-24 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-20 12:48 [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function Rickard Strandqvist
2014-12-20 18:07 ` Larry Finger
2014-12-24 16:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).