* [PATCH] scsi: aic7xxx: aic7770: Remove unused function
@ 2015-01-02 20:30 Rickard Strandqvist
2015-01-10 13:29 ` Hannes Reinecke
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-02 20:30 UTC (permalink / raw)
To: Hannes Reinecke, James E.J. Bottomley
Cc: Rickard Strandqvist, linux-scsi, linux-kernel
Remove the function aic7770_find_device() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/scsi/aic7xxx/aic7770.c | 14 --------------
drivers/scsi/aic7xxx/aic7xxx.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7770.c b/drivers/scsi/aic7xxx/aic7770.c
index 5000bd6..cbe10755 100644
--- a/drivers/scsi/aic7xxx/aic7770.c
+++ b/drivers/scsi/aic7xxx/aic7770.c
@@ -107,20 +107,6 @@ struct aic7770_identity aic7770_ident_table[] =
};
const int ahc_num_aic7770_devs = ARRAY_SIZE(aic7770_ident_table);
-struct aic7770_identity *
-aic7770_find_device(uint32_t id)
-{
- struct aic7770_identity *entry;
- int i;
-
- for (i = 0; i < ahc_num_aic7770_devs; i++) {
- entry = &aic7770_ident_table[i];
- if (entry->full_id == (id & entry->id_mask))
- return (entry);
- }
- return (NULL);
-}
-
int
aic7770_config(struct ahc_softc *ahc, struct aic7770_identity *entry, u_int io)
{
diff --git a/drivers/scsi/aic7xxx/aic7xxx.h b/drivers/scsi/aic7xxx/aic7xxx.h
index f695774..ead8924 100644
--- a/drivers/scsi/aic7xxx/aic7xxx.h
+++ b/drivers/scsi/aic7xxx/aic7xxx.h
@@ -1144,7 +1144,6 @@ void ahc_pci_resume(struct ahc_softc *ahc);
#endif
/*************************** EISA/VL Front End ********************************/
-struct aic7770_identity *aic7770_find_device(uint32_t);
int aic7770_config(struct ahc_softc *ahc,
struct aic7770_identity *,
u_int port);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: aic7xxx: aic7770: Remove unused function
2015-01-02 20:30 [PATCH] scsi: aic7xxx: aic7770: Remove unused function Rickard Strandqvist
@ 2015-01-10 13:29 ` Hannes Reinecke
0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2015-01-10 13:29 UTC (permalink / raw)
To: Rickard Strandqvist, James E.J. Bottomley; +Cc: linux-scsi, linux-kernel
On 01/02/2015 09:30 PM, Rickard Strandqvist wrote:
> Remove the function aic7770_find_device() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-10 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-02 20:30 [PATCH] scsi: aic7xxx: aic7770: Remove unused function Rickard Strandqvist
2015-01-10 13:29 ` Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).