* [PATCH v2] ARM: dts: add bcm2835-pwm bindings
@ 2015-01-07 11:00 Bart Tanghe
2015-01-10 16:34 ` Stephen Warren
0 siblings, 1 reply; 2+ messages in thread
From: Bart Tanghe @ 2015-01-07 11:00 UTC (permalink / raw)
To: swarren, lee
Cc: thierry.reding, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, devicetree, linux-arm-kernel,
linux-rpi-kernel, linux-kernel, Bart Tanghe
To probe the bcm2835-pwm driver properly, this dts bindings has to be added
to the bcm2835 dtsi file.
In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
---
Changes in v2:
- status set to disabled
- follow the clock naming convention
Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be>
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index 3342cb1..ba76bb4 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -146,6 +147,14 @@
interrupts = <1 9>;
};
+ pwm: pwm@7e20e000 {
+ compatible = "brcm,bcm2835-pwm";
+ reg = <0x7e20c000 0x28>;
+ clocks = <&clk_pwm>;
+ #pwm-cells = <2>;
+ status = "disabled";
+ };
+
arm-pmu {
compatible = "arm,arm1176-pmu";
};
@@ -179,5 +188,13 @@
clock-output-names = "spi";
clock-frequency = <250000000>;
};
+
+ clk_pwm: clock@3 {
+ compatible = "fixed-clock";
+ reg = <3>;
+ #clock-cells = <0>;
+ clock-output-names = "pwm";
+ clock-frequency = <9200000>;
+ };
};
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ARM: dts: add bcm2835-pwm bindings
2015-01-07 11:00 [PATCH v2] ARM: dts: add bcm2835-pwm bindings Bart Tanghe
@ 2015-01-10 16:34 ` Stephen Warren
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2015-01-10 16:34 UTC (permalink / raw)
To: Bart Tanghe, lee
Cc: thierry.reding, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, devicetree, linux-arm-kernel,
linux-rpi-kernel, linux-kernel
On 01/07/2015 04:00 AM, Bart Tanghe wrote:
> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
> to the bcm2835 dtsi file.
> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> + pwm: pwm@7e20e000 {
> + compatible = "brcm,bcm2835-pwm";
> + reg = <0x7e20c000 0x28>;
> + clocks = <&clk_pwm>;
> + #pwm-cells = <2>;
> + status = "disabled";
> + };
Can the nodes be kept sorted by reg value; I think this should be added
between the existing i2c@20205000 and sdhci@7e300000 nodes.
Aside from that,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-10 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-07 11:00 [PATCH v2] ARM: dts: add bcm2835-pwm bindings Bart Tanghe
2015-01-10 16:34 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).