* [PATCH] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used
@ 2015-01-28 22:35 Rickard Strandqvist
2015-01-29 15:24 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-28 22:35 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten
Cc: Rickard Strandqvist, Greg Kroah-Hartman, devel, linux-kernel
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
index 1b6324c..8882423 100644
--- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
+++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
@@ -115,10 +115,9 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
{
struct dyna_pci10xx_private *devpriv = dev->private;
int n;
- unsigned int chan, range;
- chan = CR_CHAN(insn->chanspec);
- range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
+ CR_CHAN(insn->chanspec);
+ range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
mutex_lock(&devpriv->mutex);
for (n = 0; n < insn->n; n++) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used
2015-01-28 22:35 [PATCH] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used Rickard Strandqvist
@ 2015-01-29 15:24 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-01-29 15:24 UTC (permalink / raw)
To: Rickard Strandqvist, H Hartley Sweeten
Cc: Greg Kroah-Hartman, devel, linux-kernel
On 28/01/15 22:35, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/dyna_pci10xx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> index 1b6324c..8882423 100644
> --- a/drivers/staging/comedi/drivers/dyna_pci10xx.c
> +++ b/drivers/staging/comedi/drivers/dyna_pci10xx.c
> @@ -115,10 +115,9 @@ static int dyna_pci10xx_insn_write_ao(struct comedi_device *dev,
> {
> struct dyna_pci10xx_private *devpriv = dev->private;
> int n;
> - unsigned int chan, range;
>
> - chan = CR_CHAN(insn->chanspec);
> - range = range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
> + CR_CHAN(insn->chanspec);
> + range_codes_pci1050_ai[CR_RANGE((insn->chanspec))];
Both those lines produce compiler warnings, are not needed, don't belong
here and should be removed. The AO subdevice has a single, fixed range.
>
> mutex_lock(&devpriv->mutex);
> for (n = 0; n < insn->n; n++) {
>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 22:35 [PATCH] staging: comedi: drivers: dyna_pci10xx: Removed variables that is never used Rickard Strandqvist
2015-01-29 15:24 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).