From: Baoquan He <bhe@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, x86@kernel.org,
vgoyal@redhat.com, keescook@chromium.org, ak@linux.intel.com,
ebiederm@xmission.com, kexec@lists.infradead.org,
whissi@whissi.de, kumagai-atsushi@mxc.nes.nec.co.jp,
hpa@zytor.com
Subject: Re: [resend Patch v3 2/2] export the kernel image size KERNEL_IMAGE_SIZE
Date: Mon, 02 Feb 2015 15:32:16 +0800 [thread overview]
Message-ID: <54CF2800.5070608@redhat.com> (raw)
In-Reply-To: <1412060896-1902-2-git-send-email-bhe@redhat.com>
Hi Thomas,
Could you please also merge this patch? Since you have merged this patch
"x86, boot: Skip relocs when load address unchanged [commit f285f4a21]",
and this issue was raised because it broke kexec/kdump, then I posted
these 2 patches. Without this patch makedumpfile will be broken when
enable kaslr and do the kdump.
Thanks
Baouqan
On 09/30/2014 03:08 PM, Baoquan He wrote:
> Now kaslr makes kernel image size changable, not the fixed size 512M.
> So KERNEL_IMAGE_SIZE need be exported to VMCOREINFO, otherwise makedumfile
> will crash.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Acked-by: Kees Cook <keescook@chromium.org>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> kernel/kexec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 2bee072..bd680d3 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -2003,6 +2003,9 @@ static int __init crash_save_vmcoreinfo_init(void)
> #endif
> VMCOREINFO_NUMBER(PG_head_mask);
> VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
> +#ifdef CONFIG_X86
> + VMCOREINFO_NUMBER(KERNEL_IMAGE_SIZE);
> +#endif
> #ifdef CONFIG_HUGETLBFS
> VMCOREINFO_SYMBOL(free_huge_page);
> #endif
>
next prev parent reply other threads:[~2015-02-02 7:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 7:08 [resend Patch v3 1/2] kaslr: check if kernel location is changed Baoquan He
2014-09-30 7:08 ` [resend Patch v3 2/2] export the kernel image size KERNEL_IMAGE_SIZE Baoquan He
2015-02-02 7:32 ` Baoquan He [this message]
2015-02-09 20:18 ` Kees Cook
2014-09-30 21:21 ` [resend Patch v3 1/2] kaslr: check if kernel location is changed H. Peter Anvin
2014-10-01 13:52 ` Vivek Goyal
2014-10-08 15:09 ` H. Peter Anvin
2014-10-08 19:27 ` Vivek Goyal
2014-10-11 3:14 ` Baoquan He
2014-10-11 10:34 ` H. Peter Anvin
2014-10-11 12:38 ` Baoquan He
2014-10-11 12:44 ` Baoquan He
2014-10-13 12:52 ` Vivek Goyal
2014-10-13 15:19 ` Vivek Goyal
2014-10-13 15:43 ` H. Peter Anvin
2014-10-13 17:22 ` Vivek Goyal
2014-10-14 12:49 ` Vivek Goyal
2014-10-15 3:37 ` Baoquan He
2014-10-15 20:22 ` Vivek Goyal
2014-10-15 20:32 ` H. Peter Anvin
2014-10-15 23:55 ` Baoquan He
2014-10-15 23:58 ` Baoquan He
2014-10-28 5:04 ` Baoquan He
2014-10-08 14:40 ` Baoquan He
2015-01-09 2:09 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF2800.5070608@redhat.com \
--to=bhe@redhat.com \
--cc=ak@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=whissi@whissi.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).