* [PATCH -next] sensors: fix build of pwm-fan.c when THERMAL=m
@ 2015-03-05 23:27 Randy Dunlap
2015-03-06 3:59 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2015-03-05 23:27 UTC (permalink / raw)
To: lm-sensors, LKML; +Cc: Kamil Debski, Guenter Roeck, Jean Delvare
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when CONFIG_THERMAL=m and SENSORS_PWM_FAN=y
by restricting SENSORS_PWM_FAN to 'm' when THERMAL=m.
drivers/built-in.o: In function `pwm_fan_remove':
pwm-fan.c:(.text+0x22ba58): undefined reference to `thermal_cooling_device_unregister'
drivers/built-in.o: In function `pwm_fan_probe':
pwm-fan.c:(.text+0x22bebb): undefined reference to `thermal_of_cooling_device_register'
pwm-fan.c:(.text+0x22bf11): undefined reference to `thermal_cdev_update'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kamil Debski <k.debski@samsung.com>
---
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20150305.orig/drivers/hwmon/Kconfig
+++ linux-next-20150305/drivers/hwmon/Kconfig
@@ -1174,6 +1174,7 @@ source drivers/hwmon/pmbus/Kconfig
config SENSORS_PWM_FAN
tristate "PWM fan"
depends on (PWM && OF) || COMPILE_TEST
+ depends on THERMAL || THERMAL=n
help
If you say yes here you get support for fans connected to PWM lines.
The driver uses the generic PWM interface, thus it will work on a
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] sensors: fix build of pwm-fan.c when THERMAL=m
2015-03-05 23:27 [PATCH -next] sensors: fix build of pwm-fan.c when THERMAL=m Randy Dunlap
@ 2015-03-06 3:59 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-03-06 3:59 UTC (permalink / raw)
To: Randy Dunlap, lm-sensors, LKML; +Cc: Kamil Debski, Jean Delvare
On 03/05/2015 03:27 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_THERMAL=m and SENSORS_PWM_FAN=y
> by restricting SENSORS_PWM_FAN to 'm' when THERMAL=m.
>
> drivers/built-in.o: In function `pwm_fan_remove':
> pwm-fan.c:(.text+0x22ba58): undefined reference to `thermal_cooling_device_unregister'
> drivers/built-in.o: In function `pwm_fan_probe':
> pwm-fan.c:(.text+0x22bebb): undefined reference to `thermal_of_cooling_device_register'
> pwm-fan.c:(.text+0x22bf11): undefined reference to `thermal_cdev_update'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kamil Debski <k.debski@samsung.com>
> ---
Applied, thanks.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-06 3:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 23:27 [PATCH -next] sensors: fix build of pwm-fan.c when THERMAL=m Randy Dunlap
2015-03-06 3:59 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).