From: Shuah Khan <shuahkh@osg.samsung.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
mmarek@suse.cz, linux-api@vger.kernel.org
Subject: Re: [PATCH v3 6/7] selftests/mqueue: Use implicit rules
Date: Mon, 09 Mar 2015 17:37:40 -0600 [thread overview]
Message-ID: <54FE2EC4.2050901@osg.samsung.com> (raw)
In-Reply-To: <1425465694-27095-6-git-send-email-mpe@ellerman.id.au>
On 03/04/2015 03:41 AM, Michael Ellerman wrote:
> There's no need to open-code the build rules, use the implicit ones.
>
> This has the nice side effect of enabling cross compilation.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/mqueue/Makefile | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
> index 6ca7261b55dc..ed85a1d7ee36 100644
> --- a/tools/testing/selftests/mqueue/Makefile
> +++ b/tools/testing/selftests/mqueue/Makefile
> @@ -1,6 +1,11 @@
> -all:
> - gcc -O2 mq_open_tests.c -o mq_open_tests -lrt
> - gcc -O2 -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt
Nack. I can't take this one either. This breaks make kselftest
run. mqueue fails to build.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-03-09 23:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 10:41 [PATCH v3 1/7] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-03-04 10:41 ` [PATCH v3 2/7] selftests: Add install target Michael Ellerman
2015-03-04 10:41 ` [PATCH v3 3/7] selftests: Add install support for the powerpc tests Michael Ellerman
2015-03-04 10:41 ` [PATCH v3 4/7] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-03-04 10:41 ` [PATCH v3 5/7] selftests/timers: Use implicit rules Michael Ellerman
2015-03-09 23:17 ` Shuah Khan
2015-03-04 10:41 ` [PATCH v3 6/7] selftests/mqueue: " Michael Ellerman
2015-03-09 23:37 ` Shuah Khan [this message]
2015-03-04 10:41 ` [PATCH v3 7/7] selftests/mount: " Michael Ellerman
2015-03-09 23:41 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FE2EC4.2050901@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).