Re: [PATCH V8 04/10] USB: f81232: implement read IIR/MSR with endpoint

From: Peter Hung <hpeter@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw,
	peter_hong@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V8 04/10] USB: f81232: implement read IIR/MSR with endpoint
Date: Mon, 16 Mar 2015 17:18:11 +0800	[thread overview]
Message-ID: <55069FD3.2080807@gmail.com> (raw)
In-Reply-To: <20150316085501.GB14918@localhost>

Hello,

Johan Hovold 於 2015/3/16 下午 04:55 寫道:
> On Mon, Mar 16, 2015 at 11:08:29AM +0800, Peter Hung wrote:
>>> Could you rewrite this as
>>>
>>> 	if (status < 0)
>>> 		status = usb_translate_errors(status);
>>> 	else
>>> 		status = 0;
>>
>> In my definition the return value of set/getregister(), 0 is success,
>> negative values are errors. The function usb_control_msg() return value
>> is success transmited/received byte. It's maybe return 0. I want to
>> treat 0 with error(-EIO). But if pass 0 to usb_translate_errors(), It
>> will return 0 back. So I need especially handle with status == 0.
>
> I meant to write
>
> 	if (status < 0)
>   		status = usb_translate_errors(status);
> 	else
> 		status = -EIO;
>
> which I think is more readable.

It's looks more readable of the style that you mentioned.
Thanks for your advice, I'll add it with next patch.

-- 
With Best Regards,
Peter Hung