Re: [PATCH v5 2/3] dt-bindings: thermal: add loongson2k thermal binding

From: Yinbo Zhu <zhuyinbo@loongson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: zhanghongchen <zhanghongchen@loongson.cn>,
	Liu Peibao <liupeibao@loongson.cn>,
	zhuyinbo@loongson.cn
Subject: Re: [PATCH v5 2/3] dt-bindings: thermal: add loongson2k thermal binding
Date: Thu, 29 Sep 2022 18:00:35 +0800	[thread overview]
Message-ID: <550a852b-0ee4-8179-48a2-6cb11a3dd800@loongson.cn> (raw)
In-Reply-To: <06fa0bd2-c447-d705-01be-791207a4be8a@linaro.org>

在 2022/9/29 下午5:04, Krzysztof Kozlowski 写道:
> On 29/09/2022 10:23, Yinbo Zhu wrote:
>>
>>
>> 在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道:
>>> On 29/09/2022 09:07, Yinbo Zhu wrote:
>>>>>>>>
>>>>>>>> ... and please test your patches before sending :(
>>>>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ?
>>>>>> Need fix that warning, right?
>>>>>
>>>>> Yes. You said you tested it but then sent with an error... so it's not
>>>>> really a testing.
>>>> sorry, I did do some testing. but I think It is okay that can generate a
>>>> dtb  without reporting an error when compile yaml file, in fact, I
>>>> ignore the warning,  I will fix it in v6.
>>>
>>>
>>> Do you also send the code with warnings reported by GCC? Judging by
>>> number of kernel test robot reports, it could be. So just to be very,
>>> very clear: do not send any code which generates any warning. For GCC
>>> this means W=1 builds.
>> I don't find about the warning about GCC when compile yaml file.
>> and I dont't know the meaning about W=1, you said about "W=1" is to execute
>> following command to compile the yaml, right?
> 
> GCC is about your C code. You were sending patches knowing that they
> have warnings. It's not good. All warnings must be fixed.
what you said about C code warning whether is follows ? If is it, and I 
had add a static for loongson2_thermal_remove in v3 version code, I
think it shoud be fixed  about the warning.
 >> drivers/thermal/loongson2_thermal.c:183:5: warning: no previous 
prototype for function 'loongson2_thermal_remove' [-Wmissing-prototypes]
    int loongson2_thermal_remove(struct platform_device *pdev)
        ^
    drivers/thermal/loongson2_thermal.c:183:1: note: declare 'static' if 
the function is not intended to be used outside of this translation unit
    int loongson2_thermal_remove(struct platform_device *pdev)
    ^
    static
    1 warning generated.

If you said about C code warning isn't about about 
"loongson2_thermal_remove" and I may be loss a mail about that C code 
warning, Could you foward a mail about that C code warning. because I 
don't find any C code warning when compile C code.

About the C code warning, it was base on v6 code?

TKs,
Yinbo Zhu.
> 
> Best regards,
> Krzysztof
> 