From: Yinbo Zhu <zhuyinbo@loongson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: zhanghongchen <zhanghongchen@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>,
zhuyinbo@loongson.cn
Subject: Re: [PATCH v5 2/3] dt-bindings: thermal: add loongson2k thermal binding
Date: Thu, 29 Sep 2022 16:23:46 +0800 [thread overview]
Message-ID: <a205592c-9e5b-0cf2-88d7-aabe0bdcc2ae@loongson.cn> (raw)
In-Reply-To: <f54a40ea-99bf-e341-3bbd-851b250cc9cd@linaro.org>
在 2022/9/29 下午3:45, Krzysztof Kozlowski 写道:
> On 29/09/2022 09:07, Yinbo Zhu wrote:
>>>>>>
>>>>>> ... and please test your patches before sending :(
>>>> You said is refer that "reg: [[0, 534779136], [0, 48]] is too long" ?
>>>> Need fix that warning, right?
>>>
>>> Yes. You said you tested it but then sent with an error... so it's not
>>> really a testing.
>> sorry, I did do some testing. but I think It is okay that can generate a
>> dtb without reporting an error when compile yaml file, in fact, I
>> ignore the warning, I will fix it in v6.
>
>
> Do you also send the code with warnings reported by GCC? Judging by
> number of kernel test robot reports, it could be. So just to be very,
> very clear: do not send any code which generates any warning. For GCC
> this means W=1 builds.
I don't find about the warning about GCC when compile yaml file.
and I dont't know the meaning about W=1, you said about "W=1" is to execute
following command to compile the yaml, right?
root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m
dt_binding_check W=1
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml
I compile it use v6 patch that compile result as follows:
root@m-pc:/home/m/workspace/test/code/upstream# make DT_CHECKER_FLAGS=-m
dt_binding_check W=1
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml
DTC
Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb
CHECK
Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.example.dtb
In addtion, if you said was about loongson2_thermal.c, this code has no
warning that I had check.
BRs,
Yinbo Zhu.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-09-29 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 8:37 [PATCH v5 1/3] MAINTAINERS: add maintainer for thermal driver for loongson2 SoCs Yinbo Zhu
2022-09-28 8:37 ` [PATCH v5 2/3] dt-bindings: thermal: add loongson2k thermal binding Yinbo Zhu
2022-09-28 8:37 ` Krzysztof Kozlowski
2022-09-28 14:18 ` Krzysztof Kozlowski
2022-09-29 3:42 ` Yinbo Zhu
2022-09-29 3:57 ` Yinbo Zhu
2022-09-29 7:00 ` Krzysztof Kozlowski
2022-09-29 7:07 ` Yinbo Zhu
2022-09-29 7:45 ` Krzysztof Kozlowski
2022-09-29 8:23 ` Yinbo Zhu [this message]
2022-09-29 9:04 ` Krzysztof Kozlowski
2022-09-29 10:00 ` Yinbo Zhu
2022-09-30 1:39 ` Yinbo Zhu
2022-09-28 12:38 ` Rob Herring
2022-09-28 8:37 ` [PATCH v5 3/3] thermal: loongson2: add thermal management support Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a205592c-9e5b-0cf2-88d7-aabe0bdcc2ae@loongson.cn \
--to=zhuyinbo@loongson.cn \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=zhanghongchen@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).