* [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS
@ 2020-01-21 15:18 Andy Shevchenko
2020-01-22 2:06 ` Alex Shi
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2020-01-21 15:18 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: Andy Shevchenko, Alex Shi
The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
introduced some new test cases to the test_bitmap.c module. Among these
it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.
Reported-by: Alex Shi <alex.shi@linux.alibaba.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/test_bitmap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 61ed71c1daba..6b13150667f5 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -278,6 +278,8 @@ static void __init test_replace(void)
unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
DECLARE_BITMAP(bmap, 1024);
+ BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
+
bitmap_zero(bmap, 1024);
bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
expect_eq_bitmap(bmap, exp3_0_1, nbits);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS
2020-01-21 15:18 [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS Andy Shevchenko
@ 2020-01-22 2:06 ` Alex Shi
0 siblings, 0 replies; 2+ messages in thread
From: Alex Shi @ 2020-01-22 2:06 UTC (permalink / raw)
To: Andy Shevchenko, Andrew Morton, linux-kernel
在 2020/1/21 下午11:18, Andy Shevchenko 写道:
> The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
> introduced some new test cases to the test_bitmap.c module. Among these
> it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.
>
> Reported-by: Alex Shi <alex.shi@linux.alibaba.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> lib/test_bitmap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 61ed71c1daba..6b13150667f5 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -278,6 +278,8 @@ static void __init test_replace(void)
> unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
> DECLARE_BITMAP(bmap, 1024);
>
> + BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
> +
> bitmap_zero(bmap, 1024);
> bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
> expect_eq_bitmap(bmap, exp3_0_1, nbits);
>
It looks nice. :)
Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 15:18 [PATCH v1] lib/test_bitmap: Make use of EXP2_IN_BITS Andy Shevchenko
2020-01-22 2:06 ` Alex Shi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).