From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: kishon@ti.com, swarren@wwwdotorg.org, thierry.reding@gmail.com,
gnurou@gmail.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] phy: add missing header dependencies
Date: Wed, 31 Aug 2016 12:00:01 +0200 [thread overview]
Message-ID: <5510665.v78tdpezgV@wuerfel> (raw)
In-Reply-To: <1472633809-19904-1-git-send-email-baoyou.xie@linaro.org>
On Wednesday, August 31, 2016 4:56:49 PM CEST Baoyou Xie wrote:
> We get 5 warnings when building kernel with W=1:
> drivers/phy/tegra/xusb.c:948:27: warning: no previous prototype for 'tegra_xusb_padctl_get' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:981:6: warning: no previous prototype for 'tegra_xusb_padctl_put' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:988:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_save_context' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:998:5: warning: no previous prototype for 'tegra_xusb_padctl_hsic_set_idle' [-Wmissing-prototypes]
> drivers/phy/tegra/xusb.c:1008:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_set_lfps_detect' [-Wmissing-prototypes]
>
> In fact, these functions are declared in linux/phy/tegra/xusb.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Patch looks good
Acked-by: Arnd Bergmann <arnd@arndb.de>
In the subject line, this time being more specific is better (there
are many distinct phy drivers), so use "phy: tegra: ..." here.
Arnd
next prev parent reply other threads:[~2016-08-31 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 8:56 [PATCH] phy: add missing header dependencies Baoyou Xie
2016-08-31 10:00 ` Arnd Bergmann [this message]
2016-09-01 11:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5510665.v78tdpezgV@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=gnurou@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).