Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes - Lars-Peter Clausen

From: Lars-Peter Clausen <lars@metafoo.de>
To: sathyanarayanan.kuppuswamy@linux.intel.com,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Robert Dolca <robert.dolca@gmail.com>,
	Robert Dolca <robert.dolca@intel.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Denis CIOCCA <denis.ciocca@st.com>
Subject: Re: [PATCH] IIO: Adds ACPI support for ST gyroscopes
Date: Wed, 25 Mar 2015 19:08:55 +0100	[thread overview]
Message-ID: <5512F9B7.2030101@metafoo.de> (raw)
In-Reply-To: <5512F8EA.2040506@linux.intel.com>

On 03/25/2015 07:05 PM, sathyanarayanan kuppuswamy wrote:
>>   static acpi_status
>>   acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
>>                   u32 bits, u64 *value, void *handler_context,
>> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
>> index edf274cabe81..c12a3f24ada4 100644
>> --- a/drivers/i2c/i2c-core.c
>> +++ b/drivers/i2c/i2c-core.c
>> @@ -629,8 +629,13 @@ static int i2c_device_probe(struct device *dev)
>>       if (!client)
>>           return 0;
>> -    if (!client->irq && dev->of_node) {
>> -        int irq = of_irq_get(dev->of_node, 0);
>> +    if (client->irq <= 0) {
> Isn't irq 0 a valid interrupt number ? Shouldn't it be client->irq < 0 ?

0 is a invalid interrupt number these days, and is typically used to 
indicate no IRQ.