* [PATCH] ftracetest: replace usleep by sleep
@ 2015-03-25 17:36 Luis Henriques
2015-03-25 18:57 ` Steven Rostedt
0 siblings, 1 reply; 7+ messages in thread
From: Luis Henriques @ 2015-03-25 17:36 UTC (permalink / raw)
To: Shuah Khan; +Cc: Namhyung Kim, Steven Rostedt, linux-kernel
'usleep' seems to be a distro-specific utility and may not be
available:
[5] event tracing - enable/disable with event level files [FAIL]
execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
+ . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
+ [ ! -f set_event -o ! -d events/sched ]
+ reset_tracer
+ echo nop
+ do_reset
+ echo
+ clear_trace
+ echo
+ echo sched:sched_switch
+ usleep 1
./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
Replace it with the more standard sleep.
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++---
tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
index 668616d9bb03..abafc0c3605c 100644
--- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
@@ -21,7 +21,7 @@ reset_tracer
do_reset
echo 'sched:sched_switch' > set_event
-usleep 1
+sleep 0.001
count=`cat trace | grep sched_switch | wc -l`
if [ $count -eq 0 ]; then
@@ -31,7 +31,7 @@ fi
do_reset
echo 1 > events/sched/sched_switch/enable
-usleep 1
+sleep 0.001
count=`cat trace | grep sched_switch | wc -l`
if [ $count -eq 0 ]; then
@@ -41,7 +41,7 @@ fi
do_reset
echo 0 > events/sched/sched_switch/enable
-usleep 1
+sleep 0.001
count=`cat trace | grep sched_switch | wc -l`
if [ $count -ne 0 ]; then
diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
index 655c415b6e7f..d1e0f5b770c3 100644
--- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
@@ -21,7 +21,7 @@ reset_tracer
do_reset
echo 'sched:*' > set_event
-usleep 1
+sleep 0.001
count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
if [ $count -lt 3 ]; then
@@ -31,7 +31,7 @@ fi
do_reset
echo 1 > events/sched/enable
-usleep 1
+sleep 0.001
count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
if [ $count -lt 3 ]; then
@@ -41,7 +41,7 @@ fi
do_reset
echo 0 > events/sched/enable
-usleep 1
+sleep 0.001
count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l`
if [ $count -ne 0 ]; then
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ftracetest: replace usleep by sleep
2015-03-25 17:36 [PATCH] ftracetest: replace usleep by sleep Luis Henriques
@ 2015-03-25 18:57 ` Steven Rostedt
2015-03-25 19:02 ` Luis Henriques
2015-03-26 2:50 ` Pádraig Brady
0 siblings, 2 replies; 7+ messages in thread
From: Steven Rostedt @ 2015-03-25 18:57 UTC (permalink / raw)
To: Luis Henriques; +Cc: Shuah Khan, Namhyung Kim, linux-kernel, Masami Hiramatsu
On Wed, 25 Mar 2015 17:36:34 +0000
Luis Henriques <luis.henriques@canonical.com> wrote:
> 'usleep' seems to be a distro-specific utility and may not be
> available:
>
> [5] event tracing - enable/disable with event level files [FAIL]
> execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> + [ ! -f set_event -o ! -d events/sched ]
> + reset_tracer
> + echo nop
> + do_reset
> + echo
> + clear_trace
> + echo
> + echo sched:sched_switch
> + usleep 1
> ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
>
> Replace it with the more standard sleep.
>
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++---
> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> index 668616d9bb03..abafc0c3605c 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> @@ -21,7 +21,7 @@ reset_tracer
> do_reset
>
> echo 'sched:sched_switch' > set_event
> -usleep 1
> +sleep 0.001
We had patches out about this, because sleep 0.001 is not always
supported either.
I forgot what the final solution was suppose to be.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ftracetest: replace usleep by sleep
2015-03-25 18:57 ` Steven Rostedt
@ 2015-03-25 19:02 ` Luis Henriques
2015-03-25 19:51 ` Steven Rostedt
2015-03-26 2:50 ` Pádraig Brady
1 sibling, 1 reply; 7+ messages in thread
From: Luis Henriques @ 2015-03-25 19:02 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Shuah Khan, Namhyung Kim, linux-kernel, Masami Hiramatsu
On Wed, Mar 25, 2015 at 02:57:58PM -0400, Steven Rostedt wrote:
> On Wed, 25 Mar 2015 17:36:34 +0000
> Luis Henriques <luis.henriques@canonical.com> wrote:
>
> > 'usleep' seems to be a distro-specific utility and may not be
> > available:
> >
> > [5] event tracing - enable/disable with event level files [FAIL]
> > execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > + [ ! -f set_event -o ! -d events/sched ]
> > + reset_tracer
> > + echo nop
> > + do_reset
> > + echo
> > + clear_trace
> > + echo
> > + echo sched:sched_switch
> > + usleep 1
> > ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
> >
> > Replace it with the more standard sleep.
> >
> > Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> > ---
> > tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++---
> > tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > index 668616d9bb03..abafc0c3605c 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > @@ -21,7 +21,7 @@ reset_tracer
> > do_reset
> >
> > echo 'sched:sched_switch' > set_event
> > -usleep 1
> > +sleep 0.001
>
> We had patches out about this, because sleep 0.001 is not always
> supported either.
>
> I forgot what the final solution was suppose to be.
>
> -- Steve
Would a 'sleep 1' be acceptable? Do we care about the execution time?
Cheers,
--
Luís
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ftracetest: replace usleep by sleep
2015-03-25 19:02 ` Luis Henriques
@ 2015-03-25 19:51 ` Steven Rostedt
2015-03-26 0:10 ` Namhyung Kim
0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2015-03-25 19:51 UTC (permalink / raw)
To: Luis Henriques; +Cc: Shuah Khan, Namhyung Kim, linux-kernel, Masami Hiramatsu
On Wed, 25 Mar 2015 19:02:41 +0000
Luis Henriques <luis.henriques@canonical.com> wrote:
> Would a 'sleep 1' be acceptable? Do we care about the execution time?
Yes we do. Thus we are thinking of doing some other command, or perhaps
nothing at all. But I think that's where we ended.
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ftracetest: replace usleep by sleep
2015-03-25 19:51 ` Steven Rostedt
@ 2015-03-26 0:10 ` Namhyung Kim
0 siblings, 0 replies; 7+ messages in thread
From: Namhyung Kim @ 2015-03-26 0:10 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Luis Henriques, Shuah Khan, linux-kernel, Masami Hiramatsu
Hi Steve,
On Wed, Mar 25, 2015 at 03:51:19PM -0400, Steven Rostedt wrote:
> On Wed, 25 Mar 2015 19:02:41 +0000
> Luis Henriques <luis.henriques@canonical.com> wrote:
>
>
> > Would a 'sleep 1' be acceptable? Do we care about the execution time?
>
> Yes we do. Thus we are thinking of doing some other command, or perhaps
> nothing at all. But I think that's where we ended.
Right. I also forgot about the patch, sorry.
So what we really need is an (sched) event, and 'cat trace' itself
will generate one before reading the trace buffer.
I'll resend the patch soon.
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ftracetest: replace usleep by sleep
2015-03-25 18:57 ` Steven Rostedt
2015-03-25 19:02 ` Luis Henriques
@ 2015-03-26 2:50 ` Pádraig Brady
2015-03-26 13:42 ` Steven Rostedt
1 sibling, 1 reply; 7+ messages in thread
From: Pádraig Brady @ 2015-03-26 2:50 UTC (permalink / raw)
To: Steven Rostedt, Luis Henriques
Cc: Shuah Khan, Namhyung Kim, linux-kernel, Masami Hiramatsu
On 25/03/15 18:57, Steven Rostedt wrote:
> On Wed, 25 Mar 2015 17:36:34 +0000
> Luis Henriques <luis.henriques@canonical.com> wrote:
>
>> 'usleep' seems to be a distro-specific utility and may not be
>> available:
>>
>> [5] event tracing - enable/disable with event level files [FAIL]
>> execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> + [ ! -f set_event -o ! -d events/sched ]
>> + reset_tracer
>> + echo nop
>> + do_reset
>> + echo
>> + clear_trace
>> + echo
>> + echo sched:sched_switch
>> + usleep 1
>> ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
>>
>> Replace it with the more standard sleep.
>>
>> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
>> ---
>> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 6 +++---
>> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> index 668616d9bb03..abafc0c3605c 100644
>> --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
>> @@ -21,7 +21,7 @@ reset_tracer
>> do_reset
>>
>> echo 'sched:sched_switch' > set_event
>> -usleep 1
>> +sleep 0.001
>
> We had patches out about this, because sleep 0.001 is not always
> supported either.
really?
In that edge case you might:
sleep .001 || sleep 1
Pádraig.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ftracetest: replace usleep by sleep
2015-03-26 2:50 ` Pádraig Brady
@ 2015-03-26 13:42 ` Steven Rostedt
0 siblings, 0 replies; 7+ messages in thread
From: Steven Rostedt @ 2015-03-26 13:42 UTC (permalink / raw)
To: Pádraig Brady
Cc: Luis Henriques, Shuah Khan, Namhyung Kim, linux-kernel, Masami Hiramatsu
On Thu, 26 Mar 2015 02:50:50 +0000
Pádraig Brady <P@draigBrady.com> wrote:
> >> echo 'sched:sched_switch' > set_event
> >> -usleep 1
> >> +sleep 0.001
> >
> > We had patches out about this, because sleep 0.001 is not always
> > supported either.
>
> really?
> In that edge case you might:
It's not too much of an edge case, as it is busybox that has issue.
-- Steve
>
> sleep .001 || sleep 1
>
> Pádraig.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-26 13:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 17:36 [PATCH] ftracetest: replace usleep by sleep Luis Henriques
2015-03-25 18:57 ` Steven Rostedt
2015-03-25 19:02 ` Luis Henriques
2015-03-25 19:51 ` Steven Rostedt
2015-03-26 0:10 ` Namhyung Kim
2015-03-26 2:50 ` Pádraig Brady
2015-03-26 13:42 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).