From: Chanwoo Choi <cw00.choi@samsung.com>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: myungjoo.ham@samsung.com, rogerq@ti.com,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection
Date: Thu, 09 Apr 2015 11:12:34 +0900 [thread overview]
Message-ID: <5525E012.5050207@samsung.com> (raw)
In-Reply-To: <1427980385-21285-3-git-send-email-r.baldyga@samsung.com>
Hi Robert,
On 04/02/2015 10:13 PM, Robert Baldyga wrote:
> This patch adds VBUS pin detection support to extcon-usb-gpio driver.
> It allows to use this driver with boards which have both VBUS and ID
> pins, or only one of them.
>
> Following table of states presents relationship between this signals
> and detected cable type:
>
> State | ID | VBUS
> ----------------------------------------
> [1] USB | H | H
> [2] none | H | L
> [3] USB & USB-HOST | L | H
> [4] USB-HOST | L | L
>
> In case we have only one of these signals:
> - VBUS only - we want to distinguish between [1] and [2], so ID is always 1.
> - ID only - we want to distinguish between [1] and [4], so VBUS = ID.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
> drivers/extcon/extcon-usb-gpio.c | 169 +++++++++++++++++++++++++++------------
> 1 file changed, 119 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f6aa99d..baf7add 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -32,7 +32,9 @@ struct usb_extcon_info {
> struct extcon_dev *edev;
>
> struct gpio_desc *id_gpiod;
> + struct gpio_desc *vbus_gpiod;
> int id_irq;
> + int vbus_irq;
>
> unsigned long debounce_jiffies;
> struct delayed_work wq_detcable;
> @@ -52,40 +54,51 @@ static const char *usb_extcon_cable[] = {
> NULL,
> };
>
> +/*
> + * "USB" = VBUS and "USB-HOST" = !ID, so we have:
> + *
> + * State | ID | VBUS
> + * ----------------------------------------
> + * [1] USB | H | H
> + * [2] none | H | L
> + * [3] USB & USB-HOST | L | H
> + * [4] USB-HOST | L | L
> + *
> + * In case we have only one of these signals:
> + * - VBUS only - we want to distinguish between [1] and [2], so ID is always 1.
> + * - ID only - we want to distinguish between [1] and [4], so VBUS = ID.
> + */
> +
> static void usb_extcon_detect_cable(struct work_struct *work)
> {
> int id;
> + int vbus;
> struct usb_extcon_info *info = container_of(to_delayed_work(work),
> struct usb_extcon_info,
> wq_detcable);
>
> - /* check ID and update cable state */
> - id = gpiod_get_value_cansleep(info->id_gpiod);
> - if (id) {
> - /*
> - * ID = 1 means USB HOST cable detached.
> - * As we don't have event for USB peripheral cable attached,
> - * we simulate USB peripheral attach here.
> - */
> + /* check ID and VBUS and update cable state */
> +
> + id = info->id_gpiod ?
> + gpiod_get_value_cansleep(info->id_gpiod) : 1;
> +
> + vbus = info->vbus_gpiod ?
> + gpiod_get_value_cansleep(info->vbus_gpiod) : id;
> +
> + /* at first we clean states which are no longer active */
> + if (id)
> extcon_set_cable_state(info->edev,
> - usb_extcon_cable[EXTCON_CABLE_USB_HOST],
> - false);
> + usb_extcon_cable[EXTCON_CABLE_USB_HOST], false);
> + if (!vbus)
> extcon_set_cable_state(info->edev,
> - usb_extcon_cable[EXTCON_CABLE_USB],
> - true);
> - } else {
> - /*
> - * ID = 0 means USB HOST cable attached.
> - * As we don't have event for USB peripheral cable detached,
> - * we simulate USB peripheral detach here.
> - */
> + usb_extcon_cable[EXTCON_CABLE_USB], false);
> +
> + if (!id)
> extcon_set_cable_state(info->edev,
> - usb_extcon_cable[EXTCON_CABLE_USB],
> - false);
> + usb_extcon_cable[EXTCON_CABLE_USB_HOST], true);
> + if (vbus)
> extcon_set_cable_state(info->edev,
> - usb_extcon_cable[EXTCON_CABLE_USB_HOST],
> - true);
> - }
> + usb_extcon_cable[EXTCON_CABLE_USB], true);
> }
Looks good to me of this patch.
But, I have one question about case[3]
If id is low and vbus is high, this patch will update the state of both USB and USB-HOST cable as attached state.
Is it possible that two different cables (both USB and USB-HOST) are connected to one port simultaneously?
> + * "USB" = VBUS and "USB-HOST" = !ID, so we have:
> + *
> + * State | ID | VBUS
> + * ----------------------------------------
> + * [1] USB | H | H
> + * [2] none | H | L
> + * [3] USB & USB-HOST | L | H
> + * [4] USB-HOST | L | L
> + *
[snip]
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-04-09 2:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 13:13 [PATCH v3 0/4] extcon: usb-gpio: fixes and improvements Robert Baldyga
2015-04-02 13:13 ` [PATCH v3 1/4] extcon: usb-gpio: register extcon device before IRQ registration Robert Baldyga
2015-04-03 0:09 ` Chanwoo Choi
2015-04-02 13:13 ` [PATCH v3 2/4] extcon: usb-gpio: add support for VBUS detection Robert Baldyga
2015-04-02 14:02 ` Roger Quadros
2015-04-09 2:12 ` Chanwoo Choi [this message]
2015-04-09 7:57 ` Robert Baldyga
2015-04-09 9:07 ` Chanwoo Choi
2015-04-09 9:24 ` Robert Baldyga
2015-04-09 9:59 ` Roger Quadros
2015-04-09 10:18 ` Robert Baldyga
2015-04-10 7:39 ` Chanwoo Choi
2015-04-10 7:17 ` Chanwoo Choi
2015-04-10 7:45 ` Robert Baldyga
2015-04-10 8:10 ` Chanwoo Choi
2015-04-10 8:46 ` Robert Baldyga
2015-04-10 9:18 ` Chanwoo Choi
2015-04-10 9:42 ` Robert Baldyga
2015-04-14 10:01 ` Roger Quadros
2015-04-14 10:02 ` Roger Quadros
2015-04-14 10:31 ` Chanwoo Choi
2015-04-14 10:38 ` Roger Quadros
2015-04-14 11:29 ` Chanwoo Choi
2015-04-15 3:27 ` Peter Chen
2015-04-15 7:50 ` Roger Quadros
2015-04-15 9:26 ` Chanwoo Choi
2015-04-16 1:59 ` Peter Chen
2015-04-16 7:00 ` Chanwoo Choi
2015-04-16 7:13 ` Ivan T. Ivanov
2015-04-16 7:59 ` Chanwoo Choi
2015-04-16 8:01 ` Peter Chen
2015-04-16 8:26 ` Chanwoo Choi
2015-04-30 7:32 ` Roger Quadros
2015-04-30 7:55 ` Chanwoo Choi
2015-04-30 8:04 ` Roger Quadros
2015-04-16 7:59 ` Peter Chen
2015-04-16 7:16 ` Roger Quadros
2015-04-02 13:13 ` [PATCH v3 3/4] extcon: usb-gpio: make debounce value configurable in devicetree Robert Baldyga
2015-04-02 13:13 ` [PATCH v3 4/4] Documentation: extcon: usb-gpio: update usb-gpio binding description Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5525E012.5050207@samsung.com \
--to=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=r.baldyga@samsung.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).