Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

[Michael Wang <yun.wang@profitbricks.com>]

On 04/22/2015 06:45 PM, ira.weiny wrote:
> On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote:
>>
>> On 04/22/2015 07:40 AM, Jason Gunthorpe wrote:
>>> On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote:
>>>  
>>>> Introduce helper cap_ipoib() to help us check if the port of an
>>>> IB device support IP over Infiniband.
>>>
>>> I thought we were dropping this in favor of listing the actual
>>> features the ULP required unconditionally? One of my messages had the
>>> start of a list..
> 
> ???  I forget.  I was arguing that we should not have it.  But I thought others
> disagreed with me so it was left in.
> 
> V4 of this patch had no responses.
> 
> https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg24040.html
> 
> Jason, I can't find the email where you mentioned a list?

I don't see a list too :-P but agreed the ULP reform idea, the check should be

ipoib_init()
{
	if (device don't suport SA or IB CM or...)
		return error;
	...
}

So I'll put the reform to that series.

Regards,
Michael Wang

> 
> Ira
>