linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Devesh Sharma <Devesh.Sharma@Emulex.Com>
To: Michael Wang <yun.wang@profitbricks.com>,
	Roland Dreier <roland@kernel.org>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hal@dev.mellanox.co.il" <hal@dev.mellanox.co.il>
Cc: Tom Tucker <tom@opengridcomputing.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Eli Cohen <eli@mellanox.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	"Or Gerlitz" <ogerlitz@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	"Ira Weiny" <ira.weiny@intel.com>, Tom Talpey <tom@talpey.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Doug Ledford <dledford@redhat.com>
Subject: RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers
Date: Tue, 21 Apr 2015 05:41:20 +0000	[thread overview]
Message-ID: <EE7902D3F51F404C82415C4803930ACD5DC44113@CMEXMB1.ad.emulex.com> (raw)
In-Reply-To: <5534B8C9.506@profitbricks.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 7540 bytes --]

Hi Michael,

is there a specific git branch available to pull out all the patches?

-Regards
Devesh

> -----Original Message-----
> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
> owner@vger.kernel.org] On Behalf Of Michael Wang
> Sent: Monday, April 20, 2015 1:59 PM
> To: Roland Dreier; Sean Hefty; Hal Rosenstock; linux-rdma@vger.kernel.org;
> linux-kernel@vger.kernel.org; hal@dev.mellanox.co.il
> Cc: Tom Tucker; Steve Wise; Hoang-Nam Nguyen; Christoph Raisch; Mike
> Marciniszyn; Eli Cohen; Faisal Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran;
> Ira Weiny; Tom Talpey; Jason Gunthorpe; Doug Ledford; Michael Wang
> Subject: [PATCH v5 00/27] IB/Verbs: IB Management Helpers
> 
> 
> Since v4:
>   * Thanks for the comments from Hal, Sean, Tom, Or Gerlitz, Jason,
>     Roland, Ira and Steve :-) Please remind me if anything missed :-P
>   * Fix logical issue inside 3#, 14#
>   * Refine 3#, 4#, 5# with label 'free'
>   * Rework 10# to stop using port 1 when port already assigned
> 
> There are plenty of lengthy code to check the transport type of IB device, or the
> link layer type of it's port, but actually we are just speculating whether a
> particular management/feature is supported by the device/port.
> 
> Thus instead of inferring, we should have our own mechanism for IB
> management capability/protocol/feature checking, several proposals below.
> 
> This patch set will reform the method of getting transport type, we will now
> using query_transport() instead of inferring from transport and link layer
> respectively, also we defined the new transport type to make the concept more
> reasonable.
> 
> Mapping List:
> 		node-type	link-layer	old-transport	new-transport
> nes		RNIC		ETH		IWARP		IWARP
> amso1100	RNIC		ETH		IWARP		IWARP
> cxgb3   	RNIC		ETH		IWARP		IWARP
> cxgb4   	RNIC		ETH		IWARP		IWARP
> usnic   	USNIC_UDP	ETH		USNIC_UDP	USNIC_UDP
> ocrdma  	IB_CA		ETH		IB		IBOE
> mlx4    	IB_CA		IB/ETH		IB		IB/IBOE
> mlx5    	IB_CA		IB		IB		IB
> ehca    	IB_CA		IB		IB		IB
> ipath   	IB_CA		IB		IB		IB
> mthca   	IB_CA		IB		IB		IB
> qib     	IB_CA		IB		IB		IB
> 
> For example:
> 	if (transport == IB) && (link-layer == ETH) will now become:
> 	if (query_transport() == IBOE)
> 
> Thus we will be able to get rid of the respective transport and link-layer
> checking, and it will help us to add new protocol/Technology (like OPA) more
> easier, also with the introduced management helpers, IB management logical
> will be more clear and easier for extending.
> 
> Highlights:
>     The patch set covered a wide range of IB stuff, thus for those who are
>     familiar with the particular part, your suggestion would be invaluable ;-)
> 
>     Patch 1#~15# included all the logical reform, 16#~25# introduced the
>     management helpers, 26#~27# do clean up.
> 
>     Patches haven't been tested yet, we appreciate if any one who have these
>     HW willing to provide his Tested-by :-)
> 
>     Doug suggested the bitmask mechanism:
> 	https://www.mail-archive.com/linux-
> rdma@vger.kernel.org/msg23765.html
>     which could be the plan for future reforming, we prefer that to be another
>     series which focus on semantic and performance.
> 
>     This patch-set is somewhat 'bloated' now and it may be a good timing for
>     staging, I'd like to suggest we focus on improving existed helpers and push
>     all the further reforms into next series ;-)
> 
> Proposals:
>     Sean:
> 	https://www.mail-archive.com/linux-
> rdma@vger.kernel.org/msg23339.html
>     Doug:
> 	https://www.mail-archive.com/linux-
> rdma@vger.kernel.org/msg23418.html
> 	https://www.mail-archive.com/linux-
> rdma@vger.kernel.org/msg23765.html
>     Jason:
> 	https://www.mail-archive.com/linux-
> rdma@vger.kernel.org/msg23425.html
> 
> Michael Wang (27):
>     IB/Verbs: Implement new callback query_transport()
>     IB/Verbs: Implement raw management helpers
>     IB/Verbs: Reform IB-core mad/agent/user_mad
>     IB/Verbs: Reform IB-core cm
>     IB/Verbs: Reform IB-core sa_query
>     IB/Verbs: Reform IB-core multicast
>     IB/Verbs: Reform IB-ulp ipoib
>     IB/Verbs: Reform IB-ulp xprtrdma
>     IB/Verbs: Reform IB-core verbs/uverbs_cmd/sysfs
>     IB/Verbs: Reform cm related part in IB-core cma/ucm
>     IB/Verbs: Reform route related part in IB-core cma
>     IB/Verbs: Reform mcast related part in IB-core cma
>     IB/Verbs: Reserve legacy transport type in 'dev_addr'
>     IB/Verbs: Reform cma_acquire_dev()
>     IB/Verbs: Reform rest part in IB-core cma
>     IB/Verbs: Use management helper cap_ib_mad()
>     IB/Verbs: Use management helper cap_ib_smi()
>     IB/Verbs: Use management helper cap_ib_cm()
>     IB/Verbs: Use management helper cap_iw_cm()
>     IB/Verbs: Use management helper cap_ib_sa()
>     IB/Verbs: Use management helper cap_ib_mcast()
>     IB/Verbs: Use management helper cap_ipoib()
>     IB/Verbs: Use management helper cap_read_multi_sge()
>     IB/Verbs: Use management helper cap_af_ib()
>     IB/Verbs: Use management helper cap_eth_ah()
>     IB/Verbs: Clean up rdma_ib_or_iboe()
>     IB/Verbs: Cleanup rdma_node_get_transport()
> 
> ---
>  drivers/infiniband/core/agent.c              |    4
>  drivers/infiniband/core/cm.c                 |   26 +-
>  drivers/infiniband/core/cma.c                |  328 ++++++++++++---------------
>  drivers/infiniband/core/device.c             |    1
>  drivers/infiniband/core/mad.c                |   51 ++--
>  drivers/infiniband/core/multicast.c          |   18 -
>  drivers/infiniband/core/sa_query.c           |   41 +--
>  drivers/infiniband/core/sysfs.c              |    8
>  drivers/infiniband/core/ucm.c                |    5
>  drivers/infiniband/core/ucma.c               |   27 --
>  drivers/infiniband/core/user_mad.c           |   32 +-
>  drivers/infiniband/core/uverbs_cmd.c         |    6
>  drivers/infiniband/core/verbs.c              |   33 --
>  drivers/infiniband/hw/amso1100/c2_provider.c |    7
>  drivers/infiniband/hw/cxgb3/iwch_provider.c  |    7
>  drivers/infiniband/hw/cxgb4/provider.c       |    7
>  drivers/infiniband/hw/ehca/ehca_hca.c        |    6
>  drivers/infiniband/hw/ehca/ehca_iverbs.h     |    3
>  drivers/infiniband/hw/ehca/ehca_main.c       |    1
>  drivers/infiniband/hw/ipath/ipath_verbs.c    |    7
>  drivers/infiniband/hw/mlx4/main.c            |   10
>  drivers/infiniband/hw/mlx5/main.c            |    7
>  drivers/infiniband/hw/mthca/mthca_provider.c |    7
>  drivers/infiniband/hw/nes/nes_verbs.c        |    6
>  drivers/infiniband/hw/ocrdma/ocrdma_main.c   |    1
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c  |    6
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.h  |    3
>  drivers/infiniband/hw/qib/qib_verbs.c        |    7
>  drivers/infiniband/hw/usnic/usnic_ib_main.c  |    1
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.c |    6
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.h |    2
>  drivers/infiniband/ulp/ipoib/ipoib_main.c    |   17 -
>  include/rdma/ib_verbs.h                      |  204 +++++++++++++++-
>  net/sunrpc/xprtrdma/svc_rdma_recvfrom.c      |    6
>  net/sunrpc/xprtrdma/svc_rdma_transport.c     |   51 +---
>  35 files changed, 584 insertions(+), 368 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body
> of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  parent reply	other threads:[~2015-04-21  5:42 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  8:28 [PATCH v5 00/27] IB/Verbs: IB Management Helpers Michael Wang
2015-04-20  8:32 ` [PATCH v5 01/27] IB/Verbs: Implement new callback query_transport() Michael Wang
2015-04-22  0:04   ` ira.weiny
2015-04-22 15:02   ` Doug Ledford
2015-04-22 15:21     ` Devesh Sharma
2015-04-22 16:22       ` ira.weiny
2015-04-22 16:42       ` Doug Ledford
2015-04-23  7:13     ` Michael Wang
2015-04-20  8:32 ` [PATCH v5 02/27] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-22  0:05   ` ira.weiny
2015-04-20  8:33 ` [PATCH v5 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-22  0:05   ` ira.weiny
2015-04-20  8:33 ` [PATCH v5 04/27] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-20 17:04   ` Hal Rosenstock
2015-04-21  7:42     ` Michael Wang
2015-04-22  0:05   ` ira.weiny
2015-04-20  8:34 ` [PATCH v5 05/27] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-22  0:05   ` ira.weiny
2015-04-20  8:34 ` [PATCH v5 06/27] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-22  0:06   ` ira.weiny
2015-04-20  8:35 ` [PATCH v5 07/27] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-22  0:06   ` ira.weiny
2015-04-20  8:35 ` [PATCH v5 08/27] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-22  0:06   ` ira.weiny
2015-04-20  8:36 ` [PATCH v5 09/27] IB/Verbs: Reform IB-core verbs/uverbs_cmd/sysfs Michael Wang
2015-04-21 23:19   ` ira.weiny
2015-04-22  7:38     ` Michael Wang
2015-04-22 16:28       ` ira.weiny
2015-04-23  9:25         ` Michael Wang
2015-04-20  8:36 ` [PATCH v5 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-22  0:07   ` ira.weiny
2015-04-20  8:37 ` [PATCH v5 11/27] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-22  0:07   ` ira.weiny
2015-04-20  8:37 ` [PATCH v5 12/27] IB/Verbs: Reform mcast " Michael Wang
2015-04-22  0:07   ` ira.weiny
2015-04-20  8:38 ` [PATCH v5 13/27] IB/Verbs: Reserve legacy transport type in 'dev_addr' Michael Wang
2015-04-21  5:58   ` Devesh Sharma
2015-04-21  8:05     ` Michael Wang
2015-04-22  0:08   ` ira.weiny
2015-04-20  8:38 ` [PATCH v5 14/27] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-04-21  6:15   ` Devesh Sharma
2015-04-21  8:08     ` Michael Wang
2015-04-22  0:08   ` ira.weiny
2015-04-20  8:38 ` [PATCH v5 15/27] IB/Verbs: Reform rest part in IB-core cma Michael Wang
2015-04-22  0:08   ` ira.weiny
2015-04-20  8:39 ` [PATCH v5 16/27] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-22  0:09   ` ira.weiny
2015-04-20  8:39 ` [PATCH v5 17/27] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-22  0:09   ` ira.weiny
2015-04-20  8:40 ` [PATCH v5 18/27] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-22  0:09   ` ira.weiny
2015-04-20  8:40 ` [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-20 14:00   ` Steve Wise
2015-04-20 15:16     ` Michael Wang
2015-04-20 15:51       ` Tom Tucker
2015-04-20 16:19         ` Jason Gunthorpe
2015-04-20 16:39           ` Tom Tucker
2015-04-21  7:39         ` Michael Wang
2015-04-21 15:06           ` Tom Tucker
2015-04-22  0:10   ` ira.weiny
2015-04-20  8:40 ` [PATCH v5 20/27] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-22  0:10   ` ira.weiny
2015-04-20  8:41 ` [PATCH v5 21/27] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-22  0:10   ` ira.weiny
2015-04-20  8:41 ` [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib() Michael Wang
2015-04-22  0:11   ` ira.weiny
2015-04-22  5:40   ` Jason Gunthorpe
2015-04-22  8:49     ` Michael Wang
2015-04-22 16:45       ` ira.weiny
2015-04-22 16:54         ` Hefty, Sean
2015-04-23  9:31         ` Michael Wang
2015-04-22 17:24       ` Jason Gunthorpe
2015-04-23  7:53         ` Michael Wang
2015-04-20  8:42 ` [PATCH v5 23/27] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-22  0:11   ` ira.weiny
2015-04-20  8:42 ` [PATCH v5 24/27] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-22  0:11   ` ira.weiny
2015-04-20  8:43 ` [PATCH v5 25/27] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-04-22  0:11   ` ira.weiny
2015-04-20  8:43 ` [PATCH v5 26/27] IB/Verbs: Clean up rdma_ib_or_iboe() Michael Wang
2015-04-22  0:12   ` ira.weiny
2015-04-20  8:43 ` [PATCH v5 27/27] IB/Verbs: Cleanup rdma_node_get_transport() Michael Wang
2015-04-22  0:13   ` ira.weiny
2015-04-21  5:41 ` Devesh Sharma [this message]
2015-04-21  7:46   ` [PATCH v5 00/27] IB/Verbs: IB Management Helpers Michael Wang
2015-04-21 11:03     ` Devesh Sharma
2015-04-21 15:56       ` Michael Wang
2015-04-21 23:36 ` Liran Liss
2015-04-22  2:41   ` ira.weiny
2015-04-22  8:32     ` Michael Wang
     [not found]     ` <DB4PR05MB086335365371E756B789FE84B1EE0@DB4PR05MB0863.eurprd05.prod.outlook.com>
2015-04-22 16:40       ` Jason Gunthorpe
     [not found]         ` <DB4PR05MB08633B2B2E3BA32752EE8098B1EC0@DB4PR05MB0863.eurprd05.prod.outlook.com>
2015-04-24 16:42           ` Jason Gunthorpe
2015-04-27 19:10             ` ira.weiny
2015-04-22 16:40     ` Hefty, Sean
2015-04-24 14:49       ` Liran Liss
2015-04-22  8:30   ` Michael Wang
2015-04-22 16:16     ` Liran Liss
2015-04-23  7:33       ` Michael Wang
2015-04-24 14:44         ` Liran Liss
2015-04-24 15:07           ` Michael Wang
2015-04-27 19:22           ` ira.weiny
2015-04-22 14:59   ` Doug Ledford
2015-04-22 16:57     ` Jason Gunthorpe
2015-04-23  8:36       ` Michael Wang
2015-04-22 17:10     ` ira.weiny
2015-04-23  9:36       ` Michael Wang
     [not found]       ` <DB4PR05MB08630282DEFFFB181A525B67B1EC0@DB4PR05MB0863.eurprd05.prod.outlook.com>
2015-04-27 20:58         ` ira.weiny
2015-04-22 16:46   ` Dave Goodell (dgoodell)
2015-04-22  0:28 ` ira.weiny
2015-04-22  7:44   ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EE7902D3F51F404C82415C4803930ACD5DC44113@CMEXMB1.ad.emulex.com \
    --to=devesh.sharma@emulex.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=hnguyen@de.ibm.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    --cc=tom@talpey.com \
    --cc=yun.wang@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).