* [PATCH] rsxx: Replace zero-length array with flexible-array member
@ 2020-02-12 19:46 Gustavo A. R. Silva
2020-03-19 21:12 ` Gustavo A. R. Silva
2020-03-19 21:27 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2020-02-12 19:46 UTC (permalink / raw)
To: Joshua Morris, Philip Kelleher, Jens Axboe
Cc: linux-block, linux-kernel, Gustavo A. R. Silva
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/block/rsxx/dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c
index 111eb659e66d..1914f5488b22 100644
--- a/drivers/block/rsxx/dma.c
+++ b/drivers/block/rsxx/dma.c
@@ -80,7 +80,7 @@ struct dma_tracker {
struct dma_tracker_list {
spinlock_t lock;
int head;
- struct dma_tracker list[0];
+ struct dma_tracker list[];
};
--
2.25.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rsxx: Replace zero-length array with flexible-array member
2020-02-12 19:46 [PATCH] rsxx: Replace zero-length array with flexible-array member Gustavo A. R. Silva
@ 2020-03-19 21:12 ` Gustavo A. R. Silva
2020-03-19 21:27 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2020-03-19 21:12 UTC (permalink / raw)
To: Joshua Morris, Philip Kelleher, Jens Axboe; +Cc: linux-block, linux-kernel
Hi all,
Friendly ping: Who can take this?
Thanks
--
Gustavo
On 2/12/20 1:46 PM, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertenly introduced[3] to the codebase from now on.
>
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
>
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
>
> This issue was found with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/block/rsxx/dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c
> index 111eb659e66d..1914f5488b22 100644
> --- a/drivers/block/rsxx/dma.c
> +++ b/drivers/block/rsxx/dma.c
> @@ -80,7 +80,7 @@ struct dma_tracker {
> struct dma_tracker_list {
> spinlock_t lock;
> int head;
> - struct dma_tracker list[0];
> + struct dma_tracker list[];
> };
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rsxx: Replace zero-length array with flexible-array member
2020-02-12 19:46 [PATCH] rsxx: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-03-19 21:12 ` Gustavo A. R. Silva
@ 2020-03-19 21:27 ` Jens Axboe
2020-03-19 21:35 ` Gustavo A. R. Silva
1 sibling, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2020-03-19 21:27 UTC (permalink / raw)
To: Gustavo A. R. Silva, Joshua Morris, Philip Kelleher
Cc: linux-block, linux-kernel
On 2/12/20 12:46 PM, Gustavo A. R. Silva wrote:
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertenly introduced[3] to the codebase from now on.
>
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
>
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
>
> This issue was found with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Applied for 5.7, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rsxx: Replace zero-length array with flexible-array member
2020-03-19 21:27 ` Jens Axboe
@ 2020-03-19 21:35 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2020-03-19 21:35 UTC (permalink / raw)
To: Jens Axboe, Joshua Morris, Philip Kelleher; +Cc: linux-block, linux-kernel
On 3/19/20 4:27 PM, Jens Axboe wrote:
>>
>> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
>> [2] https://github.com/KSPP/linux/issues/21
>> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Applied for 5.7, thanks.
>
Thanks, Jens.
--
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-19 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 19:46 [PATCH] rsxx: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-03-19 21:12 ` Gustavo A. R. Silva
2020-03-19 21:27 ` Jens Axboe
2020-03-19 21:35 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).