[PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Alexandre Belloni]

Add the Atmel sama5d3 and sama5d4 and their peripherals to multi_v7_defconfig.

Note that the console will be ttyAT0 instead of the usual ttyS0.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/configs/multi_v7_defconfig | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index b7e6b6fba5e0..adab236c80db 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -18,6 +18,9 @@ CONFIG_MACH_ARMADA_375=y
 CONFIG_MACH_ARMADA_38X=y
 CONFIG_MACH_ARMADA_XP=y
 CONFIG_MACH_DOVE=y
+CONFIG_ARCH_AT91=y
+CONFIG_SOC_SAMA5D3=y
+CONFIG_SOC_SAMA5D4=y
 CONFIG_ARCH_BCM=y
 CONFIG_ARCH_BCM_CYGNUS=y
 CONFIG_ARCH_BCM_21664=y
@@ -131,6 +134,7 @@ CONFIG_CAN=y
 CONFIG_CAN_RAW=y
 CONFIG_CAN_BCM=y
 CONFIG_CAN_DEV=y
+CONFIG_CAN_AT91=m
 CONFIG_CAN_XILINXCAN=y
 CONFIG_CAN_MCP251X=y
 CONFIG_CFG80211=m
@@ -149,13 +153,16 @@ CONFIG_MTD_CMDLINE_PARTS=y
 CONFIG_MTD_BLOCK=y
 CONFIG_MTD_M25P80=y
 CONFIG_MTD_NAND=y
+CONFIG_MTD_NAND_ATMEL=y
 CONFIG_MTD_NAND_DAVINCI=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_AD525X_DPOT=y
 CONFIG_AD525X_DPOT_I2C=y
+CONFIG_ATMEL_TCLIB=y
 CONFIG_ICS932S401=y
+CONFIG_ATMEL_SSC=m
 CONFIG_APDS9802ALS=y
 CONFIG_ISL29003=y
 CONFIG_EEPROM_AT24=y
@@ -202,6 +209,7 @@ CONFIG_RT2X00=m
 CONFIG_RT2800USB=m
 CONFIG_INPUT_JOYDEV=y
 CONFIG_INPUT_EVDEV=y
+CONFIG_KEYBOARD_QT1070=m
 CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_TEGRA=y
 CONFIG_KEYBOARD_SPEAR=y
@@ -225,6 +233,9 @@ CONFIG_SERIAL_8250_EM=y
 CONFIG_SERIAL_8250_MT6577=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
+CONFIG_SERIAL_ATMEL=y
+CONFIG_SERIAL_ATMEL_CONSOLE=y
+CONFIG_SERIAL_ATMEL_TTYAT=y
 CONFIG_SERIAL_MESON=y
 CONFIG_SERIAL_MESON_CONSOLE=y
 CONFIG_SERIAL_SAMSUNG=y
@@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
 CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
 CONFIG_SERIAL_ST_ASC=y
 CONFIG_SERIAL_ST_ASC_CONSOLE=y
+CONFIG_HW_RANDOM=y
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_DAVINCI=y
 CONFIG_I2C_MUX=y
 CONFIG_I2C_MUX_PCA954x=y
 CONFIG_I2C_MUX_PINCTRL=y
+CONFIG_I2C_AT91=m
 CONFIG_I2C_CADENCE=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_I2C_GPIO=m
 CONFIG_I2C_EXYNOS5=y
+CONFIG_I2C_GPIO=m
 CONFIG_I2C_MV64XXX=y
 CONFIG_I2C_RIIC=y
 CONFIG_I2C_S3C2410=y
@@ -269,6 +283,7 @@ CONFIG_I2C_TEGRA=y
 CONFIG_I2C_XILINX=y
 CONFIG_I2C_RCAR=y
 CONFIG_SPI=y
+CONFIG_SPI_ATMEL=m
 CONFIG_SPI_CADENCE=y
 CONFIG_SPI_DAVINCI=y
 CONFIG_SPI_OMAP24XX=y
@@ -397,6 +412,8 @@ CONFIG_SND=y
 CONFIG_SND_DYNAMIC_MINORS=y
 CONFIG_SND_USB_AUDIO=y
 CONFIG_SND_SOC=y
+CONFIG_SND_ATMEL_SOC=m
+CONFIG_SND_ATMEL_SOC_WM8904=m
 CONFIG_SND_SOC_SH4_FSI=m
 CONFIG_SND_SOC_RCAR=m
 CONFIG_SND_SOC_TEGRA=y
@@ -455,6 +472,7 @@ CONFIG_MMC_SDHCI_BCM_KONA=y
 CONFIG_MMC_SDHCI_ST=y
 CONFIG_MMC_OMAP=y
 CONFIG_MMC_OMAP_HS=y
+CONFIG_MMC_ATMELMCI=y
 CONFIG_MMC_MVSDIO=y
 CONFIG_MMC_SDHI=y
 CONFIG_MMC_DW=y
@@ -495,6 +513,8 @@ CONFIG_RTC_DRV_TPS65910=y
 CONFIG_RTC_DRV_S35390A=m
 CONFIG_RTC_DRV_EM3027=y
 CONFIG_RTC_DRV_PL031=y
+CONFIG_RTC_DRV_AT91RM9200=m
+CONFIG_RTC_DRV_AT91SAM9=m
 CONFIG_RTC_DRV_VT8500=y
 CONFIG_RTC_DRV_SUN6I=y
 CONFIG_RTC_DRV_SUNXI=y
@@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
 CONFIG_RTC_DRV_TEGRA=y
 CONFIG_DMADEVICES=y
 CONFIG_DW_DMAC=y
+CONFIG_AT_HDMAC=y
+CONFIG_AT_XDMAC=y
 CONFIG_MV_XOR=y
 CONFIG_TEGRA20_APB_DMA=y
 CONFIG_SH_DMAE=y
@@ -536,9 +558,12 @@ CONFIG_TEGRA_IOMMU_SMMU=y
 CONFIG_MEMORY=y
 CONFIG_TI_AEMIF=y
 CONFIG_IIO=y
+CONFIG_AT91_ADC=m
 CONFIG_XILINX_XADC=y
 CONFIG_AK8975=y
 CONFIG_PWM=y
+CONFIG_PWM_ATMEL=m
+CONFIG_PWM_ATMEL_TCB=m
 CONFIG_PWM_RENESAS_TPU=y
 CONFIG_PWM_TEGRA=y
 CONFIG_PWM_VT8500=y
@@ -575,3 +600,6 @@ CONFIG_LOCKUP_DETECTOR=y
 CONFIG_CRYPTO_DEV_TEGRA_AES=y
 CONFIG_CPUFREQ_DT=y
 CONFIG_KEYSTONE_IRQ=y
+CONFIG_CRYPTO_DEV_ATMEL_AES=m
+CONFIG_CRYPTO_DEV_ATMEL_TDES=m
+CONFIG_CRYPTO_DEV_ATMEL_SHA=m
-- 
2.1.0

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Nicolas Ferre]

Le 03/04/2015 11:01, Alexandre Belloni a écrit :
> Add the Atmel sama5d3 and sama5d4 and their peripherals to multi_v7_defconfig.
> 
> Note that the console will be ttyAT0 instead of the usual ttyS0.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

It seems good to me: thanks Alexandre.

Arnd, Olof, Kevin: do you have a comment about this addition?

If it's okay on your side, I may have to rebase it on top of whichever
branch you want, just to avoid conflicts:
- your most recent arm-soc/next/defconfig branch
- or the v4.1-rc3 tag on which the branch is made from?

Bye.


> ---
>  arch/arm/configs/multi_v7_defconfig | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index b7e6b6fba5e0..adab236c80db 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -18,6 +18,9 @@ CONFIG_MACH_ARMADA_375=y
>  CONFIG_MACH_ARMADA_38X=y
>  CONFIG_MACH_ARMADA_XP=y
>  CONFIG_MACH_DOVE=y
> +CONFIG_ARCH_AT91=y
> +CONFIG_SOC_SAMA5D3=y
> +CONFIG_SOC_SAMA5D4=y
>  CONFIG_ARCH_BCM=y
>  CONFIG_ARCH_BCM_CYGNUS=y
>  CONFIG_ARCH_BCM_21664=y
> @@ -131,6 +134,7 @@ CONFIG_CAN=y
>  CONFIG_CAN_RAW=y
>  CONFIG_CAN_BCM=y
>  CONFIG_CAN_DEV=y
> +CONFIG_CAN_AT91=m
>  CONFIG_CAN_XILINXCAN=y
>  CONFIG_CAN_MCP251X=y
>  CONFIG_CFG80211=m
> @@ -149,13 +153,16 @@ CONFIG_MTD_CMDLINE_PARTS=y
>  CONFIG_MTD_BLOCK=y
>  CONFIG_MTD_M25P80=y
>  CONFIG_MTD_NAND=y
> +CONFIG_MTD_NAND_ATMEL=y
>  CONFIG_MTD_NAND_DAVINCI=y
>  CONFIG_MTD_SPI_NOR=y
>  CONFIG_MTD_UBI=y
>  CONFIG_BLK_DEV_LOOP=y
>  CONFIG_AD525X_DPOT=y
>  CONFIG_AD525X_DPOT_I2C=y
> +CONFIG_ATMEL_TCLIB=y
>  CONFIG_ICS932S401=y
> +CONFIG_ATMEL_SSC=m
>  CONFIG_APDS9802ALS=y
>  CONFIG_ISL29003=y
>  CONFIG_EEPROM_AT24=y
> @@ -202,6 +209,7 @@ CONFIG_RT2X00=m
>  CONFIG_RT2800USB=m
>  CONFIG_INPUT_JOYDEV=y
>  CONFIG_INPUT_EVDEV=y
> +CONFIG_KEYBOARD_QT1070=m
>  CONFIG_KEYBOARD_GPIO=y
>  CONFIG_KEYBOARD_TEGRA=y
>  CONFIG_KEYBOARD_SPEAR=y
> @@ -225,6 +233,9 @@ CONFIG_SERIAL_8250_EM=y
>  CONFIG_SERIAL_8250_MT6577=y
>  CONFIG_SERIAL_AMBA_PL011=y
>  CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
> +CONFIG_SERIAL_ATMEL=y
> +CONFIG_SERIAL_ATMEL_CONSOLE=y
> +CONFIG_SERIAL_ATMEL_TTYAT=y
>  CONFIG_SERIAL_MESON=y
>  CONFIG_SERIAL_MESON_CONSOLE=y
>  CONFIG_SERIAL_SAMSUNG=y
> @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>  CONFIG_SERIAL_ST_ASC=y
>  CONFIG_SERIAL_ST_ASC_CONSOLE=y
> +CONFIG_HW_RANDOM=y
>  CONFIG_I2C_CHARDEV=y
>  CONFIG_I2C_DAVINCI=y
>  CONFIG_I2C_MUX=y
>  CONFIG_I2C_MUX_PCA954x=y
>  CONFIG_I2C_MUX_PINCTRL=y
> +CONFIG_I2C_AT91=m
>  CONFIG_I2C_CADENCE=y
>  CONFIG_I2C_DESIGNWARE_PLATFORM=y
>  CONFIG_I2C_GPIO=m
>  CONFIG_I2C_EXYNOS5=y
> +CONFIG_I2C_GPIO=m
>  CONFIG_I2C_MV64XXX=y
>  CONFIG_I2C_RIIC=y
>  CONFIG_I2C_S3C2410=y
> @@ -269,6 +283,7 @@ CONFIG_I2C_TEGRA=y
>  CONFIG_I2C_XILINX=y
>  CONFIG_I2C_RCAR=y
>  CONFIG_SPI=y
> +CONFIG_SPI_ATMEL=m
>  CONFIG_SPI_CADENCE=y
>  CONFIG_SPI_DAVINCI=y
>  CONFIG_SPI_OMAP24XX=y
> @@ -397,6 +412,8 @@ CONFIG_SND=y
>  CONFIG_SND_DYNAMIC_MINORS=y
>  CONFIG_SND_USB_AUDIO=y
>  CONFIG_SND_SOC=y
> +CONFIG_SND_ATMEL_SOC=m
> +CONFIG_SND_ATMEL_SOC_WM8904=m
>  CONFIG_SND_SOC_SH4_FSI=m
>  CONFIG_SND_SOC_RCAR=m
>  CONFIG_SND_SOC_TEGRA=y
> @@ -455,6 +472,7 @@ CONFIG_MMC_SDHCI_BCM_KONA=y
>  CONFIG_MMC_SDHCI_ST=y
>  CONFIG_MMC_OMAP=y
>  CONFIG_MMC_OMAP_HS=y
> +CONFIG_MMC_ATMELMCI=y
>  CONFIG_MMC_MVSDIO=y
>  CONFIG_MMC_SDHI=y
>  CONFIG_MMC_DW=y
> @@ -495,6 +513,8 @@ CONFIG_RTC_DRV_TPS65910=y
>  CONFIG_RTC_DRV_S35390A=m
>  CONFIG_RTC_DRV_EM3027=y
>  CONFIG_RTC_DRV_PL031=y
> +CONFIG_RTC_DRV_AT91RM9200=m
> +CONFIG_RTC_DRV_AT91SAM9=m
>  CONFIG_RTC_DRV_VT8500=y
>  CONFIG_RTC_DRV_SUN6I=y
>  CONFIG_RTC_DRV_SUNXI=y
> @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
>  CONFIG_RTC_DRV_TEGRA=y
>  CONFIG_DMADEVICES=y
>  CONFIG_DW_DMAC=y
> +CONFIG_AT_HDMAC=y
> +CONFIG_AT_XDMAC=y
>  CONFIG_MV_XOR=y
>  CONFIG_TEGRA20_APB_DMA=y
>  CONFIG_SH_DMAE=y
> @@ -536,9 +558,12 @@ CONFIG_TEGRA_IOMMU_SMMU=y
>  CONFIG_MEMORY=y
>  CONFIG_TI_AEMIF=y
>  CONFIG_IIO=y
> +CONFIG_AT91_ADC=m
>  CONFIG_XILINX_XADC=y
>  CONFIG_AK8975=y
>  CONFIG_PWM=y
> +CONFIG_PWM_ATMEL=m
> +CONFIG_PWM_ATMEL_TCB=m
>  CONFIG_PWM_RENESAS_TPU=y
>  CONFIG_PWM_TEGRA=y
>  CONFIG_PWM_VT8500=y
> @@ -575,3 +600,6 @@ CONFIG_LOCKUP_DETECTOR=y
>  CONFIG_CRYPTO_DEV_TEGRA_AES=y
>  CONFIG_CPUFREQ_DT=y
>  CONFIG_KEYSTONE_IRQ=y
> +CONFIG_CRYPTO_DEV_ATMEL_AES=m
> +CONFIG_CRYPTO_DEV_ATMEL_TDES=m
> +CONFIG_CRYPTO_DEV_ATMEL_SHA=m
> 


-- 
Nicolas Ferre

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Arnd Bergmann]

On Tuesday 19 May 2015 11:15:43 Nicolas Ferre wrote:
> Le 03/04/2015 11:01, Alexandre Belloni a écrit :
> > Add the Atmel sama5d3 and sama5d4 and their peripherals to multi_v7_defconfig.
> > 
> > Note that the console will be ttyAT0 instead of the usual ttyS0.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> It seems good to me: thanks Alexandre.
> 
> Arnd, Olof, Kevin: do you have a comment about this addition?

We're trying to move to a more modular build of multi_v7_defconfig.
Please make all drivers that are not required for booting '=m',
and ensure that they have a MODULE_DEVICE_TABLE entry that allows
autoloading.

Most of the symbols are already marked =m here, but there are a
few that I'm wondering about:

> If it's okay on your side, I may have to rebase it on top of whichever
> branch you want, just to avoid conflicts:
> - your most recent arm-soc/next/defconfig branch
> - or the v4.1-rc3 tag on which the branch is made from?

-rc3 is fine, we can easily handle the conflicts when merging in your
patch.

> > @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
> >  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
> >  CONFIG_SERIAL_ST_ASC=y
> >  CONFIG_SERIAL_ST_ASC_CONSOLE=y
> > +CONFIG_HW_RANDOM=y
> >  CONFIG_I2C_CHARDEV=y
> >  CONFIG_I2C_DAVINCI=y
> >  CONFIG_I2C_MUX=y

seems non-essential.

> > @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
> >  CONFIG_RTC_DRV_TEGRA=y
> >  CONFIG_DMADEVICES=y
> >  CONFIG_DW_DMAC=y
> > +CONFIG_AT_HDMAC=y
> > +CONFIG_AT_XDMAC=y
> >  CONFIG_MV_XOR=y
> >  CONFIG_TEGRA20_APB_DMA=y
> >  CONFIG_SH_DMAE=y

What are these required for? I assume you need them for MMC? If so, that's
fine.

	Arnd

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Alexandre Belloni]

On 19/05/2015 at 13:04:22 +0200, Arnd Bergmann wrote :
> > > @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
> > >  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
> > >  CONFIG_SERIAL_ST_ASC=y
> > >  CONFIG_SERIAL_ST_ASC_CONSOLE=y
> > > +CONFIG_HW_RANDOM=y
> > >  CONFIG_I2C_CHARDEV=y
> > >  CONFIG_I2C_DAVINCI=y
> > >  CONFIG_I2C_MUX=y
> 
> seems non-essential.
> 

That is an oversight, it should be compiled as a module.

> > > @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
> > >  CONFIG_RTC_DRV_TEGRA=y
> > >  CONFIG_DMADEVICES=y
> > >  CONFIG_DW_DMAC=y
> > > +CONFIG_AT_HDMAC=y
> > > +CONFIG_AT_XDMAC=y
> > >  CONFIG_MV_XOR=y
> > >  CONFIG_TEGRA20_APB_DMA=y
> > >  CONFIG_SH_DMAE=y
> 
> What are these required for? I assume you need them for MMC? If so, that's
> fine.
> 

That is indeed the reason.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Nicolas Ferre]

Le 19/05/2015 14:33, Alexandre Belloni a écrit :
> On 19/05/2015 at 13:04:22 +0200, Arnd Bergmann wrote :
>>>> @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
>>>>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>>>>  CONFIG_SERIAL_ST_ASC=y
>>>>  CONFIG_SERIAL_ST_ASC_CONSOLE=y
>>>> +CONFIG_HW_RANDOM=y
>>>>  CONFIG_I2C_CHARDEV=y
>>>>  CONFIG_I2C_DAVINCI=y
>>>>  CONFIG_I2C_MUX=y
>>
>> seems non-essential.
>>
> 
> That is an oversight, it should be compiled as a module.

Ok, I modify it: no need to bother sending a new revision.

>>>> @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
>>>>  CONFIG_RTC_DRV_TEGRA=y
>>>>  CONFIG_DMADEVICES=y
>>>>  CONFIG_DW_DMAC=y
>>>> +CONFIG_AT_HDMAC=y
>>>> +CONFIG_AT_XDMAC=y
>>>>  CONFIG_MV_XOR=y
>>>>  CONFIG_TEGRA20_APB_DMA=y
>>>>  CONFIG_SH_DMAE=y
>>
>> What are these required for? I assume you need them for MMC? If so, that's
>> fine.
>>
> 
> That is indeed the reason.

Yep.

So I simply do a s/y/m/ on the CONFIG_HW_RANDOM then included it in our
at91-4.2-defconfig branch.

Bye,
-- 
Nicolas Ferre

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Nicolas Ferre]

Le 19/05/2015 15:02, Nicolas Ferre a écrit :
> Le 19/05/2015 14:33, Alexandre Belloni a écrit :
>> On 19/05/2015 at 13:04:22 +0200, Arnd Bergmann wrote :
>>>>> @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
>>>>>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>>>>>  CONFIG_SERIAL_ST_ASC=y
>>>>>  CONFIG_SERIAL_ST_ASC_CONSOLE=y
>>>>> +CONFIG_HW_RANDOM=y
>>>>>  CONFIG_I2C_CHARDEV=y
>>>>>  CONFIG_I2C_DAVINCI=y
>>>>>  CONFIG_I2C_MUX=y
>>>
>>> seems non-essential.
>>>
>>
>> That is an oversight, it should be compiled as a module.
> 
> Ok, I modify it: no need to bother sending a new revision.
> 
>>>>> @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
>>>>>  CONFIG_RTC_DRV_TEGRA=y
>>>>>  CONFIG_DMADEVICES=y
>>>>>  CONFIG_DW_DMAC=y
>>>>> +CONFIG_AT_HDMAC=y
>>>>> +CONFIG_AT_XDMAC=y
>>>>>  CONFIG_MV_XOR=y
>>>>>  CONFIG_TEGRA20_APB_DMA=y
>>>>>  CONFIG_SH_DMAE=y
>>>
>>> What are these required for? I assume you need them for MMC? If so, that's
>>> fine.
>>>
>>
>> That is indeed the reason.
> 
> Yep.
> 
> So I simply do a s/y/m/ on the CONFIG_HW_RANDOM then included it in our
> at91-4.2-defconfig branch.

In fact it's a boolean. So removing it does the trick.

Bye,
-- 
Nicolas Ferre

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Nicolas Ferre]

Le 19/05/2015 15:28, Nicolas Ferre a écrit :
> Le 19/05/2015 15:02, Nicolas Ferre a écrit :
>> Le 19/05/2015 14:33, Alexandre Belloni a écrit :
>>> On 19/05/2015 at 13:04:22 +0200, Arnd Bergmann wrote :
>>>>>> @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
>>>>>>  CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>>>>>>  CONFIG_SERIAL_ST_ASC=y
>>>>>>  CONFIG_SERIAL_ST_ASC_CONSOLE=y
>>>>>> +CONFIG_HW_RANDOM=y
>>>>>>  CONFIG_I2C_CHARDEV=y
>>>>>>  CONFIG_I2C_DAVINCI=y
>>>>>>  CONFIG_I2C_MUX=y
>>>>
>>>> seems non-essential.
>>>>
>>>
>>> That is an oversight, it should be compiled as a module.
>>
>> Ok, I modify it: no need to bother sending a new revision.
>>
>>>>>> @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
>>>>>>  CONFIG_RTC_DRV_TEGRA=y
>>>>>>  CONFIG_DMADEVICES=y
>>>>>>  CONFIG_DW_DMAC=y
>>>>>> +CONFIG_AT_HDMAC=y
>>>>>> +CONFIG_AT_XDMAC=y
>>>>>>  CONFIG_MV_XOR=y
>>>>>>  CONFIG_TEGRA20_APB_DMA=y
>>>>>>  CONFIG_SH_DMAE=y
>>>>
>>>> What are these required for? I assume you need them for MMC? If so, that's
>>>> fine.
>>>>
>>>
>>> That is indeed the reason.
>>
>> Yep.
>>
>> So I simply do a s/y/m/ on the CONFIG_HW_RANDOM then included it in our
>> at91-4.2-defconfig branch.
> 
> In fact it's a boolean. So removing it does the trick.

Wrong: it's a tristate: sorry for the noise. But removing is the way to
go anyway...

Bye,
-- 
Nicolas Ferre

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Kevin Hilman]

FYI... This patch is now in linux-next, and boot tests for all the
sama5d[34] boards in kernelci.org have failed to boot.

   http://kernelci.org/boot/all/job/next/kernel/next-20150520/

Kevin

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Alexandre Belloni]

Hi,

On 20/05/2015 at 06:53:50 -0700, Kevin Hilman wrote :
> FYI... This patch is now in linux-next, and boot tests for all the
> sama5d[34] boards in kernelci.org have failed to boot.
> 
>    http://kernelci.org/boot/all/job/next/kernel/next-20150520/
> 

Hum, I'm pretty sure you see the heartbeat led blinking ;)

I think I told you a while ago on IRC and this is part of the commit
message. You have to use ttyAT0 instead of ttyS0 in your bootargs. I'm
not sure how I can make that more obvious, I'm open to any idea.

I'm planning to send a series adding stdout-path to the atmel boards
when I'm back next week. Hopefully this will solve that issue.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Kevin Hilman]

On Wed, May 20, 2015 at 7:08 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hi,
>
> On 20/05/2015 at 06:53:50 -0700, Kevin Hilman wrote :
>> FYI... This patch is now in linux-next, and boot tests for all the
>> sama5d[34] boards in kernelci.org have failed to boot.
>>
>>    http://kernelci.org/boot/all/job/next/kernel/next-20150520/
>>
>
> Hum, I'm pretty sure you see the heartbeat led blinking ;)

I don't see anything because this is automated testing. ;)

> I think I told you a while ago on IRC and this is part of the commit
> message. You have to use ttyAT0 instead of ttyS0 in your bootargs. I'm
> not sure how I can make that more obvious, I'm open to any idea.

If you told me, I forgot.  Sorry.

> I'm planning to send a series adding stdout-path to the atmel boards
> when I'm back next week. Hopefully this will solve that issue.

That should solve it.  In the mean time, I'll have to tweak the
bootargs to have both ttyS0 and ttyATA0 because these boards are
tested on older kernels as well.

Kevin

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Robert Nelson]

On Wed, May 20, 2015 at 9:08 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hi,
>
> On 20/05/2015 at 06:53:50 -0700, Kevin Hilman wrote :
>> FYI... This patch is now in linux-next, and boot tests for all the
>> sama5d[34] boards in kernelci.org have failed to boot.
>>
>>    http://kernelci.org/boot/all/job/next/kernel/next-20150520/
>>
>
> Hum, I'm pretty sure you see the heartbeat led blinking ;)
>
> I think I told you a while ago on IRC and this is part of the commit
> message. You have to use ttyAT0 instead of ttyS0 in your bootargs. I'm
> not sure how I can make that more obvious, I'm open to any idea.
>
> I'm planning to send a series adding stdout-path to the atmel boards
> when I'm back next week. Hopefully this will solve that issue.

Alexandre,

considering all the old boot-loaders, have you thought about adding a
compatibility config similar to:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=00648d0282dcca1da453c0b20d27e24bf901a854

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Alexandre Belloni]

Hi,

On 20/05/2015 at 10:18:16 -0500, Robert Nelson wrote :
> On Wed, May 20, 2015 at 9:08 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Hi,
> >
> > On 20/05/2015 at 06:53:50 -0700, Kevin Hilman wrote :
> >> FYI... This patch is now in linux-next, and boot tests for all the
> >> sama5d[34] boards in kernelci.org have failed to boot.
> >>
> >>    http://kernelci.org/boot/all/job/next/kernel/next-20150520/
> >>
> >
> > Hum, I'm pretty sure you see the heartbeat led blinking ;)
> >
> > I think I told you a while ago on IRC and this is part of the commit
> > message. You have to use ttyAT0 instead of ttyS0 in your bootargs. I'm
> > not sure how I can make that more obvious, I'm open to any idea.
> >
> > I'm planning to send a series adding stdout-path to the atmel boards
> > when I'm back next week. Hopefully this will solve that issue.
> 
> Alexandre,
> 
> considering all the old boot-loaders, have you thought about adding a
> compatibility config similar to:
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=00648d0282dcca1da453c0b20d27e24bf901a854
> 

We are not there yet. sama5_defconfig and at91_dt_defconfig will still
produce kernels using ttyS and not ttyAT. The switch will not happen
until you set CONFIG_SERIAL_ATMEL_TTYAT which has been present since
2.6.19. The issue is that it is mandatory to use it in a multi_v7
configuration because the 8250 driver is compiled in and is conflicting.


Kevin and Tyler jumped on the introduction of sama5 in multi_v7 and got
the issue. As long as you stick to the at91 only configurations, you
will be fine ;)
I hope this clarifies the thing :)

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family

[Alexandre Belloni]

On 20/05/2015 at 07:59:10 -0700, Kevin Hilman wrote :
> > Hum, I'm pretty sure you see the heartbeat led blinking ;)
> 
> I don't see anything because this is automated testing. ;)
> 

I was thinking that your job was looking at those boards with blinking
LEDs while attending conference calls ;)

> > I think I told you a while ago on IRC and this is part of the commit
> > message. You have to use ttyAT0 instead of ttyS0 in your bootargs. I'm
> > not sure how I can make that more obvious, I'm open to any idea.
> 
> If you told me, I forgot.  Sorry.
> 

No problem, it was in the previous development cycle, I was not
expecting you to remember :)

> That should solve it.  In the mean time, I'll have to tweak the
> bootargs to have both ttyS0 and ttyATA0 because these boards are
> tested on older kernels as well.

Like said this is not really a matter of old/new kernel. The only thing
that is changing is the selection of CONFIG_SERIAL_ATMEL_TTYAT. This
option is not selected by sama5_defconfig but you could already build a
kernel with it since 2.6.19.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com