From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
bhelgaas@google.com, matthew.garrett@nebula.com,
rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com
Subject: Re: [PATCH V5 09/12] ACPI: introduce acpi platform exclude id list
Date: Mon, 28 Apr 2014 00:21:55 +0200 [thread overview]
Message-ID: <5562797.vTJauiAbJc@vostro.rjw.lan> (raw)
In-Reply-To: <1396886819-2637-10-git-send-email-rui.zhang@intel.com>
On Tuesday, April 08, 2014 12:06:56 AM Zhang Rui wrote:
> For ACPI PIC (PNP0000) and Timer (PNP0100) device objects, although
> they have _HID control method, but they should not be enumerated to
> platform bus, because there will never be any platform drivers for them.
>
> Thus an exclude id list is introduced in this patch to prevent
> those platform device nodes from being created.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This should go into [6/12] as well.
> ---
> drivers/acpi/acpi_platform.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 33376a9..91ed43a 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -22,6 +22,17 @@
>
> ACPI_MODULE_NAME("platform");
>
> +static const struct acpi_device_id excluded_id_list[] = {
> + {"PNP0000", 0}, /* PIC */
> + {"PNP0100", 0}, /* Timer */
> + {"", 0},
> +};
> +
> +static bool is_exclusive_device(struct acpi_device *dev)
> +{
> + return !acpi_match_device_ids(dev, excluded_id_list);
> +}
> +
> /**
> * acpi_create_platform_device - Create platform device for ACPI device node
> * @adev: ACPI device node to create a platform device for.
> @@ -48,6 +59,9 @@ int acpi_create_platform_device(struct acpi_device *adev,
> if (adev->physical_node_count)
> return 0;
>
> + if (is_exclusive_device(adev))
> + return 0;
> +
> INIT_LIST_HEAD(&resource_list);
> count = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
> if (count < 0) {
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-04-27 22:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 16:06 [PATCH V5 00/12] ACPI: change the way of enumerating PNPACPI/Platform devices Zhang Rui
2014-04-07 16:06 ` [PATCH V5 01/12] ACPI: introduce .match() callback for ACPI scan handler Zhang Rui
2014-04-07 16:06 ` [PATCH V5 02/12] PNPACPI: use whilte list for pnpacpi device enumeration Zhang Rui
2014-04-27 22:01 ` Rafael J. Wysocki
2014-04-28 1:40 ` Zhang Rui
2014-04-28 20:35 ` Rafael J. Wysocki
2014-04-28 20:44 ` Bjorn Helgaas
2014-04-07 16:06 ` [PATCH V5 03/12] ACPI: remove ids that does not comply with the ACPI PNP id rule Zhang Rui
2014-04-07 16:06 ` [PATCH V5 04/12] ACPI: remove unsupported serial PNP ids from acpi pnp scan handler id lsit Zhang Rui
2014-04-07 16:06 ` [PATCH V5 05/12] ACPI: check and enumerate CMOS RTC devices explicitly Zhang Rui
2014-04-27 22:17 ` Rafael J. Wysocki
2014-04-27 22:19 ` Rafael J. Wysocki
2014-04-28 1:50 ` Zhang Rui
2014-04-07 16:06 ` [PATCH V5 06/12] ACPI: introduce platform_id flag Zhang Rui
2014-04-27 22:20 ` Rafael J. Wysocki
2014-04-28 1:51 ` Zhang Rui
2014-04-07 16:06 ` [PATCH V5 07/12] ACPI: use platform bus as the default bus for _HID enumeration Zhang Rui
2014-04-07 16:06 ` [PATCH V5 08/12] ACPI: introduce dummy lpss scan handler Zhang Rui
2014-04-27 22:23 ` Rafael J. Wysocki
2014-04-28 1:57 ` Zhang Rui
2014-04-07 16:06 ` [PATCH V5 09/12] ACPI: introduce acpi platform exclude id list Zhang Rui
2014-04-27 22:21 ` Rafael J. Wysocki [this message]
2014-04-28 1:57 ` Zhang Rui
2014-04-28 20:31 ` Rafael J. Wysocki
2014-04-07 16:06 ` [PATCH V5 10/12] ACPI: introduce dummy container scan handler Zhang Rui
2014-04-07 16:06 ` [PATCH V5 11/12] ACPI: introduce dummy memory hotplug " Zhang Rui
2014-04-07 16:06 ` [PATCH V5 12/12] ACPI: introduce .handle_children flag for acpi " Zhang Rui
2014-04-27 22:26 ` Rafael J. Wysocki
2014-04-28 2:07 ` Zhang Rui
2014-04-28 20:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5562797.vTJauiAbJc@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).