linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] ARM: zynq: DT: Use the zynq binding with macb
@ 2015-05-27 20:00 Nathan Sullivan
  2015-05-27 20:52 ` Sören Brinkmann
  0 siblings, 1 reply; 3+ messages in thread
From: Nathan Sullivan @ 2015-05-27 20:00 UTC (permalink / raw)
  To: michal.simek
  Cc: soren.brinkmann, linux, devicetree, linux-kernel, Nathan Sullivan

Use the new zynq binding for macb ethernet, since it will disable half
duplex gigabit like the Zynq TRM says to do. Also allow the compatible
cadence gem binding that won't disable half duplex but works otherwise.

Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
---
 arch/arm/boot/dts/zynq-7000.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index a5cd2ed..0691508 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -193,7 +193,7 @@
 		};
 
 		gem0: ethernet@e000b000 {
-			compatible = "cdns,gem";
+			compatible = "cdns,zynq-gem", "cdns,gem";
 			reg = <0xe000b000 0x1000>;
 			status = "disabled";
 			interrupts = <0 22 4>;
@@ -204,7 +204,7 @@
 		};
 
 		gem1: ethernet@e000c000 {
-			compatible = "cdns,gem";
+			compatible = "cdns,zynq-gem", "cdns,gem";
 			reg = <0xe000c000 0x1000>;
 			status = "disabled";
 			interrupts = <0 45 4>;
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] ARM: zynq: DT: Use the zynq binding with macb
  2015-05-27 20:00 [PATCH v3] ARM: zynq: DT: Use the zynq binding with macb Nathan Sullivan
@ 2015-05-27 20:52 ` Sören Brinkmann
  2015-05-28  6:54   ` Michal Simek
  0 siblings, 1 reply; 3+ messages in thread
From: Sören Brinkmann @ 2015-05-27 20:52 UTC (permalink / raw)
  To: Nathan Sullivan; +Cc: michal.simek, linux, devicetree, linux-kernel

On Wed, 2015-05-27 at 03:00PM -0500, Nathan Sullivan wrote:
> Use the new zynq binding for macb ethernet, since it will disable half
> duplex gigabit like the Zynq TRM says to do. Also allow the compatible
> cadence gem binding that won't disable half duplex but works otherwise.
> 
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>

Assuming that the corresponding patch(es) for the driver and DT docs
went through:
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>

> ---

For future reference, please include a changelog here documenting what
changes between patch iterations.

	Thanks,
	Sören

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] ARM: zynq: DT: Use the zynq binding with macb
  2015-05-27 20:52 ` Sören Brinkmann
@ 2015-05-28  6:54   ` Michal Simek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2015-05-28  6:54 UTC (permalink / raw)
  To: Sören Brinkmann, Nathan Sullivan
  Cc: michal.simek, linux, devicetree, linux-kernel

On 05/27/2015 10:52 PM, Sören Brinkmann wrote:
> On Wed, 2015-05-27 at 03:00PM -0500, Nathan Sullivan wrote:
>> Use the new zynq binding for macb ethernet, since it will disable half
>> duplex gigabit like the Zynq TRM says to do. Also allow the compatible
>> cadence gem binding that won't disable half duplex but works otherwise.
>>
>> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> 
> Assuming that the corresponding patch(es) for the driver and DT docs
> went through:
> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
> 
>> ---
> 
> For future reference, please include a changelog here documenting what
> changes between patch iterations.

Applied and send in my PR.

Thanks,
Michal


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-28  6:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-27 20:00 [PATCH v3] ARM: zynq: DT: Use the zynq binding with macb Nathan Sullivan
2015-05-27 20:52 ` Sören Brinkmann
2015-05-28  6:54   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).