* xen/tmem: use BUILD_BUG_ON() in favor of BUG_ON()
@ 2015-05-28 8:23 Jan Beulich
2015-05-28 10:36 ` David Vrabel
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2015-05-28 8:23 UTC (permalink / raw)
To: David Vrabel, Boris Ostrovsky, Konrad Rzeszutek Wilk; +Cc: linux-kernel
... when the checked expression is compile time constant.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/xen/tmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 4.1-rc5/drivers/xen/tmem.c
+++ 4.1-rc5-tmem-BUILD_BUG_ON/drivers/xen/tmem.c
@@ -395,7 +395,7 @@ static int __init xen_tmem_init(void)
}
#endif
#ifdef CONFIG_CLEANCACHE
- BUG_ON(sizeof(struct cleancache_filekey) != sizeof(struct tmem_oid));
+ BUILD_BUG_ON(sizeof(struct cleancache_filekey) != sizeof(struct tmem_oid));
if (tmem_enabled && cleancache) {
int err;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: xen/tmem: use BUILD_BUG_ON() in favor of BUG_ON()
2015-05-28 8:23 xen/tmem: use BUILD_BUG_ON() in favor of BUG_ON() Jan Beulich
@ 2015-05-28 10:36 ` David Vrabel
2015-05-28 10:53 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: David Vrabel @ 2015-05-28 10:36 UTC (permalink / raw)
To: Jan Beulich, Boris Ostrovsky, Konrad Rzeszutek Wilk; +Cc: linux-kernel
On 28/05/15 09:23, Jan Beulich wrote:
> ... when the checked expression is compile time constant.
Commit messages should be complete sentences, please.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: xen/tmem: use BUILD_BUG_ON() in favor of BUG_ON()
2015-05-28 10:36 ` David Vrabel
@ 2015-05-28 10:53 ` Jan Beulich
2015-05-28 11:13 ` David Vrabel
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2015-05-28 10:53 UTC (permalink / raw)
To: David Vrabel; +Cc: Boris Ostrovsky, Konrad Rzeszutek Wilk, linux-kernel
>>> On 28.05.15 at 12:36, <david.vrabel@citrix.com> wrote:
> On 28/05/15 09:23, Jan Beulich wrote:
>> ... when the checked expression is compile time constant.
>
> Commit messages should be complete sentences, please.
Do you mean I should repeat the start of the sentence from the
title in the body?
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: xen/tmem: use BUILD_BUG_ON() in favor of BUG_ON()
2015-05-28 10:53 ` Jan Beulich
@ 2015-05-28 11:13 ` David Vrabel
0 siblings, 0 replies; 4+ messages in thread
From: David Vrabel @ 2015-05-28 11:13 UTC (permalink / raw)
To: Jan Beulich; +Cc: Boris Ostrovsky, Konrad Rzeszutek Wilk, linux-kernel
On 28/05/15 11:53, Jan Beulich wrote:
>>>> On 28.05.15 at 12:36, <david.vrabel@citrix.com> wrote:
>> On 28/05/15 09:23, Jan Beulich wrote:
>>> ... when the checked expression is compile time constant.
>>
>> Commit messages should be complete sentences, please.
>
> Do you mean I should repeat the start of the sentence from the
> title in the body?
Well, in this case the body is redundant and could be omitted.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-28 11:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-28 8:23 xen/tmem: use BUILD_BUG_ON() in favor of BUG_ON() Jan Beulich
2015-05-28 10:36 ` David Vrabel
2015-05-28 10:53 ` Jan Beulich
2015-05-28 11:13 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).