* [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions
@ 2017-10-03 8:40 SF Markus Elfring
2017-10-03 14:21 ` Sudeep Holla
0 siblings, 1 reply; 4+ messages in thread
From: SF Markus Elfring @ 2017-10-03 8:40 UTC (permalink / raw)
To: linux-arm-kernel, Liviu Dudau, Lorenzo Pieralisi, Russell King,
Sudeep Holla
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 3 Oct 2017 10:30:07 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/arm/mach-vexpress/spc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-vexpress/spc.c b/arch/arm/mach-vexpress/spc.c
index fe488523694c..21c064267af5 100644
--- a/arch/arm/mach-vexpress/spc.c
+++ b/arch/arm/mach-vexpress/spc.c
@@ -451,10 +451,8 @@ int __init ve_spc_init(void __iomem *baseaddr, u32 a15_clusid, int irq)
{
int ret;
info = kzalloc(sizeof(*info), GFP_KERNEL);
- if (!info) {
- pr_err(SPCLOG "unable to allocate mem\n");
+ if (!info)
return -ENOMEM;
- }
info->baseaddr = baseaddr;
info->a15_clusid = a15_clusid;
@@ -535,10 +533,8 @@ static struct clk *ve_spc_clk_register(struct device *cpu_dev)
struct clk_spc *spc;
spc = kzalloc(sizeof(*spc), GFP_KERNEL);
- if (!spc) {
- pr_err("could not allocate spc clk\n");
+ if (!spc)
return ERR_PTR(-ENOMEM);
- }
spc->hw.init = &init;
spc->cluster = topology_physical_package_id(cpu_dev->id);
--
2.14.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions
2017-10-03 8:40 [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
@ 2017-10-03 14:21 ` Sudeep Holla
2017-10-03 14:27 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Sudeep Holla @ 2017-10-03 14:21 UTC (permalink / raw)
To: SF Markus Elfring, linux-arm-kernel
Cc: Liviu Dudau, Lorenzo Pieralisi, Russell King, Sudeep Holla, LKML,
kernel-janitors
Hi,
I am not sure if such trivial patches get merged by someone via
kernel-janitors list with just maintainers ack or not. Please let
me know if you want me to pickup this, for now I am just Ack-ing.
On 03/10/17 09:40, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 3 Oct 2017 10:30:07 +0200
>
> Omit extra messages for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions
2017-10-03 14:21 ` Sudeep Holla
@ 2017-10-03 14:27 ` Dan Carpenter
2017-10-03 14:29 ` Sudeep Holla
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2017-10-03 14:27 UTC (permalink / raw)
To: Sudeep Holla
Cc: SF Markus Elfring, linux-arm-kernel, Liviu Dudau,
Lorenzo Pieralisi, Russell King, LKML, kernel-janitors
On Tue, Oct 03, 2017 at 03:21:25PM +0100, Sudeep Holla wrote:
> Hi,
>
> I am not sure if such trivial patches get merged by someone via
> kernel-janitors list with just maintainers ack or not. Please let
> me know if you want me to pickup this, for now I am just Ack-ing.
No. kernel-janitors doesn't pick up patches.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions
2017-10-03 14:27 ` Dan Carpenter
@ 2017-10-03 14:29 ` Sudeep Holla
0 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2017-10-03 14:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudeep Holla, SF Markus Elfring, linux-arm-kernel, Liviu Dudau,
Lorenzo Pieralisi, Russell King, LKML, kernel-janitors
On 03/10/17 15:27, Dan Carpenter wrote:
> On Tue, Oct 03, 2017 at 03:21:25PM +0100, Sudeep Holla wrote:
>> Hi,
>>
>> I am not sure if such trivial patches get merged by someone via
>> kernel-janitors list with just maintainers ack or not. Please let
>> me know if you want me to pickup this, for now I am just Ack-ing.
>
> No. kernel-janitors doesn't pick up patches.
>
Thanks for the quick response. I will pick this up then.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-03 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 8:40 [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-10-03 14:21 ` Sudeep Holla
2017-10-03 14:27 ` Dan Carpenter
2017-10-03 14:29 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).