linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
	Patrick Lai <plai@codeaurora.org>,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kwestfie@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 1/2] ASoC: qcom: document apq8016 sbc machine driver bindings
Date: Tue, 09 Jun 2015 18:08:24 +0100	[thread overview]
Message-ID: <55771D88.4050603@linaro.org> (raw)
In-Reply-To: <20150609165718.GH14071@sirena.org.uk>



On 09/06/15 17:57, Mark Brown wrote:
> On Tue, Jun 09, 2015 at 01:59:29PM +0100, Srinivas Kandagatla wrote:
>
>> >+Optional CPU/CODEC subnodes properties:
>> >+- external	: flag to indicate if the I2S is connected to external codec
>> >+Example:
> Missing blank line between the property and the "Example:".  I'm still
I will fix it in next version.
> not sure I understand why we need a boolean property indicating if an
> external CODEC is in use - what is the consequence of setting this
> property?
As of today, the consequence of setting this flag is to setup correct 
dai_link names.
Also there are some limitations on which MI2S can be configured to 
external or internal codecs, this flag can be used in future to validate 
such configurations, if required.

--srini

  reply	other threads:[~2015-06-09 17:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 12:58 [PATCH v5 0/2] ASoC: qcom: add support to apq8016 sbc machine driver Srinivas Kandagatla
2015-06-09 12:59 ` [PATCH v5 1/2] ASoC: qcom: document apq8016 sbc machine driver bindings Srinivas Kandagatla
2015-06-09 16:57   ` Mark Brown
2015-06-09 17:08     ` Srinivas Kandagatla [this message]
2015-06-09 17:13       ` Mark Brown
2015-06-09 17:31         ` Srinivas Kandagatla
2015-06-09 12:59 ` [PATCH v5 2/2] ASoC: qcom: add apq8016 sound card support Srinivas Kandagatla
2015-06-09 17:07   ` Mark Brown
2015-06-09 17:51     ` Srinivas Kandagatla
2015-06-09 18:04       ` Mark Brown
2015-06-09 18:22         ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55771D88.4050603@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kwestfie@codeaurora.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).