* [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix
@ 2015-06-16 11:56 Guillermo O. Freschi
2015-06-16 12:57 ` Ian Abbott
2015-06-16 14:32 ` Sudip Mukherjee
0 siblings, 2 replies; 4+ messages in thread
From: Guillermo O. Freschi @ 2015-06-16 11:56 UTC (permalink / raw)
To: abbotti; +Cc: linux-kernel, Guillermo O. Freschi
Removed some spaces before a tab character.
Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
---
drivers/staging/comedi/drivers/pcl816.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index 1ccb2f1..781b321 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
/* check whole chanlist */
for (i = 0, segpos = 0; i < chanlen; i++) {
- if (chanlist[i] != chansegment[i % seglen]) {
+ if (chanlist[i] != chansegment[i % seglen]) {
dev_dbg(dev->class_dev,
"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
i, CR_CHAN(chansegment[i]),
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix
2015-06-16 11:56 [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix Guillermo O. Freschi
@ 2015-06-16 12:57 ` Ian Abbott
2015-06-16 14:32 ` Sudip Mukherjee
1 sibling, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-06-16 12:57 UTC (permalink / raw)
To: Guillermo O. Freschi; +Cc: linux-kernel
On 16/06/15 12:56, Guillermo O. Freschi wrote:
> Removed some spaces before a tab character.
>
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl816.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
> index 1ccb2f1..781b321 100644
> --- a/drivers/staging/comedi/drivers/pcl816.c
> +++ b/drivers/staging/comedi/drivers/pcl816.c
> @@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
>
> /* check whole chanlist */
> for (i = 0, segpos = 0; i < chanlen; i++) {
> - if (chanlist[i] != chansegment[i % seglen]) {
> + if (chanlist[i] != chansegment[i % seglen]) {
> dev_dbg(dev->class_dev,
> "bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
> i, CR_CHAN(chansegment[i]),
>
Thanks, but it's also fixed by commit 8b4e7da516aa in linux-next.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix
2015-06-16 11:56 [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix Guillermo O. Freschi
2015-06-16 12:57 ` Ian Abbott
@ 2015-06-16 14:32 ` Sudip Mukherjee
1 sibling, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2015-06-16 14:32 UTC (permalink / raw)
To: Guillermo O. Freschi; +Cc: abbotti, linux-kernel
On Tue, Jun 16, 2015 at 08:56:40AM -0300, Guillermo O. Freschi wrote:
> Removed some spaces before a tab character.
>
> Signed-off-by: Guillermo O. Freschi <kedrot@gmail.com>
I should have checked when you sent your v1. This patch will not apply.
This change has already been done by commit:
8b4e7da51 ("staging: comedi/drivers/pcl.* coding style fixes")
please create your patches based on staging-testing tree.
and always use scripts/get_maintainer.pl to get a list of people and
mailing lists to send your patch.
regards
sudip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix
@ 2015-06-16 22:32 Tordek
0 siblings, 0 replies; 4+ messages in thread
From: Tordek @ 2015-06-16 22:32 UTC (permalink / raw)
To: linux-kernel
> Thanks, but it's also fixed by commit 8b4e7da516aa in linux-next.
I see. Thank you and Sudip for your feedback, I'll look into the proper branches next time!
--
Guillermo O. «Tordek» Freschi
http://tordek.me :: http://twitter.com/tordek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-16 22:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-16 11:56 [PATCH v2] drivers/staging/comedi/drivers/pcl816.c: style fix Guillermo O. Freschi
2015-06-16 12:57 ` Ian Abbott
2015-06-16 14:32 ` Sudip Mukherjee
2015-06-16 22:32 Tordek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).