From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings
Date: Thu, 1 Mar 2018 17:26:06 +0100 [thread overview]
Message-ID: <55819630-6198-6227-63ef-69311b21b255@redhat.com> (raw)
In-Reply-To: <20180301162215.GC12864@sirena.org.uk>
Hi,
On 01-03-18 17:22, Mark Brown wrote:
> On Sun, Feb 18, 2018 at 11:01:45PM +0100, Hans de Goede wrote:
>> The ignore_suspend settings were added in an attempt to try and fix
>> suspend / resume issues. But they never fully fixed these and now we've
>> a proper fix, so lets remove these.
>
> Do these systems not have the ability to continue to play audio through
> suspend using the DSP? That's the sort of thing that ignore_suspend is
> normally used for.
In theory yes, in practice if we keep ignore_suspend set then we get
audio for a couple of more seconds after suspend until the buffers
are empty, as we have no code keeping them filled, which is not really
useful, since we don't support this in a meaningful way it is better
to just do a normal full suspend.
Regards,
Hans
next prev parent reply other threads:[~2018-03-01 16:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 22:01 [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues Hans de Goede
2018-02-18 22:01 ` [PATCH 1/9] ASoC: Intel: sst: Fix error-code check in sst_pause_stream() Hans de Goede
2018-02-19 13:47 ` Andy Shevchenko
2018-02-19 14:00 ` Hans de Goede
2018-02-18 22:01 ` [PATCH 2/9] ASoC: Intel: sst: Remove 2 unused members from stream_info struct Hans de Goede
2018-02-18 22:01 ` [PATCH 3/9] ASoC: Intel: sst: Remove unnecessary sst_init_stream() function Hans de Goede
2018-02-18 22:01 ` [PATCH 4/9] ASoC: Intel: sst: Remove unused STREAM_DECODE and STREAM_RESET states Hans de Goede
2018-02-18 22:01 ` [PATCH 5/9] ASoC: Intel: sst: Add sst_realloc_stream() function Hans de Goede
2018-02-18 22:01 ` [PATCH 6/9] ASoC: Intel: sst: Free streams on suspend, re-alloc on resume Hans de Goede
2018-02-19 13:51 ` Andy Shevchenko
2018-02-19 14:02 ` Hans de Goede
2018-02-19 16:29 ` Mark Brown
2018-02-19 16:32 ` Hans de Goede
2018-02-19 16:35 ` Mark Brown
2018-02-18 22:01 ` [PATCH 7/9] ASoc: rt5651: Fix regcache sync errors " Hans de Goede
2018-02-18 22:01 ` [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings Hans de Goede
2018-03-01 16:22 ` Mark Brown
2018-03-01 16:26 ` Hans de Goede [this message]
2018-03-01 16:48 ` Mark Brown
2018-03-01 16:58 ` Hans de Goede
2018-03-01 17:17 ` Mark Brown
2018-03-04 14:11 ` Hans de Goede
2018-03-05 13:50 ` Hans de Goede
2018-03-05 15:34 ` Mark Brown
2018-02-18 22:01 ` [PATCH 9/9] ASoC: Intel: bytcr_rt5651: " Hans de Goede
2018-02-19 13:53 ` [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55819630-6198-6227-63ef-69311b21b255@redhat.com \
--to=hdegoede@redhat.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).