From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] ASoC: Intel: sst: Fix error-code check in sst_pause_stream()
Date: Mon, 19 Feb 2018 15:47:48 +0200 [thread overview]
Message-ID: <CAHp75VeANVAbjq69x2k3mEkodhzWctQ58EVOz90CjgnS5K+UTQ@mail.gmail.com> (raw)
In-Reply-To: <20180218220146.22485-2-hdegoede@redhat.com>
On Mon, Feb 19, 2018 at 12:01 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> The value returned by sst_prepare_and_post_msg() is a negated SST_ERR_*
> value, so we must check for -SST_ERR_INVALID_STREAM_ID. Note that
> sst_pause_resume() already has the correct check.
>
Should it have Fixes tag?
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> sound/soc/intel/atom/sst/sst_stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_stream.c b/sound/soc/intel/atom/sst/sst_stream.c
> index 7ee6aeb7e0af..b082b0922a7a 100644
> --- a/sound/soc/intel/atom/sst/sst_stream.c
> +++ b/sound/soc/intel/atom/sst/sst_stream.c
> @@ -253,7 +253,7 @@ int sst_pause_stream(struct intel_sst_drv *sst_drv_ctx, int str_id)
> if (retval == 0) {
> str_info->prev = str_info->status;
> str_info->status = STREAM_PAUSED;
> - } else if (retval == SST_ERR_INVALID_STREAM_ID) {
> + } else if (retval == -SST_ERR_INVALID_STREAM_ID) {
> retval = -EINVAL;
> mutex_lock(&sst_drv_ctx->sst_lock);
> sst_clean_stream(str_info);
> --
> 2.14.3
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-02-19 13:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 22:01 [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues Hans de Goede
2018-02-18 22:01 ` [PATCH 1/9] ASoC: Intel: sst: Fix error-code check in sst_pause_stream() Hans de Goede
2018-02-19 13:47 ` Andy Shevchenko [this message]
2018-02-19 14:00 ` Hans de Goede
2018-02-18 22:01 ` [PATCH 2/9] ASoC: Intel: sst: Remove 2 unused members from stream_info struct Hans de Goede
2018-02-18 22:01 ` [PATCH 3/9] ASoC: Intel: sst: Remove unnecessary sst_init_stream() function Hans de Goede
2018-02-18 22:01 ` [PATCH 4/9] ASoC: Intel: sst: Remove unused STREAM_DECODE and STREAM_RESET states Hans de Goede
2018-02-18 22:01 ` [PATCH 5/9] ASoC: Intel: sst: Add sst_realloc_stream() function Hans de Goede
2018-02-18 22:01 ` [PATCH 6/9] ASoC: Intel: sst: Free streams on suspend, re-alloc on resume Hans de Goede
2018-02-19 13:51 ` Andy Shevchenko
2018-02-19 14:02 ` Hans de Goede
2018-02-19 16:29 ` Mark Brown
2018-02-19 16:32 ` Hans de Goede
2018-02-19 16:35 ` Mark Brown
2018-02-18 22:01 ` [PATCH 7/9] ASoc: rt5651: Fix regcache sync errors " Hans de Goede
2018-02-18 22:01 ` [PATCH 8/9] ASoC: Intel: bytcr_rt5640: Drop unwanted ignore_suspend settings Hans de Goede
2018-03-01 16:22 ` Mark Brown
2018-03-01 16:26 ` Hans de Goede
2018-03-01 16:48 ` Mark Brown
2018-03-01 16:58 ` Hans de Goede
2018-03-01 17:17 ` Mark Brown
2018-03-04 14:11 ` Hans de Goede
2018-03-05 13:50 ` Hans de Goede
2018-03-05 15:34 ` Mark Brown
2018-02-18 22:01 ` [PATCH 9/9] ASoC: Intel: bytcr_rt5651: " Hans de Goede
2018-02-19 13:53 ` [PATCH 0/9] ASoC: Intel: sst: Fix Bay Trail suspend/resume issues Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeANVAbjq69x2k3mEkodhzWctQ58EVOz90CjgnS5K+UTQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).