linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence
@ 2015-06-16 14:03 Abdul, Hussain (H.)
  2015-06-19  5:59 ` Abdul, Hussain (H.)
       [not found] ` <DB5PR06MB1112DB9D7F15F4F6C2B87B0FDFA10@DB5PR06MB1112.eurprd06.prod.outlook.com>
  0 siblings, 2 replies; 4+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-16 14:03 UTC (permalink / raw)
  To: gregkh
  Cc: devel, Ravindran, Madhusudhanan (M.), Dighe, Niranjan (N.), linux-kernel

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Abdul Hussain (6):
    staging: comedi: dmm32at: Simplify a trivial if-return sequence
    staging: comedi: fl512: Simplify a trivial if-return sequence
    staging: comedi: daqboard2000: Simplify a trivial if-return sequence
    staging: comedi: dac02: Simplify a trivial if-return sequence
    staging: comedi: daq_dio24: Simplify a trivial if-return sequence
    staging: comedi: s626: Simplify a trivial if-return sequence


drivers/staging/comedi/drivers/dac02.c        | 6 +-----
drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
drivers/staging/comedi/drivers/fl512.c        | 6 +-----
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
drivers/staging/comedi/drivers/s626.c         | 6 +-----


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence
  2015-06-16 14:03 [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence Abdul, Hussain (H.)
@ 2015-06-19  5:59 ` Abdul, Hussain (H.)
  2015-06-20 12:40   ` Ian Abbott
       [not found] ` <DB5PR06MB1112DB9D7F15F4F6C2B87B0FDFA10@DB5PR06MB1112.eurprd06.prod.outlook.com>
  1 sibling, 1 reply; 4+ messages in thread
From: Abdul, Hussain (H.) @ 2015-06-19  5:59 UTC (permalink / raw)
  To: gregkh; +Cc: abbotti, hsweeten, devel, linux-kernel



This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Abdul Hussain (6):
    staging: comedi: dmm32at: Simplify a trivial if-return sequence
    staging: comedi: fl512: Simplify a trivial if-return sequence
    staging: comedi: daqboard2000: Simplify a trivial if-return sequence
    staging: comedi: dac02: Simplify a trivial if-return sequence
    staging: comedi: daq_dio24: Simplify a trivial if-return sequence
    staging: comedi: s626: Simplify a trivial if-return sequence


drivers/staging/comedi/drivers/dac02.c        | 6 +-----
drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
drivers/staging/comedi/drivers/fl512.c        | 6 +-----
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
drivers/staging/comedi/drivers/s626.c         | 6 +-----





^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence
  2015-06-19  5:59 ` Abdul, Hussain (H.)
@ 2015-06-20 12:40   ` Ian Abbott
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-06-20 12:40 UTC (permalink / raw)
  To: Abdul, Hussain (H.), gregkh; +Cc: hsweeten, devel, linux-kernel

On 19/06/15 06:59, Abdul, Hussain (H.) wrote:
>
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Abdul Hussain (6):
>      staging: comedi: dmm32at: Simplify a trivial if-return sequence
>      staging: comedi: fl512: Simplify a trivial if-return sequence
>      staging: comedi: daqboard2000: Simplify a trivial if-return sequence
>      staging: comedi: dac02: Simplify a trivial if-return sequence
>      staging: comedi: daq_dio24: Simplify a trivial if-return sequence
>      staging: comedi: s626: Simplify a trivial if-return sequence
>
>
> drivers/staging/comedi/drivers/dac02.c        | 6 +-----
> drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
> drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
> drivers/staging/comedi/drivers/fl512.c        | 6 +-----
> drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
> drivers/staging/comedi/drivers/s626.c         | 6 +-----


Looks good apart from the checkpatch warning in patch 3 as pointed out 
by Sudip.

For patches 1-2 and 4-6:
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/6] Staging: comedi: Simplify a trivial if-return sequence
       [not found] ` <DB5PR06MB1112DB9D7F15F4F6C2B87B0FDFA10@DB5PR06MB1112.eurprd06.prod.outlook.com>
@ 2015-06-22  9:18   ` Ian Abbott
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-06-22  9:18 UTC (permalink / raw)
  To: Abdul, Hussain (H.), gregkh
  Cc: devel, Ravindran, Madhusudhanan (M.), Dighe, Niranjan (N.), linux-kernel

On 22/06/15 07:10, Abdul, Hussain (H.) wrote:
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Abdul Hussain (6):
>      staging: comedi: dmm32at: Simplify a trivial if-return sequence
>      staging: comedi: fl512: Simplify a trivial if-return sequence
>      staging: comedi: daqboard2000: Simplify a trivial if-return sequence
>      staging: comedi: dac02: Simplify a trivial if-return sequence
>      staging: comedi: ni_daq_dio24: Simplify a trivial if-return sequence
>      staging: comedi: s626: Simplify a trivial if-return sequence
>
>   drivers/staging/comedi/drivers/dac02.c        | 6 +-----
>   drivers/staging/comedi/drivers/daqboard2000.c | 8 ++------
>   drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
>   drivers/staging/comedi/drivers/fl512.c        | 6 +-----
>   drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
>   drivers/staging/comedi/drivers/s626.c         | 6 +-----
>   6 files changed, 7 insertions(+), 31 deletions(-)
>
>

Looks good.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-22  9:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-16 14:03 [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence Abdul, Hussain (H.)
2015-06-19  5:59 ` Abdul, Hussain (H.)
2015-06-20 12:40   ` Ian Abbott
     [not found] ` <DB5PR06MB1112DB9D7F15F4F6C2B87B0FDFA10@DB5PR06MB1112.eurprd06.prod.outlook.com>
2015-06-22  9:18   ` [PATCH v2 " Ian Abbott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).