From: Johan Jonker <jbx6244@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>,
Justin Swartz <justin.swartz@risingedge.co.za>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
mark.rutland@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH v4 2/3] ARM: dts: rockchip: add rga node for rk322x
Date: Sat, 18 Apr 2020 14:14:45 +0200 [thread overview]
Message-ID: <558b35c3-7f75-8d0d-048b-c55c06fa8a53@gmail.com> (raw)
In-Reply-To: <2533855.f5ZhyS2AsA@phil>
On 4/18/20 12:53 PM, Heiko Stuebner wrote:
> Am Samstag, 18. April 2020, 11:56:03 CEST schrieb Justin Swartz:
>> Hi Johan, Heiko,
>>
>> On 2020-04-18 11:49, Heiko Stuebner wrote:
>>
>>> Am Samstag, 18. April 2020, 11:15:27 CEST schrieb Johan Jonker:
>>>
>>>> Hi Justin, Heiko,
>>>>
>>>> In the discussion about "rockchip,px30-rga" it was mentioned that:
>>>> "no status for soc internal components without any board-specifics".
>>>> The binding is in mainline, but the dts node is missing I think.
>>>> Should this also be changed?
>>>
>>> yep, drop the status disabled from the dtsi and that then results
>>> in not needing the board-level enablement
>>>
>>> (background: rga is a simple mem2mem device without any
>>> board-specific hooks)
>>
>> Shall I submit version 5 of this patch series?
>
> I guess so ... especially as we expect patch1 to go through the
> media tree and sending a new version might serve as a ping :-)
> and include the Ack by Rob for easy applying
The conversion to rockchip-rga.yaml including rockchip,rk3228-rga is
already reviewed by robh.
>
>
> Heiko
>
>
>>
>>> Johan
>>>
>>> +&rga {
>>> + status = "okay";
>>> +};
>>> +
>>>
>>> Add a node to define the presence of RGA, a 2D raster
>>> graphic acceleration unit.
>>>
>>> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
>>> ---
>>> arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/rk322x.dtsi
>>> b/arch/arm/boot/dts/rk322x.dtsi
>>> index 340ed6ccb..29d50bebc 100644
>>> --- a/arch/arm/boot/dts/rk322x.dtsi
>>> +++ b/arch/arm/boot/dts/rk322x.dtsi
>>> @@ -621,6 +621,17 @@
>>> status = "disabled";
>>> };
>>>
>>> + rga: rga@20060000 {
>>> + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
>>> + reg = <0x20060000 0x1000>;
>>> + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
>>> + clock-names = "aclk", "hclk", "sclk";
>>> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru
>>> SRST_RGA_H>;
>>> + reset-names = "core", "axi", "ahb";
>>> + status = "disabled";
>>> remove?
>>>
>>> + };
>>> +
>>> iep_mmu: iommu@20070800 {
>>> compatible = "rockchip,iommu";
>>> reg = <0x20070800 0x100>;
>>
>
>
>
>
next prev parent reply other threads:[~2020-04-18 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 22:30 [PATCH v4 0/3] Add rga to rk322x device tree Justin Swartz
2020-02-03 22:40 ` [PATCH v4 1/3] [media] dt-bindings: Add binding for rk3228 rga Justin Swartz
2020-02-06 19:06 ` Rob Herring
2020-03-01 0:29 ` Heiko Stuebner
2020-02-03 22:40 ` [PATCH v4 2/3] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-04-18 9:15 ` Johan Jonker
2020-04-18 9:49 ` Heiko Stuebner
2020-04-18 9:56 ` Justin Swartz
2020-04-18 10:53 ` Heiko Stuebner
2020-04-18 12:14 ` Johan Jonker [this message]
2020-04-19 12:51 ` [PATCH v5 0/1] Add rga to rk322x device tree Justin Swartz
2020-05-18 22:52 ` Heiko Stuebner
2020-04-19 12:51 ` [PATCH v5 1/1] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-02-03 22:40 ` [PATCH v4 3/3] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558b35c3-7f75-8d0d-048b-c55c06fa8a53@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=justin.swartz@risingedge.co.za \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).