[GIT PULL] ARM: EXYNOS: dts: Improvements for 4.3

[GIT PULL] ARM: EXYNOS: dts: Improvements for 4.3

[Krzysztof Kozlowski]

Dear Kukjin,

DTS related improvements. Description along with a tag.
You can find them also on the lists with my reviewed-by.

Best regards,
Krzysztof


The following changes since commit a419d78a6f97f8c977fe55d5d590cd0654ecd1ee:

  ARM: dts: Exynos4210: add CPU OPP and regulator supply property (2015-07-13 21:16:05 +0900)

are available in the git repository at:

  https://github.com/krzk/linux.git tags/samsung-dt-4.3

for you to fetch changes up to cd0b551be420d49c2bde8dcf5ea147278dc89ffb:

  ARM: dts: Extend exynos5420-pinctrl nodes using labels instead of paths (2015-07-16 11:22:11 +0900)

----------------------------------------------------------------
Device Tree improvements for Exynos based boards:
1. Enable proper USB 3.0 regulators on Odroid XU3 board.
2. Set over-heat and over-voltage thresholds for Trats2 board fuel
   gauge.
3. Fix missing display frequency on Exynos3250 Rinato board
   (necessary to fix the display).
4. Enable thermal management and fan control on Odroid XU3 board.
   The speed of fan is adjusted to current temperature of SoC.
5. Cleanups and usage of label-notation for overriding nodes.

----------------------------------------------------------------
Anand Moon (5):
      ARM: dts: odroidxu3: Enable USB3 regulators
      ARM: dts: exynos5422-odroidxu3: Add pwm-fan node
      ARM: dts: exynos5422-odroidxu3: Enable TMU at Exynos5422 base
      ARM: dts: exynos5422-odroidxu3: Define default thermal-zones
      ARM: dts: exynos5422-odroidxu3: Enable thermal-zones

Andreas Färber (1):
      ARM: dts: Clean up exynos5410-smdk5410 indentation

Hyungwon Hwang (1):
      ARM: dts: fix the clock-frequency of exynos3250-rinato board's panel

Javier Martinez Canillas (4):
      ARM: dts: Include exynos5250-pinctrl after the nodes were defined
      ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths
      ARM: dts: Include exynos5420-pinctrl after the nodes were defined
      ARM: dts: Extend exynos5420-pinctrl nodes using labels instead of paths

Krzysztof Kozlowski (2):
      ARM: dts: Set max17047 over heat and over voltage thresholds
      ARM: dts: Use labels for overriding nodes in exynos4210-universal

 arch/arm/boot/dts/exynos3250-rinato.dts            |    2 +-
 arch/arm/boot/dts/exynos4210-universal_c210.dts    |  620 ++++----
 arch/arm/boot/dts/exynos4412-trats2.dts            |    3 +
 arch/arm/boot/dts/exynos5250-pinctrl.dtsi          | 1600 ++++++++++----------
 arch/arm/boot/dts/exynos5250.dtsi                  |    3 +-
 arch/arm/boot/dts/exynos5410-smdk5410.dts          |    6 +-
 arch/arm/boot/dts/exynos5420-pinctrl.dtsi          | 1411 +++++++++--------
 arch/arm/boot/dts/exynos5420.dtsi                  |    3 +-
 arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi      |   59 +
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi |   46 +
 10 files changed, 1930 insertions(+), 1823 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi

[GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Krzysztof Kozlowski]

Dear Kukjin,

Exynos mach-code related improvements. Description along with a tag.
You can find them also on the lists with my reviewed-by.

Best regards,
Krzysztof


The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:

  Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-07-05 16:24:54 -0700)

are available in the git repository at:


  https://github.com/krzk/linux.git tags/samsung-mach-4.3

for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:

  cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)

----------------------------------------------------------------
Improvements for Exynos based boards:
1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
   is removed.
2. Fix memory leak in cpufreq error path.
3. Cleanups: remove duplicated define with bootloader's sleep magic
   constant, staticize local function, drop 'owner' from
   platform driver, fix cast of iomem to ERR_PTR.

----------------------------------------------------------------
Bartlomiej Zolnierkiewicz (1):
      cpufreq: exynos: remove Exynos5250 specific cpufreq driver support

Krzysztof Kozlowski (4):
      ARM: EXYNOS: pmu: Make local function static
      ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
      ARM: EXYNOS: pmu: Drop owner assignment
      ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem

Shailendra Verma (1):
      cpufreq: exynos: Fix for memory leak in case SOC name does not match

Thomas Abraham (3):
      clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
      ARM: dts: Exynos5250: add CPU OPP and regulator supply property
      ARM: Exynos: switch to using generic cpufreq driver for Exynos5250

 arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
 arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
 arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
 arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
 arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
 arch/arm/mach-exynos/common.h             |   6 +
 arch/arm/mach-exynos/exynos.c             |   1 +
 arch/arm/mach-exynos/firmware.c           |   2 -
 arch/arm/mach-exynos/platsmp.c            |   2 +-
 arch/arm/mach-exynos/pmu.c                |   3 +-
 arch/arm/mach-exynos/suspend.c            |   4 +-
 drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
 drivers/cpufreq/Kconfig.arm               |  11 --
 drivers/cpufreq/Makefile                  |   1 -
 drivers/cpufreq/exynos-cpufreq.c          |   9 +-
 drivers/cpufreq/exynos-cpufreq.h          |  17 ---
 drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
 include/dt-bindings/clock/exynos5250.h    |   1 +
 18 files changed, 84 insertions(+), 252 deletions(-)
 delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c

RE: [GIT PULL] ARM: EXYNOS: dts: Improvements for 4.3

[Kukjin Kim]

Krzysztof Kozlowski wrote:
> 
> Dear Kukjin,
> 
Hi Krzysztof,

> DTS related improvements. Description along with a tag.
> You can find them also on the lists with my reviewed-by.
> 
> Best regards,
> Krzysztof
> 
> 
> The following changes since commit a419d78a6f97f8c977fe55d5d590cd0654ecd1ee:
> 
>   ARM: dts: Exynos4210: add CPU OPP and regulator supply property (2015-07-13 21:16:05 +0900)
> 
> are available in the git repository at:
> 
>   https://github.com/krzk/linux.git tags/samsung-dt-4.3
> 
> for you to fetch changes up to cd0b551be420d49c2bde8dcf5ea147278dc89ffb:
> 
>   ARM: dts: Extend exynos5420-pinctrl nodes using labels instead of paths (2015-07-16 11:22:11 +0900)
> 
> ----------------------------------------------------------------
> Device Tree improvements for Exynos based boards:
> 1. Enable proper USB 3.0 regulators on Odroid XU3 board.
> 2. Set over-heat and over-voltage thresholds for Trats2 board fuel
>    gauge.
> 3. Fix missing display frequency on Exynos3250 Rinato board
>    (necessary to fix the display).
> 4. Enable thermal management and fan control on Odroid XU3 board.
>    The speed of fan is adjusted to current temperature of SoC.
> 5. Cleanups and usage of label-notation for overriding nodes.
> 
> ----------------------------------------------------------------
> Anand Moon (5):
>       ARM: dts: odroidxu3: Enable USB3 regulators
>       ARM: dts: exynos5422-odroidxu3: Add pwm-fan node
>       ARM: dts: exynos5422-odroidxu3: Enable TMU at Exynos5422 base
>       ARM: dts: exynos5422-odroidxu3: Define default thermal-zones
>       ARM: dts: exynos5422-odroidxu3: Enable thermal-zones
> 
> Andreas Färber (1):
>       ARM: dts: Clean up exynos5410-smdk5410 indentation
> 
> Hyungwon Hwang (1):
>       ARM: dts: fix the clock-frequency of exynos3250-rinato board's panel
> 
> Javier Martinez Canillas (4):
>       ARM: dts: Include exynos5250-pinctrl after the nodes were defined
>       ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths
>       ARM: dts: Include exynos5420-pinctrl after the nodes were defined
>       ARM: dts: Extend exynos5420-pinctrl nodes using labels instead of paths
> 
> Krzysztof Kozlowski (2):
>       ARM: dts: Set max17047 over heat and over voltage thresholds
>       ARM: dts: Use labels for overriding nodes in exynos4210-universal
> 
>  arch/arm/boot/dts/exynos3250-rinato.dts            |    2 +-
>  arch/arm/boot/dts/exynos4210-universal_c210.dts    |  620 ++++----
>  arch/arm/boot/dts/exynos4412-trats2.dts            |    3 +
>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi          | 1600 ++++++++++----------
>  arch/arm/boot/dts/exynos5250.dtsi                  |    3 +-
>  arch/arm/boot/dts/exynos5410-smdk5410.dts          |    6 +-
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi          | 1411 +++++++++--------
>  arch/arm/boot/dts/exynos5420.dtsi                  |    3 +-
>  arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi      |   59 +
>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi |   46 +
>  10 files changed, 1930 insertions(+), 1823 deletions(-)
>  create mode 100644 arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi
> --

Applied all of changes into fixes/non-critical and next/dt-samsung.

Note will be sent out to arm-soc in a couple of days.

Thanks,
Kukjin

RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Kukjin Kim]

Krzysztof Kozlowski wrote:
> 
> Dear Kukjin,
> 
> Exynos mach-code related improvements. Description along with a tag.
> You can find them also on the lists with my reviewed-by.
> 
> Best regards,
> Krzysztof
> 
> 
> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
> 
>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
> 07-05 16:24:54 -0700)
> 
> are available in the git repository at:
> 
> 
>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
> 
> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
> 
>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
> 
> ----------------------------------------------------------------
> Improvements for Exynos based boards:
> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>    is removed.
> 2. Fix memory leak in cpufreq error path.
> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>    constant, staticize local function, drop 'owner' from
>    platform driver, fix cast of iomem to ERR_PTR.
> 
> ----------------------------------------------------------------
> Bartlomiej Zolnierkiewicz (1):
>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
> 
> Krzysztof Kozlowski (4):
>       ARM: EXYNOS: pmu: Make local function static
>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>       ARM: EXYNOS: pmu: Drop owner assignment
>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
> 
> Shailendra Verma (1):
>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
> 
> Thomas Abraham (3):
>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
> 
>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>  arch/arm/mach-exynos/common.h             |   6 +
>  arch/arm/mach-exynos/exynos.c             |   1 +
>  arch/arm/mach-exynos/firmware.c           |   2 -
>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>  arch/arm/mach-exynos/pmu.c                |   3 +-
>  arch/arm/mach-exynos/suspend.c            |   4 +-
>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>  drivers/cpufreq/Kconfig.arm               |  11 --
>  drivers/cpufreq/Makefile                  |   1 -
>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>  include/dt-bindings/clock/exynos5250.h    |   1 +
>  18 files changed, 84 insertions(+), 252 deletions(-)
>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
> --

Applied above changes into fixes/non-critical, next/cleanup-samsung,
next/dt-samsung and next/cpufreq-clk-samsung according to the change.

BTW since I can't see any ack from cpufreq guy for the patch "cpufreq:
exynos: Fix for memory leak in case SOC name does not match" so I couldn't.

Thanks,
Kukjin

Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Krzysztof Kozlowski]

2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> Krzysztof Kozlowski wrote:
>>
>> Dear Kukjin,
>>
>> Exynos mach-code related improvements. Description along with a tag.
>> You can find them also on the lists with my reviewed-by.
>>
>> Best regards,
>> Krzysztof
>>
>>
>> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
>>
>>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
>> 07-05 16:24:54 -0700)
>>
>> are available in the git repository at:
>>
>>
>>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
>>
>> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
>>
>>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
>>
>> ----------------------------------------------------------------
>> Improvements for Exynos based boards:
>> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>>    is removed.
>> 2. Fix memory leak in cpufreq error path.
>> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>>    constant, staticize local function, drop 'owner' from
>>    platform driver, fix cast of iomem to ERR_PTR.
>>
>> ----------------------------------------------------------------
>> Bartlomiej Zolnierkiewicz (1):
>>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
>>
>> Krzysztof Kozlowski (4):
>>       ARM: EXYNOS: pmu: Make local function static
>>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>>       ARM: EXYNOS: pmu: Drop owner assignment
>>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
>>
>> Shailendra Verma (1):
>>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
>>
>> Thomas Abraham (3):
>>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
>>
>>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>>  arch/arm/mach-exynos/common.h             |   6 +
>>  arch/arm/mach-exynos/exynos.c             |   1 +
>>  arch/arm/mach-exynos/firmware.c           |   2 -
>>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>>  arch/arm/mach-exynos/pmu.c                |   3 +-
>>  arch/arm/mach-exynos/suspend.c            |   4 +-
>>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>>  drivers/cpufreq/Kconfig.arm               |  11 --
>>  drivers/cpufreq/Makefile                  |   1 -
>>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>>  include/dt-bindings/clock/exynos5250.h    |   1 +
>>  18 files changed, 84 insertions(+), 252 deletions(-)
>>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
>> --
>
> Applied above changes into fixes/non-critical, next/cleanup-samsung,
> next/dt-samsung and next/cpufreq-clk-samsung according to the change.

Thanks!

>
> BTW since I can't see any ack from cpufreq guy for the patch "cpufreq:
> exynos: Fix for memory leak in case SOC name does not match" so I couldn't.

Indeed, my mistake. This was acked by Lukasz Majewski and Viresh
Kumar. My commit message should be fixed. Can you apply it with these
missing acks?

Best regards,
Krzysztof

Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Krzysztof Kozlowski]

2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
>> Krzysztof Kozlowski wrote:
>>>
>>> Dear Kukjin,
>>>
>>> Exynos mach-code related improvements. Description along with a tag.
>>> You can find them also on the lists with my reviewed-by.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>>
>>> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
>>>
>>>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
>>> 07-05 16:24:54 -0700)
>>>
>>> are available in the git repository at:
>>>
>>>
>>>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
>>>
>>> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
>>>
>>>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
>>>
>>> ----------------------------------------------------------------
>>> Improvements for Exynos based boards:
>>> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>>>    is removed.
>>> 2. Fix memory leak in cpufreq error path.
>>> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>>>    constant, staticize local function, drop 'owner' from
>>>    platform driver, fix cast of iomem to ERR_PTR.
>>>
>>> ----------------------------------------------------------------
>>> Bartlomiej Zolnierkiewicz (1):
>>>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
>>>
>>> Krzysztof Kozlowski (4):
>>>       ARM: EXYNOS: pmu: Make local function static
>>>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>>>       ARM: EXYNOS: pmu: Drop owner assignment
>>>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
>>>
>>> Shailendra Verma (1):
>>>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
>>>
>>> Thomas Abraham (3):
>>>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>>>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>>>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
>>>
>>>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>>>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>>>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>>>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>>>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>>>  arch/arm/mach-exynos/common.h             |   6 +
>>>  arch/arm/mach-exynos/exynos.c             |   1 +
>>>  arch/arm/mach-exynos/firmware.c           |   2 -
>>>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>>>  arch/arm/mach-exynos/pmu.c                |   3 +-
>>>  arch/arm/mach-exynos/suspend.c            |   4 +-
>>>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>>>  drivers/cpufreq/Kconfig.arm               |  11 --
>>>  drivers/cpufreq/Makefile                  |   1 -
>>>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>>>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>>>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>>>  include/dt-bindings/clock/exynos5250.h    |   1 +
>>>  18 files changed, 84 insertions(+), 252 deletions(-)
>>>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
>>> --
>>
>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.

Cc-ed Bartlomiej,

One issue found: splitting DTS change for Exynos 5250 cpufreq to
separate branch will break bisectability. The commit "ARM: dts:
Exynos5250: add CPU OPP and regulator supply property":
1. MUST be put after "clk: samsung: exynos5250: add cpu clock
configuration data and instantiate cpu clock" to prevent build
failures,
2. should be put before "ARM: Exynos: switch to using generic cpufreq
driver for Exynos5250" to prevent lost cpufreq functionality.

Doing otherwise would lose bisectability which is really unfortunate
when you can simply avoid it. This should remain in the same branch -
next/cpufreq-clk-samsung.

Best regards,
Krzysztof

Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Krzysztof Kozlowski]

On 21.07.2015 14:21, Krzysztof Kozlowski wrote:
> 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
>>> Krzysztof Kozlowski wrote:
>>>>
>>>> Dear Kukjin,
>>>>
>>>> Exynos mach-code related improvements. Description along with a tag.
>>>> You can find them also on the lists with my reviewed-by.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>>
>>>> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
>>>>
>>>>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
>>>> 07-05 16:24:54 -0700)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>
>>>>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
>>>>
>>>> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
>>>>
>>>>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
>>>>
>>>> ----------------------------------------------------------------
>>>> Improvements for Exynos based boards:
>>>> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>>>>    is removed.
>>>> 2. Fix memory leak in cpufreq error path.
>>>> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>>>>    constant, staticize local function, drop 'owner' from
>>>>    platform driver, fix cast of iomem to ERR_PTR.
>>>>
>>>> ----------------------------------------------------------------
>>>> Bartlomiej Zolnierkiewicz (1):
>>>>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
>>>>
>>>> Krzysztof Kozlowski (4):
>>>>       ARM: EXYNOS: pmu: Make local function static
>>>>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>>>>       ARM: EXYNOS: pmu: Drop owner assignment
>>>>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
>>>>
>>>> Shailendra Verma (1):
>>>>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
>>>>
>>>> Thomas Abraham (3):
>>>>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>>>>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>>>>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
>>>>
>>>>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>>>>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>>>>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>>>>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>>>>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>>>>  arch/arm/mach-exynos/common.h             |   6 +
>>>>  arch/arm/mach-exynos/exynos.c             |   1 +
>>>>  arch/arm/mach-exynos/firmware.c           |   2 -
>>>>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>>>>  arch/arm/mach-exynos/pmu.c                |   3 +-
>>>>  arch/arm/mach-exynos/suspend.c            |   4 +-
>>>>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>>>>  drivers/cpufreq/Kconfig.arm               |  11 --
>>>>  drivers/cpufreq/Makefile                  |   1 -
>>>>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>>>>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>>>>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>>>>  include/dt-bindings/clock/exynos5250.h    |   1 +
>>>>  18 files changed, 84 insertions(+), 252 deletions(-)
>>>>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
>>>> --
>>>
>>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
>>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.
> 
> Cc-ed Bartlomiej,
> 
> One issue found: splitting DTS change for Exynos 5250 cpufreq to
> separate branch will break bisectability. The commit "ARM: dts:
> Exynos5250: add CPU OPP and regulator supply property":
> 1. MUST be put after "clk: samsung: exynos5250: add cpu clock
> configuration data and instantiate cpu clock" to prevent build
> failures,
> 2. should be put before "ARM: Exynos: switch to using generic cpufreq
> driver for Exynos5250" to prevent lost cpufreq functionality.
> 
> Doing otherwise would lose bisectability which is really unfortunate
> when you can simply avoid it. This should remain in the same branch -
> next/cpufreq-clk-samsung.

Dear Kukjin,

Nothing changed since yesterday... so let me point this in a more clear
way. The way you divided the patchset causes build errors:

--------------
HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator
supply property for exynos5250

ERROR: Failed build: -A arm -c exynos on
565872a601c4d91a75b917b1fb40ff27ad7ebb08

LOGS:
Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
make[1]: *** [dtbs] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2
--------------

This breaks bisectability without any special valid reason.

Best regards,
Krzysztof

RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Kukjin Kim]

Krzysztof Kozlowski wrote:
> 
> On 21.07.2015 14:21, Krzysztof Kozlowski wrote:
> > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> >>> Krzysztof Kozlowski wrote:

[...]

> >>>> --
> >>>
> >>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
> >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.
> >
> > Cc-ed Bartlomiej,
> >
> > One issue found: splitting DTS change for Exynos 5250 cpufreq to
> > separate branch will break bisectability. The commit "ARM: dts:
> > Exynos5250: add CPU OPP and regulator supply property":
> > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock
> > configuration data and instantiate cpu clock" to prevent build
> > failures,
> > 2. should be put before "ARM: Exynos: switch to using generic cpufreq
> > driver for Exynos5250" to prevent lost cpufreq functionality.
> >
> > Doing otherwise would lose bisectability which is really unfortunate
> > when you can simply avoid it. This should remain in the same branch -
> > next/cpufreq-clk-samsung.
> 
> Dear Kukjin,
> 
> Nothing changed since yesterday... so let me point this in a more clear
> way. The way you divided the patchset causes build errors:
> 
> --------------
> HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator
> supply property for exynos5250
> 
> ERROR: Failed build: -A arm -c exynos on
> 565872a601c4d91a75b917b1fb40ff27ad7ebb08
> 
> LOGS:
> Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
> make[1]: *** [dtbs] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> --------------
> 
> This breaks bisectability without any special valid reason.
> 
Hi,

I couldn't check e-mail yesterday because of annual health check.
Anyway, I'll look at the error and handle it soon.

Thanks for your check.
Kukjin

RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Kukjin Kim]

Kukjin Kim wrote:
> 
> Krzysztof Kozlowski wrote:
> >
> > On 21.07.2015 14:21, Krzysztof Kozlowski wrote:
> > > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> > >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> > >>> Krzysztof Kozlowski wrote:
> 
> [...]
> 
> > >>>> --
> > >>>
> > >>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
> > >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.
> > >
> > > Cc-ed Bartlomiej,
> > >
> > > One issue found: splitting DTS change for Exynos 5250 cpufreq to
> > > separate branch will break bisectability. The commit "ARM: dts:
> > > Exynos5250: add CPU OPP and regulator supply property":
> > > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock
> > > configuration data and instantiate cpu clock" to prevent build
> > > failures,
> > > 2. should be put before "ARM: Exynos: switch to using generic cpufreq
> > > driver for Exynos5250" to prevent lost cpufreq functionality.
> > >
> > > Doing otherwise would lose bisectability which is really unfortunate
> > > when you can simply avoid it. This should remain in the same branch -
> > > next/cpufreq-clk-samsung.
> >
> > Dear Kukjin,
> >
> > Nothing changed since yesterday... so let me point this in a more clear
> > way. The way you divided the patchset causes build errors:
> >
> > --------------
> > HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator
> > supply property for exynos5250
> >
> > ERROR: Failed build: -A arm -c exynos on
> > 565872a601c4d91a75b917b1fb40ff27ad7ebb08
> >
> > LOGS:
> > Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error
> > FATAL ERROR: Unable to parse input tree
> > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
> > make[1]: *** [dtbs] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [sub-make] Error 2
> > --------------
> >
> > This breaks bisectability without any special valid reason.
> >
> Hi,
> 
> I couldn't check e-mail yesterday because of annual health check.
> Anyway, I'll look at the error and handle it soon.
> 
OK, the change for the include/dt-bindings/clock/exynos5250.h file which is in
next/cpufreq-clk-samsung branch should be provided in next/dt-samsung branch.
It should be fine tonight in my time.

One more thing, the splitting changes into dt and driver side would be required
generally and if it has dependency like this, proper merge topic branch is
required by maintainer. But I've missed last action :(

Thanks,
Kukjin

Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

[Krzysztof Kozlowski]

On 23.07.2015 17:11, Kukjin Kim wrote:
> Kukjin Kim wrote:
>>
>> Krzysztof Kozlowski wrote:
>>>
>>> On 21.07.2015 14:21, Krzysztof Kozlowski wrote:
>>>> 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>>>>> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
>>>>>> Krzysztof Kozlowski wrote:
>>
>> [...]
>>
>>>>>>> --
>>>>>>
>>>>>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
>>>>>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.
>>>>
>>>> Cc-ed Bartlomiej,
>>>>
>>>> One issue found: splitting DTS change for Exynos 5250 cpufreq to
>>>> separate branch will break bisectability. The commit "ARM: dts:
>>>> Exynos5250: add CPU OPP and regulator supply property":
>>>> 1. MUST be put after "clk: samsung: exynos5250: add cpu clock
>>>> configuration data and instantiate cpu clock" to prevent build
>>>> failures,
>>>> 2. should be put before "ARM: Exynos: switch to using generic cpufreq
>>>> driver for Exynos5250" to prevent lost cpufreq functionality.
>>>>
>>>> Doing otherwise would lose bisectability which is really unfortunate
>>>> when you can simply avoid it. This should remain in the same branch -
>>>> next/cpufreq-clk-samsung.
>>>
>>> Dear Kukjin,
>>>
>>> Nothing changed since yesterday... so let me point this in a more clear
>>> way. The way you divided the patchset causes build errors:
>>>
>>> --------------
>>> HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator
>>> supply property for exynos5250
>>>
>>> ERROR: Failed build: -A arm -c exynos on
>>> 565872a601c4d91a75b917b1fb40ff27ad7ebb08
>>>
>>> LOGS:
>>> Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error
>>> FATAL ERROR: Unable to parse input tree
>>> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
>>> make[1]: *** [dtbs] Error 2
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [sub-make] Error 2
>>> --------------
>>>
>>> This breaks bisectability without any special valid reason.
>>>
>> Hi,
>>
>> I couldn't check e-mail yesterday because of annual health check.
>> Anyway, I'll look at the error and handle it soon.
>>
> OK, the change for the include/dt-bindings/clock/exynos5250.h file which is in
> next/cpufreq-clk-samsung branch should be provided in next/dt-samsung branch.
> It should be fine tonight in my time.
> 
> One more thing, the splitting changes into dt and driver side would be required
> generally and if it has dependency like this, proper merge topic branch is
> required by maintainer. But I've missed last action :(

You prepared a topic branch - next/cpufreq-clk-samsung. I think
everything can be put in it and this would solve any issues.

Best regards,
Krzysztof