* [PATCH V4] iio: declare struct to fix warning
@ 2015-08-04 8:32 Pengyu Ma
2015-08-08 11:29 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Pengyu Ma @ 2015-08-04 8:32 UTC (permalink / raw)
To: jic23, linux-kernel, linux-iio, pengyu.ma
When compile iio related driver the following warning shown:
include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
int (*set_trigger_state)(struct iio_trigger *trig, bool state);
include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
struct iio_dev *indio_dev);
'struct iio_dev' and 'struct iio_trigger' was used before declaration,
forward declaration for these structs to fix warning.
Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
---
include/linux/iio/trigger.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index fa76c79..1c9e028 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -18,6 +18,9 @@ struct iio_subirq {
bool enabled;
};
+struct iio_dev;
+struct iio_trigger;
+
/**
* struct iio_trigger_ops - operations structure for an iio_trigger.
* @owner: used to monitor usage count of the trigger.
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V4] iio: declare struct to fix warning
2015-08-04 8:32 [PATCH V4] iio: declare struct to fix warning Pengyu Ma
@ 2015-08-08 11:29 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-08-08 11:29 UTC (permalink / raw)
To: Pengyu Ma, linux-kernel, linux-iio
On 04/08/15 09:32, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
> int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
> struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
As we have had no reports of a case of this causing trouble for
a mainlined driver, and we are reasonably late in the current cycle,
I have applied this for the next merge windows (togreg branch) rather
than sending it the fast way as a fix.
Note togreg will be initially pushed out as testing to the let the
autobuilders play with it.
Thanks,
Jonathan
> ---
> include/linux/iio/trigger.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..1c9e028 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,9 @@ struct iio_subirq {
> bool enabled;
> };
>
> +struct iio_dev;
> +struct iio_trigger;
> +
> /**
> * struct iio_trigger_ops - operations structure for an iio_trigger.
> * @owner: used to monitor usage count of the trigger.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-08 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-04 8:32 [PATCH V4] iio: declare struct to fix warning Pengyu Ma
2015-08-08 11:29 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).