* [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
@ 2015-08-11 7:46 Shawn Lin
2015-08-11 14:53 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Lin @ 2015-08-11 7:46 UTC (permalink / raw)
To: Michal Simek, soren.brinkmann
Cc: Ulf Hansson, linux-kernel, devicetree, Shawn Lin
This patch adds the compatible string in sdhci-of-arasan.c to
support sdhci-arasan5.1 version of controller. No documented
controller IP version is found in the TRM, so we use ths version
of command queueing engine integrated into this controller by arasan
to specify our controller.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
Changes in v1:
- Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, sdhci-5.1" since
SDHCI will check "host->max_clk == 0" and let driver get it from host->ops->get_max_clock.
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
drivers/mmc/host/sdhci-of-arasan.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index 7e94903..da541c3 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
@@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
Required Properties:
- compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
- 'arasan,sdhci-4.9a'
+ 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
- reg: From mmc bindings: Register location and length.
- clocks: From clock bindings: Handles to clock inputs.
- clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index ef5a7d2..75379cb 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
static const struct of_device_id sdhci_arasan_of_match[] = {
{ .compatible = "arasan,sdhci-8.9a" },
+ { .compatible = "arasan,sdhci-5.1" },
{ .compatible = "arasan,sdhci-4.9a" },
{ }
};
--
2.3.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
2015-08-11 7:46 [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1 Shawn Lin
@ 2015-08-11 14:53 ` Michal Simek
2015-08-12 5:07 ` Michal Simek
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2015-08-11 14:53 UTC (permalink / raw)
To: Shawn Lin, Michal Simek, soren.brinkmann
Cc: Ulf Hansson, linux-kernel, devicetree
On 08/11/2015 09:46 AM, Shawn Lin wrote:
> This patch adds the compatible string in sdhci-of-arasan.c to
> support sdhci-arasan5.1 version of controller. No documented
> controller IP version is found in the TRM, so we use ths version
> of command queueing engine integrated into this controller by arasan
> to specify our controller.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> ---
>
> Changes in v1:
> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, sdhci-5.1" since
> SDHCI will check "host->max_clk == 0" and let driver get it from host->ops->get_max_clock.
>
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
> drivers/mmc/host/sdhci-of-arasan.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 7e94903..da541c3 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>
> Required Properties:
> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
> - 'arasan,sdhci-4.9a'
> + 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
> - reg: From mmc bindings: Register location and length.
> - clocks: From clock bindings: Handles to clock inputs.
> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index ef5a7d2..75379cb 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
>
> static const struct of_device_id sdhci_arasan_of_match[] = {
> { .compatible = "arasan,sdhci-8.9a" },
> + { .compatible = "arasan,sdhci-5.1" },
> { .compatible = "arasan,sdhci-4.9a" },
> { }
> };
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
2015-08-11 14:53 ` Michal Simek
@ 2015-08-12 5:07 ` Michal Simek
2015-08-17 23:40 ` Shawn Lin
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2015-08-12 5:07 UTC (permalink / raw)
To: Shawn Lin, Michal Simek, soren.brinkmann
Cc: Ulf Hansson, linux-kernel, devicetree, linux-mmc
+linux-mmc
On 08/11/2015 04:53 PM, Michal Simek wrote:
> On 08/11/2015 09:46 AM, Shawn Lin wrote:
>> This patch adds the compatible string in sdhci-of-arasan.c to
>> support sdhci-arasan5.1 version of controller. No documented
>> controller IP version is found in the TRM, so we use ths version
>> of command queueing engine integrated into this controller by arasan
>> to specify our controller.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>
>> ---
>>
>> Changes in v1:
>> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, sdhci-5.1" since
>> SDHCI will check "host->max_clk == 0" and let driver get it from host->ops->get_max_clock.
>>
>> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
>> drivers/mmc/host/sdhci-of-arasan.c | 1 +
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> index 7e94903..da541c3 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>>
>> Required Properties:
>> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
>> - 'arasan,sdhci-4.9a'
>> + 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
>> - reg: From mmc bindings: Register location and length.
>> - clocks: From clock bindings: Handles to clock inputs.
>> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index ef5a7d2..75379cb 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
>>
>> static const struct of_device_id sdhci_arasan_of_match[] = {
>> { .compatible = "arasan,sdhci-8.9a" },
>> + { .compatible = "arasan,sdhci-5.1" },
>> { .compatible = "arasan,sdhci-4.9a" },
>> { }
>> };
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
2015-08-12 5:07 ` Michal Simek
@ 2015-08-17 23:40 ` Shawn Lin
2015-08-25 12:07 ` Ulf Hansson
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Lin @ 2015-08-17 23:40 UTC (permalink / raw)
To: Ulf Hansson
Cc: Michal Simek, soren.brinkmann, shawn.lin, linux-kernel,
devicetree, linux-mmc
Hi Ulf,
On 2015/8/12 13:07, Michal Simek wrote:
> +linux-mmc
>
> On 08/11/2015 04:53 PM, Michal Simek wrote:
>> On 08/11/2015 09:46 AM, Shawn Lin wrote:
>>> This patch adds the compatible string in sdhci-of-arasan.c to
>>> support sdhci-arasan5.1 version of controller. No documented
>>> controller IP version is found in the TRM, so we use ths version
>>> of command queueing engine integrated into this controller by arasan
>>> to specify our controller.
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>
>>> ---
>>>
>>> Changes in v1:
>>> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, sdhci-5.1" since
>>> SDHCI will check "host->max_clk == 0" and let driver get it from host->ops->get_max_clock.
>>>
>>> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
>>> drivers/mmc/host/sdhci-of-arasan.c | 1 +
>>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> index 7e94903..da541c3 100644
>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>>>
>>> Required Properties:
>>> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
>>> - 'arasan,sdhci-4.9a'
>>> + 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
>>> - reg: From mmc bindings: Register location and length.
>>> - clocks: From clock bindings: Handles to clock inputs.
>>> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>>> index ef5a7d2..75379cb 100644
>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
>>>
>>> static const struct of_device_id sdhci_arasan_of_match[] = {
>>> { .compatible = "arasan,sdhci-8.9a" },
>>> + { .compatible = "arasan,sdhci-5.1" },
>>> { .compatible = "arasan,sdhci-4.9a" },
>>> { }
>>> };
>>>
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
Could you pull this patch into your repository?
>>
>> Thanks,
>> Michal
>>
>>
>
>
>
>
--
Shawn Lin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
2015-08-17 23:40 ` Shawn Lin
@ 2015-08-25 12:07 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2015-08-25 12:07 UTC (permalink / raw)
To: Shawn Lin
Cc: Michal Simek, Sören Brinkmann, linux-kernel, devicetree, linux-mmc
On 18 August 2015 at 01:40, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Hi Ulf,
>
>
> On 2015/8/12 13:07, Michal Simek wrote:
>>
>> +linux-mmc
>>
>> On 08/11/2015 04:53 PM, Michal Simek wrote:
>>>
>>> On 08/11/2015 09:46 AM, Shawn Lin wrote:
>>>>
>>>> This patch adds the compatible string in sdhci-of-arasan.c to
>>>> support sdhci-arasan5.1 version of controller. No documented
>>>> controller IP version is found in the TRM, so we use ths version
>>>> of command queueing engine integrated into this controller by arasan
>>>> to specify our controller.
>>>>
>>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v1:
>>>> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan,
>>>> sdhci-5.1" since
>>>> SDHCI will check "host->max_clk == 0" and let driver get it from
>>>> host->ops->get_max_clock.
>>>>
>>>> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
>>>> drivers/mmc/host/sdhci-of-arasan.c | 1 +
>>>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> index 7e94903..da541c3 100644
>>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>>> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>>>>
>>>> Required Properties:
>>>> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
>>>> - 'arasan,sdhci-4.9a'
>>>> + 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
>>>> - reg: From mmc bindings: Register location and length.
>>>> - clocks: From clock bindings: Handles to clock inputs.
>>>> - clock-names: From clock bindings: Tuple including "clk_xin" and
>>>> "clk_ahb"
>>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c
>>>> b/drivers/mmc/host/sdhci-of-arasan.c
>>>> index ef5a7d2..75379cb 100644
>>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>>> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct
>>>> platform_device *pdev)
>>>>
>>>> static const struct of_device_id sdhci_arasan_of_match[] = {
>>>> { .compatible = "arasan,sdhci-8.9a" },
>>>> + { .compatible = "arasan,sdhci-5.1" },
>>>> { .compatible = "arasan,sdhci-4.9a" },
>>>> { }
>>>> };
>>>>
>>>
>>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
>
> Could you pull this patch into your repository?
>
Thanks, applied for next!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
@ 2015-08-11 7:57 Shawn Lin
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Lin @ 2015-08-11 7:57 UTC (permalink / raw)
To: Michal Simek, soren.brinkmann
Cc: Ulf Hansson, linux-kernel, devicetree, linux-mmc, Shawn Lin
This patch adds the compatible string in sdhci-of-arasan.c to
support sdhci-arasan5.1 version of controller. No documented
controller IP version is found in the TRM, so we use ths version
of command queueing engine integrated into this controller by arasan
to specify our controller.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
Changes in v1:
- Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, sdhci-5.1" since
SDHCI will check "host->max_clk == 0" and let driver get it from host->ops->get_max_clock.
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
drivers/mmc/host/sdhci-of-arasan.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index 7e94903..da541c3 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
@@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
Required Properties:
- compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
- 'arasan,sdhci-4.9a'
+ 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
- reg: From mmc bindings: Register location and length.
- clocks: From clock bindings: Handles to clock inputs.
- clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index ef5a7d2..75379cb 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
static const struct of_device_id sdhci_arasan_of_match[] = {
{ .compatible = "arasan,sdhci-8.9a" },
+ { .compatible = "arasan,sdhci-5.1" },
{ .compatible = "arasan,sdhci-4.9a" },
{ }
};
--
2.3.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-25 12:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-11 7:46 [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1 Shawn Lin
2015-08-11 14:53 ` Michal Simek
2015-08-12 5:07 ` Michal Simek
2015-08-17 23:40 ` Shawn Lin
2015-08-25 12:07 ` Ulf Hansson
2015-08-11 7:57 Shawn Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).