linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver
@ 2015-09-03 11:06 Luis de Bethencourt
  2015-09-03 15:24 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-03 11:06 UTC (permalink / raw)
  To: linux-kernel; +Cc: Wim Van Sebroeck, linux-watchdog, Javier Martinez Canillas

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
 drivers/watchdog/moxart_wdt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
index 2789da2..60b0605 100644
--- a/drivers/watchdog/moxart_wdt.c
+++ b/drivers/watchdog/moxart_wdt.c
@@ -168,6 +168,7 @@ static const struct of_device_id moxart_watchdog_match[] = {
 	{ .compatible = "moxa,moxart-watchdog" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, moxart_watchdog_match);
 
 static struct platform_driver moxart_wdt_driver = {
 	.probe      = moxart_wdt_probe,
-- 
2.4.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver
  2015-09-03 11:06 [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-03 15:24 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2015-09-03 15:24 UTC (permalink / raw)
  To: Luis de Bethencourt, linux-kernel
  Cc: Wim Van Sebroeck, linux-watchdog, Javier Martinez Canillas

On 09/03/2015 04:06 AM, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/moxart_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
> index 2789da2..60b0605 100644
> --- a/drivers/watchdog/moxart_wdt.c
> +++ b/drivers/watchdog/moxart_wdt.c
> @@ -168,6 +168,7 @@ static const struct of_device_id moxart_watchdog_match[] = {
>   	{ .compatible = "moxa,moxart-watchdog" },
>   	{ },
>   };
> +MODULE_DEVICE_TABLE(of, moxart_watchdog_match);
>
>   static struct platform_driver moxart_wdt_driver = {
>   	.probe      = moxart_wdt_probe,
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-03 15:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-03 11:06 [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-03 15:24 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).