* [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC
@ 2015-10-06 12:13 Tony Lindgren
2015-10-06 12:18 ` Roger Quadros
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2015-10-06 12:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Roger Quadros, linux-omap
Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug")
added a debug option for GPMC, but somehow managed to keep it unselectable.
This probably happened because I had some uncommitted changes and the
GPMC option is selected in the platform specific Kconfig.
Let's also update the description a bit, it does not mention that
enabling the debug option also disables the reset of GPMC controller
during the init as pointed out by Uwe Kleine-König
<u.kleine-koenig@pengutronix.de>.
Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug")
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/memory/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -58,12 +58,13 @@ config OMAP_GPMC
memory drives like NOR, NAND, OneNAND, SRAM.
config OMAP_GPMC_DEBUG
- bool
+ bool "Enable GPMC debug output and skip reset of GPMC during init"
depends on OMAP_GPMC
help
Enables verbose debugging mostly to decode the bootloader provided
- timings. Enable this during development to configure devices
- connected to the GPMC bus.
+ timings. To preserve the bootloader provided timings, the reset
+ of GPMC is skipped during init. Enable this during development to
+ configure devices connected to the GPMC bus.
config MVEBU_DEVBUS
bool "Marvell EBU Device Bus Controller"
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC
2015-10-06 12:13 [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC Tony Lindgren
@ 2015-10-06 12:18 ` Roger Quadros
0 siblings, 0 replies; 2+ messages in thread
From: Roger Quadros @ 2015-10-06 12:18 UTC (permalink / raw)
To: Tony Lindgren, linux-kernel; +Cc: linux-omap
On 06/10/15 15:13, Tony Lindgren wrote:
> Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug")
> added a debug option for GPMC, but somehow managed to keep it unselectable.
>
> This probably happened because I had some uncommitted changes and the
> GPMC option is selected in the platform specific Kconfig.
>
> Let's also update the description a bit, it does not mention that
> enabling the debug option also disables the reset of GPMC controller
> during the init as pointed out by Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de>.
>
> Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug")
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/memory/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -58,12 +58,13 @@ config OMAP_GPMC
> memory drives like NOR, NAND, OneNAND, SRAM.
>
> config OMAP_GPMC_DEBUG
> - bool
> + bool "Enable GPMC debug output and skip reset of GPMC during init"
> depends on OMAP_GPMC
> help
> Enables verbose debugging mostly to decode the bootloader provided
> - timings. Enable this during development to configure devices
> - connected to the GPMC bus.
> + timings. To preserve the bootloader provided timings, the reset
> + of GPMC is skipped during init. Enable this during development to
> + configure devices connected to the GPMC bus.
>
> config MVEBU_DEVBUS
> bool "Marvell EBU Device Bus Controller"
>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-06 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06 12:13 [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC Tony Lindgren
2015-10-06 12:18 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).