From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mans Rullgard <mans@mansr.com>, Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs
Date: Wed, 7 Oct 2015 14:31:59 +0200 [thread overview]
Message-ID: <561510BF.7050207@linaro.org> (raw)
In-Reply-To: <56150369.2050609@sigmadesigns.com>
On 10/07/2015 01:35 PM, Marc Gonzalez wrote:
> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
> Use it for clocksource, sched_clock, and delay_timer.
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
> AFAICS, clocksource_register_hz does not report failures via its
> return value (always 0) but writes warnings to stdout?
Yeah, it returns always 0. I suggest you assume it is returning an error
code, that will be safer for future changes in the framework (if any).
> Open question: can I call register_current_timer_delay,
> sched_clock_register, clocksource_register_hz in any order?
> ---
Yes, I think so. Thomas ?
[ ... ]
> +static void __init tango_clocksource_init(struct device_node *np)
> +{
> + struct clk *clk = of_clk_get(np, 0);
> + unsigned int xtal_freq = clk_get_rate(clk);
> + xtal_in_cnt = of_iomap(np, 0);
> + if (xtal_in_cnt == NULL)
> + panic("%s: of_iomap failed\n", np->full_name);
^^^^^^^^^^^
That does not comply with the Linux kernel coding style.
xtal_in_cnt = of_iomap(np, 0);
if (!xtal_in_cnt) {
pr_err("Argh!");
return;
}
clk = of_clk_get(np, 0);
if (!clk) {
pr_err("grumf!");
return;
}
freq = clk_get_rate(clk);
> +
> + delay_timer.freq = xtal_freq;
> + delay_timer.read_current_timer = read_xtal_counter;
> + register_current_timer_delay(&delay_timer);
> + sched_clock_register(read_sched_clock, 32, xtal_freq);
> + clocksource_register_hz(&tango_xtal, xtal_freq);
ret = clocksource_register_hz(&tango_xtal, xtal_freq);
if (ret) {
pr_err("oups!");
return;
}
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-10-07 12:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 15:10 [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez
2015-10-06 23:09 ` Daniel Lezcano
2015-10-07 8:23 ` Marc Gonzalez
2015-10-07 9:47 ` Daniel Lezcano
2015-10-07 11:14 ` Marc Gonzalez
2015-10-07 11:35 ` Daniel Lezcano
2015-10-07 11:35 ` [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez
2015-10-07 12:31 ` Daniel Lezcano [this message]
2015-10-07 13:17 ` Marc Gonzalez
2015-10-07 16:03 ` Daniel Lezcano
2015-10-07 20:12 ` Mason
2015-10-09 12:13 ` [PATCH v3] " Marc Gonzalez
2015-10-09 13:24 ` Daniel Lezcano
2015-10-09 13:46 ` Marc Gonzalez
2015-10-09 14:21 ` Daniel Lezcano
2015-10-09 16:39 ` Nicolas Pitre
2015-10-09 14:37 ` [PATCH v4] " Marc Gonzalez
2015-10-09 14:42 ` Daniel Lezcano
2015-10-09 14:59 ` [PATCH v5] " Marc Gonzalez
2015-10-16 12:07 ` Daniel Lezcano
2015-10-09 14:51 ` [PATCH v4] " Måns Rullgård
2015-10-09 15:42 ` Marc Gonzalez
2015-10-09 16:01 ` Måns Rullgård
2015-10-09 16:36 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561510BF.7050207@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=slash.tmp@free.fr \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).