From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
To: Mans Rullgard <mans@mansr.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>, Mason <slash.tmp@free.fr>,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs
Date: Fri, 9 Oct 2015 18:36:01 +0200 [thread overview]
Message-ID: <5617ECF1.7040605@sigmadesigns.com> (raw)
In-Reply-To: <yw1x37xkjajn.fsf@unicorn.mansr.com>
On 09/10/2015 18:01, Måns Rullgård wrote:
> Marc Gonzalez wrote:
>
>> Måns Rullgård wrote:
>>
>>> Marc Gonzalez wrote:
>>>
>>>> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
>>>> Use it for clocksource, sched_clock, and delay_timer.
>>>
>>> Given the nature of this hardware, I think it would make much more sense
>>> to support it in a generic fashion. Otherwise the next chip that comes
>>> along with a similar counter will result in near duplicate of this
>>> "driver", and so on.
>>
>> I didn't /want/ to write this driver, or rather this "driver" as you put it
>> (implying that it is so trivial that I am lame even to submit it). It was
>> living happily in arch/arm/clock-tango.c, but Arnd pointed out that such
>> code must migrate to drivers/clocksource.
>>
>> I find your claim that this minimal device (a single register really) should
>> be supported in a generic fashion questionable. No one seems to have ever
>> needed this, yet it has suddenly become urgent to have it right now?
>
> Apparently, nobody has needed it before (I can't say for sure that no
> existing drivers could be simplified). That doesn't mean that nobody
> will need it again. When something can be supported in a generic way,
> it is usually a good idea to do that. It saves work in the long term.
You snipped this:
I would probably have used your driver had it been mainlined.
(Also note that your driver doesn't set up the delay timer, which I want.)
>> I'm sorry if my mainlining effort is not compatible with your schedule, but
>> I've been working on this port for 6 months, and I can't wait a few more
>> weeks just because you're not quite ready. (Have you mainstreamed the eth
>> and intc driver? I would actually need those.)
>
> You (Sigma)
I am not Sigma, I am Marc. I am a software dev grunt, and I have
no influence on recruitment process, business decisions, etc.
> had the chance to contract me to help out with this work and
> strongly indicated ("we will send you a contract for review by the end
> of the week") that you would. Then you backtracked in a rather ugly
> manner.
I am sorry that you were treated like that :-(
> Forgive me if I'm less than motivated to suddenly spend hours
> of unpaid time helping you get things in shape.
<confused> I am just asking that you stop popping up on MLs NAKing
each one of my patches.
> If you don't want to pay me, you also don't get to set my schedule.
<confused> Are you referring to the DT changes I've asked you to make?
> Besides, you've never
> shown any interest whatsoever in upstreaming before, so I really don't
> see why it is so urgent for you now.
Trying to turn the tables, nice :-)
It is urgent because I have been working full-time on this for two months,
and I'd like to have results to show for it. (Management is not convinced
that upstreaming is a good idea.)
If you take a step back, you'll see that I have accepted your input and
criticism every time I thought it was warranted, e.g. everything UART
related. (And why would I not? It's nice to benefit from great work.)
But your claims regarding the clock tree are inaccurate. (I'll address
them in a separate message.)
Regards.
prev parent reply other threads:[~2015-10-09 16:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 15:10 [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez
2015-10-06 23:09 ` Daniel Lezcano
2015-10-07 8:23 ` Marc Gonzalez
2015-10-07 9:47 ` Daniel Lezcano
2015-10-07 11:14 ` Marc Gonzalez
2015-10-07 11:35 ` Daniel Lezcano
2015-10-07 11:35 ` [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez
2015-10-07 12:31 ` Daniel Lezcano
2015-10-07 13:17 ` Marc Gonzalez
2015-10-07 16:03 ` Daniel Lezcano
2015-10-07 20:12 ` Mason
2015-10-09 12:13 ` [PATCH v3] " Marc Gonzalez
2015-10-09 13:24 ` Daniel Lezcano
2015-10-09 13:46 ` Marc Gonzalez
2015-10-09 14:21 ` Daniel Lezcano
2015-10-09 16:39 ` Nicolas Pitre
2015-10-09 14:37 ` [PATCH v4] " Marc Gonzalez
2015-10-09 14:42 ` Daniel Lezcano
2015-10-09 14:59 ` [PATCH v5] " Marc Gonzalez
2015-10-16 12:07 ` Daniel Lezcano
2015-10-09 14:51 ` [PATCH v4] " Måns Rullgård
2015-10-09 15:42 ` Marc Gonzalez
2015-10-09 16:01 ` Måns Rullgård
2015-10-09 16:36 ` Marc Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5617ECF1.7040605@sigmadesigns.com \
--to=marc_gonzalez@sigmadesigns.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=slash.tmp@free.fr \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).