[PATCH] iio: mxs-lradc: Fix temperature offset

[PATCH] iio: mxs-lradc: Fix temperature offset

[Alexandre Belloni]

0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.

Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index 3f7715c9968b..67bfa54c4fb1 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
 		if (chan->type == IIO_TEMP) {
 			/* The calculated value from the ADC is in Kelvin, we
 			 * want Celsius for hwmon so the offset is
-			 * -272.15 * scale
+			 * -273.15 * scale
 			 */
-			*val = -1075;
-			*val2 = 691699;
+			*val = -1079;
+			*val2 = 644268;
 
 			return IIO_VAL_INT_PLUS_MICRO;
 		}
-- 
2.1.4

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Stefan Wahren]

Hi,

> Alexandre Belloni <alexandre.belloni@free-electrons.com> hat am 6. Oktober
> 2015 um 16:22 geschrieben:
>
>
> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>
> Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> b/drivers/staging/iio/adc/mxs-lradc.c
> index 3f7715c9968b..67bfa54c4fb1 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
> if (chan->type == IIO_TEMP) {
> /* The calculated value from the ADC is in Kelvin, we
> * want Celsius for hwmon so the offset is
> - * -272.15 * scale
> + * -273.15 * scale
> */
> - *val = -1075;
> - *val2 = 691699;
> + *val = -1079;
> + *val2 = 644268;
>

i think it would be nice to break down the calculation of these magic values in
a second patch.

Regards
Stefan

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Marek Vasut]

On 10/06/2015 16:22, Alexandre Belloni wrote:
> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>
> Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Nice find :-)

Acked-by: Marek Vasut <marex@denx.de>

(I am using different MUA, please pardon the possible issues)

> ---
>   drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index 3f7715c9968b..67bfa54c4fb1 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>   		if (chan->type == IIO_TEMP) {
>   			/* The calculated value from the ADC is in Kelvin, we
>   			 * want Celsius for hwmon so the offset is
> -			 * -272.15 * scale
> +			 * -273.15 * scale
>   			 */
> -			*val = -1075;
> -			*val2 = 691699;
> +			*val = -1079;
> +			*val2 = 644268;
>
>   			return IIO_VAL_INT_PLUS_MICRO;
>   		}
>

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Marek Vasut]

On 10/06/2015 20:43, Stefan Wahren wrote:
> Hi,
>
>> Alexandre Belloni <alexandre.belloni@free-electrons.com> hat am 6. Oktober
>> 2015 um 16:22 geschrieben:
>>
>>
>> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>>
>> Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> ---
>> drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
>> b/drivers/staging/iio/adc/mxs-lradc.c
>> index 3f7715c9968b..67bfa54c4fb1 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>> if (chan->type == IIO_TEMP) {
>> /* The calculated value from the ADC is in Kelvin, we
>> * want Celsius for hwmon so the offset is
>> - * -272.15 * scale
>> + * -273.15 * scale
>> */
>> - *val = -1075;
>> - *val2 = 691699;
>> + *val = -1079;
>> + *val2 = 644268;
>>
>
> i think it would be nice to break down the calculation of these magic values in
> a second patch.

Indeed, I agree. I hope Alexandre can send another patch for that soon :-)

> Regards
> Stefan
>

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Alexandre Belloni]

Hi,

On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote :
> >>/* The calculated value from the ADC is in Kelvin, we
> >>* want Celsius for hwmon so the offset is
> >>- * -272.15 * scale
> >>+ * -273.15 * scale
> >>*/
> >>- *val = -1075;
> >>- *val2 = 691699;
> >>+ *val = -1079;
> >>+ *val2 = 644268;
> >>
> >
> >i think it would be nice to break down the calculation of these magic values in
> >a second patch.
> 
> Indeed, I agree. I hope Alexandre can send another patch for that soon :-)
> 

On my side, I'm not sure this is worth more than a comment. If
necessary, I can write that the datasheet specifies that the scale is
4/1.012 here also.

Else you end up with something like that (naive implementation):

#define SCALE (4 * 1000 / 1012)

val = -273150000 * SCALE / 1000000;
val2 = 273150000 * SCALE + 1000000 * val;

I don't feel this is any clearer because we can't use floating points in
the kernel anyway.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Stefan Wahren]

Am 07.10.2015 um 02:44 schrieb Alexandre Belloni:
> Hi,
>
> On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote :
>>>> /* The calculated value from the ADC is in Kelvin, we
>>>> * want Celsius for hwmon so the offset is
>>>> - * -272.15 * scale
>>>> + * -273.15 * scale
>>>> */
>>>> - *val = -1075;
>>>> - *val2 = 691699;
>>>> + *val = -1079;
>>>> + *val2 = 644268;
>>>>
>>> i think it would be nice to break down the calculation of these magic values in
>>> a second patch.
>> Indeed, I agree. I hope Alexandre can send another patch for that soon :-)
>>
> On my side, I'm not sure this is worth more than a comment. If
> necessary, I can write that the datasheet specifies that the scale is
> 4/1.012 here also.

I'm okay with that.

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Marek Vasut]

On Wednesday, October 07, 2015 at 09:12:56 AM, Stefan Wahren wrote:
> Am 07.10.2015 um 02:44 schrieb Alexandre Belloni:
> > Hi,
> > 
> > On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote :
> >>>> /* The calculated value from the ADC is in Kelvin, we
> >>>> * want Celsius for hwmon so the offset is
> >>>> - * -272.15 * scale
> >>>> + * -273.15 * scale
> >>>> */
> >>>> - *val = -1075;
> >>>> - *val2 = 691699;
> >>>> + *val = -1079;
> >>>> + *val2 = 644268;
> >>> 
> >>> i think it would be nice to break down the calculation of these magic
> >>> values in a second patch.
> >> 
> >> Indeed, I agree. I hope Alexandre can send another patch for that soon
> >> :-)
> > 
> > On my side, I'm not sure this is worth more than a comment. If
> > necessary, I can write that the datasheet specifies that the scale is
> > 4/1.012 here also.
> 
> I'm okay with that.

I'm fine either way, it's not worth wasting more time on this trivial stuff.
I'd say just pick this one.

Best regards,
Marek Vasut

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Jonathan Cameron]

On 07/10/15 00:13, Marek Vasut wrote:
> On 10/06/2015 16:22, Alexandre Belloni wrote:
>> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>>
>> Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> Nice find :-)
> 
> Acked-by: Marek Vasut <marex@denx.de>
Ah, missed this when applying.  Have added your Ack to the V2 and will
push it out later.

J
> 
> (I am using different MUA, please pardon the possible issues)
> 
>> ---
>>   drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
>> index 3f7715c9968b..67bfa54c4fb1 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>>           if (chan->type == IIO_TEMP) {
>>               /* The calculated value from the ADC is in Kelvin, we
>>                * want Celsius for hwmon so the offset is
>> -             * -272.15 * scale
>> +             * -273.15 * scale
>>                */
>> -            *val = -1075;
>> -            *val2 = 691699;
>> +            *val = -1079;
>> +            *val2 = 644268;
>>
>>               return IIO_VAL_INT_PLUS_MICRO;
>>           }
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html