From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: andrew-ct.chen@mediatek.com
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com
Subject: Re: [PATCH 1/3] dt-bindings: add document of mediatek efuse driver
Date: Mon, 26 Oct 2015 09:56:14 +0000 [thread overview]
Message-ID: <562DF8BE.4060205@linaro.org> (raw)
In-Reply-To: <1444984751-4572-2-git-send-email-andrew-ct.chen@mediatek.com>
On 16/10/15 09:39, andrew-ct.chen@mediatek.com wrote:
> From: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
>
> Add Mediatek MT8173 EFUSE Devicetree binding file
>
> Signed-off-by: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
Looks good to me, minor comment below.
Will queue this for v4.5 once v4.4-rc1 is released.
> ---
> .../devicetree/bindings/nvmem/mtk-efuse.txt | 36 ++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
>
> diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> new file mode 100644
> index 0000000..92edc3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> @@ -0,0 +1,36 @@
> += Mediatek MTK-EFUSE device tree bindings =
> +
> +This binding is intended to represent MTK-EFUSE which is found in most Mediatek SOCs.
> +
> +Required properties:
> +- compatible: should be "mediatek,mt8173-efuse" or "mediatek,mt8135-efuse"
Can we make the compatible more generic for mediatek socs? Like
"mediatek,efuse" Or are they different in each SOC?
--srini
> +- reg: Should contain registers location and length
> +
> += Data cells =
> +Are child nodes of MTK-EFUSE, bindings of which as described in
> +bindings/nvmem/nvmem.txt
> +
> +Example:
> +
> + efuse: efuse@10206000 {
> + compatible = "mediatek,mt8173-efuse";
> + reg = <0 0x10206000 0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + /* Data cells */
> + thermal_calibration: calib@528 {
> + reg = <0x528 0xc>;
> + };
> + };
> +
> += Data consumers =
> +Are device nodes which consume nvmem data cells.
> +
> +For example:
> +
> + thermal {
> + ...
> + nvmem-cells = <&thermal_calibration>;
> + nvmem-cell-names = "calibration";
> + };
>
next prev parent reply other threads:[~2015-10-26 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 8:39 [PATCH 0/3] Mediatek EFUSE Support andrew-ct.chen
2015-10-16 8:39 ` [PATCH 1/3] dt-bindings: add document of mediatek efuse driver andrew-ct.chen
2015-10-26 9:56 ` Srinivas Kandagatla [this message]
2015-10-26 10:23 ` Sascha Hauer
2015-10-26 10:55 ` Srinivas Kandagatla
2015-10-27 5:32 ` andrew-ct chen
2015-10-27 9:27 ` andrew-ct chen
2015-10-16 8:39 ` [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver andrew-ct.chen
2015-10-26 9:56 ` Srinivas Kandagatla
2015-10-26 10:28 ` Sascha Hauer
2015-10-26 10:39 ` Srinivas Kandagatla
2015-10-27 5:32 ` andrew-ct chen
2015-10-27 9:28 ` andrew-ct chen
2015-10-16 8:39 ` [PATCH 3/3] dts: arm64: Add EFUSE device node andrew-ct.chen
2015-10-19 6:49 ` [PATCH 0/3] Mediatek EFUSE Support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562DF8BE.4060205@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).