From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: andrew-ct.chen@mediatek.com,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com
Subject: Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver
Date: Mon, 26 Oct 2015 10:39:46 +0000 [thread overview]
Message-ID: <562E02F2.50709@linaro.org> (raw)
In-Reply-To: <20151026102834.GE25308@pengutronix.de>
On 26/10/15 10:28, Sascha Hauer wrote:
> On Mon, Oct 26, 2015 at 09:56:24AM +0000, Srinivas Kandagatla wrote:
>>> + .val_bits = 32,
>>> + .reg_stride = 4,
>>> +};
>>> +
>>> +static int mtk_efuse_probe(struct platform_device *pdev)
>>> +{
>>> + struct device *dev = &pdev->dev;
>>> + struct resource *res;
>>> + struct nvmem_device *nvmem;
>>> + struct nvmem_config *econfig;
>>> + struct regmap *regmap;
>>> + void __iomem *base;
>>> +
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> + base = devm_ioremap_resource(dev, res);
>>> + if (IS_ERR(base))
>>> + return PTR_ERR(base);
>>> +
>>> + econfig = devm_kzalloc(dev, sizeof(*econfig), GFP_KERNEL);
>>> + if (!econfig)
>>> + return -ENOMEM;
>> Why not use static econfig variable?
>
> Because drivers should not assume there is only one instance of them in
> the system. The qfprom driver does this and it's only a matter of
Good point, Yes, you are right. If MTK has possibility of having more
than one efuse we can leave the code as it is.
> putting a second qcom,qfprom node into the device tree to break the
> driver.
It would indeed.
--srini
>
> Sascha
>
next prev parent reply other threads:[~2015-10-26 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 8:39 [PATCH 0/3] Mediatek EFUSE Support andrew-ct.chen
2015-10-16 8:39 ` [PATCH 1/3] dt-bindings: add document of mediatek efuse driver andrew-ct.chen
2015-10-26 9:56 ` Srinivas Kandagatla
2015-10-26 10:23 ` Sascha Hauer
2015-10-26 10:55 ` Srinivas Kandagatla
2015-10-27 5:32 ` andrew-ct chen
2015-10-27 9:27 ` andrew-ct chen
2015-10-16 8:39 ` [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver andrew-ct.chen
2015-10-26 9:56 ` Srinivas Kandagatla
2015-10-26 10:28 ` Sascha Hauer
2015-10-26 10:39 ` Srinivas Kandagatla [this message]
2015-10-27 5:32 ` andrew-ct chen
2015-10-27 9:28 ` andrew-ct chen
2015-10-16 8:39 ` [PATCH 3/3] dts: arm64: Add EFUSE device node andrew-ct.chen
2015-10-19 6:49 ` [PATCH 0/3] Mediatek EFUSE Support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E02F2.50709@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).