* [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously
@ 2015-09-21 6:51 Fu, Zhonghui
2015-09-21 9:32 ` Andy Shevchenko
2015-11-16 6:25 ` Fu, Zhonghui
0 siblings, 2 replies; 4+ messages in thread
From: Fu, Zhonghui @ 2015-09-21 6:51 UTC (permalink / raw)
To: Ulf Hansson, Adrian Hunter, yunpeng.gao, andriy.shevchenko,
peter.griffin
Cc: linux-mmc, linux-kernel
Now, PM core supports asynchronous suspend/resume mode for devices
during system suspend/resume, and the power state transition of one
device may be completed in separate kernel thread. PM core ensures
all power state transition timing dependency between devices. This
patch enables sdhci-acpi device to suspend/resume asynchronously.
This will take advantage of multicore and improve system
suspend/resume speed.
Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
---
Changes in v2:
- Amend commit message.
drivers/mmc/host/sdhci-acpi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 22d929f..67e6263 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
}
+ device_enable_async_suspend(dev);
+
return 0;
err_free:
-- 1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously
2015-09-21 6:51 [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously Fu, Zhonghui
@ 2015-09-21 9:32 ` Andy Shevchenko
2015-11-16 6:29 ` Fu, Zhonghui
2015-11-16 6:25 ` Fu, Zhonghui
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2015-09-21 9:32 UTC (permalink / raw)
To: Fu, Zhonghui, Ulf Hansson, Adrian Hunter, yunpeng.gao, peter.griffin
Cc: linux-mmc, linux-kernel
On Mon, 2015-09-21 at 14:51 +0800, Fu, Zhonghui wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition timing dependency between devices. This
> patch enables sdhci-acpi device to suspend/resume asynchronously.
> This will take advantage of multicore and improve system
> suspend/resume speed.
>
It would be nice I think to put here statistics you collected as well.
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
> Changes in v2:
> - Amend commit message.
>
> drivers/mmc/host/sdhci-acpi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci
> -acpi.c
> index 22d929f..67e6263 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct
> platform_device *pdev)
> pm_runtime_enable(dev);
> }
>
> + device_enable_async_suspend(dev);
> +
> return 0;
>
> err_free:
> -- 1.7.1
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously
2015-09-21 9:32 ` Andy Shevchenko
@ 2015-11-16 6:29 ` Fu, Zhonghui
0 siblings, 0 replies; 4+ messages in thread
From: Fu, Zhonghui @ 2015-11-16 6:29 UTC (permalink / raw)
To: Andy Shevchenko, Ulf Hansson, Adrian Hunter, yunpeng.gao, peter.griffin
Cc: linux-mmc, linux-kernel
On 9/21/2015 5:32 PM, Andy Shevchenko wrote:
> On Mon, 2015-09-21 at 14:51 +0800, Fu, Zhonghui wrote:
>> Now, PM core supports asynchronous suspend/resume mode for devices
>> during system suspend/resume, and the power state transition of one
>> device may be completed in separate kernel thread. PM core ensures
>> all power state transition timing dependency between devices. This
>> patch enables sdhci-acpi device to suspend/resume asynchronously.
>> This will take advantage of multicore and improve system
>> suspend/resume speed.
>>
> It would be nice I think to put here statistics you collected as well.
Sorry for replying this mail after long leave.
I have added the test result into commit message and sent the latest version of this patch:"[PATCH v3] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously".
Thanks,
Zhonghui
>
>> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
>> ---
>> Changes in v2:
>> - Amend commit message.
>>
>> drivers/mmc/host/sdhci-acpi.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci
>> -acpi.c
>> index 22d929f..67e6263 100644
>> --- a/drivers/mmc/host/sdhci-acpi.c
>> +++ b/drivers/mmc/host/sdhci-acpi.c
>> @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct
>> platform_device *pdev)
>> pm_runtime_enable(dev);
>> }
>>
>> + device_enable_async_suspend(dev);
>> +
>> return 0;
>>
>> err_free:
>> -- 1.7.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously
2015-09-21 6:51 [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously Fu, Zhonghui
2015-09-21 9:32 ` Andy Shevchenko
@ 2015-11-16 6:25 ` Fu, Zhonghui
1 sibling, 0 replies; 4+ messages in thread
From: Fu, Zhonghui @ 2015-11-16 6:25 UTC (permalink / raw)
To: Ulf Hansson, Adrian Hunter, yunpeng.gao, andriy.shevchenko,
peter.griffin
Cc: linux-mmc, linux-kernel
Please review the latest version: "[PATCH v3] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously"
Thanks,
Zhonghui
On 9/21/2015 2:51 PM, Fu, Zhonghui wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition timing dependency between devices. This
> patch enables sdhci-acpi device to suspend/resume asynchronously.
> This will take advantage of multicore and improve system
> suspend/resume speed.
>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
> Changes in v2:
> - Amend commit message.
>
> drivers/mmc/host/sdhci-acpi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 22d929f..67e6263 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
> pm_runtime_enable(dev);
> }
>
> + device_enable_async_suspend(dev);
> +
> return 0;
>
> err_free:
> -- 1.7.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-16 6:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-21 6:51 [PATCH v2] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously Fu, Zhonghui
2015-09-21 9:32 ` Andy Shevchenko
2015-11-16 6:29 ` Fu, Zhonghui
2015-11-16 6:25 ` Fu, Zhonghui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).