From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Simon Arlott <simon@fire.lp0.eu>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Jonas Gorski <jogo@openwrt.org>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2 (v2)] leds-bcm6328: Reuse bcm6328_led_set() instead of copying its functionality
Date: Mon, 16 Nov 2015 22:33:06 +0100 [thread overview]
Message-ID: <564A4B92.4040401@gmail.com> (raw)
In-Reply-To: <564A3B9B.7040608@simon.arlott.org.uk>
Still wrong, you are setting the led value after unlocking the spinlock.
El 16/11/2015 a las 21:24, Simon Arlott escribió:
> When ensuring a consistent initial LED state in bcm6328_led (as they may
> be blinking instead of on/off), the LED register is set using an inverted
> copy of bcm6328_led_set(). To avoid further errors relating to active low
> handling, call this function directly instead.
>
> As bcm6328_led_set() acquires the same spinlock again when updating the
> register, it is called after unlocking.
>
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> ---
> drivers/leds/leds-bcm6328.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c
> index c7ea5c6..95d0cf9 100644
> --- a/drivers/leds/leds-bcm6328.c
> +++ b/drivers/leds/leds-bcm6328.c
> @@ -314,14 +314,10 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
> } else {
> led->cdev.brightness = LED_OFF;
> }
> -
> - if ((led->active_low && led->cdev.brightness == LED_FULL) ||
> - (!led->active_low && led->cdev.brightness == LED_OFF))
> - bcm6328_led_mode(led, BCM6328_LED_MODE_ON);
> - else
> - bcm6328_led_mode(led, BCM6328_LED_MODE_OFF);
> spin_unlock_irqrestore(lock, flags);
>
> + bcm6328_led_set(&led->cdev, led->cdev.brightness);
> +
> led->cdev.brightness_set = bcm6328_led_set;
> led->cdev.blink_set = bcm6328_blink_set;
>
next prev parent reply other threads:[~2015-11-16 21:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 16:53 [PATCH] leds: bcm6328: Handle default-state of LEDs correctly Simon Arlott
2015-10-26 8:45 ` Jacek Anaszewski
2015-10-26 12:36 ` Simon Arlott
2015-10-28 10:56 ` Jacek Anaszewski
2015-10-29 19:48 ` [PATCH] leds-bcm6328: Reuse bcm6328_led_set() instead of copying its functionality Simon Arlott
2015-11-04 15:41 ` Jacek Anaszewski
2015-11-04 15:46 ` Álvaro Fernández Rojas
2015-11-05 10:41 ` Jacek Anaszewski
2015-11-15 13:32 ` [PATCH 1/2] " Simon Arlott
2015-11-15 13:34 ` [PATCH 2/2] leds-bcm6328: Swap LED ON and OFF definitions Simon Arlott
2015-11-23 10:20 ` Jacek Anaszewski
2015-11-16 14:38 ` [PATCH 1/2] leds-bcm6328: Reuse bcm6328_led_set() instead of copying its functionality Jacek Anaszewski
2015-11-16 20:24 ` [PATCH 1/2 (v2)] " Simon Arlott
2015-11-16 21:33 ` Álvaro Fernández Rojas [this message]
2015-11-17 7:42 ` Simon Arlott
2015-11-17 8:06 ` Jacek Anaszewski
2015-11-17 8:15 ` Jacek Anaszewski
2015-11-22 20:40 ` [PATCH 1/2 (v3)] " Simon Arlott
2015-11-23 10:19 ` Jacek Anaszewski
2015-11-23 10:20 ` [PATCH 1/2 (v2)] " Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A4B92.4040401@gmail.com \
--to=noltari@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).