linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Simon Arlott" <simon@fire.lp0.eu>
To: "Jacek Anaszewski" <j.anaszewski@samsung.com>
Cc: "Richard Purdie" <rpurdie@rpsys.net>,
	linux-leds@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"\"Álvaro Fernández Rojas\"" <noltari@gmail.com>,
	"Jonas Gorski" <jogo@openwrt.org>
Subject: Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly
Date: Mon, 26 Oct 2015 12:36:20 -0000	[thread overview]
Message-ID: <ed10b1e070e8b0d4a9eda6b32b686d1ab5b71759@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid> (raw)
In-Reply-To: <562DE832.6070903@samsung.com>

On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote:
> Hi Simon,
>
> Thanks for the patch. There are conflicts when applying
> it to the LED tree:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
>
> Please use it as a code base for your LED development.

This has already been fixed in the devel branch by d19e6b6a0062c86a75365f0715fd079245f6aab9,
although I think bcm6328_led() should adjust its use of the spinlock
to only cover reading the register and call bcm6328_led_set() instead
of copying the code from it.

-- 
Simon Arlott

  reply	other threads:[~2015-10-26 12:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24 16:53 [PATCH] leds: bcm6328: Handle default-state of LEDs correctly Simon Arlott
2015-10-26  8:45 ` Jacek Anaszewski
2015-10-26 12:36   ` Simon Arlott [this message]
2015-10-28 10:56     ` Jacek Anaszewski
2015-10-29 19:48       ` [PATCH] leds-bcm6328: Reuse bcm6328_led_set() instead of copying its functionality Simon Arlott
2015-11-04 15:41         ` Jacek Anaszewski
2015-11-04 15:46           ` Álvaro Fernández Rojas
2015-11-05 10:41             ` Jacek Anaszewski
2015-11-15 13:32               ` [PATCH 1/2] " Simon Arlott
2015-11-15 13:34                 ` [PATCH 2/2] leds-bcm6328: Swap LED ON and OFF definitions Simon Arlott
2015-11-23 10:20                   ` Jacek Anaszewski
2015-11-16 14:38                 ` [PATCH 1/2] leds-bcm6328: Reuse bcm6328_led_set() instead of copying its functionality Jacek Anaszewski
2015-11-16 20:24                   ` [PATCH 1/2 (v2)] " Simon Arlott
2015-11-16 21:33                     ` Álvaro Fernández Rojas
2015-11-17  7:42                       ` Simon Arlott
2015-11-17  8:06                         ` Jacek Anaszewski
2015-11-17  8:15                           ` Jacek Anaszewski
2015-11-22 20:40                             ` [PATCH 1/2 (v3)] " Simon Arlott
2015-11-23 10:19                               ` Jacek Anaszewski
2015-11-23 10:20                     ` [PATCH 1/2 (v2)] " Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed10b1e070e8b0d4a9eda6b32b686d1ab5b71759@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid \
    --to=simon@fire.lp0.eu \
    --cc=j.anaszewski@samsung.com \
    --cc=jogo@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).