From: Florian Fainelli <f.fainelli@gmail.com>
To: Simon Arlott <simon@fire.lp0.eu>, Rob Herring <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH (v4) 2/2] mtd: brcmnand: Add support for the BCM63268
Date: Tue, 24 Nov 2015 10:41:45 -0800 [thread overview]
Message-ID: <5654AF69.7040901@gmail.com> (raw)
In-Reply-To: <56541BD3.4070202@simon.arlott.org.uk>
On 24/11/15 00:12, Simon Arlott wrote:
> On 23/11/15 18:22, Florian Fainelli wrote:
>> On 22/11/15 14:17, Simon Arlott wrote:
>>> The BCM63268 has a NAND interrupt register with combined status and enable
>>> registers. It also has a clock for the NAND controller that needs to be
>>> enabled.
>>>
>>> Set up the device by enabling the clock, disabling and acking all
>>> interrupts, then handle the CTRL_READY interrupt.
>>>
>>> Add a "device_remove" function to struct brcmnand_soc so that the clock
>>> can be disabled when the device is removed.
>>>
>>> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
>>> ---
>>> On 22/11/15 21:59, Rob Herring wrote:
>>>>>>> + * "brcm,nand-bcm63268"
>>>>>>> + - compatible: should contain "brcm,nand-bcm<soc>", "brcm,nand-bcm63268"
>>>>>
>>>>> vendor,<soc>-device is preferred.
>>>
>>> The existing two bindings use brcm,nand-<soc>, but I've changed this one.
>>
>> Could we stick with the existing binding naming convention of using:
>>
>> brcm,nand-<soc> just so automated tools or other things can match this
>> one too, and +1 for consistency?
>
> I could submit another patch renaming the existing bindings to
> brcm,<soc>-nand, and add that to the drivers? Then they'd be consistent.
No, let's not create unnecessary churn because of a minor mistake. So,
yes we *should* have used brcm,<soc>-nand in the first place, but now
that there are DTSes out there using "brcm,nand-<soc>" there is not
really any point in doing this, so please update your patches so they
match the existing convention.
>
>> Other than, that, same comment as Jonas, why do we we need the
>> device_remove callback to be called from the main driver down to this one?
>
> I'll add a "struct brcmnand_soc *brcmnand_get_socdata(struct device *)"
> instead so that I can access the soc data before calling brcmnand_remove.
>
--
Florian
next prev parent reply other threads:[~2015-11-24 18:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 13:10 [PATCH 1/2] mtd: brcmnand: Add brcm,nand-bcm63268 device tree binding Simon Arlott
2015-11-21 13:12 ` [PATCH 2/2] mtd: brcmnand: Add support for BCM63268 interrupts Simon Arlott
2015-11-21 17:04 ` [PATCH 2/2 (v2)] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-22 14:34 ` [PATCH (v3) 2/2] " Simon Arlott
2015-11-22 21:59 ` [PATCH 1/2] mtd: brcmnand: Add brcm,nand-bcm63268 device tree binding Rob Herring
2015-11-22 22:15 ` [PATCH (v4) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand " Simon Arlott
2015-11-22 22:17 ` [PATCH (v4) 2/2] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-23 15:42 ` Jonas Gorski
2015-11-23 18:38 ` Simon Arlott
2015-11-23 18:22 ` Florian Fainelli
2015-11-24 8:12 ` Simon Arlott
2015-11-24 18:15 ` [PATCH (v5) " Simon Arlott
2015-11-24 18:41 ` Florian Fainelli [this message]
2015-11-24 20:19 ` [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Simon Arlott
2015-11-24 20:21 ` [PATCH (v6) 2/2] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-25 10:44 ` Jonas Gorski
2015-11-25 12:37 ` Simon Arlott
2015-11-25 12:53 ` Jonas Gorski
2015-11-25 19:49 ` [PATCH (v7) " Simon Arlott
2015-12-02 19:18 ` Brian Norris
2015-12-02 19:54 ` Simon Arlott
2015-12-02 20:10 ` Brian Norris
2015-11-25 20:06 ` [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Rob Herring
2015-12-02 19:05 ` Brian Norris
2015-12-02 19:36 ` Jonas Gorski
2015-12-02 19:38 ` Florian Fainelli
2015-12-02 20:02 ` Simon Arlott
2015-12-02 21:44 ` Florian Fainelli
2015-12-02 19:41 ` Simon Arlott
2015-12-02 20:00 ` Brian Norris
2015-12-02 20:12 ` Simon Arlott
2015-12-02 20:21 ` Brian Norris
2015-12-02 20:24 ` Brian Norris
2015-12-02 20:34 ` Simon Arlott
2015-12-02 20:48 ` Brian Norris
2015-11-22 22:23 ` [PATCH (v4) " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5654AF69.7040901@gmail.com \
--to=f.fainelli@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).