From: Jonas Gorski <jogo@openwrt.org>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH (v6) 2/2] mtd: brcmnand: Add support for the BCM63268
Date: Wed, 25 Nov 2015 11:44:54 +0100 [thread overview]
Message-ID: <CAOiHx==RsnZKb93hp1PXhz-Am_uJ4g_RR3R8VQ_dnd8hd1Wcpw@mail.gmail.com> (raw)
In-Reply-To: <210ac819ff369893bd7d10640026a5b75455e684@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid>
Hi,
On Tue, Nov 24, 2015 at 9:21 PM, Simon Arlott <simon@fire.lp0.eu> wrote:
> The BCM63268 has a NAND interrupt register with combined status and enable
> registers. It also has a clock for the NAND controller that needs to be
> enabled.
>
> Set up the device by enabling the clock, disabling and acking all
> interrupts, then handle the CTRL_READY interrupt.
>
> Add a brcmnand_get_socdata() function so that bcm63268_nand can obtain its
> data and disable the clock when the device is removed.
To me this now mostly looks good, one thing though ...
>
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> ---
> drivers/mtd/nand/brcmnand/Makefile | 1 +
> drivers/mtd/nand/brcmnand/bcm63268_nand.c | 179 ++++++++++++++++++++++++++++++
> drivers/mtd/nand/brcmnand/brcmnand.c | 7 ++
> drivers/mtd/nand/brcmnand/brcmnand.h | 1 +
> 4 files changed, 188 insertions(+)
> create mode 100644 drivers/mtd/nand/brcmnand/bcm63268_nand.c
>
(snip)
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index 2c8f67f..99ca69e 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -2262,6 +2262,13 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
> }
> EXPORT_SYMBOL_GPL(brcmnand_probe);
>
> +struct brcmnand_soc *brcmnand_get_socdata(struct platform_device *pdev)
> +{
> + struct brcmnand_controller *ctrl = dev_get_drvdata(&pdev->dev);
> +
> + return ctrl ? ctrl->soc : NULL;
> +}
> +
Don't you need to EXPORT_SYMBOL_GPL this one in case you build
brcmnand as module?
Jonas
next prev parent reply other threads:[~2015-11-25 10:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 13:10 [PATCH 1/2] mtd: brcmnand: Add brcm,nand-bcm63268 device tree binding Simon Arlott
2015-11-21 13:12 ` [PATCH 2/2] mtd: brcmnand: Add support for BCM63268 interrupts Simon Arlott
2015-11-21 17:04 ` [PATCH 2/2 (v2)] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-22 14:34 ` [PATCH (v3) 2/2] " Simon Arlott
2015-11-22 21:59 ` [PATCH 1/2] mtd: brcmnand: Add brcm,nand-bcm63268 device tree binding Rob Herring
2015-11-22 22:15 ` [PATCH (v4) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand " Simon Arlott
2015-11-22 22:17 ` [PATCH (v4) 2/2] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-23 15:42 ` Jonas Gorski
2015-11-23 18:38 ` Simon Arlott
2015-11-23 18:22 ` Florian Fainelli
2015-11-24 8:12 ` Simon Arlott
2015-11-24 18:15 ` [PATCH (v5) " Simon Arlott
2015-11-24 18:41 ` [PATCH (v4) " Florian Fainelli
2015-11-24 20:19 ` [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Simon Arlott
2015-11-24 20:21 ` [PATCH (v6) 2/2] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-25 10:44 ` Jonas Gorski [this message]
2015-11-25 12:37 ` Simon Arlott
2015-11-25 12:53 ` Jonas Gorski
2015-11-25 19:49 ` [PATCH (v7) " Simon Arlott
2015-12-02 19:18 ` Brian Norris
2015-12-02 19:54 ` Simon Arlott
2015-12-02 20:10 ` Brian Norris
2015-11-25 20:06 ` [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Rob Herring
2015-12-02 19:05 ` Brian Norris
2015-12-02 19:36 ` Jonas Gorski
2015-12-02 19:38 ` Florian Fainelli
2015-12-02 20:02 ` Simon Arlott
2015-12-02 21:44 ` Florian Fainelli
2015-12-02 19:41 ` Simon Arlott
2015-12-02 20:00 ` Brian Norris
2015-12-02 20:12 ` Simon Arlott
2015-12-02 20:21 ` Brian Norris
2015-12-02 20:24 ` Brian Norris
2015-12-02 20:34 ` Simon Arlott
2015-12-02 20:48 ` Brian Norris
2015-11-22 22:23 ` [PATCH (v4) " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOiHx==RsnZKb93hp1PXhz-Am_uJ4g_RR3R8VQ_dnd8hd1Wcpw@mail.gmail.com' \
--to=jogo@openwrt.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).