* [PATCH v1] arm64: dts: msm8998: thermal: split address space into two
[not found] <cover.1542911304.git.amit.kucheria@linaro.org>
@ 2018-11-22 18:32 ` Amit Kucheria
2018-11-22 20:23 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Amit Kucheria @ 2018-11-22 18:32 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arm-msm, devicetree, bjorn.andersson, edubezval,
andy.gross, David Brown, Rob Herring, Mark Rutland
We added support to split the register address space for
tsens into TM and SROT regions in 'Commit 5b1283984fa3 ("thermal: tsens:
Add support to split up register address space into two")'.
Split up the tsens address space for msm8998 since it has a similar
register layout to other versions of the IP to allow for better code
sharing.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
(Compile-tested only, since I don't have the hardware)
arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 78227cce16db..eb4f6f77969f 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -577,17 +577,18 @@
cell-index = <0>;
};
- tsens0: thermal@10aa000 {
+ tsens0: thermal@10ab000 {
compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
- reg = <0x10aa000 0x2000>;
-
+ reg = <0x10ab000 0x1000>, /* TM */
+ <0x10aa000 0x1000>; /* SROT */
#qcom,sensors = <12>;
#thermal-sensor-cells = <1>;
};
- tsens1: thermal@10ad000 {
+ tsens1: thermal@10ae000 {
compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
- reg = <0x10ad000 0x2000>;
+ reg = <0x10ae000 0x1000>, /* TM */
+ <0x10ad000 0x1000>; /* SROT */
#qcom,sensors = <8>;
#thermal-sensor-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] arm64: dts: msm8998: thermal: split address space into two
2018-11-22 18:32 ` [PATCH v1] arm64: dts: msm8998: thermal: split address space into two Amit Kucheria
@ 2018-11-22 20:23 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2018-11-22 20:23 UTC (permalink / raw)
To: Amit Kucheria
Cc: linux-kernel, linux-arm-msm, devicetree, edubezval, andy.gross,
David Brown, Rob Herring, Mark Rutland
On Thu 22 Nov 10:32 PST 2018, Amit Kucheria wrote:
> We added support to split the register address space for
> tsens into TM and SROT regions in 'Commit 5b1283984fa3 ("thermal: tsens:
> Add support to split up register address space into two")'.
>
> Split up the tsens address space for msm8998 since it has a similar
> register layout to other versions of the IP to allow for better code
> sharing.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> (Compile-tested only, since I don't have the hardware)
You do have hardware, it's available in our conmux.
Regards,
Bjorn
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 78227cce16db..eb4f6f77969f 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -577,17 +577,18 @@
> cell-index = <0>;
> };
>
> - tsens0: thermal@10aa000 {
> + tsens0: thermal@10ab000 {
> compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
> - reg = <0x10aa000 0x2000>;
> -
> + reg = <0x10ab000 0x1000>, /* TM */
> + <0x10aa000 0x1000>; /* SROT */
> #qcom,sensors = <12>;
> #thermal-sensor-cells = <1>;
> };
>
> - tsens1: thermal@10ad000 {
> + tsens1: thermal@10ae000 {
> compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
> - reg = <0x10ad000 0x2000>;
> + reg = <0x10ae000 0x1000>, /* TM */
> + <0x10ad000 0x1000>; /* SROT */
>
> #qcom,sensors = <8>;
> #thermal-sensor-cells = <1>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-22 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1542911304.git.amit.kucheria@linaro.org>
2018-11-22 18:32 ` [PATCH v1] arm64: dts: msm8998: thermal: split address space into two Amit Kucheria
2018-11-22 20:23 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).