* Re: [PATCH] fs: jfs: fix a possible data race in txBegin()
@ 2020-05-04 16:15 Markus Elfring
2020-05-05 4:10 ` Jia-Ju Bai
0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2020-05-04 16:15 UTC (permalink / raw)
To: Jia-Ju Bai, jfs-discussion; +Cc: linux-kernel, kernel-janitors, Dave Kleikamp
> Thus, a data race can occur for tblk->flag.
>
> To fix this data race, the spinlock log->gclock is used in
> txBegin().
>
> This data race is found by our concurrency fuzzer.
How do you think about a wording variant like the following?
Change description:
A data race can occur for the data structure member “flag”.
This data race was found by our concurrency fuzzer.
Thus use the spin lock “gclock” for the resetting of five
data structure members in this function implementation.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fs: jfs: fix a possible data race in txBegin()
2020-05-04 16:15 [PATCH] fs: jfs: fix a possible data race in txBegin() Markus Elfring
@ 2020-05-05 4:10 ` Jia-Ju Bai
2020-05-05 5:12 ` Markus Elfring
0 siblings, 1 reply; 6+ messages in thread
From: Jia-Ju Bai @ 2020-05-05 4:10 UTC (permalink / raw)
To: Markus Elfring, jfs-discussion
Cc: linux-kernel, kernel-janitors, Dave Kleikamp
On 2020/5/5 0:15, Markus Elfring wrote:
>> Thus, a data race can occur for tblk->flag.
>>
>> To fix this data race, the spinlock log->gclock is used in
>> txBegin().
>>
>> This data race is found by our concurrency fuzzer.
> How do you think about a wording variant like the following?
>
> Change description:
> A data race can occur for the data structure member “flag”.
> This data race was found by our concurrency fuzzer.
>
> Thus use the spin lock “gclock” for the resetting of five
> data structure members in this function implementation.
>
>
> Would you like to add the tag “Fixes” to the commit message?
>
Thanks, Markus.
I am not sure how to add the tag "Fixes"...
I need to find which previous commit add the code about txBegin()?
Best wishes,
Jia-Ju Bai
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fs: jfs: fix a possible data race in txBegin()
2020-05-05 4:10 ` Jia-Ju Bai
@ 2020-05-05 5:12 ` Markus Elfring
2020-05-05 13:04 ` Jia-Ju Bai
2020-05-05 13:23 ` Dave Kleikamp
0 siblings, 2 replies; 6+ messages in thread
From: Markus Elfring @ 2020-05-05 5:12 UTC (permalink / raw)
To: Jia-Ju Bai, jfs-discussion; +Cc: linux-kernel, kernel-janitors, Dave Kleikamp
> I am not sure how to add the tag "Fixes"...
How helpful do you find the available software documentation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=47cf1b422e6093aee2a3e55d5e162112a2c69870#n183
> I need to find which previous commit add the code about txBegin()?
I suggest to take another look at corresponding source code places
by a command like “git blame”.
https://git-scm.com/book/en/v2/Git-Tools-Debugging-with-Gits
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fs: jfs: fix a possible data race in txBegin()
2020-05-05 5:12 ` Markus Elfring
@ 2020-05-05 13:04 ` Jia-Ju Bai
2020-05-05 13:23 ` Dave Kleikamp
1 sibling, 0 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2020-05-05 13:04 UTC (permalink / raw)
To: Markus Elfring, jfs-discussion
Cc: linux-kernel, kernel-janitors, Dave Kleikamp
On 2020/5/5 13:12, Markus Elfring wrote:
>> I am not sure how to add the tag "Fixes"...
> How helpful do you find the available software documentation?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=47cf1b422e6093aee2a3e55d5e162112a2c69870#n183
>
>
>> I need to find which previous commit add the code about txBegin()?
> I suggest to take another look at corresponding source code places
> by a command like “git blame”.
> https://git-scm.com/book/en/v2/Git-Tools-Debugging-with-Gits
Thanks a lot, Markus.
I have used "git blame" to find the last change on the related source code.
I will send V2 patches, thanks again :)
Best wishes,
Jia-Ju Bai
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fs: jfs: fix a possible data race in txBegin()
2020-05-05 5:12 ` Markus Elfring
2020-05-05 13:04 ` Jia-Ju Bai
@ 2020-05-05 13:23 ` Dave Kleikamp
2020-05-05 13:32 ` Jia-Ju Bai
1 sibling, 1 reply; 6+ messages in thread
From: Dave Kleikamp @ 2020-05-05 13:23 UTC (permalink / raw)
To: Markus Elfring, Jia-Ju Bai, jfs-discussion; +Cc: linux-kernel, kernel-janitors
On 5/5/20 12:12 AM, Markus Elfring wrote:
>> I am not sure how to add the tag "Fixes"...
>
> How helpful do you find the available software documentation?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=47cf1b422e6093aee2a3e55d5e162112a2c69870#n183
>
>
>> I need to find which previous commit add the code about txBegin()?
>
> I suggest to take another look at corresponding source code places
> by a command like “git blame”.
> https://git-scm.com/book/en/v2/Git-Tools-Debugging-with-Gits
I suspect that the problem was in the code much longer than it has been
under git source control.
>
> Regards,
> Markus
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fs: jfs: fix a possible data race in txBegin()
2020-05-05 13:23 ` Dave Kleikamp
@ 2020-05-05 13:32 ` Jia-Ju Bai
0 siblings, 0 replies; 6+ messages in thread
From: Jia-Ju Bai @ 2020-05-05 13:32 UTC (permalink / raw)
To: Dave Kleikamp, Markus Elfring, Jia-Ju Bai, jfs-discussion
Cc: linux-kernel, kernel-janitors
On 2020/5/5 21:23, Dave Kleikamp wrote:
> On 5/5/20 12:12 AM, Markus Elfring wrote:
>>> I am not sure how to add the tag "Fixes"...
>> How helpful do you find the available software documentation?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=47cf1b422e6093aee2a3e55d5e162112a2c69870#n183
>>
>>
>>> I need to find which previous commit add the code about txBegin()?
>> I suggest to take another look at corresponding source code places
>> by a command like “git blame”.
>> https://git-scm.com/book/en/v2/Git-Tools-Debugging-with-Gits
> I suspect that the problem was in the code much longer than it has been
> under git source control.
I agree, because "git blame" shows the last change to txBegin() is
commit 1da177e4c3f4, which was submitted in 2005...
And this commit just added or merged the filesystem to the Linux kernel.
Thus, adding the tag "Fixes" of this commit should be useless...
Best wishes,
Jia-Ju Bai
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-05 13:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 16:15 [PATCH] fs: jfs: fix a possible data race in txBegin() Markus Elfring
2020-05-05 4:10 ` Jia-Ju Bai
2020-05-05 5:12 ` Markus Elfring
2020-05-05 13:04 ` Jia-Ju Bai
2020-05-05 13:23 ` Dave Kleikamp
2020-05-05 13:32 ` Jia-Ju Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).