[PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

[PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

[Jisheng Zhang]

Add or fix the optional clock property, then remove the CLK_IGNORE_UNUSED
flag for sdio clk(s).

This is a partialy resend of 
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379457.html

patch3, patch4 has been merged.

Since v1:
 - remove the "mmc: sdhci-pxav3: fix optional clock name" patch to not
   block the clock clean up patches, will send another separate patch
   after talking with HW people.

Jisheng Zhang (2):
  ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock
  ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1

 arch/arm/boot/dts/berlin2q.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.6.2

[PATCH v2 PART-RESEND 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock

[Jisheng Zhang]

The optional 2nd clock is CLKID_SDIO.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 155430a..145dd33 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -135,7 +135,7 @@
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab1000 0x200>;
 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_NFC>;
+			clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_SDIO>;
 			clock-names = "io", "core";
 			status = "disabled";
 		};
-- 
2.6.2

[PATCH v2 PART-RESEND 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1

[Jisheng Zhang]

Add the optional 2nd clock for BG2Q's sdhci0 and sdhci1. This would let the
clock be disabled during runtime pm, so saves power a bit.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 145dd33..3920310 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -118,7 +118,8 @@
 		sdhci0: sdhci@ab0000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0000 0x200>;
-			clocks = <&chip_clk CLKID_SDIO1XIN>;
+			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+			clock-names = "io", "core";
 			interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
 			status = "disabled";
 		};
@@ -126,7 +127,8 @@
 		sdhci1: sdhci@ab0800 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0800 0x200>;
-			clocks = <&chip_clk CLKID_SDIO1XIN>;
+			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+			clock-names = "io", "core";
 			interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
 			status = "disabled";
 		};
-- 
2.6.2

Re: [PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

[Sebastian Hesselbarth]

On 16.11.2015 11:56, Jisheng Zhang wrote:
> Add or fix the optional clock property, then remove the CLK_IGNORE_UNUSED
> flag for sdio clk(s).
> 
> This is a partialy resend of 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379457.html
> 
> patch3, patch4 has been merged.

Great! Really!

As they have been taken without my Acked-by, ignoring my request to
_not_ remove the CLK_IGNORE_UNUSED flags _before_ these two, the
remaining patches now become fixes.

Please resend the patches with a proper description what and why they
are fixes now.

Sebastian

Re: [PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

[Sebastian Hesselbarth]

On 19.11.2015 21:31, Sebastian Hesselbarth wrote:
> On 16.11.2015 11:56, Jisheng Zhang wrote:
>> Add or fix the optional clock property, then remove the CLK_IGNORE_UNUSED
>> flag for sdio clk(s).
>>
>> This is a partialy resend of 
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379457.html
>>
>> patch3, patch4 has been merged.
> 
> Great! Really!
> 
> As they have been taken without my Acked-by, ignoring my request to
> _not_ remove the CLK_IGNORE_UNUSED flags _before_ these two, the
> remaining patches now become fixes.
> 
> Please resend the patches with a proper description what and why they
> are fixes now.

Is this going to be resolved anytime soon?

If not, I am going to send a revert for the CLK_IGNORE_UNUSED patch
and we start this from the beginning.

Sebastian

Re: [PATCH v2 PART-RESEND 0/2] berlin sdhci clock clean up

[Jisheng Zhang]

Dear Sebastian,

On Sun, 6 Dec 2015 11:07:41 +0100
Sebastian Hesselbarth wrote:

> On 19.11.2015 21:31, Sebastian Hesselbarth wrote:
> > On 16.11.2015 11:56, Jisheng Zhang wrote:  
> >> Add or fix the optional clock property, then remove the CLK_IGNORE_UNUSED
> >> flag for sdio clk(s).
> >>
> >> This is a partialy resend of 
> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379457.html
> >>
> >> patch3, patch4 has been merged.  
> > 
> > Great! Really!
> > 
> > As they have been taken without my Acked-by, ignoring my request to
> > _not_ remove the CLK_IGNORE_UNUSED flags _before_ these two, the
> > remaining patches now become fixes.
> > 
> > Please resend the patches with a proper description what and why they
> > are fixes now.  
> 
> Is this going to be resolved anytime soon?
> 
> If not, I am going to send a revert for the CLK_IGNORE_UNUSED patch
> and we start this from the beginning.

I will send patches today.

Thanks a lot,
Jisheng